Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
path: root/.rubocop_todo/style
diff options
context:
space:
mode:
Diffstat (limited to '.rubocop_todo/style')
-rw-r--r--.rubocop_todo/style/bare_percent_literals.yml1
-rw-r--r--.rubocop_todo/style/class_and_module_children.yml5
-rw-r--r--.rubocop_todo/style/empty_method.yml2
-rw-r--r--.rubocop_todo/style/format_string.yml5
-rw-r--r--.rubocop_todo/style/guard_clause.yml8
-rw-r--r--.rubocop_todo/style/if_inside_else.yml1
-rw-r--r--.rubocop_todo/style/if_unless_modifier.yml17
-rw-r--r--.rubocop_todo/style/next.yml1
-rw-r--r--.rubocop_todo/style/numeric_literal_prefix.yml4
-rw-r--r--.rubocop_todo/style/open_struct_use.yml27
-rw-r--r--.rubocop_todo/style/percent_literal_delimiters.yml16
-rw-r--r--.rubocop_todo/style/redundant_interpolation.yml1
-rw-r--r--.rubocop_todo/style/redundant_regexp_escape.yml1
-rw-r--r--.rubocop_todo/style/redundant_self.yml4
-rw-r--r--.rubocop_todo/style/string_concatenation.yml3
-rw-r--r--.rubocop_todo/style/string_literals_in_interpolation.yml2
-rw-r--r--.rubocop_todo/style/symbol_proc.yml1
17 files changed, 10 insertions, 89 deletions
diff --git a/.rubocop_todo/style/bare_percent_literals.yml b/.rubocop_todo/style/bare_percent_literals.yml
index 658c6c22baa..104ead817d5 100644
--- a/.rubocop_todo/style/bare_percent_literals.yml
+++ b/.rubocop_todo/style/bare_percent_literals.yml
@@ -10,7 +10,6 @@ Style/BarePercentLiterals:
- 'app/models/integrations/datadog.rb'
- 'app/services/feature_flags/base_service.rb'
- 'app/services/repositories/base_service.rb'
- - 'app/services/repositories/destroy_rollback_service.rb'
- 'app/services/repositories/destroy_service.rb'
- 'ee/app/services/jira/jql_builder_service.rb'
- 'ee/lib/ee/gitlab/checks/push_rules/file_size_check.rb'
diff --git a/.rubocop_todo/style/class_and_module_children.yml b/.rubocop_todo/style/class_and_module_children.yml
index 9d89acfb394..fab05667adb 100644
--- a/.rubocop_todo/style/class_and_module_children.yml
+++ b/.rubocop_todo/style/class_and_module_children.yml
@@ -220,14 +220,11 @@ Style/ClassAndModuleChildren:
- 'app/controllers/projects/runner_projects_controller.rb'
- 'app/controllers/projects/runners_controller.rb'
- 'app/controllers/projects/service_desk_controller.rb'
- - 'app/controllers/projects/service_hook_logs_controller.rb'
- 'app/controllers/projects/service_ping_controller.rb'
- - 'app/controllers/projects/services_controller.rb'
- 'app/controllers/projects/snippets/application_controller.rb'
- 'app/controllers/projects/snippets/blobs_controller.rb'
- 'app/controllers/projects/snippets_controller.rb'
- 'app/controllers/projects/starrers_controller.rb'
- - 'app/controllers/projects/static_site_editor_controller.rb'
- 'app/controllers/projects/tags/releases_controller.rb'
- 'app/controllers/projects/tags_controller.rb'
- 'app/controllers/projects/templates_controller.rb'
@@ -354,9 +351,7 @@ Style/ClassAndModuleChildren:
- 'app/serializers/merge_requests/pipeline_entity.rb'
- 'app/services/projects/branches_by_mode_service.rb'
- 'app/services/repositories/base_service.rb'
- - 'app/services/repositories/destroy_rollback_service.rb'
- 'app/services/repositories/destroy_service.rb'
- - 'app/services/repositories/shell_destroy_service.rb'
- 'app/uploaders/dependency_proxy/file_uploader.rb'
- 'app/uploaders/packages/composer/cache_uploader.rb'
- 'app/uploaders/packages/debian/component_file_uploader.rb'
diff --git a/.rubocop_todo/style/empty_method.yml b/.rubocop_todo/style/empty_method.yml
index 9bca01015aa..aa3972a0b22 100644
--- a/.rubocop_todo/style/empty_method.yml
+++ b/.rubocop_todo/style/empty_method.yml
@@ -53,7 +53,7 @@ Style/EmptyMethod:
- 'app/controllers/projects/pipeline_schedules_controller.rb'
- 'app/controllers/projects/product_analytics_controller.rb'
- 'app/controllers/projects/runners_controller.rb'
- - 'app/controllers/projects/services_controller.rb'
+ - 'app/controllers/projects/settings/integrations_controller.rb'
- 'app/controllers/projects/settings/packages_and_registries_controller.rb'
- 'app/controllers/projects/tags/releases_controller.rb'
- 'app/controllers/projects/terraform_controller.rb'
diff --git a/.rubocop_todo/style/format_string.yml b/.rubocop_todo/style/format_string.yml
index 82ece4dd3bd..a9065bb5932 100644
--- a/.rubocop_todo/style/format_string.yml
+++ b/.rubocop_todo/style/format_string.yml
@@ -41,7 +41,6 @@ Style/FormatString:
- 'app/controllers/projects/merge_requests_controller.rb'
- 'app/controllers/projects/performance_monitoring/dashboards_controller.rb'
- 'app/controllers/projects/pipeline_schedules_controller.rb'
- - 'app/controllers/projects/services_controller.rb'
- 'app/controllers/projects/settings/ci_cd_controller.rb'
- 'app/controllers/projects_controller.rb'
- 'app/controllers/search_controller.rb'
@@ -109,7 +108,6 @@ Style/FormatString:
- 'app/models/integrations/external_wiki.rb'
- 'app/models/integrations/flowdock.rb'
- 'app/models/integrations/hangouts_chat.rb'
- - 'app/models/integrations/irker.rb'
- 'app/models/integrations/jenkins.rb'
- 'app/models/integrations/jira.rb'
- 'app/models/integrations/mattermost.rb'
@@ -184,7 +182,6 @@ Style/FormatString:
- 'config/initializers/rack_lineprof.rb'
- 'danger/roulette/Dangerfile'
- 'ee/app/components/billing/plan_component.rb'
- - 'ee/app/components/namespaces/preview_free_user_cap_alert_component.rb'
- 'ee/app/controllers/admin/elasticsearch_controller.rb'
- 'ee/app/controllers/admin/geo/application_controller.rb'
- 'ee/app/controllers/admin/geo/projects_controller.rb'
@@ -237,7 +234,6 @@ Style/FormatString:
- 'ee/app/services/merge_requests/create_from_vulnerability_data_service.rb'
- 'ee/app/services/namespaces/check_excess_storage_size_service.rb'
- 'ee/app/services/namespaces/check_storage_size_service.rb'
- - 'ee/app/services/network_policies/responses.rb'
- 'ee/app/services/security/security_orchestration_policies/policy_configuration_validation_service.rb'
- 'ee/app/services/security/security_orchestration_policies/validate_policy_service.rb'
- 'ee/app/services/timebox_report_service.rb'
@@ -265,7 +261,6 @@ Style/FormatString:
- 'ee/lib/gitlab/expiring_subscription_message.rb'
- 'ee/lib/gitlab/geo.rb'
- 'ee/lib/gitlab/manual_quarterly_co_term_banner.rb'
- - 'ee/lib/gitlab/manual_renewal_banner.rb'
- 'ee/lib/gitlab/vulnerabilities/container_scanning_vulnerability.rb'
- 'ee/lib/tasks/gitlab/elastic.rake'
- 'ee/spec/controllers/admin/licenses_controller_spec.rb'
diff --git a/.rubocop_todo/style/guard_clause.yml b/.rubocop_todo/style/guard_clause.yml
index 12eda8abf13..c7109639677 100644
--- a/.rubocop_todo/style/guard_clause.yml
+++ b/.rubocop_todo/style/guard_clause.yml
@@ -60,7 +60,6 @@ Style/GuardClause:
- 'app/finders/ci/runners_finder.rb'
- 'app/finders/deployments_finder.rb'
- 'app/finders/group_members_finder.rb'
- - 'app/finders/projects/serverless/functions_finder.rb'
- 'app/finders/snippets_finder.rb'
- 'app/graphql/mutations/concerns/mutations/spam_protection.rb'
- 'app/graphql/mutations/design_management/delete.rb'
@@ -73,7 +72,6 @@ Style/GuardClause:
- 'app/graphql/resolvers/concerns/time_frame_arguments.rb'
- 'app/graphql/resolvers/projects/jira_projects_resolver.rb'
- 'app/graphql/types/ci/job_type.rb'
- - 'app/graphql/types/concerns/find_closest.rb'
- 'app/helpers/admin/user_actions_helper.rb'
- 'app/helpers/appearances_helper.rb'
- 'app/helpers/application_helper.rb'
@@ -135,7 +133,6 @@ Style/GuardClause:
- 'app/models/integrations/datadog.rb'
- 'app/models/integrations/emails_on_push.rb'
- 'app/models/integrations/harbor.rb'
- - 'app/models/integrations/irker.rb'
- 'app/models/integrations/jenkins.rb'
- 'app/models/integrations/jira.rb'
- 'app/models/integrations/pipelines_email.rb'
@@ -236,7 +233,6 @@ Style/GuardClause:
- 'app/services/post_receive_service.rb'
- 'app/services/projects/after_rename_service.rb'
- 'app/services/projects/create_service.rb'
- - 'app/services/projects/destroy_rollback_service.rb'
- 'app/services/projects/destroy_service.rb'
- 'app/services/projects/hashed_storage/rollback_service.rb'
- 'app/services/projects/import_export/export_service.rb'
@@ -247,7 +243,6 @@ Style/GuardClause:
- 'app/services/projects/update_service.rb'
- 'app/services/protected_branches/legacy_api_update_service.rb'
- 'app/services/snippets/repository_validation_service.rb'
- - 'app/services/static_site_editor/config_service.rb'
- 'app/services/todo_service.rb'
- 'app/services/users/build_service.rb'
- 'app/services/users/update_service.rb'
@@ -465,7 +460,6 @@ Style/GuardClause:
- 'ee/lib/gitlab/insights/serializers/chartjs/multi_series_serializer.rb'
- 'ee/lib/gitlab/insights/validators/params_validator.rb'
- 'ee/lib/omni_auth/strategies/group_saml.rb'
- - 'ee/lib/pseudonymizer/dumper.rb'
- 'ee/spec/features/billings/billing_plans_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb'
- 'ee/spec/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker_spec.rb'
@@ -547,7 +541,6 @@ Style/GuardClause:
- 'lib/gitlab/database/partitioning/sliding_list_strategy.rb'
- 'lib/gitlab/database/postgresql_adapter/force_disconnectable_mixin.rb'
- 'lib/gitlab/database/query_analyzers/restrict_allowed_schemas.rb'
- - 'lib/gitlab/diff/custom_diff.rb'
- 'lib/gitlab/diff/file.rb'
- 'lib/gitlab/diff/highlight.rb'
- 'lib/gitlab/diff/highlight_cache.rb'
@@ -582,7 +575,6 @@ Style/GuardClause:
- 'lib/gitlab/graphql/pagination/keyset/conditions/null_condition.rb'
- 'lib/gitlab/graphql/pagination/keyset/order_info.rb'
- 'lib/gitlab/graphql/pagination/keyset/query_builder.rb'
- - 'lib/gitlab/graphql/query_analyzers/recursion_analyzer.rb'
- 'lib/gitlab/i18n/metadata_entry.rb'
- 'lib/gitlab/i18n/po_linter.rb'
- 'lib/gitlab/import_export/after_export_strategies/web_upload_strategy.rb'
diff --git a/.rubocop_todo/style/if_inside_else.yml b/.rubocop_todo/style/if_inside_else.yml
index fcddbae74fc..3ce6e5ec704 100644
--- a/.rubocop_todo/style/if_inside_else.yml
+++ b/.rubocop_todo/style/if_inside_else.yml
@@ -14,7 +14,6 @@ Style/IfInsideElse:
- 'app/models/ci/build.rb'
- 'app/models/namespace.rb'
- 'app/presenters/project_presenter.rb'
- - 'app/services/service_ping/build_payload_service.rb'
- 'app/services/system_notes/commit_service.rb'
- 'app/services/task_list_toggle_service.rb'
- 'app/services/user_project_access_changed_service.rb'
diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml
index 7bbc62d4c27..645fc5f764c 100644
--- a/.rubocop_todo/style/if_unless_modifier.yml
+++ b/.rubocop_todo/style/if_unless_modifier.yml
@@ -8,7 +8,6 @@ Style/IfUnlessModifier:
- 'app/channels/graphql_channel.rb'
- 'app/controllers/admin/application_settings_controller.rb'
- 'app/controllers/admin/projects_controller.rb'
- - 'app/controllers/admin/requests_profiles_controller.rb'
- 'app/controllers/admin/runners_controller.rb'
- 'app/controllers/admin/users_controller.rb'
- 'app/controllers/application_controller.rb'
@@ -57,7 +56,6 @@ Style/IfUnlessModifier:
- 'app/controllers/projects/protected_refs_controller.rb'
- 'app/controllers/projects/releases_controller.rb'
- 'app/controllers/projects/runners_controller.rb'
- - 'app/controllers/projects/services_controller.rb'
- 'app/controllers/registrations_controller.rb'
- 'app/controllers/repositories/git_http_controller.rb'
- 'app/controllers/repositories/lfs_api_controller.rb'
@@ -204,7 +202,6 @@ Style/IfUnlessModifier:
- 'app/models/integrations/base_chat_notification.rb'
- 'app/models/integrations/datadog.rb'
- 'app/models/integrations/harbor.rb'
- - 'app/models/integrations/irker.rb'
- 'app/models/integrations/jenkins.rb'
- 'app/models/integrations/jira.rb'
- 'app/models/integrations/pushover.rb'
@@ -381,13 +378,11 @@ Style/IfUnlessModifier:
- 'app/services/projects/update_repository_storage_service.rb'
- 'app/services/resource_access_tokens/create_service.rb'
- 'app/services/resource_events/change_labels_service.rb'
- - 'app/services/service_ping/devops_report_service.rb'
- 'app/services/snippets/create_service.rb'
- 'app/services/snippets/destroy_service.rb'
- 'app/services/snippets/repository_validation_service.rb'
- 'app/services/spam/spam_action_service.rb'
- 'app/services/spam/spam_verdict_service.rb'
- - 'app/services/static_site_editor/config_service.rb'
- 'app/services/system_notes/issuables_service.rb'
- 'app/services/tags/destroy_service.rb'
- 'app/services/two_factor/destroy_service.rb'
@@ -416,7 +411,6 @@ Style/IfUnlessModifier:
- 'app/views/projects/merge_requests/index.atom.builder'
- 'app/workers/authorized_project_update/user_refresh_from_replica_worker.rb'
- 'app/workers/auto_devops/disable_worker.rb'
- - 'app/workers/bulk_imports/pipeline_worker.rb'
- 'app/workers/cleanup_container_repository_worker.rb'
- 'app/workers/concerns/application_worker.rb'
- 'app/workers/concerns/packages/cleanup_artifact_worker.rb'
@@ -424,7 +418,6 @@ Style/IfUnlessModifier:
- 'app/workers/concerns/worker_attributes.rb'
- 'app/workers/database/batched_background_migration/single_database_worker.rb'
- 'app/workers/file_hook_worker.rb'
- - 'app/workers/issue_rebalancing_worker.rb'
- 'app/workers/issues/rebalancing_worker.rb'
- 'app/workers/merge_request_mergeability_check_worker.rb'
- 'app/workers/object_storage/migrate_uploads_worker.rb'
@@ -501,7 +494,6 @@ Style/IfUnlessModifier:
- 'ee/app/controllers/projects/push_rules_controller.rb'
- 'ee/app/controllers/projects/settings/slacks_controller.rb'
- 'ee/app/controllers/trials_controller.rb'
- - 'ee/app/finders/ee/alert_management/alerts_finder.rb'
- 'ee/app/finders/iterations_finder.rb'
- 'ee/app/finders/merge_trains_finder.rb'
- 'ee/app/finders/security/pipeline_vulnerabilities_finder.rb'
@@ -614,8 +606,6 @@ Style/IfUnlessModifier:
- 'ee/app/services/ee/users/update_service.rb'
- 'ee/app/services/elastic/indexing_control_service.rb'
- 'ee/app/services/elastic/process_bookkeeping_service.rb'
- - 'ee/app/services/epic_links/create_service.rb'
- - 'ee/app/services/epic_links/update_service.rb'
- 'ee/app/services/epics/base_service.rb'
- 'ee/app/services/epics/create_service.rb'
- 'ee/app/services/epics/update_dates_service.rb'
@@ -723,7 +713,6 @@ Style/IfUnlessModifier:
- 'ee/lib/gitlab/geo/log_cursor/daemon.rb'
- 'ee/lib/gitlab/geo/log_cursor/events/repository_deleted_event.rb'
- 'ee/lib/gitlab/geo/oauth/logout_token.rb'
- - 'ee/lib/gitlab/geo/replication/base_transfer.rb'
- 'ee/lib/gitlab/geo/replication/blob_downloader.rb'
- 'ee/lib/gitlab/geo/replicator.rb'
- 'ee/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate.rb'
@@ -739,13 +728,10 @@ Style/IfUnlessModifier:
- 'ee/lib/gitlab/usage/metrics/instrumentations/count_users_creating_ci_builds_metric.rb'
- 'ee/lib/gitlab/usage/metrics/instrumentations/license_metric.rb'
- 'ee/lib/omni_auth/strategies/group_saml.rb'
- - 'ee/lib/pseudonymizer/dumper.rb'
- - 'ee/lib/pseudonymizer/uploader.rb'
- 'ee/lib/sidebars/groups/menus/administration_menu.rb'
- 'ee/lib/sidebars/groups/menus/analytics_menu.rb'
- 'ee/lib/sidebars/groups/menus/security_compliance_menu.rb'
- 'ee/lib/tasks/geo.rake'
- - 'ee/lib/tasks/gitlab/db.rake'
- 'ee/lib/tasks/gitlab/geo.rake'
- 'ee/lib/tasks/gitlab/seed/insights.rake'
- 'ee/spec/controllers/subscriptions_controller_spec.rb'
@@ -949,7 +935,6 @@ Style/IfUnlessModifier:
- 'lib/gitlab/database/reindexing/reindex_concurrently.rb'
- 'lib/gitlab/database/transaction/observer.rb'
- 'lib/gitlab/database/with_lock_retries.rb'
- - 'lib/gitlab/diff/custom_diff.rb'
- 'lib/gitlab/diff/formatters/base_formatter.rb'
- 'lib/gitlab/diff/rendered/notebook/diff_file.rb'
- 'lib/gitlab/elasticsearch/logs/lines.rb'
@@ -1158,7 +1143,6 @@ Style/IfUnlessModifier:
- 'rubocop/cop/ignored_columns.rb'
- 'rubocop/cop/migration/add_limit_to_text_columns.rb'
- 'rubocop/cop/migration/add_reference.rb'
- - 'rubocop/cop/migration/hash_index.rb'
- 'rubocop/cop/migration/remove_column.rb'
- 'rubocop/cop/migration/sidekiq_queue_migrate.rb'
- 'rubocop/cop/performance/ar_exists_and_present_blank.rb'
@@ -1180,7 +1164,6 @@ Style/IfUnlessModifier:
- 'spec/factories/projects.rb'
- 'spec/factories/protected_tags.rb'
- 'spec/factories/users.rb'
- - 'spec/factories_spec.rb'
- 'spec/features/admin/admin_users_spec.rb'
- 'spec/features/merge_request/batch_comments_spec.rb'
- 'spec/features/merge_request/user_sees_avatar_on_diff_notes_spec.rb'
diff --git a/.rubocop_todo/style/next.yml b/.rubocop_todo/style/next.yml
index e1f9b927db6..ba2bd293696 100644
--- a/.rubocop_todo/style/next.yml
+++ b/.rubocop_todo/style/next.yml
@@ -5,7 +5,6 @@ Style/Next:
# Temporarily disabled due to too many offenses
Enabled: false
Exclude:
- - 'app/finders/projects/serverless/functions_finder.rb'
- 'app/models/preloaders/environments/deployment_preloader.rb'
- 'app/models/route.rb'
- 'app/services/authorized_project_update/find_records_due_for_refresh_service.rb'
diff --git a/.rubocop_todo/style/numeric_literal_prefix.yml b/.rubocop_todo/style/numeric_literal_prefix.yml
index b469a68ff5a..ea0b028d11c 100644
--- a/.rubocop_todo/style/numeric_literal_prefix.yml
+++ b/.rubocop_todo/style/numeric_literal_prefix.yml
@@ -10,16 +10,12 @@ Style/NumericLiteralPrefix:
- 'config/initializers/01_secret_token.rb'
- 'config/initializers/1_settings.rb'
- 'db/post_migrate/20220131000001_schedule_trace_expiry_removal.rb'
- - 'ee/lib/gitlab/geo/replication/base_transfer.rb'
- 'ee/lib/gitlab/geo/replication/blob_downloader.rb'
- 'ee/spec/lib/bulk_imports/groups/pipelines/iterations_pipeline_spec.rb'
- 'ee/spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb'
- 'ee/spec/lib/gitlab/geo/replication/blob_downloader_spec.rb'
- - 'ee/spec/lib/gitlab/geo/replication/file_transfer_spec.rb'
- - 'ee/spec/lib/gitlab/geo/replication/job_artifact_transfer_spec.rb'
- 'ee/spec/migrations/schedule_trace_expiry_removal_spec.rb'
- 'ee/spec/models/analytics/devops_adoption/snapshot_spec.rb'
- - 'ee/spec/models/ci/minutes/quota_spec.rb'
- 'ee/spec/models/ee/group_spec.rb'
- 'ee/spec/models/gitlab/seat_link_data_spec.rb'
- 'ee/spec/services/incident_management/oncall_schedules/update_service_spec.rb'
diff --git a/.rubocop_todo/style/open_struct_use.yml b/.rubocop_todo/style/open_struct_use.yml
index e6af3b7bf24..15e4539072d 100644
--- a/.rubocop_todo/style/open_struct_use.yml
+++ b/.rubocop_todo/style/open_struct_use.yml
@@ -1,21 +1,12 @@
---
Style/OpenStructUse:
Exclude:
- - ee/spec/features/projects/new_project_spec.rb
- - ee/spec/finders/template_finder_spec.rb
- - ee/spec/helpers/ee/blob_helper_spec.rb
- - ee/spec/lib/gitlab/auth/group_saml/failure_handler_spec.rb
- - ee/spec/lib/gitlab/legacy_github_import/project_creator_spec.rb
- - lib/gitlab/testing/request_inspector_middleware.rb
- - spec/factories/wiki_pages.rb
- - spec/graphql/mutations/branches/create_spec.rb
- - spec/graphql/mutations/clusters/agent_tokens/create_spec.rb
- - spec/graphql/mutations/clusters/agents/create_spec.rb
- - spec/graphql/mutations/clusters/agents/delete_spec.rb
- - spec/graphql/mutations/commits/create_spec.rb
- - spec/helpers/application_settings_helper_spec.rb
- - spec/helpers/profiles_helper_spec.rb
- - spec/lib/gitlab/gitaly_client/blobs_stitcher_spec.rb
- - spec/lib/gitlab/gitaly_client/diff_stitcher_spec.rb
- - spec/services/system_note_service_spec.rb
- - spec/support/helpers/repo_helpers.rb
+ - 'ee/spec/features/projects/new_project_spec.rb'
+ - 'ee/spec/finders/template_finder_spec.rb'
+ - 'ee/spec/helpers/ee/blob_helper_spec.rb'
+ - 'ee/spec/lib/gitlab/auth/group_saml/failure_handler_spec.rb'
+ - 'spec/factories/wiki_pages.rb'
+ - 'spec/helpers/profiles_helper_spec.rb'
+ - 'spec/lib/gitlab/gitaly_client/blobs_stitcher_spec.rb'
+ - 'spec/lib/gitlab/gitaly_client/diff_stitcher_spec.rb'
+ - 'spec/support/helpers/repo_helpers.rb'
diff --git a/.rubocop_todo/style/percent_literal_delimiters.yml b/.rubocop_todo/style/percent_literal_delimiters.yml
index bf50c4c1922..487e0e7cd20 100644
--- a/.rubocop_todo/style/percent_literal_delimiters.yml
+++ b/.rubocop_todo/style/percent_literal_delimiters.yml
@@ -117,7 +117,6 @@ Style/PercentLiteralDelimiters:
- 'app/models/integrations/external_wiki.rb'
- 'app/models/integrations/field.rb'
- 'app/models/integrations/flowdock.rb'
- - 'app/models/integrations/irker.rb'
- 'app/models/integrations/jenkins.rb'
- 'app/models/integrations/jira.rb'
- 'app/models/integrations/packagist.rb'
@@ -178,7 +177,6 @@ Style/PercentLiteralDelimiters:
- 'app/services/projects/update_service.rb'
- 'app/services/prometheus/proxy_service.rb'
- 'app/services/repositories/base_service.rb'
- - 'app/services/repositories/destroy_rollback_service.rb'
- 'app/services/repositories/destroy_service.rb'
- 'app/services/repository_archive_clean_up_service.rb'
- 'app/services/resource_access_tokens/create_service.rb'
@@ -192,7 +190,6 @@ Style/PercentLiteralDelimiters:
- 'app/validators/addressable_url_validator.rb'
- 'app/validators/gitlab/zoom_url_validator.rb'
- 'app/validators/json_schema_validator.rb'
- - 'app/workers/irker_worker.rb'
- 'app/workers/members_destroyer/unassign_issuables_worker.rb'
- 'app/workers/projects/record_target_platforms_worker.rb'
- 'config/application.rb'
@@ -229,7 +226,6 @@ Style/PercentLiteralDelimiters:
- 'db/migrate/20210621044000_rename_services_indexes_to_integrations.rb'
- 'db/migrate/20210709085759_index_batched_migration_jobs_by_max_value.rb'
- 'db/migrate/20210928155022_improve_index_for_error_tracking.rb'
- - 'db/optional_migrations/composite_primary_keys.rb'
- 'db/post_migrate/20210329102724_add_new_trail_plans.rb'
- 'db/post_migrate/20210420121149_backfill_conversion_of_ci_job_artifacts.rb'
- 'db/post_migrate/20210426094549_backfill_ci_builds_for_bigint_conversion.rb'
@@ -296,7 +292,6 @@ Style/PercentLiteralDelimiters:
- 'ee/lib/api/managed_licenses.rb'
- 'ee/lib/api/status_checks.rb'
- 'ee/lib/api/visual_review_discussions.rb'
- - 'ee/lib/banzai/pipeline/incident_management/timeline_event_pipeline.rb'
- 'ee/lib/ee/api/helpers/members_helpers.rb'
- 'ee/lib/ee/api/helpers/projects_helpers.rb'
- 'ee/lib/ee/api/search.rb'
@@ -308,7 +303,6 @@ Style/PercentLiteralDelimiters:
- 'ee/lib/ee/gitlab/checks/push_rules/file_size_check.rb'
- 'ee/lib/ee/gitlab/ci/parsers/security/validators/schema_validator.rb'
- 'ee/lib/ee/gitlab/etag_caching/router/rails.rb'
- - 'ee/lib/ee/gitlab/integrations/sti_type.rb'
- 'ee/lib/ee/gitlab/middleware/read_only/controller.rb'
- 'ee/lib/ee/gitlab/path_regex.rb'
- 'ee/lib/ee/gitlab/uploads/migration_helper.rb'
@@ -319,7 +313,6 @@ Style/PercentLiteralDelimiters:
- 'ee/lib/elastic/latest/git_class_proxy.rb'
- 'ee/lib/elastic/latest/project_instance_proxy.rb'
- 'ee/lib/elastic/latest/snippet_class_proxy.rb'
- - 'ee/lib/gitlab/alert_management/payload/cilium.rb'
- 'ee/lib/gitlab/auth/group_saml/auth_hash.rb'
- 'ee/lib/gitlab/ci/parsers/security/formatters/dast.rb'
- 'ee/lib/gitlab/geo.rb'
@@ -371,7 +364,6 @@ Style/PercentLiteralDelimiters:
- 'ee/spec/lib/banzai/filter/references/epic_reference_filter_spec.rb'
- 'ee/spec/lib/banzai/filter/references/iteration_reference_filter_spec.rb'
- 'ee/spec/lib/banzai/filter/references/vulnerability_reference_filters_spec.rb'
- - 'ee/spec/lib/banzai/pipeline/incident_management/timeline_event_pipeline_spec.rb'
- 'ee/spec/lib/ee/gitlab/alert_management/payload/generic_spec.rb'
- 'ee/spec/lib/ee/gitlab/auth/ldap/access_levels_spec.rb'
- 'ee/spec/lib/ee/gitlab/auth/ldap/config_spec.rb'
@@ -561,7 +553,6 @@ Style/PercentLiteralDelimiters:
- 'lib/gitlab/gitaly_client/diff.rb'
- 'lib/gitlab/gitaly_client/wiki_page.rb'
- 'lib/gitlab/graphql/pagination/keyset/order_info.rb'
- - 'lib/gitlab/graphql/query_analyzers/recursion_analyzer.rb'
- 'lib/gitlab/hotlinking_detector.rb'
- 'lib/gitlab/import_export/command_line_util.rb'
- 'lib/gitlab/import_export/file_importer.rb'
@@ -648,10 +639,6 @@ Style/PercentLiteralDelimiters:
- 'rubocop/migration_helpers.rb'
- 'scripts/qa/testcases-check'
- 'scripts/regenerate-schema'
- - 'shared/packages/6b/86/6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b/packages/57/files/67/package.gemspec'
- - 'shared/packages/6b/86/6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b/packages/6/files/5/package.gemspec'
- - 'shared/packages/6b/86/6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b/packages/7/files/7/package.gemspec'
- - 'shared/packages/6b/86/6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b/packages/88/files/91/package.gemspec'
- 'sidekiq_cluster/cli.rb'
- 'spec/benchmarks/banzai_benchmark.rb'
- 'spec/commands/sidekiq_cluster/cli_spec.rb'
@@ -676,7 +663,6 @@ Style/PercentLiteralDelimiters:
- 'spec/controllers/projects/performance_monitoring/dashboards_controller_spec.rb'
- 'spec/controllers/projects/pipelines_controller_spec.rb'
- 'spec/controllers/projects/settings/ci_cd_controller_spec.rb'
- - 'spec/controllers/projects/static_site_editor_controller_spec.rb'
- 'spec/controllers/projects_controller_spec.rb'
- 'spec/controllers/registrations/welcome_controller_spec.rb'
- 'spec/controllers/search_controller_spec.rb'
@@ -898,7 +884,6 @@ Style/PercentLiteralDelimiters:
- 'spec/lib/gitlab/jira_import/issue_serializer_spec.rb'
- 'spec/lib/gitlab/jira_import/labels_importer_spec.rb'
- 'spec/lib/gitlab/kubernetes/kubectl_cmd_spec.rb'
- - 'spec/lib/gitlab/kubernetes/network_policy_spec.rb'
- 'spec/lib/gitlab/kubernetes/role_spec.rb'
- 'spec/lib/gitlab/language_data_spec.rb'
- 'spec/lib/gitlab/markup_helper_spec.rb'
@@ -1001,7 +986,6 @@ Style/PercentLiteralDelimiters:
- 'spec/models/integrations/bamboo_spec.rb'
- 'spec/models/integrations/buildkite_spec.rb'
- 'spec/models/integrations/campfire_spec.rb'
- - 'spec/models/integrations/irker_spec.rb'
- 'spec/models/integrations/jira_spec.rb'
- 'spec/models/integrations/teamcity_spec.rb'
- 'spec/models/issue_spec.rb'
diff --git a/.rubocop_todo/style/redundant_interpolation.yml b/.rubocop_todo/style/redundant_interpolation.yml
index fb190ff2100..0d3651eb7b2 100644
--- a/.rubocop_todo/style/redundant_interpolation.yml
+++ b/.rubocop_todo/style/redundant_interpolation.yml
@@ -77,7 +77,6 @@ Style/RedundantInterpolation:
- 'qa/qa/resource/events/base.rb'
- 'qa/qa/service/praefect_manager.rb'
- 'qa/qa/specs/features/browser_ui/4_verify/pipeline/include_multiple_files_from_a_project_spec.rb'
- - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/parent_child_pipelines_dependent_relationship_spec.rb'
- 'qa/qa/specs/features/browser_ui/5_package/container_registry/container_registry_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_templates_spec.rb'
- 'qa/qa/tools/generate_perf_testdata.rb'
diff --git a/.rubocop_todo/style/redundant_regexp_escape.yml b/.rubocop_todo/style/redundant_regexp_escape.yml
index 1a88f62ab64..969a23601ca 100644
--- a/.rubocop_todo/style/redundant_regexp_escape.yml
+++ b/.rubocop_todo/style/redundant_regexp_escape.yml
@@ -35,7 +35,6 @@ Style/RedundantRegexpEscape:
- 'ee/lib/gitlab/geo/git_ssh_proxy.rb'
- 'ee/lib/gitlab/return_to_location.rb'
- 'ee/spec/features/read_only_spec.rb'
- - 'ee/spec/helpers/seats_count_alert_helper_spec.rb'
- 'ee/spec/helpers/vulnerabilities_helper_spec.rb'
- 'ee/spec/lib/ee/gitlab/usage_data_counters/hll_redis_counter_spec.rb'
- 'ee/spec/mailers/notify_spec.rb'
diff --git a/.rubocop_todo/style/redundant_self.yml b/.rubocop_todo/style/redundant_self.yml
index e363f83761b..1aba23c90ae 100644
--- a/.rubocop_todo/style/redundant_self.yml
+++ b/.rubocop_todo/style/redundant_self.yml
@@ -260,7 +260,6 @@ Style/RedundantSelf:
- 'ee/lib/elastic/latest/note_config.rb'
- 'ee/lib/elastic/migration.rb'
- 'ee/lib/gem_extensions/elasticsearch/model/indexing/instance_methods.rb'
- - 'ee/lib/gitlab/alert_management/payload/cilium.rb'
- 'ee/lib/gitlab/analytics/cycle_analytics/summary/base_time.rb'
- 'ee/lib/gitlab/auth/group_saml/response_check.rb'
- 'ee/lib/gitlab/auth/group_saml/user.rb'
@@ -277,7 +276,6 @@ Style/RedundantSelf:
- 'ee/lib/gitlab/geo/oauth/logout_state.rb'
- 'ee/lib/gitlab/geo/replicator.rb'
- 'ee/lib/gitlab/template/custom_template.rb'
- - 'ee/lib/system_check/app/elasticsearch_check.rb'
- 'ee/spec/helpers/ee/feature_flags_helper_spec.rb'
- 'ee/spec/helpers/ee/graph_helper_spec.rb'
- 'ee/spec/models/geo/deleted_project_spec.rb'
@@ -365,8 +363,6 @@ Style/RedundantSelf:
- 'lib/gitlab/instrumentation/redis_base.rb'
- 'lib/gitlab/jira_import.rb'
- 'lib/gitlab/jwt_token.rb'
- - 'lib/gitlab/kubernetes/cilium_network_policy.rb'
- - 'lib/gitlab/kubernetes/network_policy.rb'
- 'lib/gitlab/logger.rb'
- 'lib/gitlab/marker_range.rb'
- 'lib/gitlab/memory/instrumentation.rb'
diff --git a/.rubocop_todo/style/string_concatenation.yml b/.rubocop_todo/style/string_concatenation.yml
index 23a16f928f5..8c8dbf86b1c 100644
--- a/.rubocop_todo/style/string_concatenation.yml
+++ b/.rubocop_todo/style/string_concatenation.yml
@@ -301,11 +301,9 @@ Style/StringConcatenation:
- 'spec/services/packages/helm/extract_file_metadata_service_spec.rb'
- 'spec/services/packages/helm/process_file_service_spec.rb'
- 'spec/services/projects/create_service_spec.rb'
- - 'spec/services/projects/destroy_rollback_service_spec.rb'
- 'spec/services/projects/destroy_service_spec.rb'
- 'spec/services/projects/download_service_spec.rb'
- 'spec/services/push_event_payload_service_spec.rb'
- - 'spec/services/repositories/destroy_rollback_service_spec.rb'
- 'spec/services/repositories/destroy_service_spec.rb'
- 'spec/services/snippets/bulk_destroy_service_spec.rb'
- 'spec/services/snippets/update_service_spec.rb'
@@ -317,7 +315,6 @@ Style/StringConcatenation:
- 'spec/support/helpers/git_helpers.rb'
- 'spec/support/helpers/gitaly_setup.rb'
- 'spec/support/helpers/javascript_fixtures_helpers.rb'
- - 'spec/support/helpers/jira_service_helper.rb'
- 'spec/support/helpers/kubernetes_helpers.rb'
- 'spec/support/helpers/stub_configuration.rb'
- 'spec/support/helpers/workhorse_helpers.rb'
diff --git a/.rubocop_todo/style/string_literals_in_interpolation.yml b/.rubocop_todo/style/string_literals_in_interpolation.yml
index 3f3cb007306..cded81afa7f 100644
--- a/.rubocop_todo/style/string_literals_in_interpolation.yml
+++ b/.rubocop_todo/style/string_literals_in_interpolation.yml
@@ -24,7 +24,6 @@ Style/StringLiteralsInInterpolation:
- 'ee/app/models/license.rb'
- 'ee/app/services/epics/tree_reorder_service.rb'
- 'ee/lib/gitlab/elastic/helper.rb'
- - 'ee/lib/pseudonymizer/pager.rb'
- 'ee/spec/features/admin/admin_settings_spec.rb'
- 'lib/api/helpers/snippets_helpers.rb'
- 'lib/api/validations/validators/check_assignees_count.rb'
@@ -54,7 +53,6 @@ Style/StringLiteralsInInterpolation:
- 'qa/qa/specs/helpers/context_selector.rb'
- 'qa/qa/tools/generate_perf_testdata.rb'
- 'rubocop/cop/migration/prevent_index_creation.rb'
- - 'spec/controllers/projects/serverless/functions_controller_spec.rb'
- 'spec/features/commits_spec.rb'
- 'spec/features/dashboard/merge_requests_spec.rb'
- 'spec/features/users/login_spec.rb'
diff --git a/.rubocop_todo/style/symbol_proc.yml b/.rubocop_todo/style/symbol_proc.yml
index 12e20553e1a..5e3aa10d9e5 100644
--- a/.rubocop_todo/style/symbol_proc.yml
+++ b/.rubocop_todo/style/symbol_proc.yml
@@ -113,7 +113,6 @@ Style/SymbolProc:
- 'ee/app/workers/geo/batch/project_registry_worker.rb'
- 'ee/app/workers/geo/sync_timeout_cron_worker.rb'
- 'ee/app/workers/geo/verification_cron_worker.rb'
- - 'ee/app/workers/repository_push_audit_event_worker.rb'
- 'ee/lib/api/entities/pending_member.rb'
- 'ee/lib/api/related_epic_links.rb'
- 'ee/lib/ee/api/entities/audit_event.rb'
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-15 20:04:51 +0300