diff options
Diffstat (limited to '.rubocop_todo')
35 files changed, 50 insertions, 107 deletions
diff --git a/.rubocop_todo/gitlab/avoid_gitlab_instance_checks.yml b/.rubocop_todo/gitlab/avoid_gitlab_instance_checks.yml index 77a880115da..8a10208663e 100644 --- a/.rubocop_todo/gitlab/avoid_gitlab_instance_checks.yml +++ b/.rubocop_todo/gitlab/avoid_gitlab_instance_checks.yml @@ -135,7 +135,6 @@ Gitlab/AvoidGitlabInstanceChecks: - 'lib/gitlab/gon_helper.rb' - 'lib/gitlab/monitor/demo_projects.rb' - 'lib/gitlab/qa.rb' - - 'lib/gitlab/tracking/destinations/database_events_snowplow.rb' - 'lib/gitlab/tracking/standard_context.rb' - 'lib/gitlab/usage/metrics/instrumentations/count_ci_internal_pipelines_metric.rb' - 'lib/gitlab/usage/metrics/instrumentations/count_issues_created_manually_from_alerts_metric.rb' diff --git a/.rubocop_todo/gitlab/strong_memoize_attr.yml b/.rubocop_todo/gitlab/strong_memoize_attr.yml index 2429c2f8d7d..21287d1bd2b 100644 --- a/.rubocop_todo/gitlab/strong_memoize_attr.yml +++ b/.rubocop_todo/gitlab/strong_memoize_attr.yml @@ -452,7 +452,6 @@ Gitlab/StrongMemoizeAttr: - 'lib/api/container_repositories.rb' - 'lib/api/entities/basic_project_details.rb' - 'lib/api/helpers/authentication.rb' - - 'lib/api/terraform/modules/v1/packages.rb' - 'lib/api/unleash.rb' - 'lib/atlassian/jira_connect/jwt/asymmetric.rb' - 'lib/atlassian/jira_connect/jwt/symmetric.rb' diff --git a/.rubocop_todo/layout/array_alignment.yml b/.rubocop_todo/layout/array_alignment.yml index e8860e75d67..dcb2667bc31 100644 --- a/.rubocop_todo/layout/array_alignment.yml +++ b/.rubocop_todo/layout/array_alignment.yml @@ -183,7 +183,6 @@ Layout/ArrayAlignment: - 'qa/qa/specs/features/browser_ui/5_package/package_registry/npm/npm_instance_level_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/npm/npm_project_level_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/pypi_repository_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/10_govern/group/group_audit_logs_2_spec.rb' - 'qa/spec/specs/runner_spec.rb' - 'rubocop/cop/gitlab/rspec/avoid_setup.rb' - 'rubocop/cop/graphql/authorize_types.rb' @@ -284,7 +283,6 @@ Layout/ArrayAlignment: - 'spec/lib/gitlab/usage_data/topology_spec.rb' - 'spec/lib/gitlab/utils/merge_hash_spec.rb' - 'spec/lib/gitlab/visibility_level_spec.rb' - - 'spec/models/application_setting_spec.rb' - 'spec/models/ci/bridge_spec.rb' - 'spec/models/ci/build_spec.rb' - 'spec/models/ci/group_spec.rb' diff --git a/.rubocop_todo/layout/empty_line_after_magic_comment.yml b/.rubocop_todo/layout/empty_line_after_magic_comment.yml index 409acc4b5c1..3d6266a7438 100644 --- a/.rubocop_todo/layout/empty_line_after_magic_comment.yml +++ b/.rubocop_todo/layout/empty_line_after_magic_comment.yml @@ -203,8 +203,6 @@ Layout/EmptyLineAfterMagicComment: - 'ee/app/services/ee/system_notes/issuables_service.rb' - 'ee/app/services/gitlab_subscriptions/fetch_subscription_plans_service.rb' - 'ee/app/services/gitlab_subscriptions/reconciliations/calculate_seat_count_data_service.rb' - - 'ee/app/services/group_saml/group_managed_accounts/clean_up_members_service.rb' - - 'ee/app/services/group_saml/sign_up_service.rb' - 'ee/app/services/merge_trains/create_pipeline_service.rb' - 'ee/app/services/merge_trains/refresh_merge_request_service.rb' - 'ee/app/services/merge_trains/refresh_service.rb' @@ -312,9 +310,9 @@ Layout/EmptyLineAfterMagicComment: - 'ee/spec/models/ci/minutes/quota_spec.rb' - 'ee/spec/models/ci/minutes/usage_spec.rb' - 'ee/spec/models/deployments/approval_summary_spec.rb' - - 'ee/spec/models/group_member_spec.rb' + - 'ee/spec/models/ee/group_member_spec.rb' - 'ee/spec/models/packages/package_file_spec.rb' - - 'ee/spec/models/project_member_spec.rb' + - 'ee/spec/models/ee/project_member_spec.rb' - 'ee/spec/models/protected_environment_spec.rb' - 'ee/spec/models/protected_environments/approval_rule_spec.rb' - 'ee/spec/models/protected_environments/deploy_access_level_spec.rb' diff --git a/.rubocop_todo/layout/first_hash_element_indentation.yml b/.rubocop_todo/layout/first_hash_element_indentation.yml index 83ce52272b7..4a8ddfdbdf5 100644 --- a/.rubocop_todo/layout/first_hash_element_indentation.yml +++ b/.rubocop_todo/layout/first_hash_element_indentation.yml @@ -113,10 +113,8 @@ Layout/FirstHashElementIndentation: - 'ee/spec/services/ee/projects/unlink_fork_service_spec.rb' - 'ee/spec/services/external_status_checks/create_service_spec.rb' - 'ee/spec/services/external_status_checks/destroy_service_spec.rb' - - 'ee/spec/services/groups/create_service_spec.rb' - 'ee/spec/services/groups/destroy_service_spec.rb' - 'ee/spec/services/iterations/create_service_spec.rb' - - 'ee/spec/services/projects/create_service_spec.rb' - 'ee/spec/services/projects/disable_deploy_key_service_spec.rb' - 'ee/spec/services/projects/enable_deploy_key_service_spec.rb' - 'ee/spec/services/projects/group_links/create_service_spec.rb' diff --git a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml index 7bc8d095585..8c05d745fbb 100644 --- a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml +++ b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml @@ -293,7 +293,6 @@ Layout/LineEndStringConcatenationIndentation: - 'spec/services/snippets/create_service_spec.rb' - 'spec/services/users/email_verification/validate_token_service_spec.rb' - 'spec/services/work_items/parent_links/create_service_spec.rb' - - 'spec/support/before_all_adapter.rb' - 'spec/support/helpers/database/multiple_databases_helpers.rb' - 'spec/support/helpers/redis_without_keys.rb' - 'spec/support/matchers/have_gitlab_http_status.rb' diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index 4e78d896a89..684681750b4 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -496,8 +496,8 @@ Layout/LineLength: - 'app/services/environments/schedule_to_delete_review_apps_service.rb' - 'app/services/feature_flags/update_service.rb' - 'app/services/git/process_ref_changes_service.rb' - - 'app/services/google_cloud/create_service_accounts_service.rb' - - 'app/services/google_cloud/generate_pipeline_service.rb' + - 'app/services/cloud_seed/google_cloud/create_service_accounts_service.rb' + - 'app/services/cloud_seed/google_cloud/generate_pipeline_service.rb' - 'app/services/groups/create_service.rb' - 'app/services/groups/destroy_service.rb' - 'app/services/groups/transfer_service.rb' @@ -1012,9 +1012,7 @@ Layout/LineLength: - 'ee/app/services/geo/request_service.rb' - 'ee/app/services/geo/verification_state_backfill_service.rb' - 'ee/app/services/gitlab_subscriptions/plan_upgrade_service.rb' - - 'ee/app/services/group_saml/group_managed_accounts/transfer_membership_service.rb' - 'ee/app/services/group_saml/saml_provider/base_service.rb' - - 'ee/app/services/group_saml/sign_up_service.rb' - 'ee/app/services/groups/memberships/export_service.rb' - 'ee/app/services/groups/sync_service.rb' - 'ee/app/services/incident_management/create_incident_sla_exceeded_label_service.rb' @@ -1350,7 +1348,6 @@ Layout/LineLength: - 'ee/spec/features/groups/saml_providers_spec.rb' - 'ee/spec/features/groups/scim_token_spec.rb' - 'ee/spec/features/groups/security/compliance_dashboards_spec.rb' - - 'ee/spec/features/groups/sso_spec.rb' - 'ee/spec/features/integrations/jira/jira_issues_list_spec.rb' - 'ee/spec/features/issues/filtered_search/filter_issues_weight_spec.rb' - 'ee/spec/features/issues/form_spec.rb' @@ -1794,7 +1791,7 @@ Layout/LineLength: - 'ee/spec/models/geo_node_status_spec.rb' - 'ee/spec/models/gitlab_subscription_spec.rb' - 'ee/spec/models/gitlab_subscriptions/features_spec.rb' - - 'ee/spec/models/group_member_spec.rb' + - 'ee/spec/models/ee/group_member_spec.rb' - 'ee/spec/models/historical_data_spec.rb' - 'ee/spec/models/incident_management/escalation_policy_spec.rb' - 'ee/spec/models/incident_management/escalation_rule_spec.rb' @@ -1807,7 +1804,7 @@ Layout/LineLength: - 'ee/spec/models/issue_spec.rb' - 'ee/spec/models/iteration_spec.rb' - 'ee/spec/models/license_spec.rb' - - 'ee/spec/models/member_spec.rb' + - 'ee/spec/models/ee/member_spec.rb' - 'ee/spec/models/merge_request_spec.rb' - 'ee/spec/models/merge_requests/compliance_violation_spec.rb' - 'ee/spec/models/merge_requests/external_status_check_spec.rb' @@ -1816,7 +1813,7 @@ Layout/LineLength: - 'ee/spec/models/packages/package_file_spec.rb' - 'ee/spec/models/project_import_data_spec.rb' - 'ee/spec/models/project_import_state_spec.rb' - - 'ee/spec/models/project_member_spec.rb' + - 'ee/spec/models/ee/project_member_spec.rb' - 'ee/spec/models/project_security_setting_spec.rb' - 'ee/spec/models/protected_environment_spec.rb' - 'ee/spec/models/protected_environments/approval_rule_spec.rb' @@ -2117,7 +2114,6 @@ Layout/LineLength: - 'ee/spec/services/geo/hashed_storage_attachments_event_store_spec.rb' - 'ee/spec/services/gitlab_subscriptions/check_future_renewal_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/create_service_spec.rb' - - 'ee/spec/services/groups/create_service_spec.rb' - 'ee/spec/services/groups/memberships/export_service_spec.rb' - 'ee/spec/services/groups/transfer_service_spec.rb' - 'ee/spec/services/groups/update_repository_storage_service_spec.rb' @@ -2430,7 +2426,6 @@ Layout/LineLength: - 'lib/api/suggestions.rb' - 'lib/api/tags.rb' - 'lib/api/templates.rb' - - 'lib/api/terraform/modules/v1/packages.rb' - 'lib/api/terraform/state.rb' - 'lib/api/todos.rb' - 'lib/api/users.rb' @@ -4312,7 +4307,7 @@ Layout/LineLength: - 'spec/requests/api/search_spec.rb' - 'spec/requests/api/settings_spec.rb' - 'spec/requests/api/snippets_spec.rb' - - 'spec/requests/api/terraform/modules/v1/packages_spec.rb' + - 'spec/requests/api/terraform/modules/v1/namespace_packages_spec.rb' - 'spec/requests/api/terraform/modules/v1/project_packages_spec.rb' - 'spec/requests/api/todos_spec.rb' - 'spec/requests/api/topics_spec.rb' @@ -4458,11 +4453,10 @@ Layout/LineLength: - 'spec/services/files/update_service_spec.rb' - 'spec/services/git/branch_hooks_service_spec.rb' - 'spec/services/git/branch_push_service_spec.rb' - - 'spec/services/google_cloud/enable_cloud_run_service_spec.rb' - - 'spec/services/google_cloud/gcp_region_add_or_replace_service_spec.rb' - - 'spec/services/google_cloud/service_accounts_service_spec.rb' + - 'spec/services/cloud_seed/google_cloud/enable_cloud_run_service_spec.rb' + - 'spec/services/cloud_seed/google_cloud/gcp_region_add_or_replace_service_spec.rb' + - 'spec/services/cloud_seed/google_cloud/service_accounts_service_spec.rb' - 'spec/services/groups/autocomplete_service_spec.rb' - - 'spec/services/groups/create_service_spec.rb' - 'spec/services/groups/transfer_service_spec.rb' - 'spec/services/groups/update_service_spec.rb' - 'spec/services/groups/update_shared_runners_service_spec.rb' @@ -4564,7 +4558,6 @@ Layout/LineLength: - 'spec/services/packages/nuget/search_service_spec.rb' - 'spec/services/packages/nuget/update_package_from_metadata_service_spec.rb' - 'spec/services/packages/rubygems/process_gem_service_spec.rb' - - 'spec/services/packages/terraform_module/create_package_service_spec.rb' - 'spec/services/personal_access_tokens/create_service_spec.rb' - 'spec/services/post_receive_service_spec.rb' - 'spec/services/projects/apple_target_platform_detector_service_spec.rb' diff --git a/.rubocop_todo/layout/space_in_lambda_literal.yml b/.rubocop_todo/layout/space_in_lambda_literal.yml index 7e3af689b5f..bd901e40016 100644 --- a/.rubocop_todo/layout/space_in_lambda_literal.yml +++ b/.rubocop_todo/layout/space_in_lambda_literal.yml @@ -354,12 +354,11 @@ Layout/SpaceInLambdaLiteral: - 'lib/gitlab/event_store.rb' - 'lib/gitlab/gl_repository.rb' - 'lib/gitlab/health_checks/server.rb' - - 'lib/gitlab/import_export/import_failure_service.rb' - 'lib/gitlab/merge_requests/message_generator.rb' - 'lib/gitlab/metrics/exporter/base_exporter.rb' - 'lib/gitlab/visibility_level.rb' - 'spec/deprecation_toolkit_env.rb' - - 'spec/features/admin/users/user_spec.rb' + - 'spec/features/admin/users/admin_sees_unconfirmed_user_spec.rb' - 'spec/helpers/namespaces_helper_spec.rb' - 'spec/lib/backup/gitaly_backup_spec.rb' - 'spec/lib/container_registry/client_spec.rb' diff --git a/.rubocop_todo/layout/space_inside_parens.yml b/.rubocop_todo/layout/space_inside_parens.yml index 34f13f780fb..d044e48d7aa 100644 --- a/.rubocop_todo/layout/space_inside_parens.yml +++ b/.rubocop_todo/layout/space_inside_parens.yml @@ -35,7 +35,7 @@ Layout/SpaceInsideParens: - 'ee/spec/models/iteration_spec.rb' - 'ee/spec/models/ldap_group_link_spec.rb' - 'ee/spec/models/license_spec.rb' - - 'ee/spec/models/member_spec.rb' + - 'ee/spec/models/ee/member_spec.rb' - 'ee/spec/models/release_highlight_spec.rb' - 'ee/spec/models/security/orchestration_policy_configuration_spec.rb' - 'ee/spec/models/vulnerabilities/feedback_spec.rb' diff --git a/.rubocop_todo/lint/symbol_conversion.yml b/.rubocop_todo/lint/symbol_conversion.yml index eae5c89eef7..893e457ddff 100644 --- a/.rubocop_todo/lint/symbol_conversion.yml +++ b/.rubocop_todo/lint/symbol_conversion.yml @@ -5,7 +5,7 @@ Lint/SymbolConversion: - 'app/helpers/breadcrumbs_helper.rb' - 'app/helpers/environments_helper.rb' - 'app/helpers/tooling/visual_review_helper.rb' - - 'app/services/google_cloud/create_cloudsql_instance_service.rb' + - 'app/services/cloud_seed/google_cloud/create_cloudsql_instance_service.rb' - 'config/puma.rb' - 'ee/app/components/billing/plan_component.rb' - 'ee/app/controllers/projects/security/scanned_resources_controller.rb' diff --git a/.rubocop_todo/lint/unused_block_argument.yml b/.rubocop_todo/lint/unused_block_argument.yml index 1df273d408d..f14c02c4ecd 100644 --- a/.rubocop_todo/lint/unused_block_argument.yml +++ b/.rubocop_todo/lint/unused_block_argument.yml @@ -131,7 +131,7 @@ Lint/UnusedBlockArgument: - 'ee/spec/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate_spec.rb' - 'ee/spec/lib/gitlab/insights/project_insights_config_spec.rb' - 'ee/spec/lib/gitlab/usage_data_metrics_spec.rb' - - 'ee/spec/models/member_spec.rb' + - 'ee/spec/models/ee/member_spec.rb' - 'ee/spec/requests/api/graphql/project/pipeline/security_report_summary_spec.rb' - 'ee/spec/requests/api/graphql/vulnerabilities/sort_spec.rb' - 'ee/spec/requests/api/related_epic_links_spec.rb' diff --git a/.rubocop_todo/naming/heredoc_delimiter_naming.yml b/.rubocop_todo/naming/heredoc_delimiter_naming.yml index 92f5994092b..50f359fa448 100644 --- a/.rubocop_todo/naming/heredoc_delimiter_naming.yml +++ b/.rubocop_todo/naming/heredoc_delimiter_naming.yml @@ -105,7 +105,7 @@ Naming/HeredocDelimiterNaming: - 'spec/services/ci/create_web_ide_terminal_service_spec.rb' - 'spec/services/ci/parse_dotenv_artifact_service_spec.rb' - 'spec/services/ci/pipeline_processing/atomic_processing_service_spec.rb' - - 'spec/services/google_cloud/generate_pipeline_service_spec.rb' + - 'spec/services/cloud_seed/google_cloud/generate_pipeline_service_spec.rb' - 'spec/services/task_list_toggle_service_spec.rb' - 'spec/support/helpers/repo_helpers.rb' - 'spec/support/helpers/seed_repo.rb' diff --git a/.rubocop_todo/performance/map_compact.yml b/.rubocop_todo/performance/map_compact.yml index 8f831bf8f59..576a610006e 100644 --- a/.rubocop_todo/performance/map_compact.yml +++ b/.rubocop_todo/performance/map_compact.yml @@ -31,7 +31,7 @@ Performance/MapCompact: - 'app/services/events/render_service.rb' - 'app/services/feature_flags/update_service.rb' - 'app/services/git/base_hooks_service.rb' - - 'app/services/google_cloud/fetch_google_ip_list_service.rb' + - 'app/services/cloud_seed/google_cloud/fetch_google_ip_list_service.rb' - 'app/services/jira_import/start_import_service.rb' - 'app/services/jira_import/users_mapper_service.rb' - 'app/services/labels/available_labels_service.rb' @@ -75,7 +75,7 @@ Performance/MapCompact: - 'ee/lib/gitlab/ci/reports/metrics/reports_comparer.rb' - 'ee/lib/gitlab/search/aggregation_parser.rb' - 'ee/spec/models/analytics/issues_analytics_spec.rb' - - 'ee/spec/models/member_spec.rb' + - 'ee/spec/models/ee/member_spec.rb' - 'ee/spec/requests/api/audit_events_spec.rb' - 'ee/spec/requests/api/search_spec.rb' - 'haml_lint/linter/no_plain_nodes.rb' diff --git a/.rubocop_todo/rails/avoid_time_comparison.yml b/.rubocop_todo/rails/avoid_time_comparison.yml new file mode 100644 index 00000000000..e6b6e9fadaf --- /dev/null +++ b/.rubocop_todo/rails/avoid_time_comparison.yml @@ -0,0 +1,13 @@ +--- +Rails/AvoidTimeComparison: + Details: grace period + Exclude: + - 'app/services/packages/mark_package_files_for_destruction_service.rb' + - 'app/workers/container_registry/migration/enqueuer_worker.rb' + - 'app/workers/gitlab/import/advance_stage.rb' + - 'ee/app/services/incident_management/pending_escalations/process_service.rb' + - 'ee/app/workers/update_all_mirrors_worker.rb' + - 'lib/gitlab/chaos.rb' + - 'lib/gitlab/database/background_migration/batched_migration.rb' + - 'spec/lib/gitlab/ci/cron_parser_spec.rb' + - 'spec/support/helpers/wait_helpers.rb' diff --git a/.rubocop_todo/rails/file_path.yml b/.rubocop_todo/rails/file_path.yml index b7291734253..49d95cfeac3 100644 --- a/.rubocop_todo/rails/file_path.yml +++ b/.rubocop_todo/rails/file_path.yml @@ -99,7 +99,6 @@ Rails/FilePath: - 'spec/lib/gitlab/feature_categories_spec.rb' - 'spec/lib/gitlab/file_hook_spec.rb' - 'spec/lib/gitlab/jwt_authenticatable_spec.rb' - - 'spec/lib/gitlab/legacy_http_spec.rb' - 'spec/lib/gitlab/mail_room/mail_room_spec.rb' - 'spec/lib/gitlab/middleware/multipart/handler_spec.rb' - 'spec/lib/gitlab/multi_destination_logger_spec.rb' diff --git a/.rubocop_todo/rspec/any_instance_of.yml b/.rubocop_todo/rspec/any_instance_of.yml index 9393170aa03..bac4094b61b 100644 --- a/.rubocop_todo/rspec/any_instance_of.yml +++ b/.rubocop_todo/rspec/any_instance_of.yml @@ -251,7 +251,6 @@ RSpec/AnyInstanceOf: - 'spec/services/events/render_service_spec.rb' - 'spec/services/git/branch_push_service_spec.rb' - 'spec/services/git/process_ref_changes_service_spec.rb' - - 'spec/services/groups/create_service_spec.rb' - 'spec/services/groups/update_service_spec.rb' - 'spec/services/issuable/destroy_service_spec.rb' - 'spec/services/issues/close_service_spec.rb' diff --git a/.rubocop_todo/rspec/before_all_role_assignment.yml b/.rubocop_todo/rspec/before_all_role_assignment.yml index fcdaf78ffe8..1d015869b37 100644 --- a/.rubocop_todo/rspec/before_all_role_assignment.yml +++ b/.rubocop_todo/rspec/before_all_role_assignment.yml @@ -68,7 +68,6 @@ RSpec/BeforeAllRoleAssignment: - 'ee/spec/features/boards/sidebar_spec.rb' - 'ee/spec/features/boards/swimlanes/epics_swimlanes_sidebar_spec.rb' - 'ee/spec/features/burnup_charts_spec.rb' - - 'ee/spec/features/ci/ci_catalog_spec.rb' - 'ee/spec/features/dashboards/todos_spec.rb' - 'ee/spec/features/epic_boards/epic_boards_sidebar_spec.rb' - 'ee/spec/features/epic_boards/epic_boards_spec.rb' @@ -265,7 +264,6 @@ RSpec/BeforeAllRoleAssignment: - 'ee/spec/graphql/types/vulnerability_response_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_scanner_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_type_spec.rb' - - 'ee/spec/helpers/ee/ci/catalog/resources_helper_spec.rb' - 'ee/spec/helpers/ee/ci/pipeline_editor_helper_spec.rb' - 'ee/spec/helpers/ee/environments_helper_spec.rb' - 'ee/spec/helpers/ee/groups_helper_spec.rb' @@ -321,7 +319,7 @@ RSpec/BeforeAllRoleAssignment: - 'ee/spec/models/ee/vulnerability_spec.rb' - 'ee/spec/models/epic_issue_spec.rb' - 'ee/spec/models/epic_spec.rb' - - 'ee/spec/models/group_member_spec.rb' + - 'ee/spec/models/ee/group_member_spec.rb' - 'ee/spec/models/instance_security_dashboard_spec.rb' - 'ee/spec/models/issue_spec.rb' - 'ee/spec/models/merge_request_spec.rb' @@ -552,7 +550,6 @@ RSpec/BeforeAllRoleAssignment: - 'ee/spec/requests/jwt_controller_spec.rb' - 'ee/spec/requests/lfs_locks_api_spec.rb' - 'ee/spec/requests/projects/analytics/cycle_analytics/stages_controller_spec.rb' - - 'ee/spec/requests/projects/ci/catalog/resources_controller_spec.rb' - 'ee/spec/requests/projects/dependencies_controller_spec.rb' - 'ee/spec/requests/projects/issues_controller_spec.rb' - 'ee/spec/requests/projects/on_demand_scans_controller_spec.rb' @@ -739,7 +736,6 @@ RSpec/BeforeAllRoleAssignment: - 'ee/spec/workers/ee/new_issue_worker_spec.rb' - 'ee/spec/workers/groups/export_memberships_worker_spec.rb' - 'ee/spec/workers/llm/completion_worker_spec.rb' - - 'ee/spec/workers/merge_requests/llm/summarize_merge_request_worker_spec.rb' - 'ee/spec/workers/security/orchestration_configuration_create_bot_worker_spec.rb' - 'spec/controllers/autocomplete_controller_spec.rb' - 'spec/controllers/dashboard_controller_spec.rb' @@ -800,7 +796,7 @@ RSpec/BeforeAllRoleAssignment: - 'spec/controllers/projects_controller_spec.rb' - 'spec/controllers/repositories/lfs_storage_controller_spec.rb' - 'spec/features/admin/admin_projects_spec.rb' - - 'spec/features/admin/users/user_spec.rb' + - 'spec/features/admin/users/admin_sees_user_spec.rb' - 'spec/features/admin/users/users_spec.rb' - 'spec/features/boards/board_filters_spec.rb' - 'spec/features/boards/new_issue_spec.rb' @@ -1330,7 +1326,6 @@ RSpec/BeforeAllRoleAssignment: - 'spec/requests/api/rpm_project_packages_spec.rb' - 'spec/requests/api/rubygem_packages_spec.rb' - 'spec/requests/api/search_spec.rb' - - 'spec/requests/api/terraform/modules/v1/packages_spec.rb' - 'spec/requests/api/wikis_spec.rb' - 'spec/requests/concerns/planning_hierarchy_spec.rb' - 'spec/requests/groups/deploy_tokens_controller_spec.rb' @@ -1406,7 +1401,7 @@ RSpec/BeforeAllRoleAssignment: - 'spec/services/environments/schedule_to_delete_review_apps_service_spec.rb' - 'spec/services/files/base_service_spec.rb' - 'spec/services/git/branch_push_service_spec.rb' - - 'spec/services/google_cloud/generate_pipeline_service_spec.rb' + - 'spec/services/cloud_seed/google_cloud/generate_pipeline_service_spec.rb' - 'spec/services/groups/auto_devops_service_spec.rb' - 'spec/services/groups/autocomplete_service_spec.rb' - 'spec/services/groups/group_links/create_service_spec.rb' diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index 54e523dbfb2..7859119eb60 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -109,7 +109,6 @@ RSpec/ContextWording: - 'ee/spec/features/groups/saml_enforcement_spec.rb' - 'ee/spec/features/groups/saml_providers_spec.rb' - 'ee/spec/features/groups/security/compliance_dashboards_spec.rb' - - 'ee/spec/features/groups/sso_spec.rb' - 'ee/spec/features/groups_spec.rb' - 'ee/spec/features/ide/user_opens_ide_spec.rb' - 'ee/spec/features/issues/epic_in_issue_sidebar_spec.rb' @@ -453,7 +452,7 @@ RSpec/ContextWording: - 'ee/spec/models/geo_node_spec.rb' - 'ee/spec/models/geo_node_status_spec.rb' - 'ee/spec/models/gitlab_subscription_spec.rb' - - 'ee/spec/models/group_member_spec.rb' + - 'ee/spec/models/ee/group_member_spec.rb' - 'ee/spec/models/group_wiki_repository_spec.rb' - 'ee/spec/models/incident_management/escalation_rule_spec.rb' - 'ee/spec/models/incident_management/oncall_rotation_spec.rb' @@ -467,7 +466,7 @@ RSpec/ContextWording: - 'ee/spec/models/issue_spec.rb' - 'ee/spec/models/iteration_spec.rb' - 'ee/spec/models/license_spec.rb' - - 'ee/spec/models/member_spec.rb' + - 'ee/spec/models/ee/member_spec.rb' - 'ee/spec/models/merge_request/blocking_spec.rb' - 'ee/spec/models/merge_request_spec.rb' - 'ee/spec/models/namespace_setting_spec.rb' @@ -476,7 +475,7 @@ RSpec/ContextWording: - 'ee/spec/models/path_lock_spec.rb' - 'ee/spec/models/project_import_data_spec.rb' - 'ee/spec/models/project_import_state_spec.rb' - - 'ee/spec/models/project_member_spec.rb' + - 'ee/spec/models/ee/project_member_spec.rb' - 'ee/spec/models/protected_environment_spec.rb' - 'ee/spec/models/push_rule_spec.rb' - 'ee/spec/models/release_highlight_spec.rb' @@ -714,8 +713,6 @@ RSpec/ContextWording: - 'ee/spec/services/geo/prune_event_log_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/create_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/preview_billable_user_change_service_spec.rb' - - 'ee/spec/services/group_saml/group_managed_accounts/transfer_membership_service_spec.rb' - - 'ee/spec/services/groups/create_service_spec.rb' - 'ee/spec/services/groups/destroy_service_spec.rb' - 'ee/spec/services/groups/mark_for_deletion_service_spec.rb' - 'ee/spec/services/groups/memberships/export_service_spec.rb' @@ -750,7 +747,6 @@ RSpec/ContextWording: - 'ee/spec/services/personal_access_tokens/rotation_verifier_service_spec.rb' - 'ee/spec/services/projects/alerting/notify_service_spec.rb' - 'ee/spec/services/projects/create_from_template_service_spec.rb' - - 'ee/spec/services/projects/create_service_spec.rb' - 'ee/spec/services/projects/destroy_service_spec.rb' - 'ee/spec/services/projects/gitlab_projects_import_service_spec.rb' - 'ee/spec/services/projects/group_links/create_service_spec.rb' @@ -1040,7 +1036,7 @@ RSpec/ContextWording: - 'spec/features/admin/admin_mode_spec.rb' - 'spec/features/admin/admin_settings_spec.rb' - 'spec/features/admin/dashboard_spec.rb' - - 'spec/features/admin/users/user_spec.rb' + - 'spec/features/admin/users/admin_impersonates_user_spec.rb' - 'spec/features/admin/users/users_spec.rb' - 'spec/features/atom/dashboard_issues_spec.rb' - 'spec/features/atom/dashboard_spec.rb' @@ -1842,7 +1838,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/kubernetes/default_namespace_spec.rb' - 'spec/lib/gitlab/kubernetes/kube_client_spec.rb' - 'spec/lib/gitlab/legacy_github_import/client_spec.rb' - - 'spec/lib/gitlab/legacy_http_spec.rb' - 'spec/lib/gitlab/lfs/client_spec.rb' - 'spec/lib/gitlab/lfs_token_spec.rb' - 'spec/lib/gitlab/lograge/custom_options_spec.rb' @@ -2388,7 +2383,6 @@ RSpec/ContextWording: - 'spec/requests/api/tags_spec.rb' - 'spec/requests/api/task_completion_status_spec.rb' - 'spec/requests/api/templates_spec.rb' - - 'spec/requests/api/terraform/modules/v1/packages_spec.rb' - 'spec/requests/api/terraform/state_spec.rb' - 'spec/requests/api/terraform/state_version_spec.rb' - 'spec/requests/api/todos_spec.rb' @@ -2561,9 +2555,8 @@ RSpec/ContextWording: - 'spec/services/git/tag_push_service_spec.rb' - 'spec/services/git/wiki_push_service/change_spec.rb' - 'spec/services/git/wiki_push_service_spec.rb' - - 'spec/services/google_cloud/generate_pipeline_service_spec.rb' + - 'spec/services/cloud_seed/google_cloud/generate_pipeline_service_spec.rb' - 'spec/services/gpg_keys/create_service_spec.rb' - - 'spec/services/groups/create_service_spec.rb' - 'spec/services/groups/deploy_tokens/revoke_service_spec.rb' - 'spec/services/groups/destroy_service_spec.rb' - 'spec/services/groups/group_links/create_service_spec.rb' diff --git a/.rubocop_todo/rspec/expect_change.yml b/.rubocop_todo/rspec/expect_change.yml index f358600f4fe..2b178901b39 100644 --- a/.rubocop_todo/rspec/expect_change.yml +++ b/.rubocop_todo/rspec/expect_change.yml @@ -36,7 +36,7 @@ RSpec/ExpectChange: - 'ee/spec/models/gitlab_subscription_spec.rb' - 'ee/spec/models/group_wiki_spec.rb' - 'ee/spec/models/incident_management/issuable_escalation_status_spec.rb' - - 'ee/spec/models/member_spec.rb' + - 'ee/spec/models/ee/member_spec.rb' - 'ee/spec/models/project_import_state_spec.rb' - 'ee/spec/models/push_rule_spec.rb' - 'ee/spec/models/security/orchestration_policy_configuration_spec.rb' @@ -133,7 +133,6 @@ RSpec/ExpectChange: - 'ee/spec/services/iterations/delete_service_spec.rb' - 'ee/spec/services/iterations/roll_over_issues_service_spec.rb' - 'ee/spec/services/projects/alerting/notify_service_spec.rb' - - 'ee/spec/services/projects/create_service_spec.rb' - 'ee/spec/services/projects/destroy_service_spec.rb' - 'ee/spec/services/projects/hashed_storage/migrate_attachments_service_spec.rb' - 'ee/spec/services/projects/transfer_service_spec.rb' diff --git a/.rubocop_todo/rspec/expect_in_hook.yml b/.rubocop_todo/rspec/expect_in_hook.yml index a8896eed55d..0fc7ecfde58 100644 --- a/.rubocop_todo/rspec/expect_in_hook.yml +++ b/.rubocop_todo/rspec/expect_in_hook.yml @@ -236,7 +236,6 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/kas/client_spec.rb' - 'spec/lib/gitlab/kubernetes/kube_client_spec.rb' - 'spec/lib/gitlab/kubernetes/kubeconfig/template_spec.rb' - - 'spec/lib/gitlab/legacy_http_spec.rb' - 'spec/lib/gitlab/memory/instrumentation_spec.rb' - 'spec/lib/gitlab/memory/jemalloc_spec.rb' - 'spec/lib/gitlab/metrics/boot_time_tracker_spec.rb' diff --git a/.rubocop_todo/rspec/factory_bot/avoid_create.yml b/.rubocop_todo/rspec/factory_bot/avoid_create.yml index 6007b62c241..f2ea4e9673c 100644 --- a/.rubocop_todo/rspec/factory_bot/avoid_create.yml +++ b/.rubocop_todo/rspec/factory_bot/avoid_create.yml @@ -130,6 +130,7 @@ RSpec/FactoryBot/AvoidCreate: - 'ee/spec/serializers/dashboard_operations_project_entity_spec.rb' - 'ee/spec/serializers/dependency_entity_spec.rb' - 'ee/spec/serializers/dependency_list_serializer_spec.rb' + - 'ee/spec/serializers/ee/admin/abuse_report_details_entity_spec.rb' - 'ee/spec/serializers/ee/blob_entity_spec.rb' - 'ee/spec/serializers/ee/build_details_entity_spec.rb' - 'ee/spec/serializers/ee/ci/job_entity_spec.rb' @@ -191,6 +192,7 @@ RSpec/FactoryBot/AvoidCreate: - 'ee/spec/views/admin/groups/_form.html.haml_spec.rb' - 'ee/spec/views/admin/identities/index.html.haml_spec.rb' - 'ee/spec/views/admin/users/_credit_card_info.html.haml_spec.rb' + - 'ee/spec/views/admin/users/_phone_info.html.haml_spec.rb' - 'ee/spec/views/admin/users/index.html.haml_spec.rb' - 'ee/spec/views/admin/users/show.html.haml_spec.rb' - 'ee/spec/views/clusters/clusters/show.html.haml_spec.rb' @@ -414,6 +416,7 @@ RSpec/FactoryBot/AvoidCreate: - 'spec/presenters/user_presenter_spec.rb' - 'spec/presenters/web_hook_log_presenter_spec.rb' - 'spec/serializers/access_token_entity_base_spec.rb' + - 'spec/serializers/admin/abuse_report_details_entity_spec.rb' - 'spec/serializers/analytics_build_entity_spec.rb' - 'spec/serializers/analytics_build_serializer_spec.rb' - 'spec/serializers/analytics_issue_entity_spec.rb' diff --git a/.rubocop_todo/rspec/feature_category.yml b/.rubocop_todo/rspec/feature_category.yml index fac358d6543..aed72849075 100644 --- a/.rubocop_todo/rspec/feature_category.yml +++ b/.rubocop_todo/rspec/feature_category.yml @@ -1063,7 +1063,7 @@ RSpec/FeatureCategory: - 'ee/spec/models/gitlab_subscriptions/features_spec.rb' - 'ee/spec/models/gitlab_subscriptions/upcoming_reconciliation_spec.rb' - 'ee/spec/models/group_deletion_schedule_spec.rb' - - 'ee/spec/models/group_member_spec.rb' + - 'ee/spec/models/ee/group_member_spec.rb' - 'ee/spec/models/group_merge_request_approval_setting_spec.rb' - 'ee/spec/models/group_wiki_repository_spec.rb' - 'ee/spec/models/historical_data_spec.rb' @@ -1108,7 +1108,7 @@ RSpec/FeatureCategory: - 'ee/spec/models/project_ci_cd_setting_spec.rb' - 'ee/spec/models/project_feature_spec.rb' - 'ee/spec/models/project_import_data_spec.rb' - - 'ee/spec/models/project_member_spec.rb' + - 'ee/spec/models/ee/project_member_spec.rb' - 'ee/spec/models/project_repository_state_spec.rb' - 'ee/spec/models/project_security_setting_spec.rb' - 'ee/spec/models/protected_branch/required_code_owners_section_spec.rb' @@ -1688,7 +1688,6 @@ RSpec/FeatureCategory: - 'spec/dependencies/omniauth_saml_spec.rb' - 'spec/docs_screenshots/container_registry_docs.rb' - 'spec/docs_screenshots/wiki_docs.rb' - - 'spec/experiments/in_product_guidance_environments_webide_experiment_spec.rb' - 'spec/features/admin/dashboard_spec.rb' - 'spec/features/groups/integrations/group_integrations_spec.rb' - 'spec/features/milestones/user_views_milestones_spec.rb' @@ -2837,7 +2836,6 @@ RSpec/FeatureCategory: - 'spec/lib/gitlab/build_access_spec.rb' - 'spec/lib/gitlab/bullet_spec.rb' - 'spec/lib/gitlab/cache/helpers_spec.rb' - - 'spec/lib/gitlab/cache/import/caching_spec.rb' - 'spec/lib/gitlab/cache/metrics_spec.rb' - 'spec/lib/gitlab/cache/request_cache_spec.rb' - 'spec/lib/gitlab/cache_spec.rb' @@ -2934,8 +2932,6 @@ RSpec/FeatureCategory: - 'spec/lib/gitlab/ci/config/entry/retry_spec.rb' - 'spec/lib/gitlab/ci/config/entry/root_spec.rb' - 'spec/lib/gitlab/ci/config/entry/rules/rule/changes_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/rules/rule_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/rules_spec.rb' - 'spec/lib/gitlab/ci/config/entry/service_spec.rb' - 'spec/lib/gitlab/ci/config/entry/services_spec.rb' - 'spec/lib/gitlab/ci/config/entry/stage_spec.rb' @@ -3207,7 +3203,6 @@ RSpec/FeatureCategory: - 'spec/lib/gitlab/database/migration_helpers/announce_database_spec.rb' - 'spec/lib/gitlab/database/migration_helpers/cascading_namespace_settings_spec.rb' - 'spec/lib/gitlab/database/migration_helpers/loose_foreign_key_helpers_spec.rb' - - 'spec/lib/gitlab/database/migration_helpers/v2_spec.rb' - 'spec/lib/gitlab/database/migration_spec.rb' - 'spec/lib/gitlab/database/migrations/background_migration_helpers_spec.rb' - 'spec/lib/gitlab/database/migrations/base_background_runner_spec.rb' @@ -3692,15 +3687,11 @@ RSpec/FeatureCategory: - 'spec/lib/gitlab/lazy_spec.rb' - 'spec/lib/gitlab/legacy_github_import/branch_formatter_spec.rb' - 'spec/lib/gitlab/legacy_github_import/client_spec.rb' - - 'spec/lib/gitlab/legacy_github_import/comment_formatter_spec.rb' - 'spec/lib/gitlab/legacy_github_import/issuable_formatter_spec.rb' - - 'spec/lib/gitlab/legacy_github_import/issue_formatter_spec.rb' - 'spec/lib/gitlab/legacy_github_import/label_formatter_spec.rb' - 'spec/lib/gitlab/legacy_github_import/milestone_formatter_spec.rb' - 'spec/lib/gitlab/legacy_github_import/project_creator_spec.rb' - - 'spec/lib/gitlab/legacy_github_import/pull_request_formatter_spec.rb' - 'spec/lib/gitlab/legacy_github_import/release_formatter_spec.rb' - - 'spec/lib/gitlab/legacy_github_import/user_formatter_spec.rb' - 'spec/lib/gitlab/legacy_github_import/wiki_formatter_spec.rb' - 'spec/lib/gitlab/lets_encrypt/challenge_spec.rb' - 'spec/lib/gitlab/lets_encrypt/client_spec.rb' @@ -4363,7 +4354,6 @@ RSpec/FeatureCategory: - 'spec/models/concerns/counter_attribute_spec.rb' - 'spec/models/concerns/cron_schedulable_spec.rb' - 'spec/models/concerns/cross_database_modification_spec.rb' - - 'spec/models/concerns/database_event_tracking_spec.rb' - 'spec/models/concerns/database_reflection_spec.rb' - 'spec/models/concerns/delete_with_limit_spec.rb' - 'spec/models/concerns/deployment_platform_spec.rb' @@ -4744,7 +4734,6 @@ RSpec/FeatureCategory: - 'spec/models/users/credit_card_validation_spec.rb' - 'spec/models/users/ghost_user_migration_spec.rb' - 'spec/models/users/group_callout_spec.rb' - - 'spec/models/users/in_product_marketing_email_spec.rb' - 'spec/models/users/merge_request_interaction_spec.rb' - 'spec/models/users/phone_number_validation_spec.rb' - 'spec/models/users/project_callout_spec.rb' diff --git a/.rubocop_todo/rspec/instance_variable.yml b/.rubocop_todo/rspec/instance_variable.yml index a4d4c2119c0..9f268a71bd3 100644 --- a/.rubocop_todo/rspec/instance_variable.yml +++ b/.rubocop_todo/rspec/instance_variable.yml @@ -24,10 +24,8 @@ RSpec/InstanceVariable: - 'ee/spec/services/ee/notification_service_spec.rb' - 'ee/spec/services/ee/users/create_service_spec.rb' - 'ee/spec/services/geo/metrics_update_service_spec.rb' - - 'ee/spec/services/groups/create_service_spec.rb' - 'ee/spec/services/groups/participants_service_spec.rb' - 'ee/spec/services/projects/create_from_template_service_spec.rb' - - 'ee/spec/services/projects/create_service_spec.rb' - 'ee/spec/support/shared_examples/views/subscription_shared_examples.rb' - 'ee/spec/tasks/geo_rake_spec.rb' - 'ee/spec/views/projects/security/corpus_management/show.html.haml_spec.rb' @@ -96,7 +94,6 @@ RSpec/InstanceVariable: - 'spec/lib/gitlab/git/repository_spec.rb' - 'spec/lib/gitlab/import_export/group/tree_restorer_spec.rb' - 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb' - - 'spec/lib/gitlab/legacy_http_spec.rb' - 'spec/lib/gitlab/patch/prependable_spec.rb' - 'spec/lib/gitlab/popen_spec.rb' - 'spec/lib/gitlab/project_transfer_spec.rb' diff --git a/.rubocop_todo/rspec/named_subject.yml b/.rubocop_todo/rspec/named_subject.yml index eee81261597..a72575d26ba 100644 --- a/.rubocop_todo/rspec/named_subject.yml +++ b/.rubocop_todo/rspec/named_subject.yml @@ -193,7 +193,6 @@ RSpec/NamedSubject: - 'ee/spec/helpers/compliance_management/compliance_framework/group_settings_helper_spec.rb' - 'ee/spec/helpers/ee/auth_helper_spec.rb' - 'ee/spec/helpers/ee/branches_helper_spec.rb' - - 'ee/spec/helpers/ee/ci/catalog/resources_helper_spec.rb' - 'ee/spec/helpers/ee/ci/runners_helper_spec.rb' - 'ee/spec/helpers/ee/emails_helper_spec.rb' - 'ee/spec/helpers/ee/environments_helper_spec.rb' @@ -1101,7 +1100,6 @@ RSpec/NamedSubject: - 'ee/spec/services/product_analytics/initialize_stack_service_spec.rb' - 'ee/spec/services/projects/alerting/notify_service_spec.rb' - 'ee/spec/services/projects/create_from_template_service_spec.rb' - - 'ee/spec/services/projects/create_service_spec.rb' - 'ee/spec/services/projects/destroy_service_spec.rb' - 'ee/spec/services/projects/disable_legacy_inactive_projects_service_spec.rb' - 'ee/spec/services/projects/fork_service_spec.rb' @@ -1413,8 +1411,7 @@ RSpec/NamedSubject: - 'spec/controllers/uploads_controller_spec.rb' - 'spec/controllers/users/callouts_controller_spec.rb' - 'spec/experiments/application_experiment_spec.rb' - - 'spec/experiments/in_product_guidance_environments_webide_experiment_spec.rb' - - 'spec/features/admin/users/user_spec.rb' + - 'spec/features/admin/users/admin_impersonates_user_spec.rb' - 'spec/features/groups/clusters/user_spec.rb' - 'spec/features/merge_request/user_sees_merge_widget_spec.rb' - 'spec/features/user_settings/password_spec.rb' @@ -2425,7 +2422,6 @@ RSpec/NamedSubject: - 'spec/lib/gitlab/terraform_registry_token_spec.rb' - 'spec/lib/gitlab/throttle_spec.rb' - 'spec/lib/gitlab/time_tracking_formatter_spec.rb' - - 'spec/lib/gitlab/tracking/destinations/database_events_snowplow_spec.rb' - 'spec/lib/gitlab/tracking/destinations/snowplow_micro_spec.rb' - 'spec/lib/gitlab/tracking/destinations/snowplow_spec.rb' - 'spec/lib/gitlab/tracking_spec.rb' @@ -2975,7 +2971,6 @@ RSpec/NamedSubject: - 'spec/requests/api/releases_spec.rb' - 'spec/requests/api/rubygem_packages_spec.rb' - 'spec/requests/api/snippets_spec.rb' - - 'spec/requests/api/terraform/modules/v1/packages_spec.rb' - 'spec/requests/groups/settings/access_tokens_controller_spec.rb' - 'spec/requests/health_controller_spec.rb' - 'spec/requests/ide_controller_spec.rb' @@ -3021,7 +3016,6 @@ RSpec/NamedSubject: - 'spec/serializers/accessibility_error_entity_spec.rb' - 'spec/serializers/accessibility_reports_comparer_entity_spec.rb' - 'spec/serializers/accessibility_reports_comparer_serializer_spec.rb' - - 'spec/serializers/activity_pub/activity_streams_serializer_spec.rb' - 'spec/serializers/activity_pub/project_entity_spec.rb' - 'spec/serializers/activity_pub/release_entity_spec.rb' - 'spec/serializers/activity_pub/releases_actor_entity_spec.rb' @@ -3274,12 +3268,11 @@ RSpec/NamedSubject: - 'spec/services/git/process_ref_changes_service_spec.rb' - 'spec/services/git/tag_push_service_spec.rb' - 'spec/services/git/wiki_push_service_spec.rb' - - 'spec/services/google_cloud/fetch_google_ip_list_service_spec.rb' - - 'spec/services/google_cloud/setup_cloudsql_instance_service_spec.rb' + - 'spec/services/cloud_seed/google_cloud/fetch_google_ip_list_service_spec.rb' + - 'spec/services/cloud_seed/google_cloud/setup_cloudsql_instance_service_spec.rb' - 'spec/services/gpg_keys/create_service_spec.rb' - 'spec/services/gpg_keys/destroy_service_spec.rb' - 'spec/services/groups/autocomplete_service_spec.rb' - - 'spec/services/groups/create_service_spec.rb' - 'spec/services/groups/deploy_tokens/revoke_service_spec.rb' - 'spec/services/groups/group_links/create_service_spec.rb' - 'spec/services/groups/group_links/destroy_service_spec.rb' diff --git a/.rubocop_todo/rspec/return_from_stub.yml b/.rubocop_todo/rspec/return_from_stub.yml index 897d15c72ed..5aaa1847409 100644 --- a/.rubocop_todo/rspec/return_from_stub.yml +++ b/.rubocop_todo/rspec/return_from_stub.yml @@ -198,7 +198,6 @@ RSpec/ReturnFromStub: - 'spec/services/git/branch_hooks_service_spec.rb' - 'spec/services/git/branch_push_service_spec.rb' - 'spec/services/git/process_ref_changes_service_spec.rb' - - 'spec/services/groups/create_service_spec.rb' - 'spec/services/groups/nested_create_service_spec.rb' - 'spec/services/merge_requests/merge_orchestration_service_spec.rb' - 'spec/services/merge_requests/merge_service_spec.rb' diff --git a/.rubocop_todo/rspec/verified_doubles.yml b/.rubocop_todo/rspec/verified_doubles.yml index ffc0b2a3824..63bebcbb2df 100644 --- a/.rubocop_todo/rspec/verified_doubles.yml +++ b/.rubocop_todo/rspec/verified_doubles.yml @@ -147,8 +147,6 @@ RSpec/VerifiedDoubles: - 'ee/spec/services/geo/node_status_request_service_spec.rb' - 'ee/spec/services/geo/replication_toggle_request_service_spec.rb' - 'ee/spec/services/gitlab_subscriptions/fetch_subscription_plans_service_spec.rb' - - 'ee/spec/services/group_saml/group_managed_accounts/clean_up_members_service_spec.rb' - - 'ee/spec/services/group_saml/sign_up_service_spec.rb' - 'ee/spec/services/groups/update_repository_storage_service_spec.rb' - 'ee/spec/services/ide/schemas_config_service_spec.rb' - 'ee/spec/services/incident_management/oncall_schedules/update_service_spec.rb' @@ -536,7 +534,6 @@ RSpec/VerifiedDoubles: - 'spec/lib/gitlab/github_import/markdown_text_spec.rb' - 'spec/lib/gitlab/github_import/milestone_finder_spec.rb' - 'spec/lib/gitlab/github_import/object_counter_spec.rb' - - 'spec/lib/gitlab/github_import/page_counter_spec.rb' - 'spec/lib/gitlab/github_import/parallel_importer_spec.rb' - 'spec/lib/gitlab/github_import/parallel_scheduling_spec.rb' - 'spec/lib/gitlab/github_import/representation/diff_note_spec.rb' @@ -963,7 +960,6 @@ RSpec/VerifiedDoubles: - 'spec/workers/clusters/agents/delete_expired_events_worker_spec.rb' - 'spec/workers/concerns/application_worker_spec.rb' - 'spec/workers/concerns/gitlab/github_import/object_importer_spec.rb' - - 'spec/workers/concerns/gitlab/github_import/stage_methods_spec.rb' - 'spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb' - 'spec/workers/create_commit_signature_worker_spec.rb' - 'spec/workers/environments/auto_stop_worker_spec.rb' @@ -975,7 +971,6 @@ RSpec/VerifiedDoubles: - 'spec/workers/gitlab/github_import/stage/finish_import_worker_spec.rb' - 'spec/workers/gitlab/github_import/stage/import_base_data_worker_spec.rb' - 'spec/workers/gitlab/github_import/stage/import_issues_and_diff_notes_worker_spec.rb' - - 'spec/workers/gitlab/github_import/stage/import_lfs_objects_worker_spec.rb' - 'spec/workers/gitlab/github_import/stage/import_notes_worker_spec.rb' - 'spec/workers/gitlab/github_import/stage/import_pull_requests_merged_by_worker_spec.rb' - 'spec/workers/gitlab/github_import/stage/import_pull_requests_reviews_worker_spec.rb' diff --git a/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml b/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml index c0f48f83492..e6612b4830b 100644 --- a/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml +++ b/.rubocop_todo/sidekiq_load_balancing/worker_data_consistency.yml @@ -388,7 +388,6 @@ SidekiqLoadBalancing/WorkerDataConsistency: - 'ee/app/workers/merge_request_reset_approvals_worker.rb' - 'ee/app/workers/merge_requests/capture_suggested_reviewers_accepted_worker.rb' - 'ee/app/workers/merge_requests/fetch_suggested_reviewers_worker.rb' - - 'ee/app/workers/merge_requests/llm/summarize_merge_request_worker.rb' - 'ee/app/workers/merge_requests/sync_code_owner_approval_rules_worker.rb' - 'ee/app/workers/merge_trains/refresh_worker.rb' - 'ee/app/workers/namespaces/sync_namespace_name_worker.rb' diff --git a/.rubocop_todo/style/block_delimiters.yml b/.rubocop_todo/style/block_delimiters.yml index 8d7d98ec014..9a6ecf1e955 100644 --- a/.rubocop_todo/style/block_delimiters.yml +++ b/.rubocop_todo/style/block_delimiters.yml @@ -59,7 +59,6 @@ Style/BlockDelimiters: - 'spec/models/packages/npm/metadatum_spec.rb' - 'spec/models/packages/protection/rule_spec.rb' - 'spec/models/packages/pypi/metadatum_spec.rb' - - 'spec/models/users/in_product_marketing_email_spec.rb' - 'spec/models/users/phone_number_validation_spec.rb' - 'spec/models/users/project_callout_spec.rb' - 'spec/presenters/tree_entry_presenter_spec.rb' diff --git a/.rubocop_todo/style/explicit_block_argument.yml b/.rubocop_todo/style/explicit_block_argument.yml index db1c8073df8..1e5725a2ef0 100644 --- a/.rubocop_todo/style/explicit_block_argument.yml +++ b/.rubocop_todo/style/explicit_block_argument.yml @@ -49,7 +49,6 @@ Style/ExplicitBlockArgument: - 'lib/gitlab/gitaly_client/storage_settings.rb' - 'lib/gitlab/github_import/client.rb' - 'lib/gitlab/graphql/tracers/application_context_tracer.rb' - - 'lib/gitlab/import_export/import_failure_service.rb' - 'lib/gitlab/import_export/json/ndjson_writer.rb' - 'lib/gitlab/import_export/json/streaming_serializer.rb' - 'lib/gitlab/import_export/project/base_task.rb' diff --git a/.rubocop_todo/style/guard_clause.yml b/.rubocop_todo/style/guard_clause.yml index 429eeff3787..65847c093d5 100644 --- a/.rubocop_todo/style/guard_clause.yml +++ b/.rubocop_todo/style/guard_clause.yml @@ -347,7 +347,6 @@ Style/GuardClause: - 'ee/app/services/epics/tree_reorder_service.rb' - 'ee/app/services/epics/update_service.rb' - 'ee/app/services/geo/metrics_update_service.rb' - - 'ee/app/services/group_saml/group_managed_accounts/transfer_membership_service.rb' - 'ee/app/services/groups/update_repository_storage_service.rb' - 'ee/app/services/incident_management/oncall_rotations/remove_participant_service.rb' - 'ee/app/services/iterations/delete_service.rb' diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index db8f6d8d851..cb5e5134dcf 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -245,7 +245,7 @@ Style/IfUnlessModifier: - 'app/services/environments/canary_ingress/update_service.rb' - 'app/services/environments/reset_auto_stop_service.rb' - 'app/services/git/process_ref_changes_service.rb' - - 'app/services/google_cloud/generate_pipeline_service.rb' + - 'app/services/cloud_seed/google_cloud/generate_pipeline_service.rb' - 'app/services/groups/create_service.rb' - 'app/services/groups/transfer_service.rb' - 'app/services/groups/update_statistics_service.rb' @@ -683,7 +683,6 @@ Style/IfUnlessModifier: - 'lib/api/settings.rb' - 'lib/api/snippets.rb' - 'lib/api/tags.rb' - - 'lib/api/terraform/modules/v1/packages.rb' - 'lib/api/users.rb' - 'lib/backup/gitaly_backup.rb' - 'lib/backup/manager.rb' diff --git a/.rubocop_todo/style/inline_disable_annotation.yml b/.rubocop_todo/style/inline_disable_annotation.yml index 1a6226514e6..6c2c802d516 100644 --- a/.rubocop_todo/style/inline_disable_annotation.yml +++ b/.rubocop_todo/style/inline_disable_annotation.yml @@ -390,7 +390,6 @@ Style/InlineDisableAnnotation: - 'app/models/commit.rb' - 'app/models/commit_collection.rb' - 'app/models/commit_status.rb' - - 'app/models/concerns/analytics/cycle_analytics/parentable.rb' - 'app/models/concerns/approvable.rb' - 'app/models/concerns/async_devise_email.rb' - 'app/models/concerns/atomic_internal_id.rb' @@ -1987,7 +1986,6 @@ Style/InlineDisableAnnotation: - 'ee/spec/features/trials/saas/creation_with_one_existing_namespace_flow_spec.rb' - 'ee/spec/finders/audit_event_finder_spec.rb' - 'ee/spec/finders/ee/group_members_finder_spec.rb' - - 'ee/spec/frontend/fixtures/ci_catalog_resources.rb' - 'ee/spec/helpers/analytics/analytics_dashboards_helper_spec.rb' - 'ee/spec/helpers/ee/dashboard_helper_spec.rb' - 'ee/spec/helpers/ee/releases_helper_spec.rb' @@ -2561,7 +2559,6 @@ Style/InlineDisableAnnotation: - 'lib/gitlab/legacy_github_import/importer.rb' - 'lib/gitlab/legacy_github_import/issuable_formatter.rb' - 'lib/gitlab/legacy_github_import/user_formatter.rb' - - 'lib/gitlab/legacy_http.rb' - 'lib/gitlab/lets_encrypt/client.rb' - 'lib/gitlab/lfs_token.rb' - 'lib/gitlab/local_and_remote_storage_migration/base_migrater.rb' @@ -3054,7 +3051,6 @@ Style/InlineDisableAnnotation: - 'spec/models/ci/pipeline_spec.rb' - 'spec/models/ci/runner_manager_build_spec.rb' - 'spec/models/concerns/bulk_insertable_associations_spec.rb' - - 'spec/models/concerns/database_event_tracking_spec.rb' - 'spec/models/concerns/encrypted_user_password_spec.rb' - 'spec/models/concerns/legacy_bulk_insert_spec.rb' - 'spec/models/concerns/manual_inverse_association_spec.rb' @@ -3130,7 +3126,7 @@ Style/InlineDisableAnnotation: - 'spec/services/ci/pipeline_schedules/calculate_next_run_service_spec.rb' - 'spec/services/draft_notes/destroy_service_spec.rb' - 'spec/services/event_create_service_spec.rb' - - 'spec/services/google_cloud/enable_cloudsql_service_spec.rb' + - 'spec/services/cloud_seed/google_cloud/enable_cloudsql_service_spec.rb' - 'spec/services/import/gitlab_projects/file_acquisition_strategies/remote_file_spec.rb' - 'spec/services/merge_requests/create_service_spec.rb' - 'spec/services/merge_requests/delete_non_latest_diffs_service_spec.rb' @@ -3154,7 +3150,6 @@ Style/InlineDisableAnnotation: - 'spec/sidekiq/cron/job_gem_dependency_spec.rb' - 'spec/sidekiq_cluster/sidekiq_cluster_spec.rb' - 'spec/spec_helper.rb' - - 'spec/support/before_all_adapter.rb' - 'spec/support/capybara.rb' - 'spec/support/database/click_house/hooks.rb' - 'spec/support/db_cleaner.rb' diff --git a/.rubocop_todo/style/keyword_parameters_order.yml b/.rubocop_todo/style/keyword_parameters_order.yml index e4b751a92da..8f27a2c9f45 100644 --- a/.rubocop_todo/style/keyword_parameters_order.yml +++ b/.rubocop_todo/style/keyword_parameters_order.yml @@ -18,7 +18,6 @@ Style/KeywordParametersOrder: - 'lib/gitlab/diff/diff_refs.rb' - 'lib/gitlab/email/smime/signer.rb' - 'lib/gitlab/exclusive_lease.rb' - - 'lib/gitlab/import_export/import_failure_service.rb' - 'lib/gitlab/merge_requests/mergeability/results_store.rb' - 'lib/gitlab/usage_data_counters/editor_unique_counter.rb' - 'lib/microsoft_teams/notifier.rb' diff --git a/.rubocop_todo/style/redundant_return.yml b/.rubocop_todo/style/redundant_return.yml index 86f8bb37d67..821762457c7 100644 --- a/.rubocop_todo/style/redundant_return.yml +++ b/.rubocop_todo/style/redundant_return.yml @@ -79,7 +79,6 @@ Style/RedundantReturn: - 'ee/app/workers/ee/repository_check/single_repository_worker.rb' - 'ee/lib/api/dependency_proxy/packages/maven.rb' - 'ee/lib/ee/api/entities/billable_member.rb' - - 'ee/lib/ee/gitlab/checks/push_rules/secrets_check.rb' - 'ee/lib/gitlab/llm/chain/tools/epic_identifier/executor.rb' - 'ee/lib/gitlab/llm/chain/tools/issue_identifier/executor.rb' - 'lib/api/nuget_project_packages.rb' diff --git a/.rubocop_todo/style/redundant_self.yml b/.rubocop_todo/style/redundant_self.yml index 701ce4db7df..8c23290babe 100644 --- a/.rubocop_todo/style/redundant_self.yml +++ b/.rubocop_todo/style/redundant_self.yml @@ -384,4 +384,3 @@ Style/RedundantSelf: - 'spec/lib/gitlab/background_task_spec.rb' - 'spec/lib/gitlab/database/load_balancing_spec.rb' - 'spec/models/integration_spec.rb' - - 'spec/support/before_all_adapter.rb' |