diff options
Diffstat (limited to '.rubocop_todo')
50 files changed, 189 insertions, 819 deletions
diff --git a/.rubocop_todo/capybara/testid_finders.yml b/.rubocop_todo/capybara/testid_finders.yml index a1e0c7f642e..414a8568e80 100644 --- a/.rubocop_todo/capybara/testid_finders.yml +++ b/.rubocop_todo/capybara/testid_finders.yml @@ -1,76 +1,6 @@ --- Capybara/TestidFinders: Exclude: - - 'ee/spec/features/admin/admin_dev_ops_reports_spec.rb' - - 'ee/spec/features/admin/admin_merge_requests_approvals_spec.rb' - - 'ee/spec/features/admin/admin_sends_notification_spec.rb' - - 'ee/spec/features/admin/admin_settings_spec.rb' - - 'ee/spec/features/admin/geo/admin_geo_projects_spec.rb' - - 'ee/spec/features/admin/groups/admin_subscription_alerts_spec.rb' - - 'ee/spec/features/admin/subscriptions/admin_views_subscription_spec.rb' - - 'ee/spec/features/billings/billing_plans_spec.rb' - - 'ee/spec/features/boards/boards_licensed_features_spec.rb' - - 'ee/spec/features/boards/boards_spec.rb' - - 'ee/spec/features/boards/group_boards/board_deletion_spec.rb' - - 'ee/spec/features/boards/new_issue_spec.rb' - - 'ee/spec/features/boards/scoped_issue_board_spec.rb' - - 'ee/spec/features/boards/sidebar_spec.rb' - - 'ee/spec/features/boards/swimlanes/epics_swimlanes_drag_drop_spec.rb' - - 'ee/spec/features/boards/swimlanes/epics_swimlanes_sidebar_labels_spec.rb' - - 'ee/spec/features/boards/swimlanes/epics_swimlanes_sidebar_spec.rb' - - 'ee/spec/features/boards/swimlanes/epics_swimlanes_spec.rb' - - 'ee/spec/features/boards/user_adds_lists_to_board_spec.rb' - - 'ee/spec/features/ci/ci_catalog_spec.rb' - - 'ee/spec/features/ci/ci_minutes_spec.rb' - - 'ee/spec/features/epic_boards/epic_boards_sidebar_spec.rb' - - 'ee/spec/features/epic_boards/epic_boards_spec.rb' - - 'ee/spec/features/epics/epic_labels_spec.rb' - - 'ee/spec/features/epics/epic_related_epics_spec.rb' - - 'ee/spec/features/epics/epic_show_spec.rb' - - 'ee/spec/features/epics/update_epic_spec.rb' - - 'ee/spec/features/gitlab_subscriptions/seat_count_alert_spec.rb' - - 'ee/spec/features/groups/analytics/ci_cd_analytics_spec.rb' - - 'ee/spec/features/groups/analytics/cycle_analytics/charts_spec.rb' - - 'ee/spec/features/groups/analytics/cycle_analytics/filters_and_data_spec.rb' - - 'ee/spec/features/groups/analytics/cycle_analytics/multiple_value_streams_spec.rb' - - 'ee/spec/features/groups/contribution_analytics_spec.rb' - - 'ee/spec/features/groups/group_roadmap_spec.rb' - - 'ee/spec/features/groups/group_settings_spec.rb' - - 'ee/spec/features/groups/iterations/user_edits_iteration_cadence_spec.rb' - - 'ee/spec/features/groups/security/compliance_dashboards_spec.rb' - - 'ee/spec/features/groups/settings/user_configures_analytics_dashboards_spec.rb' - - 'ee/spec/features/groups/settings/user_configures_insights_spec.rb' - - 'ee/spec/features/groups/settings/user_configures_vsd_aggregation_spec.rb' - - 'ee/spec/features/groups/show_spec.rb' - - 'ee/spec/features/groups/usage_quotas/pipelines_tab_spec.rb' - - 'ee/spec/features/groups/usage_quotas/seats_tab_spec.rb' - - 'ee/spec/features/incidents/incident_details_spec.rb' - - 'ee/spec/features/incidents/user_uploads_metric_images_spec.rb' - - 'ee/spec/features/issues/blocking_issues_spec.rb' - - 'ee/spec/features/issues/epic_in_issue_sidebar_spec.rb' - - 'ee/spec/features/issues/issue_sidebar_spec.rb' - - 'ee/spec/features/merge_request/draft_comments_spec.rb' - - 'ee/spec/features/merge_request/user_merges_immediately_spec.rb' - - 'ee/spec/features/merge_request/user_sees_approval_widget_spec.rb' - - 'ee/spec/features/merge_request/user_sees_status_checks_widget_spec.rb' - - 'ee/spec/features/merge_request/user_sets_approval_rules_spec.rb' - - 'ee/spec/features/merge_request/user_sets_approvers_spec.rb' - - 'ee/spec/features/merge_request/user_views_blocked_merge_request_spec.rb' - - 'ee/spec/features/merge_trains/user_adds_to_merge_train_when_pipeline_succeeds_spec.rb' - - 'ee/spec/features/profiles/usage_quotas_spec.rb' - - 'ee/spec/features/projects/analytics/visualization_designer_spec.rb' - - 'ee/spec/features/projects/audit_events_spec.rb' - - 'ee/spec/features/projects/issues/user_creates_issue_spec.rb' - - 'ee/spec/features/projects/jobs/blocked_deployment_job_page_spec.rb' - - 'ee/spec/features/projects/pipelines/pipeline_spec.rb' - - 'ee/spec/features/projects/product_analytics/dashboards_shared_examples.rb' - - 'ee/spec/features/projects/security/vulnerability_report_spec.rb' - - 'ee/spec/features/projects/settings/analytics/user_configures_analytics_custom_dashboards_spec.rb' - - 'ee/spec/features/projects/settings/ee/service_desk_setting_spec.rb' - - 'ee/spec/features/projects/settings/merge_requests_settings_spec.rb' - - 'ee/spec/features/projects/settings/pipeline_subscriptions_spec.rb' - - 'ee/spec/features/projects/settings/protected_environments_spec.rb' - - 'ee/spec/features/projects/work_items/okr_spec.rb' - 'ee/spec/features/protected_branches_spec.rb' - 'ee/spec/features/registrations/combined_registration_spec.rb' - 'ee/spec/features/registrations/identity_verification_spec.rb' diff --git a/.rubocop_todo/cop/experiments_test_coverage.yml b/.rubocop_todo/cop/experiments_test_coverage.yml index 07c47bc11a6..f733851a80e 100644 --- a/.rubocop_todo/cop/experiments_test_coverage.yml +++ b/.rubocop_todo/cop/experiments_test_coverage.yml @@ -3,4 +3,3 @@ Cop/ExperimentsTestCoverage: Exclude: - 'app/controllers/groups/boards_controller.rb' - 'app/controllers/projects/boards_controller.rb' - - 'app/experiments/build_ios_app_guide_email_experiment.rb' diff --git a/.rubocop_todo/gitlab/avoid_gitlab_instance_checks.yml b/.rubocop_todo/gitlab/avoid_gitlab_instance_checks.yml new file mode 100644 index 00000000000..6e193518af1 --- /dev/null +++ b/.rubocop_todo/gitlab/avoid_gitlab_instance_checks.yml @@ -0,0 +1,147 @@ +--- +Gitlab/AvoidGitlabInstanceChecks: + Details: grace period + Exclude: + - 'app/controllers/admin/runners_controller.rb' + - 'app/controllers/explore/groups_controller.rb' + - 'app/controllers/jira_connect/oauth_application_ids_controller.rb' + - 'app/helpers/application_helper.rb' + - 'app/helpers/application_settings_helper.rb' + - 'app/helpers/auth_helper.rb' + - 'app/helpers/ci/pipelines_helper.rb' + - 'app/helpers/groups_helper.rb' + - 'app/helpers/integrations_helper.rb' + - 'app/helpers/packages_helper.rb' + - 'app/helpers/projects_helper.rb' + - 'app/helpers/sessions_helper.rb' + - 'app/helpers/sidebars_helper.rb' + - 'app/helpers/users/callouts_helper.rb' + - 'app/helpers/whats_new_helper.rb' + - 'app/mailers/devise_mailer.rb' + - 'app/models/ci/build.rb' + - 'app/models/ci/runner.rb' + - 'app/models/concerns/protected_ref_access.rb' + - 'app/models/container_repository.rb' + - 'app/models/integrations/jira.rb' + - 'app/models/member.rb' + - 'app/models/namespace.rb' + - 'app/models/project.rb' + - 'app/models/release_highlight.rb' + - 'app/policies/base_policy.rb' + - 'app/workers/container_registry/cleanup_worker.rb' + - 'app/workers/container_registry/migration/guard_worker.rb' + - 'app/workers/container_registry/record_data_repair_detail_worker.rb' + - 'app/workers/gitlab_service_ping_worker.rb' + - 'app/workers/users/deactivate_dormant_users_worker.rb' + - 'config/initializers/active_record_transaction_observer.rb' + - 'config/initializers/active_record_transaction_patches.rb' + - 'config/initializers/check_forced_decomposition.rb' + - 'config/initializers/gitlab_experiment.rb' + - 'config/initializers/gitlab_suggested_reviewers_secret.rb' + - 'config/initializers/rack_multipart_patch.rb' + - 'config/initializers/validate_puma.rb' + - 'config/initializers/warden.rb' + - 'ee/app/components/namespaces/storage/limit_alert_component.rb' + - 'ee/app/controllers/admin/namespace_limits_controller.rb' + - 'ee/app/controllers/ee/admin/users_controller.rb' + - 'ee/app/controllers/ee/application_controller.rb' + - 'ee/app/controllers/ee/dashboard/projects_controller.rb' + - 'ee/app/controllers/ee/groups/group_members_controller.rb' + - 'ee/app/controllers/ee/search_controller.rb' + - 'ee/app/controllers/sitemap_controller.rb' + - 'ee/app/finders/groups_with_templates_finder.rb' + - 'ee/app/finders/scim_finder.rb' + - 'ee/app/finders/search/elastic_projects_not_indexed_finder.rb' + - 'ee/app/helpers/ee/ci/pipelines_helper.rb' + - 'ee/app/helpers/ee/groups_helper.rb' + - 'ee/app/helpers/ee/namespaces_helper.rb' + - 'ee/app/helpers/ee/projects_helper.rb' + - 'ee/app/helpers/ee/search_helper.rb' + - 'ee/app/helpers/ee/sidebars_helper.rb' + - 'ee/app/helpers/ee/subscribable_banner_helper.rb' + - 'ee/app/helpers/ee/users/callouts_helper.rb' + - 'ee/app/helpers/ee/users_helper.rb' + - 'ee/app/helpers/gitlab_subscriptions/upcoming_reconciliation_helper.rb' + - 'ee/app/helpers/license_helper.rb' + - 'ee/app/helpers/license_monitoring_helper.rb' + - 'ee/app/helpers/trial_registrations_helper.rb' + - 'ee/app/helpers/users/identity_verification_helper.rb' + - 'ee/app/mailers/emails/in_product_marketing.rb' + - 'ee/app/models/ci/minutes/additional_pack.rb' + - 'ee/app/models/ee/application_setting.rb' + - 'ee/app/models/ee/container_repository.rb' + - 'ee/app/models/ee/member.rb' + - 'ee/app/models/ee/namespace.rb' + - 'ee/app/models/ee/namespace_setting.rb' + - 'ee/app/models/ee/plan.rb' + - 'ee/app/models/ee/preloaders/group_policy_preloader.rb' + - 'ee/app/models/ee/preloaders/single_hierarchy_project_group_plans_preloader.rb' + - 'ee/app/models/ee/project.rb' + - 'ee/app/models/ee/project_statistics.rb' + - 'ee/app/models/ee/user.rb' + - 'ee/app/models/gitlab_subscription.rb' + - 'ee/app/models/gitlab_subscriptions/add_on_purchase.rb' + - 'ee/app/models/gitlab_subscriptions/upcoming_reconciliation.rb' + - 'ee/app/models/namespaces/storage/cost_factor.rb' + - 'ee/app/models/namespaces/storage/enforcement.rb' + - 'ee/app/policies/ee/global_policy.rb' + - 'ee/app/policies/ee/group_policy.rb' + - 'ee/app/policies/ee/project_policy.rb' + - 'ee/app/serializers/ee/issue_sidebar_basic_entity.rb' + - 'ee/app/services/ci/minutes/update_project_and_namespace_usage_service.rb' + - 'ee/app/services/ci/runners/stale_group_runners_prune_service.rb' + - 'ee/app/services/ee/notification_service.rb' + - 'ee/app/services/gitlab_subscriptions/activate_service.rb' + - 'ee/app/services/gitlab_subscriptions/add_on_purchases/create_service.rb' + - 'ee/app/services/gitlab_subscriptions/reconciliations/calculate_seat_count_data_service.rb' + - 'ee/app/services/llm/base_service.rb' + - 'ee/app/services/namespaces/service_accounts/create_service.rb' + - 'ee/app/workers/ee/ci/build_finished_worker.rb' + - 'ee/app/workers/elastic_remove_expired_namespace_subscriptions_from_index_cron_worker.rb' + - 'ee/app/workers/gitlab_subscriptions/add_on_purchases/bulk_refresh_user_assignments_worker.rb' + - 'ee/app/workers/gitlab_subscriptions/add_on_purchases/schedule_bulk_refresh_user_assignments_worker.rb' + - 'ee/app/workers/gitlab_subscriptions/refresh_seats_worker.rb' + - 'ee/app/workers/gitlab_subscriptions/schedule_refresh_seats_worker.rb' + - 'ee/app/workers/update_all_mirrors_worker.rb' + - 'ee/lib/api/code_suggestions.rb' + - 'ee/lib/api/internal/upcoming_reconciliations.rb' + - 'ee/lib/api/scim/instance_scim.rb' + - 'ee/lib/ee/api/namespaces.rb' + - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' + - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_storage_size_with_recent_size.rb' + - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_storage_size_without_pipeline_artifacts_size_job.rb' + - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_storage_size_without_uploads_size.rb' + - 'ee/lib/ee/gitlab/background_migration/create_compliance_standards_adherence.rb' + - 'ee/lib/ee/gitlab/background_migration/migrate_shared_vulnerability_identifiers.rb' + - 'ee/lib/ee/gitlab/gon_helper.rb' + - 'ee/lib/ee/gitlab/scim/base_provisioning_service.rb' + - 'ee/lib/ee/gitlab/snippet_search_results.rb' + - 'ee/lib/ee/gitlab/tracking/standard_context.rb' + - 'ee/lib/ee/sidebars/groups/menus/settings_menu.rb' + - 'ee/lib/gitlab/email/message/account_validation.rb' + - 'ee/lib/gitlab/licenses/submit_license_usage_data_banner.rb' + - 'ee/lib/gitlab/llm/tanuki_bot.rb' + - 'ee/lib/gitlab/manual_quarterly_co_term_banner.rb' + - 'ee/lib/gitlab/sitemaps/generator.rb' + - 'ee/lib/sidebars/groups/menus/trial_widget_menu.rb' + - 'ee/lib/sidebars/user_settings/menus/profile_billing_menu.rb' + - 'ee/lib/tasks/gitlab/elastic.rake' + - 'ee/spec/factories/gitlab_subscriptions.rb' + - 'lib/container_registry/client.rb' + - 'lib/container_registry/gitlab_api_client.rb' + - 'lib/gitlab/background_migration/backfill_project_statistics_storage_size_with_recent_size.rb' + - 'lib/gitlab/content_security_policy/config_loader.rb' + - 'lib/gitlab/database/migration_helpers/convert_to_bigint.rb' + - 'lib/gitlab/database/migration_helpers/wraparound_autovacuum.rb' + - 'lib/gitlab/database/migration_helpers/wraparound_vacuum_helpers.rb' + - 'lib/gitlab/experiment/rollout/feature.rb' + - 'lib/gitlab/gon_helper.rb' + - 'lib/gitlab/monitor/demo_projects.rb' + - 'lib/gitlab/qa.rb' + - 'lib/gitlab/tracking/destinations/database_events_snowplow.rb' + - 'lib/gitlab/tracking/standard_context.rb' + - 'lib/gitlab/usage/metrics/instrumentations/count_ci_internal_pipelines_metric.rb' + - 'lib/gitlab/usage/metrics/instrumentations/count_issues_created_manually_from_alerts_metric.rb' + - 'lib/sidebars/admin/menus/admin_settings_menu.rb' + - 'lib/tasks/gitlab/db/migration_fix_15_11.rake' + - 'spec/helpers/sidebars_helper_spec.rb' diff --git a/.rubocop_todo/gitlab/doc_url.yml b/.rubocop_todo/gitlab/doc_url.yml index ba9d066f94c..190bda22721 100644 --- a/.rubocop_todo/gitlab/doc_url.yml +++ b/.rubocop_todo/gitlab/doc_url.yml @@ -14,9 +14,6 @@ Gitlab/DocUrl: - 'app/services/security/ci_configuration/sast_create_service.rb' - 'app/services/security/ci_configuration/sast_iac_create_service.rb' - 'app/services/security/ci_configuration/secret_detection_create_service.rb' - - 'app/services/tasks_to_be_done/create_ci_task_service.rb' - - 'app/services/tasks_to_be_done/create_code_task_service.rb' - - 'app/services/tasks_to_be_done/create_issues_task_service.rb' - 'ee/app/graphql/mutations/requirements_management/export_requirements.rb' - 'ee/app/graphql/types/vulnerability_state_enum.rb' - 'ee/app/helpers/projects/learn_gitlab_helper.rb' diff --git a/.rubocop_todo/gitlab/feature_available_usage.yml b/.rubocop_todo/gitlab/feature_available_usage.yml index 302bf8d17c4..45240467627 100644 --- a/.rubocop_todo/gitlab/feature_available_usage.yml +++ b/.rubocop_todo/gitlab/feature_available_usage.yml @@ -72,7 +72,6 @@ Gitlab/FeatureAvailableUsage: - 'ee/app/services/ee/boards/lists/create_service.rb' - 'ee/app/services/ee/boards/update_service.rb' - 'ee/app/services/ee/ide/schemas_config_service.rb' - - 'ee/app/services/ee/issuable_base_service.rb' - 'ee/app/services/ee/issue_links/create_service.rb' - 'ee/app/services/ee/issues/build_service.rb' - 'ee/app/services/ee/lfs/lock_file_service.rb' diff --git a/.rubocop_todo/gitlab/namespaced_class.yml b/.rubocop_todo/gitlab/namespaced_class.yml index 4511497315b..6268aa26248 100644 --- a/.rubocop_todo/gitlab/namespaced_class.yml +++ b/.rubocop_todo/gitlab/namespaced_class.yml @@ -218,7 +218,6 @@ Gitlab/NamespacedClass: - 'app/models/member.rb' - 'app/models/members/group_member.rb' - 'app/models/members/last_group_owner_assigner.rb' - - 'app/models/members/member_task.rb' - 'app/models/members/project_member.rb' - 'app/models/members_preloader.rb' - 'app/models/merge_request.rb' @@ -304,7 +303,6 @@ Gitlab/NamespacedClass: - 'app/models/sent_notification.rb' - 'app/models/sentry_issue.rb' - 'app/models/service_desk_setting.rb' - - 'app/models/service_list.rb' - 'app/models/shard.rb' - 'app/models/slack_integration.rb' - 'app/models/snippet.rb' @@ -991,8 +989,6 @@ Gitlab/NamespacedClass: - 'ee/app/serializers/file_lock_entity.rb' - 'ee/app/serializers/geo_node_serializer.rb' - 'ee/app/serializers/geo_node_status_serializer.rb' - - 'ee/app/serializers/geo_project_registry_entity.rb' - - 'ee/app/serializers/geo_project_registry_serializer.rb' - 'ee/app/serializers/group_analytics_serializer.rb' - 'ee/app/serializers/group_vulnerability_autocomplete_entity.rb' - 'ee/app/serializers/group_vulnerability_autocomplete_serializer.rb' diff --git a/.rubocop_todo/gitlab/policy_rule_boolean.yml b/.rubocop_todo/gitlab/policy_rule_boolean.yml deleted file mode 100644 index 64689eb8fa0..00000000000 --- a/.rubocop_todo/gitlab/policy_rule_boolean.yml +++ /dev/null @@ -1,4 +0,0 @@ ---- -Gitlab/PolicyRuleBoolean: - Exclude: - - 'ee/app/policies/ee/identity_provider_policy.rb' diff --git a/.rubocop_todo/gitlab/strong_memoize_attr.yml b/.rubocop_todo/gitlab/strong_memoize_attr.yml index 703c80c7667..33dcb37b15a 100644 --- a/.rubocop_todo/gitlab/strong_memoize_attr.yml +++ b/.rubocop_todo/gitlab/strong_memoize_attr.yml @@ -114,7 +114,6 @@ Gitlab/StrongMemoizeAttr: - 'app/models/event_collection.rb' - 'app/models/group.rb' - 'app/models/incident_management/project_incident_management_setting.rb' - - 'app/models/integrations/jira.rb' - 'app/models/internal_id.rb' - 'app/models/member.rb' - 'app/models/merge_request.rb' @@ -305,7 +304,6 @@ Gitlab/StrongMemoizeAttr: - 'ee/app/models/ee/deployment.rb' - 'ee/app/models/ee/environment.rb' - 'ee/app/models/ee/group.rb' - - 'ee/app/models/ee/integrations/jira.rb' - 'ee/app/models/ee/list.rb' - 'ee/app/models/ee/merge_request.rb' - 'ee/app/models/ee/namespace.rb' diff --git a/.rubocop_todo/layout/argument_alignment.yml b/.rubocop_todo/layout/argument_alignment.yml index c7b47be48fa..7b4b3e68b78 100644 --- a/.rubocop_todo/layout/argument_alignment.yml +++ b/.rubocop_todo/layout/argument_alignment.yml @@ -500,7 +500,6 @@ Layout/ArgumentAlignment: - 'app/services/metrics/dashboard/clone_dashboard_service.rb' - 'app/services/metrics/users_starred_dashboards/create_service.rb' - 'app/services/ml/experiment_tracking/experiment_repository.rb' - - 'app/services/pages/migrate_from_legacy_storage_service.rb' - 'app/services/post_receive_service.rb' - 'app/services/preview_markdown_service.rb' - 'app/services/protected_branches/api_service.rb' @@ -991,29 +990,8 @@ Layout/ArgumentAlignment: - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' - 'ee/spec/elastic/migrate/20221124090600_add_namespace_ancestry_ids_to_original_index_mapping_spec.rb' - 'ee/spec/elastic/migrate/20221221110300_backfill_traversal_ids_to_blobs_and_wiki_blobs_spec.rb' - - 'ee/spec/frontend/fixtures/dora/metrics.rb' - - 'ee/spec/frontend/fixtures/oncall_schedule.rb' - 'ee/spec/graphql/ee/mutations/boards/lists/create_spec.rb' - 'ee/spec/graphql/ee/mutations/ci/runner/update_spec.rb' - - 'ee/spec/graphql/mutations/dast/profiles/create_spec.rb' - - 'ee/spec/graphql/mutations/dast/profiles/run_spec.rb' - - 'ee/spec/graphql/mutations/dast/profiles/update_spec.rb' - - 'ee/spec/graphql/mutations/dast_scanner_profiles/create_spec.rb' - - 'ee/spec/graphql/mutations/dast_scanner_profiles/update_spec.rb' - - 'ee/spec/graphql/mutations/merge_requests/accept_spec.rb' - - 'ee/spec/graphql/mutations/merge_requests/set_reviewers_spec.rb' - - 'ee/spec/graphql/resolvers/ci/runners_jobs_statistics_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/path_locks_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/security_orchestration/scan_execution_policy_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/vulnerabilities/container_images_resolver_spec.rb' - - 'ee/spec/graphql/types/ci/pipeline_type_spec.rb' - - 'ee/spec/graphql/types/dast/pre_scan_verification_step_type_spec.rb' - - 'ee/spec/graphql/types/dast/pre_scan_verification_type_spec.rb' - - 'ee/spec/graphql/types/dast/profile_type_spec.rb' - - 'ee/spec/graphql/types/dast_scanner_profile_type_spec.rb' - - 'ee/spec/graphql/types/pipeline_security_report_finding_type_spec.rb' - - 'ee/spec/graphql/types/project_type_spec.rb' - - 'ee/spec/graphql/types/vulnerability_type_spec.rb' - 'ee/spec/lib/analytics/group_activity_calculator_spec.rb' - 'ee/spec/lib/analytics/merge_request_metrics_calculator_spec.rb' - 'ee/spec/lib/api/entities/protected_environments/approval_rule_for_summary_spec.rb' @@ -1077,15 +1055,12 @@ Layout/ArgumentAlignment: - 'ee/spec/lib/gitlab/geo_spec.rb' - 'ee/spec/lib/gitlab/git_access_spec.rb' - 'ee/spec/lib/gitlab/git_access_wiki_spec.rb' - - 'ee/spec/lib/gitlab/import_export/project/object_builder_spec.rb' - 'ee/spec/lib/gitlab/insights/executors/dora_executor_spec.rb' - 'ee/spec/lib/gitlab/insights/loader_spec.rb' - 'ee/spec/lib/gitlab/license_scanning/branch_components_spec.rb' - 'ee/spec/lib/gitlab/license_scanning/package_licenses_spec.rb' - 'ee/spec/lib/gitlab/prometheus/queries/additional_metrics_deployment_query_spec.rb' - 'ee/spec/lib/gitlab/status_page_spec.rb' - - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_approval_project_rules_metric_spec.rb' - - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_ci_environments_approval_required_spec.rb' - 'ee/spec/lib/gitlab/zoekt/search_results_spec.rb' - 'ee/spec/lib/incident_management/oncall_shift_generator_spec.rb' - 'ee/spec/lib/omni_auth/strategies/group_saml_spec.rb' @@ -1129,15 +1104,6 @@ Layout/ArgumentAlignment: - 'ee/spec/requests/api/graphql/mutations/security_policy/assign_security_policy_project_spec.rb' - 'ee/spec/requests/api/graphql/mutations/security_policy/create_security_policy_project_spec.rb' - 'ee/spec/requests/api/graphql/mutations/security_policy/unassign_security_policy_project_spec.rb' - - 'ee/spec/requests/api/graphql/project/branch_rules/approval_project_rules_spec.rb' - - 'ee/spec/requests/api/graphql/project/dast_profile_schedule_spec.rb' - - 'ee/spec/requests/api/graphql/project/environments_spec.rb' - - 'ee/spec/requests/api/graphql/project/pipeline/code_quality_report_summary_spec.rb' - - 'ee/spec/requests/api/graphql/project/pipeline/dast_profile_spec.rb' - - 'ee/spec/requests/api/graphql/project/pipeline/security_report_finding_spec.rb' - - 'ee/spec/requests/api/graphql/project/pipeline/security_report_findings_spec.rb' - - 'ee/spec/requests/api/graphql/project/pipeline/security_report_summary_spec.rb' - - 'ee/spec/requests/api/graphql/project/pipelines/dast_profile_spec.rb' - 'ee/spec/requests/api/group_boards_spec.rb' - 'ee/spec/requests/api/group_clusters_spec.rb' - 'ee/spec/requests/api/group_push_rule_spec.rb' @@ -1449,40 +1415,7 @@ Layout/ArgumentAlignment: - 'spec/components/previews/pajamas/alert_component_preview.rb' - 'spec/components/previews/pajamas/banner_component_preview.rb' - 'spec/components/previews/pajamas/button_component_preview.rb' - - 'spec/frontend/fixtures/autocomplete.rb' - - 'spec/frontend/fixtures/autocomplete_sources.rb' - - 'spec/frontend/fixtures/environments.rb' - - 'spec/frontend/fixtures/issues.rb' - - 'spec/frontend/fixtures/releases.rb' - - 'spec/frontend/fixtures/search.rb' - 'spec/graphql/features/authorization_spec.rb' - - 'spec/graphql/mutations/issues/set_assignees_spec.rb' - - 'spec/graphql/mutations/merge_requests/create_spec.rb' - - 'spec/graphql/mutations/merge_requests/set_assignees_spec.rb' - - 'spec/graphql/mutations/merge_requests/set_reviewers_spec.rb' - - 'spec/graphql/mutations/release_asset_links/update_spec.rb' - - 'spec/graphql/mutations/releases/update_spec.rb' - - 'spec/graphql/resolvers/board_lists_resolver_spec.rb' - - 'spec/graphql/resolvers/ci/config_resolver_spec.rb' - - 'spec/graphql/resolvers/ci/group_runners_resolver_spec.rb' - - 'spec/graphql/resolvers/ci/jobs_resolver_spec.rb' - - 'spec/graphql/resolvers/ci/project_runners_resolver_spec.rb' - - 'spec/graphql/resolvers/ci/runners_resolver_spec.rb' - - 'spec/graphql/resolvers/concerns/looks_ahead_spec.rb' - - 'spec/graphql/resolvers/concerns/resolves_groups_spec.rb' - - 'spec/graphql/resolvers/container_repositories_resolver_spec.rb' - - 'spec/graphql/resolvers/container_repository_tags_resolver_spec.rb' - - 'spec/graphql/resolvers/environments_resolver_spec.rb' - - 'spec/graphql/resolvers/project_merge_requests_resolver_spec.rb' - - 'spec/graphql/resolvers/project_milestones_resolver_spec.rb' - - 'spec/graphql/resolvers/work_items_resolver_spec.rb' - - 'spec/graphql/types/base_edge_spec.rb' - - 'spec/graphql/types/base_field_spec.rb' - - 'spec/graphql/types/ci/detailed_status_type_spec.rb' - - 'spec/graphql/types/current_user_todos_type_spec.rb' - - 'spec/graphql/types/project_statistics_type_spec.rb' - - 'spec/graphql/types/project_type_spec.rb' - - 'spec/graphql/types/todo_type_spec.rb' - 'spec/initializers/00_rails_disable_joins_spec.rb' - 'spec/initializers/secret_token_spec.rb' - 'spec/lib/api/every_api_endpoint_spec.rb' @@ -1623,17 +1556,6 @@ Layout/ArgumentAlignment: - 'spec/lib/gitlab/graphql/query_analyzers/ast/logger_analyzer_spec.rb' - 'spec/lib/gitlab/health_checks/redis_spec.rb' - 'spec/lib/gitlab/i18n/po_linter_spec.rb' - - 'spec/lib/gitlab/import_export/attributes_finder_spec.rb' - - 'spec/lib/gitlab/import_export/base/object_builder_spec.rb' - - 'spec/lib/gitlab/import_export/base/relation_factory_spec.rb' - - 'spec/lib/gitlab/import_export/design_repo_restorer_spec.rb' - - 'spec/lib/gitlab/import_export/fast_hash_serializer_spec.rb' - - 'spec/lib/gitlab/import_export/merge_request_parser_spec.rb' - - 'spec/lib/gitlab/import_export/project/object_builder_spec.rb' - - 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb' - - 'spec/lib/gitlab/import_export/shared_spec.rb' - - 'spec/lib/gitlab/import_export/snippet_repo_restorer_spec.rb' - - 'spec/lib/gitlab/import_export/snippets_repo_restorer_spec.rb' - 'spec/lib/gitlab/instrumentation_helper_spec.rb' - 'spec/lib/gitlab/legacy_github_import/wiki_formatter_spec.rb' - 'spec/lib/gitlab/markdown_cache/redis/extension_spec.rb' @@ -1666,14 +1588,6 @@ Layout/ArgumentAlignment: - 'spec/lib/gitlab/suggestions/file_suggestion_spec.rb' - 'spec/lib/gitlab/suggestions/suggestion_set_spec.rb' - 'spec/lib/gitlab/tracking/destinations/snowplow_spec.rb' - - 'spec/lib/gitlab/usage/metrics/aggregates/sources/postgres_hll_spec.rb' - - 'spec/lib/gitlab/usage/metrics/instrumentations/count_ci_internal_pipelines_metric_spec.rb' - - 'spec/lib/gitlab/usage/metrics/instrumentations/count_issues_created_manually_from_alerts_metric_spec.rb' - - 'spec/lib/gitlab/usage/metrics/instrumentations/incoming_email_encrypted_secrets_enabled_metric_spec.rb' - - 'spec/lib/gitlab/usage/metrics/instrumentations/service_desk_email_encrypted_secrets_enabled_metric_spec.rb' - - 'spec/lib/gitlab/usage/metrics/query_spec.rb' - - 'spec/lib/gitlab/usage_data_queries_spec.rb' - - 'spec/lib/gitlab/usage_data_spec.rb' - 'spec/lib/gitlab/utils/lazy_attributes_spec.rb' - 'spec/lib/gitlab/workhorse_spec.rb' - 'spec/lib/google_api/cloud_platform/client_spec.rb' @@ -1755,17 +1669,6 @@ Layout/ArgumentAlignment: - 'spec/requests/api/graphql/mutations/todos/restore_many_spec.rb' - 'spec/requests/api/graphql/mutations/todos/restore_spec.rb' - 'spec/requests/api/graphql/packages/conan_spec.rb' - - 'spec/requests/api/graphql/project/error_tracking/sentry_errors_request_spec.rb' - - 'spec/requests/api/graphql/project/issue/design_collection/version_spec.rb' - - 'spec/requests/api/graphql/project/merge_request/pipelines_spec.rb' - - 'spec/requests/api/graphql/project/merge_request_spec.rb' - - 'spec/requests/api/graphql/project/merge_requests_spec.rb' - - 'spec/requests/api/graphql/project/milestones_spec.rb' - - 'spec/requests/api/graphql/project/pipeline_spec.rb' - - 'spec/requests/api/graphql/project/project_members_spec.rb' - - 'spec/requests/api/graphql/project/project_pipeline_statistics_spec.rb' - - 'spec/requests/api/graphql/project/project_statistics_spec.rb' - - 'spec/requests/api/graphql/project/terraform/states_spec.rb' - 'spec/requests/api/graphql/tasks/task_completion_status_spec.rb' - 'spec/requests/api/graphql/user_query_spec.rb' - 'spec/requests/api/group_clusters_spec.rb' @@ -1814,18 +1717,6 @@ Layout/ArgumentAlignment: - 'spec/requests/recursive_webhook_detection_spec.rb' - 'spec/requests/users/group_callouts_spec.rb' - 'spec/requests/users/project_callouts_spec.rb' - - 'spec/routing/environments_spec.rb' - - 'spec/routing/group_routing_spec.rb' - - 'spec/routing/project_routing_spec.rb' - - 'spec/routing/routing_spec.rb' - - 'spec/rubocop/cop/rspec/env_mocking_spec.rb' - - 'spec/rubocop/cop/style/regexp_literal_mixed_preserve_spec.rb' - - 'spec/rubocop/formatter/graceful_formatter_spec.rb' - - 'spec/sidekiq/cron/job_gem_dependency_spec.rb' - - 'spec/support/shared_examples/initializers/uses_gitlab_url_blocker_shared_examples.rb' - - 'spec/support/shared_examples/integrations/integration_settings_form.rb' - - 'spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb' - - 'spec/support/shared_examples/lib/gitlab/database/background_migration_job_shared_examples.rb' - 'spec/tasks/cache_rake_spec.rb' - 'spec/tasks/gitlab/cleanup_rake_spec.rb' - 'spec/tasks/gitlab/db/decomposition/rollback/bump_ci_sequences_rake_spec.rb' diff --git a/.rubocop_todo/layout/array_alignment.yml b/.rubocop_todo/layout/array_alignment.yml index 7efa857c502..8d040f5738e 100644 --- a/.rubocop_todo/layout/array_alignment.yml +++ b/.rubocop_todo/layout/array_alignment.yml @@ -25,7 +25,6 @@ Layout/ArrayAlignment: - 'app/models/deploy_token.rb' - 'app/models/dev_ops_report/metric.rb' - 'app/models/group.rb' - - 'app/models/integration.rb' - 'app/models/integrations/hangouts_chat.rb' - 'app/models/integrations/microsoft_teams.rb' - 'app/models/integrations/pumble.rb' @@ -167,9 +166,6 @@ Layout/ArrayAlignment: - 'lib/gitlab/conflict/file_collection.rb' - 'lib/gitlab/content_security_policy/config_loader.rb' - 'lib/gitlab/database/background_migration/batched_job.rb' - - 'lib/gitlab/email/message/in_product_marketing/team.rb' - - 'lib/gitlab/email/message/in_product_marketing/trial.rb' - - 'lib/gitlab/email/message/in_product_marketing/verify.rb' - 'lib/gitlab/email/receiver.rb' - 'lib/gitlab/etag_caching/router/rails.rb' - 'lib/gitlab/git/diff.rb' diff --git a/.rubocop_todo/layout/empty_line_after_magic_comment.yml b/.rubocop_todo/layout/empty_line_after_magic_comment.yml index 35cd5f9135d..2fbb94bf41b 100644 --- a/.rubocop_todo/layout/empty_line_after_magic_comment.yml +++ b/.rubocop_todo/layout/empty_line_after_magic_comment.yml @@ -125,12 +125,6 @@ Layout/EmptyLineAfterMagicComment: - 'app/uploaders/packages/rpm/repository_file_uploader.rb' - 'app/validators/json_schema_validator.rb' - 'app/views/shared/issuable/_issuable.atom.builder' - - 'app/workers/ci/merge_requests/add_todo_when_build_fails_worker.rb' - - 'app/workers/concerns/auto_devops_queue.rb' - - 'app/workers/concerns/chaos_queue.rb' - - 'app/workers/concerns/limited_capacity/job_tracker.rb' - - 'app/workers/database/batched_background_migration/ci_database_worker.rb' - - 'app/workers/gitlab/import/stuck_project_import_jobs_worker.rb' - 'config/application.rb' - 'config/initializers/fog_core_patch.rb' - 'config/initializers/rubyzip.rb' @@ -247,8 +241,6 @@ Layout/EmptyLineAfterMagicComment: - 'ee/app/services/protected_environments/update_service.rb' - 'ee/app/services/users/captcha_challenge_service.rb' - 'ee/app/services/vulnerabilities/manually_create_service.rb' - - 'ee/app/workers/ee/issuable_export_csv_worker.rb' - - 'ee/app/workers/groups/export_memberships_worker.rb' - 'ee/db/fixtures/development/25_downstream_pipelines.rb' - 'ee/db/geo/migrate/20220617125507_create_ci_secure_file_registry.rb' - 'ee/lib/compliance_management/merge_request_approval_settings/resolver.rb' @@ -410,8 +402,6 @@ Layout/EmptyLineAfterMagicComment: - 'ee/spec/services/protected_environments/update_service_spec.rb' - 'ee/spec/services/wikis/create_attachment_service_spec.rb' - 'ee/spec/support/helpers/board_helpers.rb' - - 'ee/spec/workers/app_sec/dast/profile_schedule_worker_spec.rb' - - 'ee/spec/workers/namespaces/free_user_cap/backfill_notification_jobs_worker_spec.rb' - 'lib/api/commits.rb' - 'lib/api/concerns/packages/nuget_endpoints.rb' - 'lib/api/go_proxy.rb' @@ -800,11 +790,3 @@ Layout/EmptyLineAfterMagicComment: - 'spec/views/shared/_label_row.html.haml_spec.rb' - 'spec/views/shared/ssh_keys/_key_delete.html.haml_spec.rb' - 'spec/views/shared/wikis/_sidebar.html.haml_spec.rb' - - 'spec/workers/auto_devops/disable_worker_spec.rb' - - 'spec/workers/integrations/execute_worker_spec.rb' - - 'spec/workers/partition_creation_worker_spec.rb' - - 'spec/workers/projects/delete_branch_worker_spec.rb' - - 'spec/workers/web_hook_worker_spec.rb' - - 'tooling/danger/analytics_instrumentation.rb' - - 'tooling/danger/suggestor.rb' - - 'tooling/docs/deprecation_handling.rb' diff --git a/.rubocop_todo/layout/first_array_element_indentation.yml b/.rubocop_todo/layout/first_array_element_indentation.yml index f8b1d9b92c8..05f12783fc6 100644 --- a/.rubocop_todo/layout/first_array_element_indentation.yml +++ b/.rubocop_todo/layout/first_array_element_indentation.yml @@ -7,7 +7,6 @@ Layout/FirstArrayElementIndentation: - 'app/helpers/search_helper.rb' - 'app/models/container_repository.rb' - 'app/models/group.rb' - - 'app/models/integration.rb' - 'app/models/user.rb' - 'app/services/labels/transfer_service.rb' - 'ee/app/finders/autocomplete/project_invited_groups_finder.rb' @@ -45,9 +44,6 @@ Layout/FirstArrayElementIndentation: - 'ee/spec/requests/api/saml_group_links_spec.rb' - 'ee/spec/services/audit_events/export_csv_service_spec.rb' - 'ee/spec/services/groups/seat_usage_export_service_spec.rb' - - 'lib/gitlab/email/message/in_product_marketing/team.rb' - - 'lib/gitlab/email/message/in_product_marketing/trial.rb' - - 'lib/gitlab/email/message/in_product_marketing/verify.rb' - 'lib/gitlab/object_hierarchy.rb' - 'lib/gitlab/project_authorizations.rb' - 'qa/qa/specs/features/api/12_systems/gitaly/automatic_failover_and_recovery_spec.rb' diff --git a/.rubocop_todo/layout/line_continuation_leading_space.yml b/.rubocop_todo/layout/line_continuation_leading_space.yml index 3c39768b481..c1384bf3663 100644 --- a/.rubocop_todo/layout/line_continuation_leading_space.yml +++ b/.rubocop_todo/layout/line_continuation_leading_space.yml @@ -60,8 +60,6 @@ Layout/LineContinuationLeadingSpace: - 'spec/lib/gitlab/usage/metrics/instrumentations/count_imported_projects_total_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/gitlab_for_jira_app_direct_installations_count_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/gitlab_for_jira_app_proxy_installations_count_metric_spec.rb' - - 'spec/lib/gitlab/usage/metrics/instrumentations/in_product_marketing_email_cta_clicked_metric_spec.rb' - - 'spec/lib/gitlab/usage/metrics/instrumentations/in_product_marketing_email_sent_metric_spec.rb' - 'spec/lib/system_check/incoming_email/imap_authentication_check_spec.rb' - 'spec/models/integrations/chat_message/pipeline_message_spec.rb' - 'spec/services/feature_flags/update_service_spec.rb' diff --git a/.rubocop_todo/layout/line_continuation_spacing.yml b/.rubocop_todo/layout/line_continuation_spacing.yml index 355ef3f3ff8..721d7c56942 100644 --- a/.rubocop_todo/layout/line_continuation_spacing.yml +++ b/.rubocop_todo/layout/line_continuation_spacing.yml @@ -165,8 +165,6 @@ Layout/LineContinuationSpacing: - 'spec/lib/gitlab/usage/metrics/instrumentations/count_imported_projects_total_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/gitlab_for_jira_app_direct_installations_count_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/gitlab_for_jira_app_proxy_installations_count_metric_spec.rb' - - 'spec/lib/gitlab/usage/metrics/instrumentations/in_product_marketing_email_cta_clicked_metric_spec.rb' - - 'spec/lib/gitlab/usage/metrics/instrumentations/in_product_marketing_email_sent_metric_spec.rb' - 'spec/lib/gitlab/utils/gzip_spec.rb' - 'spec/lib/system_check/incoming_email/imap_authentication_check_spec.rb' - 'spec/mailers/emails/identity_verification_spec.rb' diff --git a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml index 0253613849e..9f826f4428b 100644 --- a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml +++ b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml @@ -194,7 +194,6 @@ Layout/LineEndStringConcatenationIndentation: - 'lib/gitlab/slash_commands/presenters/run.rb' - 'lib/gitlab/tracking/standard_context.rb' - 'lib/tasks/gitlab/db/validate_config.rake' - - 'lib/tasks/gitlab/storage.rake' - 'qa/qa/ee/page/project/settings/services/jira.rb' - 'qa/qa/specs/features/api/4_verify/api_variable_inheritance_with_forward_pipeline_variables_spec.rb' - 'qa/qa/support/system_logs/kibana.rb' @@ -266,8 +265,6 @@ Layout/LineEndStringConcatenationIndentation: - 'spec/lib/gitlab/ci/templates/themekit_gitlab_ci_yaml_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_migration_runner_spec.rb' - 'spec/lib/gitlab/database/migrations/batched_background_migration_helpers_spec.rb' - - 'spec/lib/gitlab/email/message/build_ios_app_guide_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/helper_spec.rb' - 'spec/lib/gitlab/github_import/markdown_text_spec.rb' - 'spec/lib/gitlab/github_import/representation/issue_event_spec.rb' - 'spec/lib/gitlab/insecure_key_fingerprint_spec.rb' @@ -280,8 +277,6 @@ Layout/LineEndStringConcatenationIndentation: - 'spec/lib/gitlab/usage/metrics/instrumentations/count_imported_projects_total_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/gitlab_for_jira_app_direct_installations_count_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/gitlab_for_jira_app_proxy_installations_count_metric_spec.rb' - - 'spec/lib/gitlab/usage/metrics/instrumentations/in_product_marketing_email_cta_clicked_metric_spec.rb' - - 'spec/lib/gitlab/usage/metrics/instrumentations/in_product_marketing_email_sent_metric_spec.rb' - 'spec/lib/gitlab/utils/gzip_spec.rb' - 'spec/mailers/emails/identity_verification_spec.rb' - 'spec/mailers/emails/projects_spec.rb' diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index 9fd3d47d8f0..4b7c1f75daa 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -339,9 +339,7 @@ Layout/LineLength: - 'app/models/group.rb' - 'app/models/incident_management/project_incident_management_setting.rb' - 'app/models/instance_configuration.rb' - - 'app/models/integration.rb' - 'app/models/integrations/asana.rb' - - 'app/models/integrations/bamboo.rb' - 'app/models/integrations/base_chat_notification.rb' - 'app/models/integrations/base_issue_tracker.rb' - 'app/models/integrations/bugzilla.rb' @@ -361,7 +359,6 @@ Layout/LineLength: - 'app/models/integrations/hangouts_chat.rb' - 'app/models/integrations/harbor.rb' - 'app/models/integrations/jenkins.rb' - - 'app/models/integrations/jira.rb' - 'app/models/integrations/mattermost.rb' - 'app/models/integrations/microsoft_teams.rb' - 'app/models/integrations/pipelines_email.rb' @@ -581,8 +578,6 @@ Layout/LineLength: - 'app/services/packages/npm/create_package_service.rb' - 'app/services/packages/nuget/search_service.rb' - 'app/services/packages/nuget/update_package_from_metadata_service.rb' - - 'app/services/pages/migrate_from_legacy_storage_service.rb' - - 'app/services/pages/migrate_legacy_storage_to_deployment_service.rb' - 'app/services/personal_access_tokens/create_service.rb' - 'app/services/personal_access_tokens/revoke_service.rb' - 'app/services/projects/branches_by_mode_service.rb' @@ -594,10 +589,8 @@ Layout/LineLength: - 'app/services/projects/destroy_service.rb' - 'app/services/projects/fork_service.rb' - 'app/services/projects/hashed_storage/base_attachment_service.rb' - - 'app/services/projects/hashed_storage/base_repository_service.rb' - 'app/services/projects/hashed_storage/migrate_attachments_service.rb' - 'app/services/projects/hashed_storage/migrate_repository_service.rb' - - 'app/services/projects/hashed_storage/rollback_repository_service.rb' - 'app/services/projects/lfs_pointers/lfs_download_service.rb' - 'app/services/projects/operations/update_service.rb' - 'app/services/projects/overwrite_project_service.rb' @@ -625,7 +618,6 @@ Layout/LineLength: - 'app/services/system_notes/issuables_service.rb' - 'app/services/system_notes/zoom_service.rb' - 'app/services/tags/destroy_service.rb' - - 'app/services/tasks_to_be_done/base_service.rb' - 'app/services/users/approve_service.rb' - 'app/services/users/banned_user_base_service.rb' - 'app/services/users/build_service.rb' @@ -897,7 +889,6 @@ Layout/LineLength: - 'ee/app/models/ee/container_repository.rb' - 'ee/app/models/ee/epic.rb' - 'ee/app/models/ee/group.rb' - - 'ee/app/models/ee/integrations/jira.rb' - 'ee/app/models/ee/issue.rb' - 'ee/app/models/ee/key.rb' - 'ee/app/models/ee/lfs_object.rb' @@ -1263,7 +1254,6 @@ Layout/LineLength: - 'ee/lib/gitlab/elastic/group_search_results.rb' - 'ee/lib/gitlab/elastic/project_search_results.rb' - 'ee/lib/gitlab/elastic/search_results.rb' - - 'ee/lib/gitlab/email/message/account_validation.rb' - 'ee/lib/gitlab/expiring_subscription_message.rb' - 'ee/lib/gitlab/geo.rb' - 'ee/lib/gitlab/geo/geo_node_status_check.rb' @@ -1335,7 +1325,6 @@ Layout/LineLength: - 'ee/spec/controllers/projects/pipelines_controller_spec.rb' - 'ee/spec/controllers/projects/protected_environments_controller_spec.rb' - 'ee/spec/controllers/projects/push_rules_controller_spec.rb' - - 'ee/spec/controllers/projects/runners_controller_spec.rb' - 'ee/spec/controllers/projects/security/configuration_controller_spec.rb' - 'ee/spec/controllers/projects/security/vulnerabilities_controller_spec.rb' - 'ee/spec/controllers/projects/subscriptions_controller_spec.rb' @@ -2689,13 +2678,6 @@ Layout/LineLength: - 'lib/gitlab/email/failure_handler.rb' - 'lib/gitlab/email/handler/create_issue_handler.rb' - 'lib/gitlab/email/handler/create_merge_request_handler.rb' - - 'lib/gitlab/email/message/in_product_marketing/base.rb' - - 'lib/gitlab/email/message/in_product_marketing/create.rb' - - 'lib/gitlab/email/message/in_product_marketing/helper.rb' - - 'lib/gitlab/email/message/in_product_marketing/team.rb' - - 'lib/gitlab/email/message/in_product_marketing/trial.rb' - - 'lib/gitlab/email/message/in_product_marketing/trial_short.rb' - - 'lib/gitlab/email/message/in_product_marketing/verify.rb' - 'lib/gitlab/encrypted_command_base.rb' - 'lib/gitlab/encrypted_configuration.rb' - 'lib/gitlab/endpoint_attributes/config.rb' @@ -2741,7 +2723,6 @@ Layout/LineLength: - 'lib/gitlab/grape_logging/loggers/client_env_logger.rb' - 'lib/gitlab/graphql/timeout.rb' - 'lib/gitlab/group_search_results.rb' - - 'lib/gitlab/hashed_storage/migrator.rb' - 'lib/gitlab/hook_data/key_builder.rb' - 'lib/gitlab/hotlinking_detector.rb' - 'lib/gitlab/http_io.rb' @@ -2887,7 +2868,6 @@ Layout/LineLength: - 'lib/tasks/gitlab/shell.rake' - 'lib/tasks/gitlab/sidekiq.rake' - 'lib/tasks/gitlab/snippets.rake' - - 'lib/tasks/gitlab/storage.rake' - 'lib/tasks/gitlab/terraform/migrate.rake' - 'lib/tasks/gitlab/update_templates.rake' - 'lib/tasks/gitlab/usage_data.rake' @@ -3178,7 +3158,6 @@ Layout/LineLength: - 'spec/controllers/projects/prometheus/metrics_controller_spec.rb' - 'spec/controllers/projects/registry/tags_controller_spec.rb' - 'spec/controllers/projects/repositories_controller_spec.rb' - - 'spec/controllers/projects/runners_controller_spec.rb' - 'spec/controllers/projects/settings/ci_cd_controller_spec.rb' - 'spec/controllers/projects/settings/operations_controller_spec.rb' - 'spec/controllers/projects/settings/repository_controller_spec.rb' @@ -3871,12 +3850,6 @@ Layout/LineLength: - 'spec/lib/gitlab/email/handler/unsubscribe_handler_spec.rb' - 'spec/lib/gitlab/email/handler_spec.rb' - 'spec/lib/gitlab/email/hook/smime_signature_interceptor_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/admin_verify_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/base_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/team_short_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/team_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/trial_short_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/trial_spec.rb' - 'spec/lib/gitlab/email/receiver_spec.rb' - 'spec/lib/gitlab/email/reply_parser_spec.rb' - 'spec/lib/gitlab/emoji_spec.rb' @@ -3929,7 +3902,6 @@ Layout/LineLength: - 'spec/lib/gitlab/highlight_spec.rb' - 'spec/lib/gitlab/hook_data/project_member_builder_spec.rb' - 'spec/lib/gitlab/hotlinking_detector_spec.rb' - - 'spec/lib/gitlab/http_spec.rb' - 'spec/lib/gitlab/i18n/po_linter_spec.rb' - 'spec/lib/gitlab/import/set_async_jid_spec.rb' - 'spec/lib/gitlab/import_export/attribute_cleaner_spec.rb' @@ -4204,7 +4176,6 @@ Layout/LineLength: - 'spec/models/import_failure_spec.rb' - 'spec/models/instance_configuration_spec.rb' - 'spec/models/integration_spec.rb' - - 'spec/models/integrations/bamboo_spec.rb' - 'spec/models/integrations/base_chat_notification_spec.rb' - 'spec/models/integrations/base_issue_tracker_spec.rb' - 'spec/models/integrations/chat_message/base_message_spec.rb' @@ -4299,7 +4270,6 @@ Layout/LineLength: - 'spec/models/uploads/fog_spec.rb' - 'spec/models/user_detail_spec.rb' - 'spec/models/user_spec.rb' - - 'spec/models/users/in_product_marketing_email_spec.rb' - 'spec/models/wiki_page_spec.rb' - 'spec/models/x509_certificate_spec.rb' - 'spec/policies/ci/build_policy_spec.rb' @@ -4750,8 +4720,6 @@ Layout/LineLength: - 'spec/services/packages/nuget/update_package_from_metadata_service_spec.rb' - 'spec/services/packages/rubygems/process_gem_service_spec.rb' - 'spec/services/packages/terraform_module/create_package_service_spec.rb' - - 'spec/services/pages/migrate_from_legacy_storage_service_spec.rb' - - 'spec/services/pages/migrate_legacy_storage_to_deployment_service_spec.rb' - 'spec/services/personal_access_tokens/create_service_spec.rb' - 'spec/services/post_receive_service_spec.rb' - 'spec/services/projects/apple_target_platform_detector_service_spec.rb' @@ -4772,8 +4740,6 @@ Layout/LineLength: - 'spec/services/projects/group_links/destroy_service_spec.rb' - 'spec/services/projects/hashed_storage/migrate_repository_service_spec.rb' - 'spec/services/projects/hashed_storage/migration_service_spec.rb' - - 'spec/services/projects/hashed_storage/rollback_repository_service_spec.rb' - - 'spec/services/projects/hashed_storage/rollback_service_spec.rb' - 'spec/services/projects/import_error_filter_spec.rb' - 'spec/services/projects/import_export/export_service_spec.rb' - 'spec/services/projects/import_service_spec.rb' @@ -5033,7 +4999,6 @@ Layout/LineLength: - 'spec/tasks/gitlab/refresh_project_statistics_build_artifacts_size_rake_spec.rb' - 'spec/tasks/gitlab/smtp_rake_spec.rb' - 'spec/tasks/gitlab/snippets_rake_spec.rb' - - 'spec/tasks/gitlab/storage_rake_spec.rb' - 'spec/tasks/gitlab/terraform/migrate_rake_spec.rb' - 'spec/tasks/gitlab/uploads/check_rake_spec.rb' - 'spec/tasks/gitlab/workhorse_rake_spec.rb' diff --git a/.rubocop_todo/layout/space_in_lambda_literal.yml b/.rubocop_todo/layout/space_in_lambda_literal.yml index 54ed188fd26..11e5649b57a 100644 --- a/.rubocop_todo/layout/space_in_lambda_literal.yml +++ b/.rubocop_todo/layout/space_in_lambda_literal.yml @@ -49,7 +49,6 @@ Layout/SpaceInLambdaLiteral: - 'app/models/group.rb' - 'app/models/group_group_link.rb' - 'app/models/incident_management/timeline_event_tag.rb' - - 'app/models/integration.rb' - 'app/models/integrations/base_chat_notification.rb' - 'app/models/integrations/datadog.rb' - 'app/models/internal_id.rb' @@ -66,7 +65,6 @@ Layout/SpaceInLambdaLiteral: - 'app/models/loose_foreign_keys/deleted_record.rb' - 'app/models/member.rb' - 'app/models/members/group_member.rb' - - 'app/models/members/member_task.rb' - 'app/models/merge_request.rb' - 'app/models/merge_request_diff.rb' - 'app/models/milestone.rb' @@ -101,7 +99,6 @@ Layout/SpaceInLambdaLiteral: - 'app/models/user.rb' - 'app/models/user_highest_role.rb' - 'app/models/users/callout.rb' - - 'app/models/users/in_product_marketing_email.rb' - 'app/models/users/phone_number_validation.rb' - 'app/models/users_star_project.rb' - 'app/models/zoom_meeting.rb' diff --git a/.rubocop_todo/lint/ambiguous_operator_precedence.yml b/.rubocop_todo/lint/ambiguous_operator_precedence.yml index f21c101d4a2..fc049cb68f0 100644 --- a/.rubocop_todo/lint/ambiguous_operator_precedence.yml +++ b/.rubocop_todo/lint/ambiguous_operator_precedence.yml @@ -33,7 +33,6 @@ Lint/AmbiguousOperatorPrecedence: - 'config/initializers/carrierwave_s3_encryption_headers_patch.rb' - 'config/initializers/kaminari_active_record_relation_methods_with_limit.rb' - 'danger/roulette/Dangerfile' - - 'ee/app/models/ee/integrations/jira.rb' - 'ee/app/models/geo/upload_registry.rb' - 'ee/app/models/iterations/cadence.rb' - 'ee/app/models/license.rb' @@ -67,7 +66,6 @@ Lint/AmbiguousOperatorPrecedence: - 'lib/gitlab/database/partitioning_migration_helpers/table_management_helpers.rb' - 'lib/gitlab/database/postgres_hll/buckets.rb' - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb' - - 'lib/gitlab/email/message/in_product_marketing/helper.rb' - 'lib/gitlab/i18n/po_linter.rb' - 'lib/gitlab/import_export/project/relation_factory.rb' - 'lib/gitlab/memory/instrumentation.rb' diff --git a/.rubocop_todo/lint/assignment_in_condition.yml b/.rubocop_todo/lint/assignment_in_condition.yml index 69470c7d5f0..ae2d672b4bc 100644 --- a/.rubocop_todo/lint/assignment_in_condition.yml +++ b/.rubocop_todo/lint/assignment_in_condition.yml @@ -64,7 +64,6 @@ Lint/AssignmentInCondition: - 'app/services/merge_requests/mergeability_check_service.rb' - 'app/services/metrics/dashboard/dynamic_embed_service.rb' - 'app/services/packages/debian/parse_debian822_service.rb' - - 'app/services/pages/migrate_from_legacy_storage_service.rb' - 'app/services/projects/operations/update_service.rb' - 'app/services/projects/prometheus/alerts/notify_service.rb' - 'app/services/projects/unlink_fork_service.rb' @@ -73,7 +72,6 @@ Lint/AssignmentInCondition: - 'app/services/system_notes/incident_service.rb' - 'app/services/system_notes/merge_requests_service.rb' - 'app/services/task_list_toggle_service.rb' - - 'app/services/tasks_to_be_done/base_service.rb' - 'app/services/users/last_push_event_service.rb' - 'app/services/users/refresh_authorized_projects_service.rb' - 'app/services/users/update_service.rb' diff --git a/.rubocop_todo/lint/unused_block_argument.yml b/.rubocop_todo/lint/unused_block_argument.yml index 0d57ccd0234..a6578a63918 100644 --- a/.rubocop_todo/lint/unused_block_argument.yml +++ b/.rubocop_todo/lint/unused_block_argument.yml @@ -34,7 +34,6 @@ Lint/UnusedBlockArgument: - 'app/models/concerns/avatarable.rb' - 'app/models/concerns/mentionable.rb' - 'app/models/customer_relations/organization.rb' - - 'app/models/integration.rb' - 'app/models/merge_request.rb' - 'app/models/project.rb' - 'app/models/projects/build_artifacts_size_refresh.rb' @@ -282,7 +281,6 @@ Lint/UnusedBlockArgument: - 'scripts/perf/gc/collect_gc_stats.rb' - 'scripts/qa/testcases-check' - 'scripts/review_apps/automated_cleanup.rb' - - 'scripts/used-feature-flags' - 'sidekiq_cluster/cli.rb' - 'spec/components/pajamas/button_component_spec.rb' - 'spec/components/previews/pajamas/banner_component_preview.rb' @@ -338,7 +336,6 @@ Lint/UnusedBlockArgument: - 'spec/lib/gitlab/git_access_wiki_spec.rb' - 'spec/lib/gitlab/graphql/tracers/application_context_tracer_spec.rb' - 'spec/lib/gitlab/health_checks/simple_check_shared.rb' - - 'spec/lib/gitlab/http_spec.rb' - 'spec/lib/gitlab/jwt_authenticatable_spec.rb' - 'spec/lib/gitlab/memory/jemalloc_spec.rb' - 'spec/lib/gitlab/middleware/memory_report_spec.rb' diff --git a/.rubocop_todo/lint/unused_method_argument.yml b/.rubocop_todo/lint/unused_method_argument.yml index e052454ae32..a309a041c38 100644 --- a/.rubocop_todo/lint/unused_method_argument.yml +++ b/.rubocop_todo/lint/unused_method_argument.yml @@ -118,12 +118,10 @@ Lint/UnusedMethodArgument: - 'app/models/discussion.rb' - 'app/models/external_issue.rb' - 'app/models/group.rb' - - 'app/models/integrations/bamboo.rb' - 'app/models/integrations/buildkite.rb' - 'app/models/integrations/discord.rb' - 'app/models/integrations/ewm.rb' - 'app/models/integrations/hangouts_chat.rb' - - 'app/models/integrations/jira.rb' - 'app/models/integrations/microsoft_teams.rb' - 'app/models/integrations/mock_ci.rb' - 'app/models/integrations/mock_monitoring.rb' @@ -482,7 +480,6 @@ Lint/UnusedMethodArgument: - 'lib/gitlab/graphql/project/dast_profile_connection_extension.rb' - 'lib/gitlab/graphql/query_analyzers/ast/logger_analyzer.rb' - 'lib/gitlab/graphql/tracers/timer_tracer.rb' - - 'lib/gitlab/hashed_storage/rake_helper.rb' - 'lib/gitlab/hook_data/subgroup_builder.rb' - 'lib/gitlab/import_export/after_export_strategies/base_after_export_strategy.rb' - 'lib/gitlab/import_export/fast_hash_serializer.rb' diff --git a/.rubocop_todo/migration/background_migration_base_class.yml b/.rubocop_todo/migration/background_migration_base_class.yml index 6e5d34726e9..c9ff0a41a2b 100644 --- a/.rubocop_todo/migration/background_migration_base_class.yml +++ b/.rubocop_todo/migration/background_migration_base_class.yml @@ -29,7 +29,6 @@ Migration/BackgroundMigrationBaseClass: - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb' - 'lib/gitlab/background_migration/migrate_job_artifact_registry_to_ssf.rb' - 'lib/gitlab/background_migration/migrate_null_private_profile_to_false.rb' - - 'lib/gitlab/background_migration/migrate_pages_to_zip_storage.rb' - 'lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner.rb' - 'lib/gitlab/background_migration/migrate_requirements_to_work_items.rb' - 'lib/gitlab/background_migration/migrate_shimo_confluence_integration_category.rb' diff --git a/.rubocop_todo/qa/fabricate_usage.yml b/.rubocop_todo/qa/fabricate_usage.yml new file mode 100644 index 00000000000..4560204b84c --- /dev/null +++ b/.rubocop_todo/qa/fabricate_usage.yml @@ -0,0 +1,36 @@ +--- +QA/FabricateUsage: + Include: + - 'qa/qa/specs/**/*_spec.rb' + Details: grace period + Exclude: + - 'qa/qa/specs/features/api/3_create/repository/default_branch_name_setting_spec.rb' + - 'qa/qa/specs/features/ee/api/7_configure/kubernetes/kubernetes_agent_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/10_govern/create_merge_request_with_secure_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/10_govern/dismissed_vulnerabilities_in_security_widget_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/10_govern/export_vulnerability_report_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/10_govern/fix_vulnerability_workflow_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/10_govern/group/group_audit_event_streaming_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/10_govern/project/project_audit_logs_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/10_govern/project_security_dashboard_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/10_govern/scan_result_policy_vulnerabilities_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/10_govern/security_reports_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/10_govern/vulnerabilities_jira_integration_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/10_govern/vulnerability_management_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/10_govern/vulnerability_security_training_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_ci_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_storage_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/upgrade_group_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/saas_user_limit_experience_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/utilization/free_namespace_storage_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/12_systems/geo/attachment_replication_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/12_systems/geo/database_delete_replication_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/12_systems/geo/geo_replication_ci_job_log_artifacts_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/12_systems/geo/geo_replication_maven_package_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/12_systems/geo/geo_replication_npm_registry_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/12_systems/geo/http_push_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/12_systems/geo/http_push_to_secondary_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/12_systems/geo/rename_replication_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/12_systems/geo/ssh_push_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/12_systems/geo/ssh_push_to_secondary_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/3_create/remote_development/workspace_actions_spec.rb' diff --git a/.rubocop_todo/rails/file_path.yml b/.rubocop_todo/rails/file_path.yml index eef5e580e43..9fefe1d291d 100644 --- a/.rubocop_todo/rails/file_path.yml +++ b/.rubocop_todo/rails/file_path.yml @@ -101,8 +101,8 @@ Rails/FilePath: - 'spec/lib/gitlab/database/schema_migrations/context_spec.rb' - 'spec/lib/gitlab/feature_categories_spec.rb' - 'spec/lib/gitlab/file_hook_spec.rb' - - 'spec/lib/gitlab/http_spec.rb' - 'spec/lib/gitlab/jwt_authenticatable_spec.rb' + - 'spec/lib/gitlab/legacy_http_spec.rb' - 'spec/lib/gitlab/mail_room/mail_room_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/finder_spec.rb' - 'spec/lib/gitlab/middleware/multipart/handler_spec.rb' diff --git a/.rubocop_todo/rails/output_safety.yml b/.rubocop_todo/rails/output_safety.yml index 85388e8a1da..36628384477 100644 --- a/.rubocop_todo/rails/output_safety.yml +++ b/.rubocop_todo/rails/output_safety.yml @@ -118,7 +118,6 @@ Rails/OutputSafety: - 'ee/app/helpers/push_rules_helper.rb' - 'ee/app/models/integrations/github.rb' - 'ee/lib/ee/gitlab/namespace_storage_size_error_message.rb' - - 'ee/lib/gitlab/email/message/account_validation.rb' - 'ee/lib/gitlab/expiring_subscription_message.rb' - 'ee/lib/gitlab/licenses/submit_license_usage_data_banner.rb' - 'ee/lib/gitlab/manual_quarterly_co_term_banner.rb' @@ -139,9 +138,6 @@ Rails/OutputSafety: - 'lib/gitlab/diff/inline_diff_marker.rb' - 'lib/gitlab/diff/line.rb' - 'lib/gitlab/diff/rendered/notebook/diff_file_helper.rb' - - 'lib/gitlab/email/message/in_product_marketing/helper.rb' - - 'lib/gitlab/email/message/in_product_marketing/trial.rb' - - 'lib/gitlab/email/message/in_product_marketing/verify.rb' - 'lib/gitlab/highlight.rb' - 'lib/gitlab/observability.rb' - 'lib/gitlab/other_markup.rb' diff --git a/.rubocop_todo/rspec/before_all_role_assignment.yml b/.rubocop_todo/rspec/before_all_role_assignment.yml index cc0781a337e..0905a79beca 100644 --- a/.rubocop_todo/rspec/before_all_role_assignment.yml +++ b/.rubocop_todo/rspec/before_all_role_assignment.yml @@ -26,7 +26,6 @@ RSpec/BeforeAllRoleAssignment: - 'ee/spec/controllers/groups/issues_analytics_controller_spec.rb' - 'ee/spec/controllers/groups/merge_requests_controller_spec.rb' - 'ee/spec/controllers/groups/push_rules_controller_spec.rb' - - 'ee/spec/controllers/groups/runners_controller_spec.rb' - 'ee/spec/controllers/groups/seat_usage_controller_spec.rb' - 'ee/spec/controllers/groups/security/policies_controller_spec.rb' - 'ee/spec/controllers/groups/todos_controller_spec.rb' @@ -775,7 +774,6 @@ RSpec/BeforeAllRoleAssignment: - 'spec/controllers/groups/group_members_controller_spec.rb' - 'spec/controllers/groups/imports_controller_spec.rb' - 'spec/controllers/groups/labels_controller_spec.rb' - - 'spec/controllers/groups/runners_controller_spec.rb' - 'spec/controllers/groups/settings/applications_controller_spec.rb' - 'spec/controllers/groups/settings/ci_cd_controller_spec.rb' - 'spec/controllers/groups/settings/integrations_controller_spec.rb' @@ -817,7 +815,6 @@ RSpec/BeforeAllRoleAssignment: - 'spec/controllers/projects/registry/repositories_controller_spec.rb' - 'spec/controllers/projects/repositories_controller_spec.rb' - 'spec/controllers/projects/runner_projects_controller_spec.rb' - - 'spec/controllers/projects/runners_controller_spec.rb' - 'spec/controllers/projects/settings/ci_cd_controller_spec.rb' - 'spec/controllers/projects/settings/integrations_controller_spec.rb' - 'spec/controllers/projects/settings/slacks_controller_spec.rb' @@ -1160,7 +1157,6 @@ RSpec/BeforeAllRoleAssignment: - 'spec/lib/gitlab/search_results_spec.rb' - 'spec/lib/gitlab/slash_commands/presenters/issue_move_spec.rb' - 'spec/lib/gitlab/tree_summary_spec.rb' - - 'spec/mailers/emails/in_product_marketing_spec.rb' - 'spec/models/ci/bridge_spec.rb' - 'spec/models/ci/catalog/listing_spec.rb' - 'spec/models/ci/pipeline_spec.rb' @@ -1539,7 +1535,6 @@ RSpec/BeforeAllRoleAssignment: - 'spec/services/snippets/create_service_spec.rb' - 'spec/services/snippets/destroy_service_spec.rb' - 'spec/services/snippets/update_service_spec.rb' - - 'spec/services/tasks_to_be_done/base_service_spec.rb' - 'spec/services/todo_service_spec.rb' - 'spec/services/todos/destroy/entity_leave_service_spec.rb' - 'spec/services/uploads/destroy_service_spec.rb' diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index 9f6b07c397e..f95f6424593 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -14,7 +14,6 @@ RSpec/ContextWording: - 'ee/spec/controllers/ee/groups_controller_spec.rb' - 'ee/spec/controllers/ee/projects/jobs_controller_spec.rb' - 'ee/spec/controllers/ee/projects/merge_requests/content_controller_spec.rb' - - 'ee/spec/controllers/ee/registrations_controller_spec.rb' - 'ee/spec/controllers/ee/root_controller_spec.rb' - 'ee/spec/controllers/ee/search_controller_spec.rb' - 'ee/spec/controllers/ee/sent_notifications_controller_spec.rb' @@ -161,7 +160,6 @@ RSpec/ContextWording: - 'ee/spec/features/projects/settings/push_rules_settings_spec.rb' - 'ee/spec/features/promotion_spec.rb' - 'ee/spec/features/protected_branches_spec.rb' - - 'ee/spec/features/signup_spec.rb' - 'ee/spec/features/users/login_spec.rb' - 'ee/spec/features/users/signup_spec.rb' - 'ee/spec/finders/approval_rules/group_finder_spec.rb' @@ -996,7 +994,6 @@ RSpec/ContextWording: - 'spec/controllers/metrics_controller_spec.rb' - 'spec/controllers/oauth/applications_controller_spec.rb' - 'spec/controllers/oauth/authorizations_controller_spec.rb' - - 'spec/controllers/omniauth_callbacks_controller_spec.rb' - 'spec/controllers/passwords_controller_spec.rb' - 'spec/controllers/profiles/emails_controller_spec.rb' - 'spec/controllers/profiles/notifications_controller_spec.rb' @@ -1053,7 +1050,6 @@ RSpec/ContextWording: - 'spec/controllers/projects/tree_controller_spec.rb' - 'spec/controllers/projects/web_ide_terminals_controller_spec.rb' - 'spec/controllers/projects_controller_spec.rb' - - 'spec/controllers/registrations_controller_spec.rb' - 'spec/controllers/repositories/lfs_storage_controller_spec.rb' - 'spec/controllers/root_controller_spec.rb' - 'spec/controllers/search_controller_spec.rb' @@ -1782,13 +1778,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/email/handler/service_desk_handler_spec.rb' - 'spec/lib/gitlab/email/handler/unsubscribe_handler_spec.rb' - 'spec/lib/gitlab/email/handler_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/admin_verify_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/base_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/helper_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/team_short_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/team_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/trial_short_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/trial_spec.rb' - 'spec/lib/gitlab/email/message/repository_push_spec.rb' - 'spec/lib/gitlab/email/reply_parser_spec.rb' - 'spec/lib/gitlab/encoding_helper_spec.rb' @@ -1858,7 +1847,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/hook_data/subgroup_builder_spec.rb' - 'spec/lib/gitlab/hook_data/user_builder_spec.rb' - 'spec/lib/gitlab/hotlinking_detector_spec.rb' - - 'spec/lib/gitlab/http_spec.rb' - 'spec/lib/gitlab/import/merge_request_creator_spec.rb' - 'spec/lib/gitlab/import_export/attributes_finder_spec.rb' - 'spec/lib/gitlab/import_export/command_line_util_spec.rb' @@ -1898,6 +1886,7 @@ RSpec/ContextWording: - 'spec/lib/gitlab/kubernetes/default_namespace_spec.rb' - 'spec/lib/gitlab/kubernetes/kube_client_spec.rb' - 'spec/lib/gitlab/legacy_github_import/client_spec.rb' + - 'spec/lib/gitlab/legacy_http_spec.rb' - 'spec/lib/gitlab/lfs/client_spec.rb' - 'spec/lib/gitlab/lfs_token_spec.rb' - 'spec/lib/gitlab/lograge/custom_options_spec.rb' @@ -2181,7 +2170,6 @@ RSpec/ContextWording: - 'spec/models/import_export_upload_spec.rb' - 'spec/models/import_failure_spec.rb' - 'spec/models/integration_spec.rb' - - 'spec/models/integrations/bamboo_spec.rb' - 'spec/models/integrations/base_chat_notification_spec.rb' - 'spec/models/integrations/chat_message/issue_message_spec.rb' - 'spec/models/integrations/chat_message/merge_message_spec.rb' @@ -2271,7 +2259,6 @@ RSpec/ContextWording: - 'spec/models/uploads/local_spec.rb' - 'spec/models/user_preference_spec.rb' - 'spec/models/user_spec.rb' - - 'spec/models/users/in_product_marketing_email_spec.rb' - 'spec/models/wiki_page/meta_spec.rb' - 'spec/models/wiki_page/slug_spec.rb' - 'spec/models/wiki_page_spec.rb' @@ -2768,7 +2755,6 @@ RSpec/ContextWording: - 'spec/services/packages/rubygems/dependency_resolver_service_spec.rb' - 'spec/services/packages/rubygems/process_gem_service_spec.rb' - 'spec/services/packages/terraform_module/create_package_service_spec.rb' - - 'spec/services/pages/zip_directory_service_spec.rb' - 'spec/services/pages_domains/obtain_lets_encrypt_certificate_service_spec.rb' - 'spec/services/personal_access_tokens/create_service_spec.rb' - 'spec/services/personal_access_tokens/revoke_service_spec.rb' @@ -2791,8 +2777,6 @@ RSpec/ContextWording: - 'spec/services/projects/group_links/update_service_spec.rb' - 'spec/services/projects/hashed_storage/migrate_repository_service_spec.rb' - 'spec/services/projects/hashed_storage/migration_service_spec.rb' - - 'spec/services/projects/hashed_storage/rollback_repository_service_spec.rb' - - 'spec/services/projects/hashed_storage/rollback_service_spec.rb' - 'spec/services/projects/in_product_marketing_campaign_emails_service_spec.rb' - 'spec/services/projects/lfs_pointers/lfs_download_link_list_service_spec.rb' - 'spec/services/projects/lfs_pointers/lfs_download_service_spec.rb' @@ -2833,7 +2817,6 @@ RSpec/ContextWording: - 'spec/services/system_notes/design_management_service_spec.rb' - 'spec/services/system_notes/issuables_service_spec.rb' - 'spec/services/system_notes/merge_requests_service_spec.rb' - - 'spec/services/tasks_to_be_done/base_service_spec.rb' - 'spec/services/terraform/remote_state_handler_spec.rb' - 'spec/services/terraform/states/destroy_service_spec.rb' - 'spec/services/terraform/states/trigger_destroy_service_spec.rb' @@ -3072,7 +3055,6 @@ RSpec/ContextWording: - 'spec/tasks/gitlab/gitaly_rake_spec.rb' - 'spec/tasks/gitlab/lfs/migrate_rake_spec.rb' - 'spec/tasks/gitlab/packages/migrate_rake_spec.rb' - - 'spec/tasks/gitlab/storage_rake_spec.rb' - 'spec/tasks/gitlab/terraform/migrate_rake_spec.rb' - 'spec/tasks/gitlab/workhorse_rake_spec.rb' - 'spec/tooling/danger/project_helper_spec.rb' diff --git a/.rubocop_todo/rspec/expect_change.yml b/.rubocop_todo/rspec/expect_change.yml index 02d1427c384..f625c948e79 100644 --- a/.rubocop_todo/rspec/expect_change.yml +++ b/.rubocop_todo/rspec/expect_change.yml @@ -408,7 +408,6 @@ RSpec/ExpectChange: - 'spec/services/snippets/update_statistics_service_spec.rb' - 'spec/services/spam/spam_action_service_spec.rb' - 'spec/services/suggestions/create_service_spec.rb' - - 'spec/services/tasks_to_be_done/base_service_spec.rb' - 'spec/services/terraform/states/trigger_destroy_service_spec.rb' - 'spec/services/todo_service_spec.rb' - 'spec/services/todos/destroy/destroyed_issuable_service_spec.rb' diff --git a/.rubocop_todo/rspec/expect_in_hook.yml b/.rubocop_todo/rspec/expect_in_hook.yml index 86f2a5abd41..58ddd11c934 100644 --- a/.rubocop_todo/rspec/expect_in_hook.yml +++ b/.rubocop_todo/rspec/expect_in_hook.yml @@ -12,7 +12,6 @@ RSpec/ExpectInHook: - 'ee/spec/features/projects/feature_flags/user_creates_feature_flag_spec.rb' - 'ee/spec/features/projects/feature_flags/user_deletes_feature_flag_spec.rb' - 'ee/spec/features/projects/settings/ee/service_desk_setting_spec.rb' - - 'ee/spec/features/signup_spec.rb' - 'ee/spec/finders/license_template_finder_spec.rb' - 'ee/spec/finders/projects/integrations/jira/issues_finder_spec.rb' - 'ee/spec/finders/template_finder_spec.rb' @@ -100,7 +99,6 @@ RSpec/ExpectInHook: - 'qa/qa/specs/features/browser_ui/5_package/package_registry/pypi_repository_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/cloud_activation_spec.rb' - 'spec/commands/metrics_server/metrics_server_spec.rb' - - 'spec/controllers/admin/runners_controller_spec.rb' - 'spec/controllers/autocomplete_controller_spec.rb' - 'spec/controllers/concerns/controller_with_cross_project_access_check_spec.rb' - 'spec/controllers/concerns/spammable_actions/captcha_check/html_format_actions_support_spec.rb' @@ -232,7 +230,6 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/health_checks/probes/collection_spec.rb' - 'spec/lib/gitlab/health_checks/puma_check_spec.rb' - 'spec/lib/gitlab/health_checks/server_spec.rb' - - 'spec/lib/gitlab/http_spec.rb' - 'spec/lib/gitlab/import_export/base/relation_factory_spec.rb' - 'spec/lib/gitlab/import_export/base/relation_object_saver_spec.rb' - 'spec/lib/gitlab/import_export/command_line_util_spec.rb' @@ -250,6 +247,7 @@ RSpec/ExpectInHook: - 'spec/lib/gitlab/kas/client_spec.rb' - 'spec/lib/gitlab/kubernetes/kube_client_spec.rb' - 'spec/lib/gitlab/kubernetes/kubeconfig/template_spec.rb' + - 'spec/lib/gitlab/legacy_http_spec.rb' - 'spec/lib/gitlab/memory/instrumentation_spec.rb' - 'spec/lib/gitlab/memory/jemalloc_spec.rb' - 'spec/lib/gitlab/metrics/boot_time_tracker_spec.rb' @@ -409,7 +407,6 @@ RSpec/ExpectInHook: - 'spec/services/packages/maven/metadata/sync_service_spec.rb' - 'spec/services/packages/rubygems/process_gem_service_spec.rb' - 'spec/services/packages/update_package_file_service_spec.rb' - - 'spec/services/pages/zip_directory_service_spec.rb' - 'spec/services/pages_domains/obtain_lets_encrypt_certificate_service_spec.rb' - 'spec/services/projects/after_rename_service_spec.rb' - 'spec/services/projects/branches_by_mode_service_spec.rb' diff --git a/.rubocop_todo/rspec/factory_bot/avoid_create.yml b/.rubocop_todo/rspec/factory_bot/avoid_create.yml index 2725b035d65..79e7b6027e1 100644 --- a/.rubocop_todo/rspec/factory_bot/avoid_create.yml +++ b/.rubocop_todo/rspec/factory_bot/avoid_create.yml @@ -151,7 +151,6 @@ RSpec/FactoryBot/AvoidCreate: - 'ee/spec/serializers/epic_note_entity_spec.rb' - 'ee/spec/serializers/epics/related_epic_entity_spec.rb' - 'ee/spec/serializers/fork_namespace_entity_spec.rb' - - 'ee/spec/serializers/geo_project_registry_entity_spec.rb' - 'ee/spec/serializers/incident_management/escalation_policy_entity_spec.rb' - 'ee/spec/serializers/incident_management/oncall_schedule_entity_spec.rb' - 'ee/spec/serializers/integrations/field_entity_spec.rb' @@ -360,7 +359,6 @@ RSpec/FactoryBot/AvoidCreate: - 'spec/mailers/devise_mailer_spec.rb' - 'spec/mailers/emails/auto_devops_spec.rb' - 'spec/mailers/emails/groups_spec.rb' - - 'spec/mailers/emails/in_product_marketing_spec.rb' - 'spec/mailers/emails/issues_spec.rb' - 'spec/mailers/emails/merge_requests_spec.rb' - 'spec/mailers/emails/pages_domains_spec.rb' diff --git a/.rubocop_todo/rspec/factory_bot/excessive_create_list.yml b/.rubocop_todo/rspec/factory_bot/excessive_create_list.yml index 009e60b5129..386c7317f3c 100644 --- a/.rubocop_todo/rspec/factory_bot/excessive_create_list.yml +++ b/.rubocop_todo/rspec/factory_bot/excessive_create_list.yml @@ -36,7 +36,6 @@ RSpec/FactoryBot/ExcessiveCreateList: - 'spec/services/database/consistency_check_service_spec.rb' - 'spec/services/groups/transfer_service_spec.rb' - 'spec/services/notification_service_spec.rb' - - 'spec/services/pages/migrate_from_legacy_storage_service_spec.rb' - 'spec/services/todo_service_spec.rb' - 'spec/support/shared_examples/services/notification_service_shared_examples.rb' - 'spec/workers/ssh_keys/expired_notification_worker_spec.rb' diff --git a/.rubocop_todo/rspec/missing_feature_category.yml b/.rubocop_todo/rspec/feature_category.yml index 4cc8ee1210c..a8db7b1fa09 100644 --- a/.rubocop_todo/rspec/missing_feature_category.yml +++ b/.rubocop_todo/rspec/feature_category.yml @@ -1,5 +1,5 @@ --- -RSpec/MissingFeatureCategory: +RSpec/FeatureCategory: Exclude: - 'ee/spec/components/namespaces/storage/subgroup_pre_enforcement_alert_component_spec.rb' - 'ee/spec/controllers/admin/application_settings_controller_spec.rb' @@ -971,7 +971,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/mailers/ee/emails/projects_spec.rb' - 'ee/spec/mailers/emails/epics_spec.rb' - 'ee/spec/mailers/emails/group_memberships_spec.rb' - - 'ee/spec/mailers/emails/in_product_marketing_spec.rb' - 'ee/spec/mailers/emails/namespace_storage_usage_mailer_spec.rb' - 'ee/spec/mailers/emails/requirements_spec.rb' - 'ee/spec/mailers/emails/user_cap_spec.rb' @@ -1732,7 +1731,6 @@ RSpec/MissingFeatureCategory: - 'spec/controllers/projects/prometheus/metrics_controller_spec.rb' - 'spec/controllers/projects/protected_branches_controller_spec.rb' - 'spec/controllers/projects/protected_tags_controller_spec.rb' - - 'spec/controllers/projects/registry/repositories_controller_spec.rb' - 'spec/controllers/projects/registry/tags_controller_spec.rb' - 'spec/controllers/projects/releases/evidences_controller_spec.rb' - 'spec/controllers/projects/releases_controller_spec.rb' @@ -1991,7 +1989,6 @@ RSpec/MissingFeatureCategory: - 'spec/graphql/mutations/concerns/mutations/resolves_group_spec.rb' - 'spec/graphql/mutations/concerns/mutations/resolves_issuable_spec.rb' - 'spec/graphql/mutations/container_expiration_policies/update_spec.rb' - - 'spec/graphql/mutations/container_repositories/destroy_spec.rb' - 'spec/graphql/mutations/container_repositories/destroy_tags_spec.rb' - 'spec/graphql/mutations/custom_emoji/create_spec.rb' - 'spec/graphql/mutations/custom_emoji/destroy_spec.rb' @@ -2472,8 +2469,6 @@ RSpec/MissingFeatureCategory: - 'spec/helpers/breadcrumbs_helper_spec.rb' - 'spec/helpers/button_helper_spec.rb' - 'spec/helpers/calendar_helper_spec.rb' - - 'spec/helpers/ci/builds_helper_spec.rb' - - 'spec/helpers/ci/jobs_helper_spec.rb' - 'spec/helpers/ci/pipeline_editor_helper_spec.rb' - 'spec/helpers/ci/pipelines_helper_spec.rb' - 'spec/helpers/ci/secure_files_helper_spec.rb' @@ -2765,7 +2760,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/bulk_imports/projects/pipelines/external_pull_requests_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/issues_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/merge_requests_pipeline_spec.rb' - - 'spec/lib/bulk_imports/projects/pipelines/pipeline_schedules_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/project_attributes_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/project_feature_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/protected_branches_pipeline_spec.rb' @@ -3150,7 +3144,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/ci/pipeline/expression/lexeme/not_equals_spec.rb' - 'spec/lib/gitlab/ci/pipeline/expression/lexeme/null_spec.rb' - 'spec/lib/gitlab/ci/pipeline/expression/lexeme/or_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/expression/lexeme/pattern_spec.rb' - 'spec/lib/gitlab/ci/pipeline/expression/lexeme/string_spec.rb' - 'spec/lib/gitlab/ci/pipeline/expression/lexeme/variable_spec.rb' - 'spec/lib/gitlab/ci/pipeline/expression/lexer_spec.rb' @@ -3498,17 +3491,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/email/hook/delivery_metrics_observer_spec.rb' - 'spec/lib/gitlab/email/hook/disable_email_interceptor_spec.rb' - 'spec/lib/gitlab/email/hook/smime_signature_interceptor_spec.rb' - - 'spec/lib/gitlab/email/message/build_ios_app_guide_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/admin_verify_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/base_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/create_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/helper_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/team_short_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/team_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/trial_short_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/trial_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/verify_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing_spec.rb' - 'spec/lib/gitlab/email/message/repository_push_spec.rb' - 'spec/lib/gitlab/email/receiver_spec.rb' - 'spec/lib/gitlab/email/service_desk_receiver_spec.rb' @@ -3539,7 +3521,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/exclusive_lease_helpers/sleeping_lock_spec.rb' - 'spec/lib/gitlab/exclusive_lease_helpers_spec.rb' - 'spec/lib/gitlab/exclusive_lease_spec.rb' - - 'spec/lib/gitlab/experiment/rollout/feature_spec.rb' - 'spec/lib/gitlab/external_authorization/access_spec.rb' - 'spec/lib/gitlab/external_authorization/cache_spec.rb' - 'spec/lib/gitlab/external_authorization/client_spec.rb' @@ -3762,7 +3743,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/hotlinking_detector_spec.rb' - 'spec/lib/gitlab/http_connection_adapter_spec.rb' - 'spec/lib/gitlab/http_io_spec.rb' - - 'spec/lib/gitlab/http_spec.rb' - 'spec/lib/gitlab/i18n/metadata_entry_spec.rb' - 'spec/lib/gitlab/i18n/po_linter_spec.rb' - 'spec/lib/gitlab/i18n/translation_entry_spec.rb' @@ -4116,7 +4096,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/route_map_spec.rb' - 'spec/lib/gitlab/routing_spec.rb' - 'spec/lib/gitlab/rugged_instrumentation_spec.rb' - - 'spec/lib/gitlab/saas_spec.rb' - 'spec/lib/gitlab/safe_request_loader_spec.rb' - 'spec/lib/gitlab/safe_request_purger_spec.rb' - 'spec/lib/gitlab/sample_data_template_spec.rb' @@ -4471,7 +4450,6 @@ RSpec/MissingFeatureCategory: - 'spec/mailers/emails/auto_devops_spec.rb' - 'spec/mailers/emails/groups_spec.rb' - 'spec/mailers/emails/identity_verification_spec.rb' - - 'spec/mailers/emails/in_product_marketing_spec.rb' - 'spec/mailers/emails/merge_requests_spec.rb' - 'spec/mailers/emails/pages_domains_spec.rb' - 'spec/mailers/emails/pipelines_spec.rb' @@ -4753,7 +4731,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/instance_metadata_spec.rb' - 'spec/models/integrations/asana_spec.rb' - 'spec/models/integrations/assembla_spec.rb' - - 'spec/models/integrations/bamboo_spec.rb' - 'spec/models/integrations/base_issue_tracker_spec.rb' - 'spec/models/integrations/base_slack_notification_spec.rb' - 'spec/models/integrations/base_third_party_wiki_spec.rb' @@ -4830,7 +4807,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/loose_foreign_keys/modification_tracker_spec.rb' - 'spec/models/members/group_member_spec.rb' - 'spec/models/members/last_group_owner_assigner_spec.rb' - - 'spec/models/members/member_task_spec.rb' - 'spec/models/members/project_member_spec.rb' - 'spec/models/merge_request/approval_removal_settings_spec.rb' - 'spec/models/merge_request/diff_commit_user_spec.rb' @@ -4932,7 +4908,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/project_import_data_spec.rb' - 'spec/models/project_label_spec.rb' - 'spec/models/project_metrics_setting_spec.rb' - - 'spec/models/project_pages_metadatum_spec.rb' - 'spec/models/project_repository_spec.rb' - 'spec/models/project_snippet_spec.rb' - 'spec/models/project_statistics_spec.rb' diff --git a/.rubocop_todo/rspec/file_path.yml b/.rubocop_todo/rspec/file_path.yml index ea193948909..06832184c04 100644 --- a/.rubocop_todo/rspec/file_path.yml +++ b/.rubocop_todo/rspec/file_path.yml @@ -24,6 +24,7 @@ RSpec/FilePath: - 'spec/benchmarks/banzai_benchmark.rb' - 'spec/docs_screenshots/container_registry_docs.rb' - 'spec/docs_screenshots/wiki_docs.rb' + - 'spec/initializers/gitlab_http_spec.rb' - 'spec/lib/error_tracking/sentry_client/event_spec.rb' - 'spec/lib/gitlab/import_export/import_export_spec.rb' - 'spec/lib/gitlab/mail_room/mail_room_spec.rb' diff --git a/.rubocop_todo/rspec/instance_variable.yml b/.rubocop_todo/rspec/instance_variable.yml index a5a0cec68d4..603d025fa2f 100644 --- a/.rubocop_todo/rspec/instance_variable.yml +++ b/.rubocop_todo/rspec/instance_variable.yml @@ -107,9 +107,9 @@ RSpec/InstanceVariable: - 'spec/lib/gitlab/git/diff_collection_spec.rb' - 'spec/lib/gitlab/git/diff_spec.rb' - 'spec/lib/gitlab/git/repository_spec.rb' - - 'spec/lib/gitlab/http_spec.rb' - 'spec/lib/gitlab/import_export/group/tree_restorer_spec.rb' - 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb' + - 'spec/lib/gitlab/legacy_http_spec.rb' - 'spec/lib/gitlab/patch/prependable_spec.rb' - 'spec/lib/gitlab/popen_spec.rb' - 'spec/lib/gitlab/project_transfer_spec.rb' @@ -129,7 +129,6 @@ RSpec/InstanceVariable: - 'spec/models/postgresql/replication_slot_spec.rb' - 'spec/models/project_spec.rb' - 'spec/models/user_spec.rb' - - 'spec/models/users/in_product_marketing_email_spec.rb' - 'spec/rack_servers/puma_spec.rb' - 'spec/requests/api/admin/plan_limits_spec.rb' - 'spec/requests/api/users_spec.rb' @@ -147,7 +146,6 @@ RSpec/InstanceVariable: - 'spec/services/notes/post_process_service_spec.rb' - 'spec/services/notes/update_service_spec.rb' - 'spec/services/notification_service_spec.rb' - - 'spec/services/pages/zip_directory_service_spec.rb' - 'spec/services/projects/create_from_template_service_spec.rb' - 'spec/services/projects/download_service_spec.rb' - 'spec/services/projects/fork_service_spec.rb' diff --git a/.rubocop_todo/rspec/return_from_stub.yml b/.rubocop_todo/rspec/return_from_stub.yml index 0f0a6f5a95a..1d07be7d6dc 100644 --- a/.rubocop_todo/rspec/return_from_stub.yml +++ b/.rubocop_todo/rspec/return_from_stub.yml @@ -137,8 +137,6 @@ RSpec/ReturnFromStub: - 'spec/lib/gitlab/daemon_spec.rb' - 'spec/lib/gitlab/database_importers/instance_administrators/create_group_spec.rb' - 'spec/lib/gitlab/diff/file_spec.rb' - - 'spec/lib/gitlab/email/message/build_ios_app_guide_spec.rb' - - 'spec/lib/gitlab/email/message/in_product_marketing/helper_spec.rb' - 'spec/lib/gitlab/exclusive_lease_helpers/sleeping_lock_spec.rb' - 'spec/lib/gitlab/exclusive_lease_helpers_spec.rb' - 'spec/lib/gitlab/external_authorization_spec.rb' @@ -232,8 +230,6 @@ RSpec/ReturnFromStub: - 'spec/services/projects/create_service_spec.rb' - 'spec/services/projects/hashed_storage/migrate_attachments_service_spec.rb' - 'spec/services/projects/hashed_storage/migrate_repository_service_spec.rb' - - 'spec/services/projects/hashed_storage/rollback_attachments_service_spec.rb' - - 'spec/services/projects/hashed_storage/rollback_repository_service_spec.rb' - 'spec/services/projects/in_product_marketing_campaign_emails_service_spec.rb' - 'spec/services/projects/update_remote_mirror_service_spec.rb' - 'spec/services/projects/update_service_spec.rb' diff --git a/.rubocop_todo/rspec/scattered_let.yml b/.rubocop_todo/rspec/scattered_let.yml index 479ff4fd8f9..4d93c6816cc 100644 --- a/.rubocop_todo/rspec/scattered_let.yml +++ b/.rubocop_todo/rspec/scattered_let.yml @@ -176,7 +176,6 @@ RSpec/ScatteredLet: - 'spec/lib/gitlab/utils/measuring_spec.rb' - 'spec/lib/gitlab/zentao/client_spec.rb' - 'spec/lib/peek/views/external_http_spec.rb' - - 'spec/mailers/emails/in_product_marketing_spec.rb' - 'spec/mailers/notify_spec.rb' - 'spec/mailers/previews_spec.rb' - 'spec/migrations/20220329175119_remove_leftover_ci_job_artifact_deletions_spec.rb' diff --git a/.rubocop_todo/rspec/useless_dynamic_definition.yml b/.rubocop_todo/rspec/useless_dynamic_definition.yml index 94a53324dee..75bea5601ae 100644 --- a/.rubocop_todo/rspec/useless_dynamic_definition.yml +++ b/.rubocop_todo/rspec/useless_dynamic_definition.yml @@ -5,7 +5,6 @@ RSpec/UselessDynamicDefinition: - 'ee/spec/factories/ci/job_artifacts.rb' - 'ee/spec/factories/ci/pipelines.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_security_scans_metric_spec.rb' - - 'ee/spec/support/shared_examples/lib/gitlab/elastic/search_results_shared_examples.rb' - 'spec/models/ci/resource_group_spec.rb' - 'spec/services/packages/nuget/update_package_from_metadata_service_spec.rb' - 'spec/support/helpers/cycle_analytics_helpers/test_generation.rb' diff --git a/.rubocop_todo/rspec/verified_doubles.yml b/.rubocop_todo/rspec/verified_doubles.yml index 42d1363358b..6e3e3abf87e 100644 --- a/.rubocop_todo/rspec/verified_doubles.yml +++ b/.rubocop_todo/rspec/verified_doubles.yml @@ -897,7 +897,6 @@ RSpec/VerifiedDoubles: - 'spec/services/packages/maven/find_or_create_package_service_spec.rb' - 'spec/services/packages/maven/metadata/sync_service_spec.rb' - 'spec/services/packages/nuget/metadata_extraction_service_spec.rb' - - 'spec/services/pages/zip_directory_service_spec.rb' - 'spec/services/post_receive_service_spec.rb' - 'spec/services/projects/branches_by_mode_service_spec.rb' - 'spec/services/projects/create_service_spec.rb' diff --git a/.rubocop_todo/style/explicit_block_argument.yml b/.rubocop_todo/style/explicit_block_argument.yml index 5027e699ae7..44d28967e66 100644 --- a/.rubocop_todo/style/explicit_block_argument.yml +++ b/.rubocop_todo/style/explicit_block_argument.yml @@ -85,7 +85,6 @@ Style/ExplicitBlockArgument: - 'spec/lib/gitlab/pagination/offset_pagination_spec.rb' - 'spec/lib/gitlab/usage_data_spec.rb' - 'spec/models/repository_spec.rb' - - 'spec/services/pages/zip_directory_service_spec.rb' - 'spec/services/todo_service_spec.rb' - 'spec/support/database/gitlab_schemas_validate_connection.rb' - 'spec/support/helpers/feature_flag_helpers.rb' diff --git a/.rubocop_todo/style/format_string.yml b/.rubocop_todo/style/format_string.yml index c45ddab8441..7579229871a 100644 --- a/.rubocop_todo/style/format_string.yml +++ b/.rubocop_todo/style/format_string.yml @@ -78,7 +78,6 @@ Style/FormatString: - 'app/models/diff_note.rb' - 'app/models/diff_viewer/base.rb' - 'app/models/integrations/asana.rb' - - 'app/models/integrations/bamboo.rb' - 'app/models/integrations/bugzilla.rb' - 'app/models/integrations/chat_message/pipeline_message.rb' - 'app/models/integrations/confluence.rb' @@ -91,7 +90,6 @@ Style/FormatString: - 'app/models/integrations/hangouts_chat.rb' - 'app/models/integrations/irker.rb' - 'app/models/integrations/jenkins.rb' - - 'app/models/integrations/jira.rb' - 'app/models/integrations/mattermost.rb' - 'app/models/integrations/pipelines_email.rb' - 'app/models/integrations/pivotaltracker.rb' @@ -260,10 +258,6 @@ Style/FormatString: - 'lib/gitlab/database/postgres_hll/batch_distinct_counter.rb' - 'lib/gitlab/database/reindexing/reindex_concurrently.rb' - 'lib/gitlab/database_importers/instance_administrators/create_group.rb' - - 'lib/gitlab/email/message/in_product_marketing/base.rb' - - 'lib/gitlab/email/message/in_product_marketing/create.rb' - - 'lib/gitlab/email/message/in_product_marketing/helper.rb' - - 'lib/gitlab/email/message/in_product_marketing/verify.rb' - 'lib/gitlab/exceptions_app.rb' - 'lib/gitlab/github_import/importer/pull_request_merged_by_importer.rb' - 'lib/gitlab/github_import/importer/single_endpoint_issue_events_importer.rb' @@ -302,7 +296,6 @@ Style/FormatString: - 'spec/lib/gitlab/config_checker/external_database_checker_spec.rb' - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' - 'spec/lib/gitlab/usage/service_ping_report_spec.rb' - - 'spec/models/integrations/bamboo_spec.rb' - 'spec/models/integrations/datadog_spec.rb' - 'spec/requests/api/graphql/project/jira_projects_spec.rb' - 'spec/services/groups/import_export/export_service_spec.rb' diff --git a/.rubocop_todo/style/guard_clause.yml b/.rubocop_todo/style/guard_clause.yml index 64568649287..737d3d6f5a1 100644 --- a/.rubocop_todo/style/guard_clause.yml +++ b/.rubocop_todo/style/guard_clause.yml @@ -112,7 +112,6 @@ Style/GuardClause: - 'app/models/integrations/confluence.rb' - 'app/models/integrations/datadog.rb' - 'app/models/integrations/emails_on_push.rb' - - 'app/models/integrations/jira.rb' - 'app/models/integrations/pipelines_email.rb' - 'app/models/internal_id.rb' - 'app/models/issue.rb' @@ -209,7 +208,6 @@ Style/GuardClause: - 'app/services/projects/after_rename_service.rb' - 'app/services/projects/create_service.rb' - 'app/services/projects/destroy_service.rb' - - 'app/services/projects/hashed_storage/rollback_service.rb' - 'app/services/projects/import_export/export_service.rb' - 'app/services/projects/import_service.rb' - 'app/services/projects/lfs_pointers/lfs_object_download_list_service.rb' diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index ef4fca8270d..79dd4a7680f 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -161,7 +161,6 @@ Style/IfUnlessModifier: - 'app/models/integrations/asana.rb' - 'app/models/integrations/base_chat_notification.rb' - 'app/models/integrations/datadog.rb' - - 'app/models/integrations/jira.rb' - 'app/models/integrations/pushover.rb' - 'app/models/issue.rb' - 'app/models/issue_email_participant.rb' @@ -296,7 +295,6 @@ Style/IfUnlessModifier: - 'app/services/packages/maven/find_or_create_package_service.rb' - 'app/services/packages/nuget/update_package_from_metadata_service.rb' - 'app/services/packages/pypi/create_package_service.rb' - - 'app/services/pages/migrate_legacy_storage_to_deployment_service.rb' - 'app/services/post_receive_service.rb' - 'app/services/projects/container_repository/gitlab/delete_tags_service.rb' - 'app/services/projects/container_repository/third_party/delete_tags_service.rb' @@ -304,7 +302,6 @@ Style/IfUnlessModifier: - 'app/services/projects/enable_deploy_key_service.rb' - 'app/services/projects/fork_service.rb' - 'app/services/projects/git_deduplication_service.rb' - - 'app/services/projects/hashed_storage/rollback_service.rb' - 'app/services/projects/import_export/export_service.rb' - 'app/services/projects/import_service.rb' - 'app/services/projects/lfs_pointers/lfs_download_service.rb' @@ -814,7 +811,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/database/transaction/observer.rb' - 'lib/gitlab/database/with_lock_retries.rb' - 'lib/gitlab/email/handler/service_desk_handler.rb' - - 'lib/gitlab/email/message/in_product_marketing/base.rb' - 'lib/gitlab/email/message/repository_push.rb' - 'lib/gitlab/email/receiver.rb' - 'lib/gitlab/email/reply_parser.rb' @@ -848,7 +844,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/golang.rb' - 'lib/gitlab/graphql/pagination/keyset/connection.rb' - 'lib/gitlab/graphql/queries.rb' - - 'lib/gitlab/hashed_storage/rake_helper.rb' - 'lib/gitlab/hotlinking_detector.rb' - 'lib/gitlab/http.rb' - 'lib/gitlab/http_io.rb' @@ -943,7 +938,6 @@ Style/IfUnlessModifier: - 'lib/tasks/gitlab/shell.rake' - 'lib/tasks/gitlab/sidekiq.rake' - 'lib/tasks/gitlab/snippets.rake' - - 'lib/tasks/gitlab/storage.rake' - 'lib/tasks/gitlab/update_templates.rake' - 'qa/qa/ee/resource/settings/elasticsearch.rb' - 'qa/qa/page/component/snippet.rb' diff --git a/.rubocop_todo/style/percent_literal_delimiters.yml b/.rubocop_todo/style/percent_literal_delimiters.yml index 59acd655d4b..bcaf610bf08 100644 --- a/.rubocop_todo/style/percent_literal_delimiters.yml +++ b/.rubocop_todo/style/percent_literal_delimiters.yml @@ -2,330 +2,7 @@ # Cop supports --autocorrect. Style/PercentLiteralDelimiters: Exclude: - - 'ee/lib/api/status_checks.rb' - - 'ee/lib/api/visual_review_discussions.rb' - - 'ee/lib/ee/api/helpers/members_helpers.rb' - - 'ee/lib/ee/api/helpers/projects_helpers.rb' - - 'ee/lib/ee/api/members.rb' - - 'ee/lib/ee/api/search.rb' - - 'ee/lib/ee/gitlab/alert_management/payload/generic.rb' - - 'ee/lib/ee/gitlab/auth/ldap/adapter.rb' - - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - - 'ee/lib/ee/gitlab/checks/push_rules/file_size_check.rb' - - 'ee/lib/ee/gitlab/ci/parsers/security/validators/schema_validator.rb' - - 'ee/lib/ee/gitlab/etag_caching/router/rails.rb' - - 'ee/lib/ee/gitlab/middleware/read_only/controller.rb' - - 'ee/lib/ee/gitlab/path_regex.rb' - - 'ee/lib/ee/gitlab/usage_data.rb' - - 'ee/lib/elastic/class_proxy_util.rb' - - 'ee/lib/elastic/latest/config.rb' - - 'ee/lib/elastic/latest/custom_language_analyzers.rb' - - 'ee/lib/elastic/latest/project_instance_proxy.rb' - - 'ee/lib/elastic/latest/snippet_class_proxy.rb' - - 'ee/lib/gitlab/auth/group_saml/auth_hash.rb' - - 'ee/lib/gitlab/geo/replicator.rb' - - 'ee/lib/gitlab/usage/metrics/instrumentations/license_metric.rb' - - 'ee/lib/tasks/gitlab/elastic/test.rake' - - 'ee/spec/controllers/ee/sessions_controller_spec.rb' - - 'ee/spec/controllers/groups/saml_providers_controller_spec.rb' - - 'ee/spec/controllers/groups/scim_oauth_controller_spec.rb' - - 'ee/spec/controllers/groups/sso_controller_spec.rb' - - 'ee/spec/controllers/projects/issues_controller_spec.rb' - - 'ee/spec/controllers/projects/pipelines_controller_spec.rb' - - 'ee/spec/controllers/projects/security/configuration_controller_spec.rb' - - 'ee/spec/elastic_integration/global_search_spec.rb' - - 'ee/spec/factories/dast/profile_schedule_input_type.rb' - - 'ee/spec/factories/dast/profile_schedules.rb' - - 'ee/spec/features/admin/admin_reset_pipeline_minutes_spec.rb' - - 'ee/spec/features/admin/geo/admin_geo_nodes_spec.rb' - - 'ee/spec/features/groups/sso_spec.rb' - - 'ee/spec/features/profiles/account_spec.rb' - - 'ee/spec/features/projects/environments/environments_spec.rb' - - 'ee/spec/features/projects/integrations/user_activates_jira_spec.rb' - - 'ee/spec/features/projects/settings/protected_environments_spec.rb' - - 'ee/spec/features/users/login_spec.rb' - - 'ee/spec/finders/template_finder_spec.rb' - - 'ee/spec/frontend/fixtures/saml_providers.rb' - - 'ee/spec/graphql/ee/resolvers/board_lists_resolver_spec.rb' - - 'ee/spec/graphql/ee/types/boards/board_issue_input_type_spec.rb' - - 'ee/spec/graphql/mutations/boards/update_spec.rb' - - 'ee/spec/graphql/resolvers/board_groupings/epics_resolvers_spec.rb' - - 'ee/spec/graphql/resolvers/pipeline_security_report_findings_resolver_spec.rb' - - 'ee/spec/graphql/types/dast/profile_cadence_enum_spec.rb' - - 'ee/spec/graphql/types/dast/scan_method_type_enum_spec.rb' - - 'ee/spec/graphql/types/incident_management/escalation_rule_input_type_spec.rb' - - 'ee/spec/graphql/types/scan_type_spec.rb' - - 'ee/spec/graphql/types/vulnerable_projects_by_grade_type_spec.rb' - - 'ee/spec/helpers/ee/application_settings_helper_spec.rb' - - 'ee/spec/helpers/ee/auth_helper_spec.rb' - - 'ee/spec/helpers/ee/environments_helper_spec.rb' - - 'ee/spec/helpers/ee/labels_helper_spec.rb' - - 'ee/spec/helpers/ee/security_orchestration_helper_spec.rb' - - 'ee/spec/helpers/merge_requests_helper_spec.rb' - - 'ee/spec/helpers/subscriptions_helper_spec.rb' - - 'ee/spec/helpers/vulnerabilities_helper_spec.rb' - - 'ee/spec/lib/banzai/filter/references/epic_reference_filter_spec.rb' - - 'ee/spec/lib/banzai/filter/references/iteration_reference_filter_spec.rb' - - 'ee/spec/lib/banzai/filter/references/vulnerability_reference_filters_spec.rb' - - 'ee/spec/lib/ee/backup/repositories_spec.rb' - - 'ee/spec/lib/ee/gitlab/alert_management/payload/generic_spec.rb' - - 'ee/spec/lib/ee/gitlab/auth/ldap/access_levels_spec.rb' - - 'ee/spec/lib/ee/gitlab/auth/ldap/config_spec.rb' - - 'ee/spec/lib/ee/gitlab/auth/ldap/group_spec.rb' - - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/external_users_spec.rb' - - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb' - - 'ee/spec/lib/ee/gitlab/auth/ldap/sync/groups_spec.rb' - - 'ee/spec/lib/ee/gitlab/git_access_design_spec.rb' - - 'ee/spec/lib/ee/gitlab/git_access_snippet_spec.rb' - - 'ee/spec/lib/ee/gitlab/security/scan_configuration_spec.rb' - - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb' - - 'ee/spec/lib/elastic/latest/custom_language_analyzers_spec.rb' - - 'ee/spec/lib/gitlab/alert_management/alert_payload_field_extractor_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/request_params_spec.rb' - - 'ee/spec/lib/gitlab/auth/group_saml/auth_hash_spec.rb' - - 'ee/spec/lib/gitlab/auth/group_saml/membership_updater_spec.rb' - - 'ee/spec/lib/gitlab/auth/group_saml/user_spec.rb' - - 'ee/spec/lib/gitlab/auth/ldap/adapter_spec.rb' - - 'ee/spec/lib/gitlab/auth/ldap/person_spec.rb' - - 'ee/spec/lib/gitlab/auth/saml/user_spec.rb' - - 'ee/spec/lib/gitlab/authority_analyzer_spec.rb' - - 'ee/spec/lib/gitlab/cache_spec.rb' - - 'ee/spec/lib/gitlab/ci/reports/security/finding_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/Jobs/dast_default_branch_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/dependency_scanning_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/sast_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/sast_iac_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/sast_latest_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/secret_detection_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/secret_detection_latest_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/expiring_subscription_message_spec.rb' - - 'ee/spec/lib/gitlab/git_access_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate_spec.rb' - - 'ee/spec/lib/gitlab/status_page/filter/image_filter_spec.rb' - - 'ee/spec/lib/gitlab/status_page/filter/mention_anonymization_filter_spec.rb' - - 'ee/spec/lib/gitlab/status_page/storage/s3_client_spec.rb' - - 'ee/spec/lib/gitlab/status_page/storage/s3_multipart_upload_spec.rb' - - 'ee/spec/lib/gitlab/vulnerabilities/parser_spec.rb' - - 'ee/spec/mailers/ci_minutes_usage_mailer_spec.rb' - - 'ee/spec/mailers/credentials_inventory_mailer_spec.rb' - - 'ee/spec/mailers/ee/emails/profile_spec.rb' - - 'ee/spec/mailers/emails/namespace_storage_usage_mailer_spec.rb' - - 'ee/spec/mailers/license_mailer_spec.rb' - - 'ee/spec/mailers/notify_spec.rb' - - 'ee/spec/models/approval_project_rule_spec.rb' - - 'ee/spec/models/ci/build_spec.rb' - - 'ee/spec/models/ci/pipeline_spec.rb' - - 'ee/spec/models/concerns/ee/issuable_spec.rb' - - 'ee/spec/models/concerns/ee/project_security_scanners_information_spec.rb' - - 'ee/spec/models/ee/ci/job_artifact_spec.rb' - - 'ee/spec/models/ee/ci/runner_spec.rb' - - 'ee/spec/models/ee/groups/feature_setting_spec.rb' - - 'ee/spec/models/ee/integrations/jira_spec.rb' - - 'ee/spec/models/ee/personal_access_token_spec.rb' - - 'ee/spec/models/instance_security_dashboard_spec.rb' - - 'ee/spec/models/issue_spec.rb' - - 'ee/spec/models/project_feature_spec.rb' - - 'ee/spec/models/protected_environment_spec.rb' - - 'ee/spec/models/push_rule_spec.rb' - - 'ee/spec/models/repository_spec.rb' - - 'ee/spec/models/saml_provider_spec.rb' - - 'ee/spec/models/security/scan_spec.rb' - - 'ee/spec/models/vulnerabilities/historical_statistic_spec.rb' - - 'ee/spec/models/vulnerabilities/stat_diff_spec.rb' - - 'ee/spec/models/vulnerabilities/statistic_spec.rb' - - 'ee/spec/policies/group_policy_spec.rb' - - 'ee/spec/policies/project_policy_spec.rb' - - 'ee/spec/presenters/merge_request_approver_presenter_spec.rb' - - 'ee/spec/requests/admin/user_permission_exports_controller_spec.rb' - - 'ee/spec/requests/api/dependencies_spec.rb' - - 'ee/spec/requests/api/epics_spec.rb' - - 'ee/spec/requests/api/geo_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/alert_management/http_integration/update_spec.rb' - - 'ee/spec/requests/api/graphql/project/alert_management/http_integrations_spec.rb' - - 'ee/spec/requests/api/internal/base_spec.rb' - - 'ee/spec/requests/api/issues_spec.rb' - - 'ee/spec/requests/api/merge_requests_spec.rb' - - 'ee/spec/requests/api/wikis_spec.rb' - - 'ee/spec/requests/lfs_locks_api_spec.rb' - - 'ee/spec/serializers/merge_request_widget_entity_spec.rb' - - 'ee/spec/services/admin/email_service_spec.rb' - - 'ee/spec/services/base_count_service_spec.rb' - - 'ee/spec/services/ci/compare_security_reports_service_spec.rb' - - 'ee/spec/services/ci/sync_reports_to_approval_rules_service_spec.rb' - - 'ee/spec/services/ee/auth/container_registry_authentication_service_spec.rb' - - 'ee/spec/services/ee/groups/autocomplete_service_spec.rb' - - 'ee/spec/services/ee/members/create_service_spec.rb' - - 'ee/spec/services/ee/protected_branches/create_service_spec.rb' - - 'ee/spec/services/ee/users/update_service_spec.rb' - - 'ee/spec/services/elastic/data_migration_service_spec.rb' - - 'ee/spec/services/geo/cache_invalidation_event_store_spec.rb' - - 'ee/spec/services/jira/jql_builder_service_spec.rb' - - 'ee/spec/services/personal_access_tokens/rotation_verifier_service_spec.rb' - - 'ee/spec/services/protected_environments/search_service_spec.rb' - - 'ee/spec/services/security/dependency_list_service_spec.rb' - - 'ee/spec/services/security/token_revocation_service_spec.rb' - - 'ee/spec/services/system_notes/vulnerabilities_service_spec.rb' - - 'ee/spec/support/helpers/ee/login_helpers.rb' - - 'ee/spec/support/license_scanning_reports/license_scanning_report_helper.rb' - - 'ee/spec/support/prometheus/additional_metrics_shared_examples.rb' - - 'ee/spec/support/protected_tags/access_control_shared_examples.rb' - - 'ee/spec/support/shared_examples/finders/geo/file_registry_finder_shared_examples.rb' - - 'ee/spec/support/shared_examples/finders/geo/registry_finder_shared_examples.rb' - - 'ee/spec/support/shared_examples/lib/gitlab/git_access_shared_examples.rb' - - 'ee/spec/support/shared_examples/requests/api/graphql/incident_management/escalation_policies_shared_examples.rb' - - 'ee/spec/validators/json_schema_validator_spec.rb' - - 'ee/spec/views/operations/index.html.haml_spec.rb' - - 'ee/spec/views/shared/credentials_inventory/personal_access_tokens/_personal_access_token.html.haml_spec.rb' - - 'ee/spec/workers/ee/issuable_export_csv_worker_spec.rb' - - 'ee/spec/workers/project_cache_worker_spec.rb' - - 'ee/spec/workers/repository_import_worker_spec.rb' - 'metrics_server/metrics_server.rb' - - 'qa/qa/ee/page/dashboard/projects.rb' - - 'qa/qa/ee/page/group/settings/general.rb' - - 'qa/qa/ee/page/project/issue/show.rb' - - 'qa/qa/ee/page/project/job/show.rb' - - 'qa/qa/ee/page/project/packages/index.rb' - - 'qa/qa/ee/page/project/show.rb' - - 'qa/qa/ee/page/project/snippet/index.rb' - - 'qa/qa/ee/page/project/wiki/show.rb' - - 'qa/qa/resource/events/project.rb' - - 'qa/qa/resource/personal_access_token_cache.rb' - - 'qa/qa/resource/visibility.rb' - - 'qa/qa/service/cluster_provider/gcloud.rb' - - 'qa/qa/service/praefect_manager.rb' - - 'qa/qa/specs/features/api/3_create/repository/project_archive_compare_spec.rb' - - 'qa/qa/specs/features/browser_ui/2_plan/email/trigger_email_notification_spec.rb' - - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/pipeline_with_image_pull_policy_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb' - - 'qa/spec/git/repository_spec.rb' - - 'qa/spec/page/view_spec.rb' - - 'rubocop/cop/migration/background_migrations.rb' - - 'rubocop/cop/rspec/httparty_basic_auth.rb' - - 'rubocop/migration_helpers.rb' - - 'scripts/qa/quarantine-types-check' - - 'scripts/qa/testcases-check' - - 'scripts/regenerate-schema' - - 'scripts/undercoverage' - - 'sidekiq_cluster/cli.rb' - - 'spec/benchmarks/banzai_benchmark.rb' - - 'spec/commands/sidekiq_cluster/cli_spec.rb' - - 'spec/components/pajamas/component_spec.rb' - - 'spec/controllers/concerns/continue_params_spec.rb' - - 'spec/controllers/graphql_controller_spec.rb' - - 'spec/controllers/groups/releases_controller_spec.rb' - - 'spec/controllers/jira_connect/app_descriptor_controller_spec.rb' - - 'spec/controllers/oauth/applications_controller_spec.rb' - - 'spec/controllers/profiles/two_factor_auths_controller_spec.rb' - - 'spec/controllers/projects/artifacts_controller_spec.rb' - - 'spec/controllers/projects/deploy_keys_controller_spec.rb' - - 'spec/controllers/projects/issues_controller_spec.rb' - - 'spec/controllers/projects/merge_requests/conflicts_controller_spec.rb' - - 'spec/controllers/projects/merge_requests_controller_spec.rb' - - 'spec/controllers/projects/pipelines_controller_spec.rb' - - 'spec/controllers/projects/settings/ci_cd_controller_spec.rb' - - 'spec/controllers/projects_controller_spec.rb' - - 'spec/controllers/search_controller_spec.rb' - - 'spec/controllers/snippets_controller_spec.rb' - - 'spec/experiments/ios_specific_templates_experiment_spec.rb' - - 'spec/factories/ci/builds.rb' - - 'spec/factories/ci/runners.rb' - - 'spec/factories/clusters/clusters.rb' - - 'spec/factories/clusters/integrations/prometheus.rb' - - 'spec/factories/clusters/providers/aws.rb' - - 'spec/factories/deployments.rb' - - 'spec/features/expand_collapse_diffs_spec.rb' - - 'spec/features/issuables/issuable_list_spec.rb' - - 'spec/features/issues/create_issue_for_discussions_in_merge_request_spec.rb' - - 'spec/features/issues/move_spec.rb' - - 'spec/features/issues/resource_label_events_spec.rb' - - 'spec/features/issues/user_bulk_edits_issues_labels_spec.rb' - - 'spec/features/issues/user_creates_issue_spec.rb' - - 'spec/features/markdown/markdown_spec.rb' - - 'spec/features/merge_request/user_creates_image_diff_notes_spec.rb' - - 'spec/features/merge_request/user_sees_avatar_on_diff_notes_spec.rb' - - 'spec/features/projects/active_tabs_spec.rb' - - 'spec/features/projects/artifacts/user_downloads_artifacts_spec.rb' - - 'spec/features/projects/environments/environment_spec.rb' - - 'spec/features/projects/integrations/user_activates_jira_spec.rb' - - 'spec/features/projects/jobs_spec.rb' - - 'spec/features/projects/labels/issues_sorted_by_priority_spec.rb' - - 'spec/features/projects/pipelines/pipeline_spec.rb' - - 'spec/features/projects/pipelines/pipelines_spec.rb' - - 'spec/features/tags/developer_views_tags_spec.rb' - - 'spec/features/users/login_spec.rb' - - 'spec/finders/alert_management/alerts_finder_spec.rb' - - 'spec/finders/branches_finder_spec.rb' - - 'spec/finders/ci/runners_finder_spec.rb' - - 'spec/finders/environments/environments_finder_spec.rb' - - 'spec/finders/groups_finder_spec.rb' - - 'spec/finders/license_template_finder_spec.rb' - - 'spec/finders/merge_requests_finder_spec.rb' - - 'spec/finders/tags_finder_spec.rb' - - 'spec/finders/template_finder_spec.rb' - - 'spec/graphql/mutations/alert_management/update_alert_status_spec.rb' - - 'spec/graphql/mutations/ci/runner/update_spec.rb' - - 'spec/graphql/mutations/commits/create_spec.rb' - - 'spec/graphql/resolvers/board_lists_resolver_spec.rb' - - 'spec/graphql/resolvers/container_repository_tags_resolver_spec.rb' - - 'spec/graphql/resolvers/projects/jira_projects_resolver_spec.rb' - - 'spec/graphql/resolvers/projects_resolver_spec.rb' - - 'spec/graphql/types/boards/board_issue_input_type_spec.rb' - - 'spec/graphql/types/design_management/design_collection_copy_state_enum_spec.rb' - - 'spec/graphql/types/issue_type_spec.rb' - - 'spec/helpers/appearances_helper_spec.rb' - - 'spec/helpers/application_settings_helper_spec.rb' - - 'spec/helpers/auth_helper_spec.rb' - - 'spec/helpers/breadcrumbs_helper_spec.rb' - - 'spec/helpers/ci/pipelines_helper_spec.rb' - - 'spec/helpers/clusters_helper_spec.rb' - - 'spec/helpers/diff_helper_spec.rb' - - 'spec/helpers/emails_helper_spec.rb' - - 'spec/helpers/issuables_description_templates_helper_spec.rb' - - 'spec/helpers/issues_helper_spec.rb' - - 'spec/helpers/nav_helper_spec.rb' - - 'spec/helpers/page_layout_helper_spec.rb' - - 'spec/helpers/profiles_helper_spec.rb' - - 'spec/helpers/releases_helper_spec.rb' - - 'spec/helpers/tracking_helper_spec.rb' - - 'spec/initializers/direct_upload_support_spec.rb' - - 'spec/initializers/enumerator_next_patch_spec.rb' - - 'spec/initializers/rack_multipart_patch_spec.rb' - - 'spec/lib/api/ci/helpers/runner_helpers_spec.rb' - - 'spec/lib/api/entities/user_spec.rb' - - 'spec/lib/api/helpers/common_helpers_spec.rb' - - 'spec/lib/backup/files_spec.rb' - - 'spec/lib/backup/manager_spec.rb' - - 'spec/lib/backup/repositories_spec.rb' - - 'spec/lib/banzai/filter/asset_proxy_filter_spec.rb' - - 'spec/lib/banzai/filter/autolink_filter_spec.rb' - - 'spec/lib/banzai/filter/broadcast_message_sanitization_filter_spec.rb' - - 'spec/lib/banzai/filter/image_link_filter_spec.rb' - - 'spec/lib/banzai/filter/references/alert_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/commit_range_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/commit_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/design_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/external_issue_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/feature_flag_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/issue_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/label_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/merge_request_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/milestone_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/project_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/snippet_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/user_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/syntax_highlight_filter_spec.rb' - - 'spec/lib/banzai/filter_array_spec.rb' - - 'spec/lib/banzai/pipeline/description_pipeline_spec.rb' - - 'spec/lib/banzai/pipeline/full_pipeline_spec.rb' - - 'spec/lib/banzai/pipeline/gfm_pipeline_spec.rb' - - 'spec/lib/banzai/pipeline/plain_markdown_pipeline_spec.rb' - - 'spec/lib/banzai/reference_parser/base_parser_spec.rb' - - 'spec/lib/banzai/reference_parser/issue_parser_spec.rb' - - 'spec/lib/banzai/reference_parser/merge_request_parser_spec.rb' - - 'spec/lib/bitbucket/collection_spec.rb' - - 'spec/lib/bitbucket/representation/repo_spec.rb' - - 'spec/lib/bulk_imports/common/pipelines/boards_pipeline_spec.rb' - - 'spec/lib/bulk_imports/common/transformers/prohibited_attributes_transformer_spec.rb' - 'spec/lib/gitlab/alert_management/payload/base_spec.rb' - 'spec/lib/gitlab/asset_proxy_spec.rb' - 'spec/lib/gitlab/auth/ldap/auth_hash_spec.rb' @@ -374,7 +51,6 @@ Style/PercentLiteralDelimiters: - 'spec/lib/gitlab/database/migration_helpers_spec.rb' - 'spec/lib/gitlab/database/postgres_index_spec.rb' - 'spec/lib/gitlab/database/reindexing_spec.rb' - - 'spec/lib/gitlab/database/rename_reserved_paths_migration/v1/rename_base_spec.rb' - 'spec/lib/gitlab/database/transaction/observer_spec.rb' - 'spec/lib/gitlab/dependency_linker/base_linker_spec.rb' - 'spec/lib/gitlab/dependency_linker/cargo_toml_linker_spec.rb' @@ -446,8 +122,6 @@ Style/PercentLiteralDelimiters: - 'spec/lib/gitlab/popen_spec.rb' - 'spec/lib/gitlab/process_management_spec.rb' - 'spec/lib/gitlab/process_supervisor_spec.rb' - - 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb' - - 'spec/lib/gitlab/prometheus/query_variables_spec.rb' - 'spec/lib/gitlab/quick_actions/extractor_spec.rb' - 'spec/lib/gitlab/reference_extractor_spec.rb' - 'spec/lib/gitlab/repository_cache_adapter_spec.rb' @@ -522,16 +196,13 @@ Style/PercentLiteralDelimiters: - 'spec/models/diff_viewer/base_spec.rb' - 'spec/models/environment_spec.rb' - 'spec/models/group_label_spec.rb' - - 'spec/models/group_spec.rb' - 'spec/models/instance_configuration_spec.rb' - 'spec/models/integration_spec.rb' - - 'spec/models/integrations/bamboo_spec.rb' - 'spec/models/integrations/buildkite_spec.rb' - 'spec/models/integrations/campfire_spec.rb' - 'spec/models/integrations/jira_spec.rb' - 'spec/models/integrations/teamcity_spec.rb' - 'spec/models/issue_spec.rb' - - 'spec/models/members/member_task_spec.rb' - 'spec/models/merge_request_diff_spec.rb' - 'spec/models/namespace_statistics_spec.rb' - 'spec/models/packages/package_spec.rb' @@ -541,7 +212,6 @@ Style/PercentLiteralDelimiters: - 'spec/models/project_feature_spec.rb' - 'spec/models/project_label_spec.rb' - 'spec/models/project_spec.rb' - - 'spec/models/project_team_spec.rb' - 'spec/models/projects/topic_spec.rb' - 'spec/models/prometheus_metric_spec.rb' - 'spec/models/releases/link_spec.rb' @@ -582,13 +252,11 @@ Style/PercentLiteralDelimiters: - 'spec/requests/api/graphql/project/terraform/state_spec.rb' - 'spec/requests/api/graphql/project/terraform/states_spec.rb' - 'spec/requests/api/internal/base_spec.rb' - - 'spec/requests/api/invitations_spec.rb' - 'spec/requests/api/issues/get_group_issues_spec.rb' - 'spec/requests/api/issues/get_project_issues_spec.rb' - 'spec/requests/api/issues/issues_spec.rb' - 'spec/requests/api/issues/post_projects_issues_spec.rb' - 'spec/requests/api/issues/put_projects_issues_spec.rb' - - 'spec/requests/api/members_spec.rb' - 'spec/requests/api/merge_requests_spec.rb' - 'spec/requests/api/metadata_spec.rb' - 'spec/requests/api/project_container_repositories_spec.rb' @@ -639,8 +307,6 @@ Style/PercentLiteralDelimiters: - 'spec/services/issues/export_csv_service_spec.rb' - 'spec/services/jira/requests/projects/list_service_spec.rb' - 'spec/services/lfs/file_transformer_spec.rb' - - 'spec/services/members/create_service_spec.rb' - - 'spec/services/members/invite_service_spec.rb' - 'spec/services/merge_requests/conflicts/resolve_service_spec.rb' - 'spec/services/merge_requests/merge_service_spec.rb' - 'spec/services/merge_requests/pushed_branches_service_spec.rb' @@ -684,7 +350,6 @@ Style/PercentLiteralDelimiters: - 'spec/support/shared_examples/metrics/transaction_metrics_with_labels_shared_examples.rb' - 'spec/support/shared_examples/models/application_setting_shared_examples.rb' - 'spec/support/shared_examples/models/diff_positionable_note_shared_examples.rb' - - 'spec/support/shared_examples/models/member_shared_examples.rb' - 'spec/support/shared_examples/models/project_ci_cd_settings_shared_examples.rb' - 'spec/support/shared_examples/models/wiki_shared_examples.rb' - 'spec/support/shared_examples/path_extraction_shared_examples.rb' @@ -732,4 +397,3 @@ Style/PercentLiteralDelimiters: - 'spec/workers/projects/record_target_platforms_worker_spec.rb' - 'spec/workers/stuck_merge_jobs_worker_spec.rb' - 'spec/workers/update_project_statistics_worker_spec.rb' - - 'tooling/danger/datateam.rb' diff --git a/.rubocop_todo/style/redundant_freeze.yml b/.rubocop_todo/style/redundant_freeze.yml deleted file mode 100644 index 12c9200bf54..00000000000 --- a/.rubocop_todo/style/redundant_freeze.yml +++ /dev/null @@ -1,107 +0,0 @@ ---- -# Cop supports --autocorrect. -Style/RedundantFreeze: - Exclude: - - 'lib/api/api.rb' - - 'lib/api/debian_group_packages.rb' - - 'lib/api/go_proxy.rb' - - 'lib/api/helpers.rb' - - 'lib/api/v3/github.rb' - - 'lib/api/validations/validators/git_ref.rb' - - 'lib/atlassian/jira_connect/jwt/asymmetric.rb' - - 'lib/banzai/color_parser.rb' - - 'lib/banzai/filter/ascii_doc_sanitization_filter.rb' - - 'lib/banzai/filter/attributes_filter.rb' - - 'lib/banzai/filter/autolink_filter.rb' - - 'lib/banzai/filter/blockquote_fence_filter.rb' - - 'lib/banzai/filter/footnote_filter.rb' - - 'lib/banzai/filter/gollum_tags_filter.rb' - - 'lib/banzai/filter/markdown_post_escape_filter.rb' - - 'lib/banzai/filter/markdown_pre_escape_filter.rb' - - 'lib/banzai/filter/references/abstract_reference_filter.rb' - - 'lib/banzai/filter/sanitization_filter.rb' - - 'lib/banzai/filter/task_list_filter.rb' - - 'lib/bulk_imports/common/pipelines/uploads_pipeline.rb' - - 'lib/bulk_imports/file_downloads/filename_fetch.rb' - - 'lib/error_tracking/sentry_client/pagination_parser.rb' - - 'lib/expand_variables.rb' - - 'lib/feature/definition.rb' - - 'lib/gitaly/server.rb' - - 'lib/gitlab.rb' - - 'lib/gitlab/background_migration/backfill_integrations_enable_ssl_verification.rb' - - 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb' - - 'lib/gitlab/changelog/generator.rb' - - 'lib/gitlab/ci/build/artifacts/metadata.rb' - - 'lib/gitlab/ci/config/entry/artifacts.rb' - - 'lib/gitlab/ci/config/external/file/base.rb' - - 'lib/gitlab/ci/parsers/test/junit.rb' - - 'lib/gitlab/ci/pipeline/chain/skip.rb' - - 'lib/gitlab/ci/pipeline/expression/lexeme/and.rb' - - 'lib/gitlab/ci/pipeline/expression/lexeme/equals.rb' - - 'lib/gitlab/ci/pipeline/expression/lexeme/matches.rb' - - 'lib/gitlab/ci/pipeline/expression/lexeme/not_equals.rb' - - 'lib/gitlab/ci/pipeline/expression/lexeme/not_matches.rb' - - 'lib/gitlab/ci/pipeline/expression/lexeme/null.rb' - - 'lib/gitlab/ci/pipeline/expression/lexeme/or.rb' - - 'lib/gitlab/ci/pipeline/expression/lexeme/parenthesis_close.rb' - - 'lib/gitlab/ci/pipeline/expression/lexeme/parenthesis_open.rb' - - 'lib/gitlab/ci/pipeline/expression/lexeme/pattern.rb' - - 'lib/gitlab/ci/pipeline/expression/lexeme/string.rb' - - 'lib/gitlab/ci/pipeline/expression/lexeme/variable.rb' - - 'lib/gitlab/ci/trace/section_parser.rb' - - 'lib/gitlab/ci/variables/collection/item.rb' - - 'lib/gitlab/cleanup/project_uploads.rb' - - 'lib/gitlab/color.rb' - - 'lib/gitlab/config/loader/multi_doc_yaml.rb' - - 'lib/gitlab/database/background_migration/batch_optimizer.rb' - - 'lib/gitlab/database/load_balancing/service_discovery.rb' - - 'lib/gitlab/database/migrations/runner.rb' - - 'lib/gitlab/dependency_linker/base_linker.rb' - - 'lib/gitlab/dependency_linker/gemfile_linker.rb' - - 'lib/gitlab/dependency_linker/godeps_json_linker.rb' - - 'lib/gitlab/dependency_linker/podspec_linker.rb' - - 'lib/gitlab/diff/highlight.rb' - - 'lib/gitlab/diff/pair_selector.rb' - - 'lib/gitlab/diff/suggestions_parser.rb' - - 'lib/gitlab/email/handler/base_handler.rb' - - 'lib/gitlab/email/handler/create_issue_handler.rb' - - 'lib/gitlab/email/handler/create_merge_request_handler.rb' - - 'lib/gitlab/email/handler/create_note_on_issuable_handler.rb' - - 'lib/gitlab/email/handler/service_desk_handler.rb' - - 'lib/gitlab/email/receiver.rb' - - 'lib/gitlab/error_tracking/error_repository/open_api_strategy.rb' - - 'lib/gitlab/git.rb' - - 'lib/gitlab/git/base_error.rb' - - 'lib/gitlab/git/diff.rb' - - 'lib/gitlab/git/pre_receive_error.rb' - - 'lib/gitlab/github_import/representation/diff_note.rb' - - 'lib/gitlab/github_import/representation/diff_notes/discussion_id.rb' - - 'lib/gitlab/github_import/representation/diff_notes/suggestion_formatter.rb' - - 'lib/gitlab/github_import/representation/note.rb' - - 'lib/gitlab/golang.rb' - - 'lib/gitlab/graphql/queries.rb' - - 'lib/gitlab/harbor/query.rb' - - 'lib/gitlab/i18n/po_linter.rb' - - 'lib/gitlab/i18n/translation_entry.rb' - - 'lib/gitlab/jira/dvcs.rb' - - 'lib/gitlab/merge_requests/message_generator.rb' - - 'lib/gitlab/metrics/exporter/base_exporter.rb' - - 'lib/gitlab/metrics/requests_rack_middleware.rb' - - 'lib/gitlab/metrics/subscribers/active_record.rb' - - 'lib/gitlab/metrics/system.rb' - - 'lib/gitlab/middleware/compressed_json.rb' - - 'lib/gitlab/middleware/go.rb' - - 'lib/gitlab/middleware/read_only.rb' - - 'lib/gitlab/middleware/sidekiq_web_static.rb' - - 'lib/gitlab/middleware/static.rb' - - 'lib/gitlab/path_regex.rb' - - 'lib/gitlab/push_options.rb' - - 'lib/gitlab/query_limiting/transaction.rb' - - 'lib/gitlab/quick_actions/extractor.rb' - - 'lib/gitlab/quick_actions/spend_time_and_date_separator.rb' - - 'lib/gitlab/quick_actions/timeline_text_and_date_time_separator.rb' - - 'lib/gitlab/rack_attack/request.rb' - - 'lib/gitlab/redis/hll.rb' - - 'lib/gitlab/regex.rb' - - 'lib/gitlab/regex/packages.rb' - - 'lib/gitlab/robots_txt/parser.rb' diff --git a/.rubocop_todo/style/redundant_self.yml b/.rubocop_todo/style/redundant_self.yml index 3dd497248bc..49132170448 100644 --- a/.rubocop_todo/style/redundant_self.yml +++ b/.rubocop_todo/style/redundant_self.yml @@ -82,13 +82,11 @@ Style/RedundantSelf: - 'app/models/group_group_link.rb' - 'app/models/hooks/web_hook_log.rb' - 'app/models/identity.rb' - - 'app/models/integration.rb' - 'app/models/integrations/base_chat_notification.rb' - 'app/models/integrations/base_ci.rb' - 'app/models/integrations/base_issue_tracker.rb' - 'app/models/integrations/base_slash_commands.rb' - 'app/models/integrations/emails_on_push.rb' - - 'app/models/integrations/jira.rb' - 'app/models/integrations/pipelines_email.rb' - 'app/models/integrations/zentao.rb' - 'app/models/internal_id.rb' diff --git a/.rubocop_todo/style/single_argument_dig.yml b/.rubocop_todo/style/single_argument_dig.yml index d41dc0add05..b33a9954cfc 100644 --- a/.rubocop_todo/style/single_argument_dig.yml +++ b/.rubocop_todo/style/single_argument_dig.yml @@ -6,7 +6,6 @@ Style/SingleArgumentDig: - 'app/models/ci/build.rb' - 'app/models/ci/build_report_result.rb' - 'app/models/error_tracking/error_event.rb' - - 'app/models/integrations/bamboo.rb' - 'app/serializers/codequality_degradation_entity.rb' - 'app/services/ci/update_build_state_service.rb' - 'ee/app/controllers/subscriptions_controller.rb' diff --git a/.rubocop_todo/style/sole_nested_conditional.yml b/.rubocop_todo/style/sole_nested_conditional.yml index 975da41a69a..0417039da20 100644 --- a/.rubocop_todo/style/sole_nested_conditional.yml +++ b/.rubocop_todo/style/sole_nested_conditional.yml @@ -20,7 +20,6 @@ Style/SoleNestedConditional: - 'app/services/projects/container_repository/delete_tags_service.rb' - 'app/services/projects/create_service.rb' - 'app/services/projects/hashed_storage/migration_service.rb' - - 'app/services/projects/hashed_storage/rollback_service.rb' - 'ee/app/finders/ee/snippets_finder.rb' - 'ee/app/services/ee/issue_links/create_service.rb' - 'ee/app/services/ee/lfs/unlock_file_service.rb' diff --git a/.rubocop_todo/style/string_concatenation.yml b/.rubocop_todo/style/string_concatenation.yml index ba88524e16d..b8afe0c6148 100644 --- a/.rubocop_todo/style/string_concatenation.yml +++ b/.rubocop_todo/style/string_concatenation.yml @@ -24,7 +24,6 @@ Style/StringConcatenation: - 'app/services/packages/composer/version_parser_service.rb' - 'app/services/packages/debian/generate_distribution_key_service.rb' - 'app/services/packages/debian/generate_distribution_service.rb' - - 'app/services/pages/zip_directory_service.rb' - 'app/services/repositories/base_service.rb' - 'app/services/verify_pages_domain_service.rb' - 'app/uploaders/gitlab_uploader.rb' @@ -96,7 +95,6 @@ Style/StringConcatenation: - 'lib/gitlab/database/rename_reserved_paths_migration/v1/migration_classes.rb' - 'lib/gitlab/database/unidirectional_copy_trigger.rb' - 'lib/gitlab/email/handler/service_desk_handler.rb' - - 'lib/gitlab/email/message/in_product_marketing/helper.rb' - 'lib/gitlab/git.rb' - 'lib/gitlab/git/branch.rb' - 'lib/gitlab/git/tag.rb' @@ -141,7 +139,6 @@ Style/StringConcatenation: - 'qa/qa/tools/generate_perf_testdata.rb' - 'scripts/perf/gc/print_gc_stats.rb' - 'scripts/perf/query_limiting_report.rb' - - 'scripts/used-feature-flags' - 'spec/config/settings_spec.rb' - 'spec/controllers/concerns/redirects_for_missing_path_on_tree_spec.rb' - 'spec/controllers/groups/uploads_controller_spec.rb' diff --git a/.rubocop_todo/style/string_literals_in_interpolation.yml b/.rubocop_todo/style/string_literals_in_interpolation.yml index c8cd3c9f074..daa9b90b177 100644 --- a/.rubocop_todo/style/string_literals_in_interpolation.yml +++ b/.rubocop_todo/style/string_literals_in_interpolation.yml @@ -6,7 +6,6 @@ Style/StringLiteralsInInterpolation: - 'app/helpers/colors_helper.rb' - 'app/models/application_setting_implementation.rb' - 'app/models/ci/namespace_mirror.rb' - - 'app/models/integrations/jira.rb' - 'app/services/draft_notes/publish_service.rb' - 'app/services/projects/create_service.rb' - 'app/validators/nested_attributes_duplicates_validator.rb' diff --git a/.rubocop_todo/style/symbol_proc.yml b/.rubocop_todo/style/symbol_proc.yml index a8f966d2266..fa6cf5c4a7e 100644 --- a/.rubocop_todo/style/symbol_proc.yml +++ b/.rubocop_todo/style/symbol_proc.yml @@ -69,7 +69,6 @@ Style/SymbolProc: - 'ee/app/helpers/ee/mirror_helper.rb' - 'ee/app/helpers/ee/registrations_helper.rb' - 'ee/app/models/concerns/epic_tree_sorting.rb' - - 'ee/app/models/ee/integrations/jira.rb' - 'ee/app/models/ee/issue.rb' - 'ee/app/serializers/ee/fork_namespace_entity.rb' - 'ee/app/serializers/ee/group_child_entity.rb' |