diff options
Diffstat (limited to '.rubocop_todo')
38 files changed, 35 insertions, 192 deletions
diff --git a/.rubocop_todo/cop/experiments_test_coverage.yml b/.rubocop_todo/cop/experiments_test_coverage.yml new file mode 100644 index 00000000000..1e347b2b466 --- /dev/null +++ b/.rubocop_todo/cop/experiments_test_coverage.yml @@ -0,0 +1,7 @@ +--- +Cop/ExperimentsTestCoverage: + Details: grace period + Exclude: + - 'app/controllers/groups/boards_controller.rb' + - 'app/controllers/projects/boards_controller.rb' + - 'app/experiments/build_ios_app_guide_email_experiment.rb' diff --git a/.rubocop_todo/database/avoid_inheritance_column.yml b/.rubocop_todo/database/avoid_inheritance_column.yml new file mode 100644 index 00000000000..ff4519c5568 --- /dev/null +++ b/.rubocop_todo/database/avoid_inheritance_column.yml @@ -0,0 +1,6 @@ +--- +Database/AvoidInheritanceColumn: + Exclude: + - 'app/models/event.rb' + - 'app/models/integration.rb' + - 'lib/gitlab/background_migration/backfill_project_repositories.rb' diff --git a/.rubocop_todo/gitlab/namespaced_class.yml b/.rubocop_todo/gitlab/namespaced_class.yml index 8c8306124c1..4b000876d0e 100644 --- a/.rubocop_todo/gitlab/namespaced_class.yml +++ b/.rubocop_todo/gitlab/namespaced_class.yml @@ -1082,7 +1082,6 @@ Gitlab/NamespacedClass: - 'ee/spec/support/elastic_query_name_inspector.rb' - 'ee/spec/support/test_license.rb' - 'lib/carrier_wave_string_file.rb' - - 'lib/csv_builder.rb' - 'lib/event_filter.rb' - 'lib/file_size_validator.rb' - 'lib/forever.rb' @@ -1179,7 +1178,6 @@ Gitlab/NamespacedClass: - 'lib/gitlab/namespace_sanitizer.rb' - 'lib/gitlab/namespaced_session_store.rb' - 'lib/gitlab/net_http_adapter.rb' - - 'lib/gitlab/null_request_store.rb' - 'lib/gitlab/object_hierarchy.rb' - 'lib/gitlab/omniauth_initializer.rb' - 'lib/gitlab/otp_key_rotator.rb' diff --git a/.rubocop_todo/gitlab/strong_memoize_attr.yml b/.rubocop_todo/gitlab/strong_memoize_attr.yml index b30a18be6ba..cd58daeeab4 100644 --- a/.rubocop_todo/gitlab/strong_memoize_attr.yml +++ b/.rubocop_todo/gitlab/strong_memoize_attr.yml @@ -59,8 +59,8 @@ Gitlab/StrongMemoizeAttr: - 'app/graphql/resolvers/namespace_projects_resolver.rb' - 'app/graphql/resolvers/work_items_resolver.rb' - 'app/graphql/types/board_list_type.rb' + - 'app/helpers/admin/broadcast_messages_helper.rb' - 'app/helpers/appearances_helper.rb' - - 'app/helpers/broadcast_messages_helper.rb' - 'app/helpers/diff_helper.rb' - 'app/helpers/operations_helper.rb' - 'app/helpers/page_layout_helper.rb' diff --git a/.rubocop_todo/layout/argument_alignment.yml b/.rubocop_todo/layout/argument_alignment.yml index be750a04f7c..35923d68b93 100644 --- a/.rubocop_todo/layout/argument_alignment.yml +++ b/.rubocop_todo/layout/argument_alignment.yml @@ -4,18 +4,6 @@ Layout/ArgumentAlignment: Exclude: - 'app/graphql/mutations/achievements/create.rb' - 'app/graphql/mutations/admin/sidekiq_queues/delete_jobs.rb' - - 'app/graphql/mutations/alert_management/alerts/set_assignees.rb' - - 'app/graphql/mutations/alert_management/base.rb' - - 'app/graphql/mutations/alert_management/http_integration/create.rb' - - 'app/graphql/mutations/alert_management/http_integration/destroy.rb' - - 'app/graphql/mutations/alert_management/http_integration/http_integration_base.rb' - - 'app/graphql/mutations/alert_management/http_integration/reset_token.rb' - - 'app/graphql/mutations/alert_management/http_integration/update.rb' - - 'app/graphql/mutations/alert_management/prometheus_integration/create.rb' - - 'app/graphql/mutations/alert_management/prometheus_integration/prometheus_integration_base.rb' - - 'app/graphql/mutations/alert_management/prometheus_integration/reset_token.rb' - - 'app/graphql/mutations/alert_management/prometheus_integration/update.rb' - - 'app/graphql/mutations/alert_management/update_alert_status.rb' - 'app/graphql/mutations/award_emojis/base.rb' - 'app/graphql/mutations/base_mutation.rb' - 'app/graphql/mutations/boards/common_mutation_arguments.rb' @@ -286,7 +274,6 @@ Layout/ArgumentAlignment: - 'app/graphql/types/ci/analytics_type.rb' - 'app/graphql/types/ci/application_setting_type.rb' - 'app/graphql/types/ci/build_need_type.rb' - - 'app/graphql/types/ci/ci_cd_setting_type.rb' - 'app/graphql/types/ci/code_quality_degradation_severity_enum.rb' - 'app/graphql/types/ci/code_quality_report_summary_type.rb' - 'app/graphql/types/ci/config/config_type.rb' @@ -442,7 +429,6 @@ Layout/ArgumentAlignment: - 'app/graphql/types/project_invitation_type.rb' - 'app/graphql/types/project_member_type.rb' - 'app/graphql/types/project_statistics_type.rb' - - 'app/graphql/types/project_type.rb' - 'app/graphql/types/projects/branch_rule_type.rb' - 'app/graphql/types/projects/fork_details_type.rb' - 'app/graphql/types/projects/repository_language_type.rb' @@ -1279,12 +1265,12 @@ Layout/ArgumentAlignment: - 'ee/spec/services/vulnerability_feedback/create_service_spec.rb' - 'ee/spec/services/vulnerability_merge_request_links/create_service_spec.rb' - 'lib/api/access_requests.rb' + - 'lib/api/admin/broadcast_messages.rb' - 'lib/api/admin/plan_limits.rb' - 'lib/api/alert_management_alerts.rb' - 'lib/api/api.rb' - 'lib/api/applications.rb' - 'lib/api/branches.rb' - - 'lib/api/broadcast_messages.rb' - 'lib/api/bulk_imports.rb' - 'lib/api/ci/job_artifacts.rb' - 'lib/api/ci/jobs.rb' @@ -1521,15 +1507,6 @@ Layout/ArgumentAlignment: - 'spec/components/previews/pajamas/alert_component_preview.rb' - 'spec/components/previews/pajamas/banner_component_preview.rb' - 'spec/components/previews/pajamas/button_component_preview.rb' - - 'spec/features/jira_oauth_provider_authorize_spec.rb' - - 'spec/features/markdown/gitlab_flavored_markdown_spec.rb' - - 'spec/features/nav/top_nav_tooltip_spec.rb' - - 'spec/features/oauth_provider_authorize_spec.rb' - - 'spec/features/participants_autocomplete_spec.rb' - - 'spec/features/profile_spec.rb' - - 'spec/features/profiles/active_sessions_spec.rb' - - 'spec/features/profiles/keys_spec.rb' - - 'spec/features/profiles/user_changes_notified_of_own_activity_spec.rb' - 'spec/frontend/fixtures/autocomplete.rb' - 'spec/frontend/fixtures/autocomplete_sources.rb' - 'spec/frontend/fixtures/environments.rb' @@ -1902,21 +1879,6 @@ Layout/ArgumentAlignment: - 'spec/rubocop/cop/rspec/env_mocking_spec.rb' - 'spec/rubocop/cop/style/regexp_literal_mixed_preserve_spec.rb' - 'spec/rubocop/formatter/graceful_formatter_spec.rb' - - 'spec/services/application_settings/update_service_spec.rb' - - 'spec/services/authorized_project_update/find_records_due_for_refresh_service_spec.rb' - - 'spec/services/auto_merge/base_service_spec.rb' - - 'spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb' - - 'spec/services/auto_merge_service_spec.rb' - - 'spec/services/award_emojis/destroy_service_spec.rb' - - 'spec/services/bulk_imports/create_service_spec.rb' - - 'spec/services/bulk_imports/get_importable_data_service_spec.rb' - - 'spec/services/clusters/kubernetes/create_or_update_namespace_service_spec.rb' - - 'spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb' - - 'spec/services/cohorts_service_spec.rb' - - 'spec/services/commits/commit_patch_service_spec.rb' - - 'spec/services/deployments/create_for_build_service_spec.rb' - - 'spec/services/deployments/link_merge_requests_service_spec.rb' - - 'spec/services/deployments/update_environment_service_spec.rb' - 'spec/services/design_management/save_designs_service_spec.rb' - 'spec/services/discussions/resolve_service_spec.rb' - 'spec/services/draft_notes/publish_service_spec.rb' @@ -1954,21 +1916,6 @@ Layout/ArgumentAlignment: - 'spec/services/resource_events/merge_into_notes_service_spec.rb' - 'spec/services/security/ci_configuration/dependency_scanning_create_service_spec.rb' - 'spec/services/security/merge_reports_service_spec.rb' - - 'spec/services/service_response_spec.rb' - - 'spec/services/suggestions/apply_service_spec.rb' - - 'spec/services/suggestions/create_service_spec.rb' - - 'spec/services/suggestions/outdate_service_spec.rb' - - 'spec/services/task_list_toggle_service_spec.rb' - - 'spec/services/todo_service_spec.rb' - - 'spec/services/users/activity_service_spec.rb' - - 'spec/services/users/destroy_service_spec.rb' - - 'spec/services/users/migrate_records_to_ghost_user_in_batches_service_spec.rb' - - 'spec/services/users/migrate_records_to_ghost_user_service_spec.rb' - - 'spec/services/users/refresh_authorized_projects_service_spec.rb' - - 'spec/services/users/reject_service_spec.rb' - - 'spec/services/webauthn/authenticate_service_spec.rb' - - 'spec/services/work_items/task_list_reference_removal_service_spec.rb' - - 'spec/services/work_items/widgets/description_service/update_service_spec.rb' - 'spec/sidekiq/cron/job_gem_dependency_spec.rb' - 'spec/support/shared_examples/initializers/uses_gitlab_url_blocker_shared_examples.rb' - 'spec/support/shared_examples/integrations/integration_settings_form.rb' diff --git a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml index 62bf63d1bb9..53954249ed4 100644 --- a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml +++ b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml @@ -187,6 +187,7 @@ Layout/LineEndStringConcatenationIndentation: - 'lib/gitlab/path_regex.rb' - 'lib/gitlab/reference_counter.rb' - 'lib/gitlab/regex.rb' + - 'lib/gitlab/regex/bulk_imports.rb' - 'lib/gitlab/seeders/ci/runner/runner_fleet_seeder.rb' - 'lib/gitlab/slash_commands/presenters/run.rb' - 'lib/gitlab/tracking/standard_context.rb' diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index ef2e380ea95..162afb96a09 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -920,7 +920,6 @@ Layout/LineLength: - 'ee/app/models/ee/upload.rb' - 'ee/app/models/ee/user.rb' - 'ee/app/models/ee/vulnerability.rb' - - 'ee/app/models/elastic/migration_record.rb' - 'ee/app/models/elastic/reindexing_slice.rb' - 'ee/app/models/epic_issue.rb' - 'ee/app/models/geo/project_registry.rb' @@ -2410,13 +2409,13 @@ Layout/LineLength: - 'ee/spec/workers/sync_seat_link_request_worker_spec.rb' - 'ee/spec/workers/update_all_mirrors_worker_spec.rb' - 'ee/spec/workers/vulnerability_exports/export_deletion_worker_spec.rb' + - 'lib/api/admin/broadcast_messages.rb' - 'lib/api/admin/instance_clusters.rb' - 'lib/api/api.rb' - 'lib/api/appearance.rb' - 'lib/api/award_emoji.rb' - 'lib/api/boards_responses.rb' - 'lib/api/branches.rb' - - 'lib/api/broadcast_messages.rb' - 'lib/api/ci/jobs.rb' - 'lib/api/ci/pipeline_schedules.rb' - 'lib/api/ci/pipelines.rb' @@ -2436,10 +2435,10 @@ Layout/LineLength: - 'lib/api/deploy_tokens.rb' - 'lib/api/deployments.rb' - 'lib/api/discussions.rb' + - 'lib/api/entities/system/broadcast_message.rb' - 'lib/api/entities/application_setting.rb' - 'lib/api/entities/basic_project_details.rb' - 'lib/api/entities/branch.rb' - - 'lib/api/entities/broadcast_message.rb' - 'lib/api/entities/container_registry.rb' - 'lib/api/entities/deploy_key.rb' - 'lib/api/entities/issue_basic.rb' @@ -2822,12 +2821,13 @@ Layout/LineLength: - 'lib/gitlab/quick_actions/merge_request_actions.rb' - 'lib/gitlab/rack_attack.rb' - 'lib/gitlab/regex.rb' + - 'lib/gitlab/regex/bulk_imports.rb' + - 'lib/gitlab/regex/packages.rb' - 'lib/gitlab/relative_positioning/item_context.rb' - 'lib/gitlab/repository_size_error_message.rb' - 'lib/gitlab/sample_data_template.rb' - 'lib/gitlab/sanitizers/svg/whitelist.rb' - 'lib/gitlab/search/abuse_detection.rb' - - 'lib/gitlab/search_results.rb' - 'lib/gitlab/setup_helper.rb' - 'lib/gitlab/sidekiq_config.rb' - 'lib/gitlab/sidekiq_config/worker_router.rb' @@ -2848,8 +2848,6 @@ Layout/LineLength: - 'lib/gitlab/usage/metrics/aggregates/aggregate.rb' - 'lib/gitlab/usage/metrics/aggregates/sources/calculations/intersection.rb' - 'lib/gitlab/usage/metrics/aggregates/sources/postgres_hll.rb' - - 'lib/gitlab/usage/metrics/name_suggestion.rb' - - 'lib/gitlab/usage/metrics/names_suggestions/generator.rb' - 'lib/gitlab/usage/service_ping_report.rb' - 'lib/gitlab/usage_data.rb' - 'lib/gitlab/usage_data/topology.rb' @@ -3447,7 +3445,6 @@ Layout/LineLength: - 'spec/finders/members_finder_spec.rb' - 'spec/finders/merge_requests/by_approvals_finder_spec.rb' - 'spec/finders/merge_requests_finder_spec.rb' - - 'spec/finders/metrics/dashboards/annotations_finder_spec.rb' - 'spec/finders/metrics/users_starred_dashboards_finder_spec.rb' - 'spec/finders/milestones_finder_spec.rb' - 'spec/finders/namespaces/projects_finder_spec.rb' @@ -3577,7 +3574,6 @@ Layout/LineLength: - 'spec/helpers/diff_helper_spec.rb' - 'spec/helpers/emails_helper_spec.rb' - 'spec/helpers/environments_helper_spec.rb' - - 'spec/helpers/events_helper_spec.rb' - 'spec/helpers/external_link_helper_spec.rb' - 'spec/helpers/gitlab_routing_helper_spec.rb' - 'spec/helpers/gitlab_script_tag_helper_spec.rb' @@ -3698,7 +3694,6 @@ Layout/LineLength: - 'spec/lib/container_registry/client_spec.rb' - 'spec/lib/container_registry/gitlab_api_client_spec.rb' - 'spec/lib/container_registry/registry_spec.rb' - - 'spec/lib/csv_builder_spec.rb' - 'spec/lib/declarative_enum_spec.rb' - 'spec/lib/error_tracking/sentry_client/issue_link_spec.rb' - 'spec/lib/error_tracking/sentry_client/pagination_parser_spec.rb' @@ -4080,8 +4075,6 @@ Layout/LineLength: - 'spec/lib/gitlab/usage/metrics/instrumentations/count_users_creating_issues_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/database_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/redis_hll_metric_spec.rb' - - 'spec/lib/gitlab/usage/metrics/name_suggestion_spec.rb' - - 'spec/lib/gitlab/usage/metrics/names_suggestions/generator_spec.rb' - 'spec/lib/gitlab/usage/metrics/query_spec.rb' - 'spec/lib/gitlab/usage/service_ping/payload_keys_processor_spec.rb' - 'spec/lib/gitlab/usage/service_ping_report_spec.rb' @@ -4343,6 +4336,7 @@ Layout/LineLength: - 'spec/rack_servers/puma_spec.rb' - 'spec/requests/admin/background_migrations_controller_spec.rb' - 'spec/requests/api/access_requests_spec.rb' + - 'spec/requests/api/admin/broadcast_messages_spec.rb' - 'spec/requests/api/admin/instance_clusters_spec.rb' - 'spec/requests/api/admin/plan_limits_spec.rb' - 'spec/requests/api/admin/sidekiq_spec.rb' @@ -4351,7 +4345,6 @@ Layout/LineLength: - 'spec/requests/api/award_emoji_spec.rb' - 'spec/requests/api/badges_spec.rb' - 'spec/requests/api/branches_spec.rb' - - 'spec/requests/api/broadcast_messages_spec.rb' - 'spec/requests/api/bulk_imports_spec.rb' - 'spec/requests/api/ci/job_artifacts_spec.rb' - 'spec/requests/api/ci/jobs_spec.rb' diff --git a/.rubocop_todo/layout/space_in_lambda_literal.yml b/.rubocop_todo/layout/space_in_lambda_literal.yml index ca6803be7e8..01189989eec 100644 --- a/.rubocop_todo/layout/space_in_lambda_literal.yml +++ b/.rubocop_todo/layout/space_in_lambda_literal.yml @@ -371,7 +371,6 @@ Layout/SpaceInLambdaLiteral: - 'spec/helpers/namespaces_helper_spec.rb' - 'spec/lib/backup/gitaly_backup_spec.rb' - 'spec/lib/container_registry/client_spec.rb' - - 'spec/lib/csv_builder_spec.rb' - 'spec/lib/gitlab/analytics/date_filler_spec.rb' - 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb' - 'spec/lib/gitlab/batch_worker_context_spec.rb' diff --git a/.rubocop_todo/layout/space_inside_parens.yml b/.rubocop_todo/layout/space_inside_parens.yml index 6b2f04eff7e..4d067749bd0 100644 --- a/.rubocop_todo/layout/space_inside_parens.yml +++ b/.rubocop_todo/layout/space_inside_parens.yml @@ -169,7 +169,6 @@ Layout/SpaceInsideParens: - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/strategies/until_executing_spec.rb' - 'spec/lib/gitlab/usage/metric_definition_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/generic_metric_spec.rb' - - 'spec/lib/gitlab/usage/metrics/name_suggestion_spec.rb' - 'spec/lib/gitlab/usage_data_spec.rb' - 'spec/lib/gitlab/utils/delegator_override/validator_spec.rb' - 'spec/lib/gitlab/utils/usage_data_spec.rb' diff --git a/.rubocop_todo/lint/ambiguous_operator_precedence.yml b/.rubocop_todo/lint/ambiguous_operator_precedence.yml index 577836b07f9..f21c101d4a2 100644 --- a/.rubocop_todo/lint/ambiguous_operator_precedence.yml +++ b/.rubocop_todo/lint/ambiguous_operator_precedence.yml @@ -78,7 +78,6 @@ Lint/AmbiguousOperatorPrecedence: - 'lib/gitlab/relative_positioning.rb' - 'lib/gitlab/template_parser/parser.rb' - 'lib/gitlab/tree_summary.rb' - - 'lib/gitlab/usage/metrics/name_suggestion.rb' - 'lib/omni_auth/strategies/bitbucket.rb' - 'qa/qa/ee/page/project/secure/pipeline_security.rb' - 'qa/qa/resource/api_fabricator.rb' @@ -94,7 +93,6 @@ Lint/AmbiguousOperatorPrecedence: - 'scripts/review_apps/automated_cleanup.rb' - 'spec/controllers/projects/issues_controller_spec.rb' - 'spec/controllers/search_controller_spec.rb' - - 'spec/helpers/events_helper_spec.rb' - 'spec/helpers/time_helper_spec.rb' - 'spec/lib/api/helpers/pagination_strategies_spec.rb' - 'spec/lib/banzai/filter/front_matter_filter_spec.rb' diff --git a/.rubocop_todo/lint/constant_definition_in_block.yml b/.rubocop_todo/lint/constant_definition_in_block.yml index 6d267d18713..98cda7a7f66 100644 --- a/.rubocop_todo/lint/constant_definition_in_block.yml +++ b/.rubocop_todo/lint/constant_definition_in_block.yml @@ -33,7 +33,6 @@ Lint/ConstantDefinitionInBlock: - 'lib/tasks/dev.rake' - 'lib/tasks/gitlab/backup.rake' - 'lib/tasks/gitlab/db.rake' - - 'lib/tasks/gitlab/db/decomposition/rollback/bump_ci_sequences.rake' - 'lib/tasks/gitlab/db/validate_config.rake' - 'lib/tasks/gitlab/docs/compile_deprecations.rake' - 'lib/tasks/gitlab/graphql.rake' diff --git a/.rubocop_todo/lint/duplicate_branch.yml b/.rubocop_todo/lint/duplicate_branch.yml index 4029432a9b0..e8fa18943d1 100644 --- a/.rubocop_todo/lint/duplicate_branch.yml +++ b/.rubocop_todo/lint/duplicate_branch.yml @@ -27,7 +27,6 @@ Lint/DuplicateBranch: - 'lib/gitlab/ci/yaml_processor.rb' - 'lib/gitlab/database/load_balancing/load_balancer.rb' - 'lib/gitlab/import_export/project/relation_factory.rb' - - 'lib/gitlab/search_results.rb' - 'lib/mattermost/session.rb' - 'lib/sidebars/groups/menus/settings_menu.rb' - 'qa/qa/resource/pipeline.rb' diff --git a/.rubocop_todo/lint/unused_block_argument.yml b/.rubocop_todo/lint/unused_block_argument.yml index 05e30a7f9ad..0d57ccd0234 100644 --- a/.rubocop_todo/lint/unused_block_argument.yml +++ b/.rubocop_todo/lint/unused_block_argument.yml @@ -235,7 +235,6 @@ Lint/UnusedBlockArgument: - 'lib/gitlab/metrics/dashboard/validator/custom_formats.rb' - 'lib/gitlab/metrics/exporter/base_exporter.rb' - 'lib/gitlab/pagination/gitaly_keyset_pager.rb' - - 'lib/gitlab/safe_request_store.rb' - 'lib/gitlab/sidekiq_config.rb' - 'lib/gitlab/sidekiq_daemon/monitor.rb' - 'lib/gitlab/suggestions/commit_message.rb' @@ -344,7 +343,6 @@ Lint/UnusedBlockArgument: - 'spec/lib/gitlab/memory/jemalloc_spec.rb' - 'spec/lib/gitlab/middleware/memory_report_spec.rb' - 'spec/lib/gitlab/middleware/speedscope_spec.rb' - - 'spec/lib/gitlab/null_request_store_spec.rb' - 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/strategies/record_loader_strategy_spec.rb' - 'spec/lib/gitlab/process_supervisor_spec.rb' - 'spec/lib/gitlab/query_limiting_spec.rb' @@ -382,7 +380,6 @@ Lint/UnusedBlockArgument: - 'spec/services/snippets/update_service_spec.rb' - 'spec/spec_helper.rb' - 'spec/support/atlassian/jira_connect/schemata.rb' - - 'spec/support/database/prevent_cross_database_modification.rb' - 'spec/support/graphql/subscriptions/action_cable/mock_action_cable.rb' - 'spec/support/helpers/cycle_analytics_helpers.rb' - 'spec/support/helpers/docs_screenshot_helpers.rb' diff --git a/.rubocop_todo/lint/unused_method_argument.yml b/.rubocop_todo/lint/unused_method_argument.yml index 086882b0f1b..e052454ae32 100644 --- a/.rubocop_todo/lint/unused_method_argument.yml +++ b/.rubocop_todo/lint/unused_method_argument.yml @@ -494,7 +494,6 @@ Lint/UnusedMethodArgument: - 'lib/gitlab/metrics/null_metric.rb' - 'lib/gitlab/metrics/subscribers/action_cable.rb' - 'lib/gitlab/metrics/subscribers/rails_cache.rb' - - 'lib/gitlab/null_request_store.rb' - 'lib/gitlab/optimistic_locking.rb' - 'lib/gitlab/otp_key_rotator.rb' - 'lib/gitlab/project_search_results.rb' @@ -506,9 +505,7 @@ Lint/UnusedMethodArgument: - 'lib/gitlab/repository_hash_cache.rb' - 'lib/gitlab/repository_set_cache.rb' - 'lib/gitlab/safe_request_loader.rb' - - 'lib/gitlab/safe_request_store.rb' - 'lib/gitlab/sanitizers/exif.rb' - - 'lib/gitlab/search_results.rb' - 'lib/gitlab/setup_helper.rb' - 'lib/gitlab/sidekiq_logging/json_formatter.rb' - 'lib/gitlab/sidekiq_logging/structured_logger.rb' @@ -541,7 +538,6 @@ Lint/UnusedMethodArgument: - 'lib/gitlab/tracking.rb' - 'lib/gitlab/untrusted_regexp/ruby_syntax.rb' - 'lib/gitlab/usage/metrics/aggregates/sources/redis_hll.rb' - - 'lib/gitlab/usage/metrics/names_suggestions/generator.rb' - 'lib/gitlab/usage_data.rb' - 'lib/gitlab/usage_data_non_sql_metrics.rb' - 'lib/gitlab/usage_data_queries.rb' diff --git a/.rubocop_todo/performance/regexp_match.yml b/.rubocop_todo/performance/regexp_match.yml index 2c80a74c538..0248938c84b 100644 --- a/.rubocop_todo/performance/regexp_match.yml +++ b/.rubocop_todo/performance/regexp_match.yml @@ -20,26 +20,6 @@ Performance/RegexpMatch: - 'lib/banzai/filter/references/reference_filter.rb' - 'lib/bulk_imports/path_normalization.rb' - 'lib/feature/definition.rb' - - 'lib/gitlab/authorized_keys.rb' - - 'lib/gitlab/checks/branch_check.rb' - - 'lib/gitlab/ci/build/artifacts/metadata.rb' - - 'lib/gitlab/ci/build/artifacts/metadata/entry.rb' - - 'lib/gitlab/ci/project_config/remote.rb' - - 'lib/gitlab/database/postgres_constraint.rb' - - 'lib/gitlab/database/postgres_foreign_key.rb' - - 'lib/gitlab/database/postgres_index.rb' - - 'lib/gitlab/database/postgres_partition.rb' - - 'lib/gitlab/database/postgres_partitioned_table.rb' - - 'lib/gitlab/database/reindexing/reindex_concurrently.rb' - - 'lib/gitlab/dependency_linker/base_linker.rb' - - 'lib/gitlab/dependency_linker/composer_json_linker.rb' - - 'lib/gitlab/diff/parser.rb' - - 'lib/gitlab/email/reply_parser.rb' - - 'lib/gitlab/git/gitmodules_parser.rb' - - 'lib/gitlab/metrics/samplers/threads_sampler.rb' - - 'lib/gitlab/middleware/sidekiq_web_static.rb' - - 'lib/gitlab/middleware/static.rb' - - 'lib/gitlab/url_blocker.rb' - 'lib/tasks/gitlab/update_templates.rake' - 'lib/uploaded_file.rb' - 'qa/qa/flow/integrations/slack.rb' diff --git a/.rubocop_todo/rails/helper_instance_variable.yml b/.rubocop_todo/rails/helper_instance_variable.yml index 13c681a634a..1c0541f732a 100644 --- a/.rubocop_todo/rails/helper_instance_variable.yml +++ b/.rubocop_todo/rails/helper_instance_variable.yml @@ -1,6 +1,7 @@ --- Rails/HelperInstanceVariable: Exclude: + - 'app/helpers/admin/broadcast_messages_helper.rb' - 'app/helpers/admin/user_actions_helper.rb' - 'app/helpers/application_helper.rb' - 'app/helpers/application_settings_helper.rb' @@ -9,7 +10,6 @@ Rails/HelperInstanceVariable: - 'app/helpers/boards_helper.rb' - 'app/helpers/branches_helper.rb' - 'app/helpers/breadcrumbs_helper.rb' - - 'app/helpers/broadcast_messages_helper.rb' - 'app/helpers/ci/builds_helper.rb' - 'app/helpers/ci/jobs_helper.rb' - 'app/helpers/commits_helper.rb' diff --git a/.rubocop_todo/rails/negate_include.yml b/.rubocop_todo/rails/negate_include.yml index 22ccaa5998e..8879146de89 100644 --- a/.rubocop_todo/rails/negate_include.yml +++ b/.rubocop_todo/rails/negate_include.yml @@ -29,7 +29,6 @@ Rails/NegateInclude: - 'lib/gitlab/email/handler/service_desk_handler.rb' - 'lib/gitlab/graphql/queries.rb' - 'lib/gitlab/import_export/attributes_permitter.rb' - - 'lib/gitlab/search_results.rb' - 'lib/gitlab/task_helpers.rb' - 'qa/qa/tools/delete_test_users.rb' - 'spec/lib/container_registry/blob_spec.rb' diff --git a/.rubocop_todo/rails/output_safety.yml b/.rubocop_todo/rails/output_safety.yml index 53f9381099f..cc2f52a3ddc 100644 --- a/.rubocop_todo/rails/output_safety.yml +++ b/.rubocop_todo/rails/output_safety.yml @@ -13,10 +13,10 @@ Rails/OutputSafety: - 'app/controllers/search_controller.rb' - 'app/graphql/types/ci/job_trace_type.rb' - 'app/graphql/types/project_type.rb' + - 'app/helpers/admin/broadcast_messages_helper.rb' - 'app/helpers/admin/application_settings/settings_helper.rb' - 'app/helpers/appearances_helper.rb' - 'app/helpers/auth_helper.rb' - - 'app/helpers/broadcast_messages_helper.rb' - 'app/helpers/commits_helper.rb' - 'app/helpers/diff_helper.rb' - 'app/helpers/dropdowns_helper.rb' diff --git a/.rubocop_todo/rails/pluck.yml b/.rubocop_todo/rails/pluck.yml index 06c0b2b1d42..150e3aff6cc 100644 --- a/.rubocop_todo/rails/pluck.yml +++ b/.rubocop_todo/rails/pluck.yml @@ -121,7 +121,6 @@ Rails/Pluck: - 'lib/gitlab/metrics/dashboard/stages/custom_metrics_details_inserter.rb' - 'lib/gitlab/sidekiq_config/cli_methods.rb' - 'lib/gitlab/sql/pattern.rb' - - 'lib/gitlab/usage/metrics/name_suggestion.rb' - 'lib/gitlab/usage_data_counters/hll_redis_counter.rb' - 'lib/gitlab/zentao/client.rb' - 'lib/tasks/gitlab/info.rake' diff --git a/.rubocop_todo/rails/redundant_foreign_key.yml b/.rubocop_todo/rails/redundant_foreign_key.yml index fc0f1c97fba..fba5168dbf3 100644 --- a/.rubocop_todo/rails/redundant_foreign_key.yml +++ b/.rubocop_todo/rails/redundant_foreign_key.yml @@ -27,7 +27,6 @@ Rails/RedundantForeignKey: - 'app/models/merge_request.rb' - 'app/models/merge_request/metrics.rb' - 'app/models/namespace.rb' - - 'app/models/namespaces/project_namespace.rb' - 'app/models/packages/debian/publication.rb' - 'app/models/project.rb' - 'app/models/resource_state_event.rb' diff --git a/.rubocop_todo/rspec/before_all.yml b/.rubocop_todo/rspec/before_all.yml new file mode 100644 index 00000000000..e7c57db9996 --- /dev/null +++ b/.rubocop_todo/rspec/before_all.yml @@ -0,0 +1,6 @@ +--- +# Cop supports --autocorrect. +RSpec/BeforeAll: + Details: grace period + Exclude: + - 'ee/spec/support/shared_examples/finders/security/findings_finder_shared_examples.rb' diff --git a/.rubocop_todo/rspec/before_all_role_assignment.yml b/.rubocop_todo/rspec/before_all_role_assignment.yml index 4b58f6fc52f..c74c0d93813 100644 --- a/.rubocop_todo/rspec/before_all_role_assignment.yml +++ b/.rubocop_todo/rspec/before_all_role_assignment.yml @@ -1096,11 +1096,10 @@ RSpec/BeforeAllRoleAssignment: - 'spec/graphql/types/todo_type_spec.rb' - 'spec/graphql/types/user_merge_request_interaction_type_spec.rb' - 'spec/graphql/types/user_type_spec.rb' + - 'spec/helpers/admin/broadcast_messages_helper_spec.rb' - 'spec/helpers/admin/user_actions_helper_spec.rb' - - 'spec/helpers/broadcast_messages_helper_spec.rb' - 'spec/helpers/ci/pipelines_helper_spec.rb' - 'spec/helpers/clusters_helper_spec.rb' - - 'spec/helpers/events_helper_spec.rb' - 'spec/helpers/groups_helper_spec.rb' - 'spec/helpers/issuables_helper_spec.rb' - 'spec/helpers/packages_helper_spec.rb' diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index c1751ebed4c..ec3ac9ff220 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -689,7 +689,6 @@ RSpec/ContextWording: - 'ee/spec/services/ee/keys/destroy_service_spec.rb' - 'ee/spec/services/ee/members/create_service_spec.rb' - 'ee/spec/services/ee/members/destroy_service_spec.rb' - - 'ee/spec/services/ee/members/import_project_team_service_spec.rb' - 'ee/spec/services/ee/members/invite_service_spec.rb' - 'ee/spec/services/ee/merge_requests/base_service_spec.rb' - 'ee/spec/services/ee/merge_requests/create_service_spec.rb' @@ -1335,7 +1334,6 @@ RSpec/ContextWording: - 'spec/finders/merge_request_target_project_finder_spec.rb' - 'spec/finders/merge_requests/by_approvals_finder_spec.rb' - 'spec/finders/merge_requests_finder_spec.rb' - - 'spec/finders/metrics/dashboards/annotations_finder_spec.rb' - 'spec/finders/metrics/users_starred_dashboards_finder_spec.rb' - 'spec/finders/milestones_finder_spec.rb' - 'spec/finders/notes_finder_spec.rb' @@ -1453,7 +1451,6 @@ RSpec/ContextWording: - 'spec/helpers/commits_helper_spec.rb' - 'spec/helpers/diff_helper_spec.rb' - 'spec/helpers/emails_helper_spec.rb' - - 'spec/helpers/events_helper_spec.rb' - 'spec/helpers/git_helper_spec.rb' - 'spec/helpers/gitlab_routing_helper_spec.rb' - 'spec/helpers/groups/group_members_helper_spec.rb' @@ -2030,8 +2027,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/usage/metrics/aggregates/sources/postgres_hll_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/redis_hll_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/redis_metric_spec.rb' - - 'spec/lib/gitlab/usage/metrics/name_suggestion_spec.rb' - - 'spec/lib/gitlab/usage/metrics/names_suggestions/generator_spec.rb' - 'spec/lib/gitlab/usage/service_ping/payload_keys_processor_spec.rb' - 'spec/lib/gitlab/usage/service_ping_report_spec.rb' - 'spec/lib/gitlab/usage_data/topology_spec.rb' diff --git a/.rubocop_todo/rspec/factory_bot/avoid_create.yml b/.rubocop_todo/rspec/factory_bot/avoid_create.yml index 40f36f8ca26..2725b035d65 100644 --- a/.rubocop_todo/rspec/factory_bot/avoid_create.yml +++ b/.rubocop_todo/rspec/factory_bot/avoid_create.yml @@ -95,7 +95,6 @@ RSpec/FactoryBot/AvoidCreate: - 'ee/spec/mailers/ee/emails/merge_requests_spec.rb' - 'ee/spec/mailers/ee/emails/profile_spec.rb' - 'ee/spec/mailers/ee/emails/projects_spec.rb' - - 'ee/spec/mailers/emails/free_user_cap_spec.rb' - 'ee/spec/mailers/emails/group_memberships_spec.rb' - 'ee/spec/mailers/emails/in_product_marketing_spec.rb' - 'ee/spec/mailers/emails/merge_commits_spec.rb' @@ -250,6 +249,7 @@ RSpec/FactoryBot/AvoidCreate: - 'spec/components/diffs/overflow_warning_component_spec.rb' - 'spec/components/diffs/stats_component_spec.rb' - 'spec/components/pajamas/avatar_component_spec.rb' + - 'spec/helpers/admin/broadcast_messages_helper_spec.rb' - 'spec/helpers/admin/identities_helper_spec.rb' - 'spec/helpers/admin/user_actions_helper_spec.rb' - 'spec/helpers/appearances_helper_spec.rb' @@ -262,7 +262,6 @@ RSpec/FactoryBot/AvoidCreate: - 'spec/helpers/blob_helper_spec.rb' - 'spec/helpers/boards_helper_spec.rb' - 'spec/helpers/branches_helper_spec.rb' - - 'spec/helpers/broadcast_messages_helper_spec.rb' - 'spec/helpers/button_helper_spec.rb' - 'spec/helpers/calendar_helper_spec.rb' - 'spec/helpers/ci/builds_helper_spec.rb' @@ -277,7 +276,6 @@ RSpec/FactoryBot/AvoidCreate: - 'spec/helpers/emails_helper_spec.rb' - 'spec/helpers/environment_helper_spec.rb' - 'spec/helpers/environments_helper_spec.rb' - - 'spec/helpers/events_helper_spec.rb' - 'spec/helpers/feature_flags_helper_spec.rb' - 'spec/helpers/gitlab_routing_helper_spec.rb' - 'spec/helpers/graph_helper_spec.rb' diff --git a/.rubocop_todo/rspec/factory_bot/excessive_create_list.yml b/.rubocop_todo/rspec/factory_bot/excessive_create_list.yml index 39aed947a48..640b0c7f400 100644 --- a/.rubocop_todo/rspec/factory_bot/excessive_create_list.yml +++ b/.rubocop_todo/rspec/factory_bot/excessive_create_list.yml @@ -14,11 +14,8 @@ RSpec/FactoryBot/ExcessiveCreateList: - 'ee/spec/support/protected_tags/access_control_shared_examples.rb' - 'ee/spec/support/shared_examples/features/protected_branches_access_control_shared_examples.rb' - 'ee/spec/views/admin/application_settings/_elasticsearch_form.html.haml_spec.rb' - - 'spec/controllers/admin/clusters_controller_spec.rb' - 'spec/controllers/autocomplete_controller_spec.rb' - 'spec/controllers/explore/projects_controller_spec.rb' - - 'spec/controllers/groups/clusters_controller_spec.rb' - - 'spec/controllers/projects/clusters_controller_spec.rb' - 'spec/controllers/projects/feature_flags_controller_spec.rb' - 'spec/controllers/projects/hooks_controller_spec.rb' - 'spec/docs_screenshots/container_registry_docs.rb' diff --git a/.rubocop_todo/rspec/missing_feature_category.yml b/.rubocop_todo/rspec/missing_feature_category.yml index cdd58e0c046..0d625f92c3f 100644 --- a/.rubocop_todo/rspec/missing_feature_category.yml +++ b/.rubocop_todo/rspec/missing_feature_category.yml @@ -140,10 +140,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/graphql/ee/types/board_list_type_spec.rb' - 'ee/spec/graphql/ee/types/board_type_spec.rb' - 'ee/spec/graphql/ee/types/boards/board_issue_input_type_spec.rb' - - 'ee/spec/graphql/ee/types/branch_protection_type_spec.rb' - - 'ee/spec/graphql/ee/types/branch_protections/merge_access_level_type_spec.rb' - - 'ee/spec/graphql/ee/types/branch_protections/push_access_level_type_spec.rb' - - 'ee/spec/graphql/ee/types/branch_protections/unprotect_access_level_type_spec.rb' - 'ee/spec/graphql/ee/types/ci/pipeline_merge_request_type_enum_spec.rb' - 'ee/spec/graphql/ee/types/clusters/agent_type_spec.rb' - 'ee/spec/graphql/ee/types/compliance_management/compliance_framework_type_spec.rb' @@ -155,7 +151,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/graphql/ee/types/milestone_type_spec.rb' - 'ee/spec/graphql/ee/types/mutation_type_spec.rb' - 'ee/spec/graphql/ee/types/notes/noteable_interface_spec.rb' - - 'ee/spec/graphql/ee/types/projects/branch_rule_type_spec.rb' - 'ee/spec/graphql/ee/types/projects/service_type_enum_spec.rb' - 'ee/spec/graphql/ee/types/repository/blob_type_spec.rb' - 'ee/spec/graphql/ee/types/todoable_interface_spec.rb' @@ -277,8 +272,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/graphql/resolvers/vulnerabilities_grade_resolver_spec.rb' - 'ee/spec/graphql/resolvers/vulnerabilities_resolver_spec.rb' - 'ee/spec/graphql/resolvers/vulnerability_severities_count_resolver_spec.rb' - - 'ee/spec/graphql/types/access_levels/group_type_spec.rb' - - 'ee/spec/graphql/types/access_levels/user_type_spec.rb' - 'ee/spec/graphql/types/admin/cloud_licenses/current_license_type_spec.rb' - 'ee/spec/graphql/types/admin/cloud_licenses/license_history_entry_type_spec.rb' - 'ee/spec/graphql/types/admin/cloud_licenses/subscription_future_entry_type_spec.rb' @@ -299,8 +292,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/graphql/types/boards/epic_list_metadata_type_spec.rb' - 'ee/spec/graphql/types/boards/epic_list_type_spec.rb' - 'ee/spec/graphql/types/boards/epic_user_preferences_type_spec.rb' - - 'ee/spec/graphql/types/branch_rules/approval_project_rule_type_spec.rb' - - 'ee/spec/graphql/types/branch_rules/external_status_check_type_spec.rb' - 'ee/spec/graphql/types/burnup_chart_daily_totals_type_spec.rb' - 'ee/spec/graphql/types/ci/code_coverage_activity_type_spec.rb' - 'ee/spec/graphql/types/ci/code_coverage_summary_spec.rb' @@ -957,7 +948,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/protected_environment_approval_rules_required_approvals_average_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/protected_environments_required_approvals_average_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/user_cap_setting_enabled_metric_spec.rb' - - 'ee/spec/lib/gitlab/usage/metrics/names_suggestions/generator_spec.rb' - 'ee/spec/lib/gitlab/usage_data_counters/epic_activity_unique_counter_spec.rb' - 'ee/spec/lib/gitlab/usage_data_counters/licenses_list_spec.rb' - 'ee/spec/lib/gitlab/usage_data_counters/streaming_audit_event_type_counter_spec.rb' @@ -1019,15 +1009,7 @@ RSpec/MissingFeatureCategory: - 'ee/spec/models/boards/epic_list_user_preference_spec.rb' - 'ee/spec/models/boards/epic_user_preference_spec.rb' - 'ee/spec/models/broadcast_message_spec.rb' - - 'ee/spec/models/ci/bridge_spec.rb' - 'ee/spec/models/ci/daily_build_group_report_result_spec.rb' - - 'ee/spec/models/ci/minutes/context_spec.rb' - - 'ee/spec/models/ci/minutes/namespace_monthly_usage_spec.rb' - - 'ee/spec/models/ci/minutes/notification_spec.rb' - - 'ee/spec/models/ci/minutes/project_monthly_usage_spec.rb' - - 'ee/spec/models/ci/minutes/usage_spec.rb' - - 'ee/spec/models/ci/pipeline_spec.rb' - - 'ee/spec/models/ci/processable_spec.rb' - 'ee/spec/models/ci/sources/project_spec.rb' - 'ee/spec/models/ci/subscriptions/project_spec.rb' - 'ee/spec/models/commit_spec.rb' @@ -1884,7 +1866,6 @@ RSpec/MissingFeatureCategory: - 'spec/finders/merge_request_target_project_finder_spec.rb' - 'spec/finders/merge_requests/by_approvals_finder_spec.rb' - 'spec/finders/merge_requests/oldest_per_commit_finder_spec.rb' - - 'spec/finders/metrics/dashboards/annotations_finder_spec.rb' - 'spec/finders/metrics/users_starred_dashboards_finder_spec.rb' - 'spec/finders/milestones_finder_spec.rb' - 'spec/finders/namespaces/projects_finder_spec.rb' @@ -2218,9 +2199,6 @@ RSpec/MissingFeatureCategory: - 'spec/graphql/types/board_list_type_spec.rb' - 'spec/graphql/types/board_type_spec.rb' - 'spec/graphql/types/boards/board_issue_input_type_spec.rb' - - 'spec/graphql/types/branch_protections/merge_access_level_type_spec.rb' - - 'spec/graphql/types/branch_protections/push_access_level_type_spec.rb' - - 'spec/graphql/types/branch_rules/branch_protection_type_spec.rb' - 'spec/graphql/types/branch_type_spec.rb' - 'spec/graphql/types/ci/analytics_type_spec.rb' - 'spec/graphql/types/ci/config/config_type_spec.rb' @@ -2421,7 +2399,6 @@ RSpec/MissingFeatureCategory: - 'spec/graphql/types/project_statistics_type_spec.rb' - 'spec/graphql/types/project_type_spec.rb' - 'spec/graphql/types/projects/base_service_type_spec.rb' - - 'spec/graphql/types/projects/branch_rule_type_spec.rb' - 'spec/graphql/types/projects/jira_project_type_spec.rb' - 'spec/graphql/types/projects/jira_service_type_spec.rb' - 'spec/graphql/types/projects/repository_language_type_spec.rb' @@ -2526,7 +2503,6 @@ RSpec/MissingFeatureCategory: - 'spec/helpers/enable_search_settings_helper_spec.rb' - 'spec/helpers/environment_helper_spec.rb' - 'spec/helpers/environments_helper_spec.rb' - - 'spec/helpers/events_helper_spec.rb' - 'spec/helpers/explore_helper_spec.rb' - 'spec/helpers/export_helper_spec.rb' - 'spec/helpers/external_link_helper_spec.rb' @@ -2767,7 +2743,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/bulk_imports/common/extractors/json_extractor_spec.rb' - 'spec/lib/bulk_imports/common/extractors/ndjson_extractor_spec.rb' - 'spec/lib/bulk_imports/common/extractors/rest_extractor_spec.rb' - - 'spec/lib/bulk_imports/common/graphql/get_members_query_spec.rb' - 'spec/lib/bulk_imports/common/pipelines/badges_pipeline_spec.rb' - 'spec/lib/bulk_imports/common/pipelines/entity_finisher_spec.rb' - 'spec/lib/bulk_imports/common/pipelines/lfs_objects_pipeline_spec.rb' @@ -2824,8 +2799,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/container_registry/path_spec.rb' - 'spec/lib/container_registry/registry_spec.rb' - 'spec/lib/container_registry/tag_spec.rb' - - 'spec/lib/csv_builder_spec.rb' - - 'spec/lib/csv_builders/stream_spec.rb' - 'spec/lib/declarative_enum_spec.rb' - 'spec/lib/error_tracking/sentry_client/api_urls_spec.rb' - 'spec/lib/error_tracking/sentry_client/event_spec.rb' @@ -3350,7 +3323,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/conflict/file_spec.rb' - 'spec/lib/gitlab/consul/internal_spec.rb' - 'spec/lib/gitlab/container_repository/tags/cache_spec.rb' - - 'spec/lib/gitlab/content_security_policy/config_loader_spec.rb' - 'spec/lib/gitlab/counters/buffered_counter_spec.rb' - 'spec/lib/gitlab/counters/legacy_counter_spec.rb' - 'spec/lib/gitlab/cross_project_access/check_collection_spec.rb' @@ -4042,7 +4014,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/nav/top_nav_menu_header_spec.rb' - 'spec/lib/gitlab/no_cache_headers_spec.rb' - 'spec/lib/gitlab/noteable_metadata_spec.rb' - - 'spec/lib/gitlab/null_request_store_spec.rb' - 'spec/lib/gitlab/object_hierarchy_spec.rb' - 'spec/lib/gitlab/omniauth_initializer_spec.rb' - 'spec/lib/gitlab/optimistic_locking_spec.rb' @@ -4162,7 +4133,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/saas_spec.rb' - 'spec/lib/gitlab/safe_request_loader_spec.rb' - 'spec/lib/gitlab/safe_request_purger_spec.rb' - - 'spec/lib/gitlab/safe_request_store_spec.rb' - 'spec/lib/gitlab/sample_data_template_spec.rb' - 'spec/lib/gitlab/sanitizers/exif_spec.rb' - 'spec/lib/gitlab/sanitizers/svg_spec.rb' @@ -4337,10 +4307,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/usage/metrics/instrumentations/uuid_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/work_items_activity_aggregated_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/key_path_processor_spec.rb' - - 'spec/lib/gitlab/usage/metrics/name_suggestion_spec.rb' - - 'spec/lib/gitlab/usage/metrics/names_suggestions/relation_parsers/having_constraints_spec.rb' - - 'spec/lib/gitlab/usage/metrics/names_suggestions/relation_parsers/joins_spec.rb' - - 'spec/lib/gitlab/usage/metrics/names_suggestions/relation_parsers/where_constraints_spec.rb' - 'spec/lib/gitlab/usage/metrics/query_spec.rb' - 'spec/lib/gitlab/usage/service_ping/instrumented_payload_spec.rb' - 'spec/lib/gitlab/usage/service_ping/payload_keys_processor_spec.rb' @@ -4419,7 +4385,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/webpack/manifest_spec.rb' - 'spec/lib/gitlab/wiki_file_finder_spec.rb' - 'spec/lib/gitlab/wiki_pages/front_matter_parser_spec.rb' - - 'spec/lib/gitlab/with_request_store_spec.rb' - 'spec/lib/gitlab/word_diff/chunk_collection_spec.rb' - 'spec/lib/gitlab/word_diff/line_processor_spec.rb' - 'spec/lib/gitlab/word_diff/parser_spec.rb' diff --git a/.rubocop_todo/rspec/verified_doubles.yml b/.rubocop_todo/rspec/verified_doubles.yml index 0d66bf5604b..6f2e884fc55 100644 --- a/.rubocop_todo/rspec/verified_doubles.yml +++ b/.rubocop_todo/rspec/verified_doubles.yml @@ -353,8 +353,6 @@ RSpec/VerifiedDoubles: - 'spec/lib/constraints/jira_encoded_url_constrainer_spec.rb' - 'spec/lib/constraints/project_url_constrainer_spec.rb' - 'spec/lib/constraints/user_url_constrainer_spec.rb' - - 'spec/lib/csv_builder_spec.rb' - - 'spec/lib/csv_builders/stream_spec.rb' - 'spec/lib/extracts_path_spec.rb' - 'spec/lib/feature_spec.rb' - 'spec/lib/gitaly/server_spec.rb' diff --git a/.rubocop_todo/style/empty_method.yml b/.rubocop_todo/style/empty_method.yml index 723a3adf412..094abdded79 100644 --- a/.rubocop_todo/style/empty_method.yml +++ b/.rubocop_todo/style/empty_method.yml @@ -120,7 +120,6 @@ Style/EmptyMethod: - 'lib/gitlab/git_access.rb' - 'lib/gitlab/import_export/json/ndjson_writer.rb' - 'lib/gitlab/mailgun/webhook_processors/base.rb' - - 'lib/gitlab/null_request_store.rb' - 'lib/gitlab/usage_data_non_sql_metrics.rb' - 'lib/mattermost/session.rb' - 'qa/qa/resource/clusters/agent.rb' diff --git a/.rubocop_todo/style/format_string.yml b/.rubocop_todo/style/format_string.yml index a45c6b39c25..c128f96eafe 100644 --- a/.rubocop_todo/style/format_string.yml +++ b/.rubocop_todo/style/format_string.yml @@ -291,7 +291,6 @@ Style/FormatString: - 'lib/gitlab/quick_actions/issue_and_merge_request_actions.rb' - 'lib/gitlab/quick_actions/merge_request_actions.rb' - 'lib/gitlab/quick_actions/relate_actions.rb' - - 'lib/gitlab/usage/metrics/name_suggestion.rb' - 'lib/gitlab/version_info.rb' - 'lib/peek/views/detailed_view.rb' - 'lib/tasks/test.rake' diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index a1f516a8abe..872282a6a93 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -905,7 +905,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/sanitizers/svg.rb' - 'lib/gitlab/search/params.rb' - 'lib/gitlab/search_context.rb' - - 'lib/gitlab/search_results.rb' - 'lib/gitlab/sidekiq_config.rb' - 'lib/gitlab/sidekiq_config/cli_methods.rb' - 'lib/gitlab/sidekiq_config/worker_router.rb' diff --git a/.rubocop_todo/style/missing_respond_to_missing.yml b/.rubocop_todo/style/missing_respond_to_missing.yml index 9387ae72d00..4c61c7fc1a6 100644 --- a/.rubocop_todo/style/missing_respond_to_missing.yml +++ b/.rubocop_todo/style/missing_respond_to_missing.yml @@ -5,7 +5,6 @@ Style/MissingRespondToMissing: - 'app/models/network/commit.rb' - 'app/services/notification_service.rb' - 'ee/app/controllers/ee/groups/application_controller.rb' - - 'ee/app/models/elastic/migration_record.rb' - 'ee/app/services/ee/audit_event_service.rb' - 'lib/declarative_enum.rb' - 'lib/gitlab/auth/ldap/dn.rb' diff --git a/.rubocop_todo/style/mutable_constant.yml b/.rubocop_todo/style/mutable_constant.yml index a86662db014..f7a82be400a 100644 --- a/.rubocop_todo/style/mutable_constant.yml +++ b/.rubocop_todo/style/mutable_constant.yml @@ -34,7 +34,6 @@ Style/MutableConstant: - 'lib/gitlab/git/lfs_pointer_file.rb' - 'lib/gitlab/issues/rebalancing/state.rb' - 'lib/gitlab/lfs/client.rb' - - 'lib/gitlab/search_results.rb' - 'lib/gitlab/seeder.rb' - 'lib/gitlab/sidekiq_signals.rb' - 'lib/gitlab/web_hooks/recursion_detection/uuid.rb' diff --git a/.rubocop_todo/style/percent_literal_delimiters.yml b/.rubocop_todo/style/percent_literal_delimiters.yml index bb29652fe96..aee5872a343 100644 --- a/.rubocop_todo/style/percent_literal_delimiters.yml +++ b/.rubocop_todo/style/percent_literal_delimiters.yml @@ -505,6 +505,7 @@ Style/PercentLiteralDelimiters: - 'lib/gitlab/query_limiting/transaction.rb' - 'lib/gitlab/reference_extractor.rb' - 'lib/gitlab/regex.rb' + - 'lib/gitlab/regex/bulk_imports.rb' - 'lib/gitlab/sanitizers/exception_message.rb' - 'lib/gitlab/sanitizers/exif.rb' - 'lib/gitlab/search/abuse_detection.rb' @@ -929,8 +930,8 @@ Style/PercentLiteralDelimiters: - 'spec/presenters/ci/pipeline_artifacts/code_quality_mr_diff_presenter_spec.rb' - 'spec/presenters/packages/nuget/packages_metadata_presenter_spec.rb' - 'spec/presenters/packages/nuget/search_results_presenter_spec.rb' + - 'spec/requests/api/admin/broadcast_messages_spec.rb' - 'spec/requests/api/badges_spec.rb' - - 'spec/requests/api/broadcast_messages_spec.rb' - 'spec/requests/api/ci/jobs_spec.rb' - 'spec/requests/api/ci/pipelines_spec.rb' - 'spec/requests/api/ci/runner/jobs_request_post_spec.rb' diff --git a/.rubocop_todo/style/redundant_freeze.yml b/.rubocop_todo/style/redundant_freeze.yml index 0877c752827..12126c58313 100644 --- a/.rubocop_todo/style/redundant_freeze.yml +++ b/.rubocop_todo/style/redundant_freeze.yml @@ -55,29 +55,6 @@ Style/RedundantFreeze: - 'app/validators/certificate_fingerprint_validator.rb' - 'app/validators/json_schema_validator.rb' - 'app/validators/line_code_validator.rb' - - 'ee/app/finders/concerns/epics/findable.rb' - - 'ee/app/finders/ee/analytics/cycle_analytics/stage_finder.rb' - - 'ee/app/finders/epics_finder.rb' - - 'ee/app/graphql/mutations/incident_management/oncall_rotation/base.rb' - - 'ee/app/graphql/types/incident_management/oncall_rotation_date_input_type.rb' - - 'ee/app/models/allowed_email_domain.rb' - - 'ee/app/models/ee/issue.rb' - - 'ee/app/models/ee/label.rb' - - 'ee/app/models/ee/project_import_state.rb' - - 'ee/app/models/ee/vulnerability.rb' - - 'ee/app/models/iteration.rb' - - 'ee/app/models/status_page/project_setting.rb' - - 'ee/app/serializers/analytics/cycle_analytics/value_stream_errors_serializer.rb' - - 'ee/app/services/elastic/data_migration_service.rb' - - 'ee/app/services/incident_management/issuable_resource_links/create_service.rb' - - 'ee/app/services/projects/restore_service.rb' - - 'ee/lib/ee/gitlab/path_regex.rb' - - 'ee/lib/ee/gitlab/web_hooks/rate_limiter.rb' - - 'ee/lib/elastic/latest/git_class_proxy.rb' - - 'ee/lib/gitlab/code_owners/reference_extractor.rb' - - 'ee/lib/gitlab/status_page/filter/image_filter.rb' - - 'ee/lib/system_check/geo/authorized_keys_check.rb' - - 'haml_lint/linter/documentation_links.rb' - 'lib/api/api.rb' - 'lib/api/concerns/packages/nuget_endpoints.rb' - 'lib/api/debian_group_packages.rb' @@ -102,7 +79,6 @@ Style/RedundantFreeze: - 'lib/banzai/filter/task_list_filter.rb' - 'lib/bulk_imports/common/pipelines/uploads_pipeline.rb' - 'lib/bulk_imports/file_downloads/filename_fetch.rb' - - 'lib/csv_builder.rb' - 'lib/error_tracking/sentry_client/pagination_parser.rb' - 'lib/expand_variables.rb' - 'lib/feature/definition.rb' @@ -187,6 +163,7 @@ Style/RedundantFreeze: - 'lib/gitlab/rack_attack/request.rb' - 'lib/gitlab/redis/hll.rb' - 'lib/gitlab/regex.rb' + - 'lib/gitlab/regex/packages.rb' - 'lib/gitlab/robots_txt/parser.rb' - 'lib/gitlab/saas.rb' - 'lib/gitlab/sanitizers/exception_message.rb' @@ -211,4 +188,3 @@ Style/RedundantFreeze: - 'lib/gitlab/x509/certificate.rb' - 'lib/gitlab/zoom_link_extractor.rb' - 'lib/sbom/package_url/argument_validator.rb' - - 'lib/tasks/gitlab/db/decomposition/rollback/bump_ci_sequences.rake' diff --git a/.rubocop_todo/style/redundant_interpolation.yml b/.rubocop_todo/style/redundant_interpolation.yml index 27cd954f506..aa3efe18d50 100644 --- a/.rubocop_todo/style/redundant_interpolation.yml +++ b/.rubocop_todo/style/redundant_interpolation.yml @@ -17,7 +17,6 @@ Style/RedundantInterpolation: - 'lib/gitlab/repository_cache_adapter.rb' - 'lib/gitlab/repository_hash_cache.rb' - 'lib/gitlab/repository_set_cache.rb' - - 'lib/gitlab/usage/metrics/names_suggestions/relation_parsers/joins.rb' - 'lib/gitlab/usage_data_counters/search_counter.rb' - 'lib/gitlab/utils.rb' - 'lib/kramdown/converter/commonmark.rb' diff --git a/.rubocop_todo/style/redundant_regexp_escape.yml b/.rubocop_todo/style/redundant_regexp_escape.yml index b1ab72bac61..93aab692379 100644 --- a/.rubocop_todo/style/redundant_regexp_escape.yml +++ b/.rubocop_todo/style/redundant_regexp_escape.yml @@ -48,7 +48,6 @@ Style/RedundantRegexpEscape: - 'lib/banzai/filter/inline_diff_filter.rb' - 'lib/banzai/filter/task_list_filter.rb' - 'lib/bulk_imports/common/pipelines/uploads_pipeline.rb' - - 'lib/csv_builder.rb' - 'lib/gitlab/background_migration/backfill_integrations_enable_ssl_verification.rb' - 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb' - 'lib/gitlab/ci/pipeline/expression/lexeme/not_matches.rb' @@ -70,6 +69,7 @@ Style/RedundantRegexpEscape: - 'lib/gitlab/quick_actions/extractor.rb' - 'lib/gitlab/quick_actions/timeline_text_and_date_time_separator.rb' - 'lib/gitlab/regex.rb' + - 'lib/gitlab/regex/packages.rb' - 'lib/gitlab/search/abuse_detection.rb' - 'lib/gitlab/task_helpers.rb' - 'lib/gitlab/url_sanitizer.rb' diff --git a/.rubocop_todo/style/string_concatenation.yml b/.rubocop_todo/style/string_concatenation.yml index a83c0f4d943..ba88524e16d 100644 --- a/.rubocop_todo/style/string_concatenation.yml +++ b/.rubocop_todo/style/string_concatenation.yml @@ -162,7 +162,6 @@ Style/StringConcatenation: - 'spec/graphql/mutations/issues/create_spec.rb' - 'spec/helpers/application_helper_spec.rb' - 'spec/helpers/diff_helper_spec.rb' - - 'spec/helpers/events_helper_spec.rb' - 'spec/helpers/search_helper_spec.rb' - 'spec/lib/api/helpers/related_resources_helpers_spec.rb' - 'spec/lib/backup/gitaly_backup_spec.rb' diff --git a/.rubocop_todo/style/symbol_proc.yml b/.rubocop_todo/style/symbol_proc.yml index 67229a8b704..a8f966d2266 100644 --- a/.rubocop_todo/style/symbol_proc.yml +++ b/.rubocop_todo/style/symbol_proc.yml @@ -13,7 +13,6 @@ Style/SymbolProc: - 'app/models/members/project_member.rb' - 'app/models/namespace.rb' - 'app/models/preloaders/merge_request_diff_preloader.rb' - - 'app/models/project_team.rb' - 'app/models/release.rb' - 'app/models/remote_mirror.rb' - 'app/models/snippet_input_action_collection.rb' |