diff options
Diffstat (limited to 'app/helpers/todos_helper.rb')
| -rw-r--r-- | app/helpers/todos_helper.rb | 14 |
1 files changed, 9 insertions, 5 deletions
diff --git a/app/helpers/todos_helper.rb b/app/helpers/todos_helper.rb index 41f39c7e798..2b4f2f11d1e 100644 --- a/app/helpers/todos_helper.rb +++ b/app/helpers/todos_helper.rb @@ -37,11 +37,12 @@ module TodosHelper end def todo_target_title(todo) - if todo.target - "\"#{todo.target.title}\"" - else - "" - end + # Design To Dos' filenames are displayed in `#todo_target_link` (see `Design#to_reference`), + # so to avoid displaying duplicate filenames in the To Do list for designs, + # we return an empty string here. + return "" if todo.target.blank? || todo.for_design? + + "\"#{todo.target.title}\"" end def todo_parent_path(todo) @@ -54,6 +55,7 @@ module TodosHelper def todo_target_type_name(todo) return _('design') if todo.for_design? + return _('alert') if todo.for_alert? todo.target_type.titleize.downcase end @@ -67,6 +69,8 @@ module TodosHelper project_commit_path(todo.project, todo.target, path_options) elsif todo.for_design? todos_design_path(todo, path_options) + elsif todo.for_alert? + details_project_alert_management_path(todo.project, todo.target) else path = [todo.resource_parent, todo.target] |