Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
Diffstat (limited to 'app/services/boards/lists/move_service.rb')
-rw-r--r--app/services/boards/lists/move_service.rb7
1 files changed, 5 insertions, 2 deletions
diff --git a/app/services/boards/lists/move_service.rb b/app/services/boards/lists/move_service.rb
index 4bb7b4dbc6d..4715f1276e3 100644
--- a/app/services/boards/lists/move_service.rb
+++ b/app/services/boards/lists/move_service.rb
@@ -22,8 +22,11 @@ module Boards
attr_reader :board, :old_position, :new_position
def valid_move?
- new_position.present? && new_position != old_position &&
- new_position >= 0 && new_position <= board.lists.movable.last.position
+ new_position.present? && new_position != old_position && new_position.between?(0, max_position)
+ end
+
+ def max_position
+ board.lists.movable.maximum(:position)
end
def reorder_intermediate_lists