diff options
Diffstat (limited to 'app/services/discussions')
-rw-r--r-- | app/services/discussions/capture_diff_note_position_service.rb | 4 | ||||
-rw-r--r-- | app/services/discussions/resolve_service.rb | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/app/services/discussions/capture_diff_note_position_service.rb b/app/services/discussions/capture_diff_note_position_service.rb index 8f12470d9e8..4e8fd90a2e7 100644 --- a/app/services/discussions/capture_diff_note_position_service.rb +++ b/app/services/discussions/capture_diff_note_position_service.rb @@ -50,9 +50,9 @@ module Discussions merge_ref_head = merge_request.merge_ref_head return unless merge_ref_head - start_sha, base_sha = merge_ref_head.parent_ids + start_sha, _ = merge_ref_head.parent_ids new_diff_refs = Gitlab::Diff::DiffRefs.new( - base_sha: base_sha, + base_sha: start_sha, start_sha: start_sha, head_sha: merge_ref_head.id) diff --git a/app/services/discussions/resolve_service.rb b/app/services/discussions/resolve_service.rb index 946fb5f1372..cd5925cd9be 100644 --- a/app/services/discussions/resolve_service.rb +++ b/app/services/discussions/resolve_service.rb @@ -56,7 +56,7 @@ module Discussions def process_auto_merge return unless merge_request - return unless @resolved_count.positive? + return unless @resolved_count > 0 return unless discussions_ready_to_merge? AutoMergeProcessWorker.perform_async(merge_request.id) |