1 files changed, 11 insertions, 104 deletions

diff --git a/app/services/packages/nuget/metadata_extraction_service.rb b/app/services/packages/nuget/metadata_extraction_service.rb
index 5c60a2912ae..e1ee29ef2c6 100644
--- a/app/services/packages/nuget/metadata_extraction_service.rb
+++ b/app/services/packages/nuget/metadata_extraction_service.rb
@@ -3,123 +3,30 @@
 module Packages
   module Nuget
     class MetadataExtractionService
-      include Gitlab::Utils::StrongMemoize
-
-      ExtractionError = Class.new(StandardError)
-
-      ROOT_XPATH = '//xmlns:package/xmlns:metadata/xmlns'
-
-      XPATHS = {
-        package_name: "#{ROOT_XPATH}:id",
-        package_version: "#{ROOT_XPATH}:version",
-        authors: "#{ROOT_XPATH}:authors",
-        description: "#{ROOT_XPATH}:description",
-        license_url: "#{ROOT_XPATH}:licenseUrl",
-        project_url: "#{ROOT_XPATH}:projectUrl",
-        icon_url: "#{ROOT_XPATH}:iconUrl"
-      }.freeze
-
-      XPATH_DEPENDENCIES = "#{ROOT_XPATH}:dependencies/xmlns:dependency".freeze
-      XPATH_DEPENDENCY_GROUPS = "#{ROOT_XPATH}:dependencies/xmlns:group".freeze
-      XPATH_TAGS = "#{ROOT_XPATH}:tags".freeze
-      XPATH_PACKAGE_TYPES = "#{ROOT_XPATH}:packageTypes/xmlns:packageType".freeze
-
-      MAX_FILE_SIZE = 4.megabytes.freeze
-
       def initialize(package_file_id)
         @package_file_id = package_file_id
       end
 
       def execute
-        raise ExtractionError, 'invalid package file' unless valid_package_file?
-
-        extract_metadata(nuspec_file_content)
+        ServiceResponse.success(payload: metadata)
       end
 
       private
 
-      def package_file
-        ::Packages::PackageFile.find_by_id(@package_file_id)
-      end
-      strong_memoize_attr :package_file
-
-      def valid_package_file?
-        package_file &&
-          package_file.package&.nuget? &&
-          package_file.file.size > 0 # rubocop:disable Style/ZeroLengthPredicate
-      end
-
-      def extract_metadata(file)
-        doc = Nokogiri::XML(file)
-
-        XPATHS.transform_values { |query| doc.xpath(query).text.presence }
-              .compact
-              .tap do |metadata|
-                metadata[:package_dependencies] = extract_dependencies(doc)
-                metadata[:package_tags] = extract_tags(doc)
-                metadata[:package_types] = extract_package_types(doc)
-              end
-      end
-
-      def extract_dependencies(doc)
-        dependencies = []
-
-        doc.xpath(XPATH_DEPENDENCIES).each do |node|
-          dependencies << extract_dependency(node)
-        end
-
-        doc.xpath(XPATH_DEPENDENCY_GROUPS).each do |group_node|
-          target_framework = group_node.attr("targetFramework")
-
-          group_node.xpath("xmlns:dependency").each do |node|
-            dependencies << extract_dependency(node).merge(target_framework: target_framework)
-          end
-        end
-
-        dependencies
-      end
-
-      def extract_dependency(node)
-        {
-          name: node.attr('id'),
-          version: node.attr('version')
-        }.compact
-      end
-
-      def extract_package_types(doc)
-        doc.xpath(XPATH_PACKAGE_TYPES).map { |node| node.attr('name') }.uniq
-      end
-
-      def extract_tags(doc)
-        tags = doc.xpath(XPATH_TAGS).text
-
-        return [] if tags.blank?
-
-        tags.split(::Packages::Tag::NUGET_TAGS_SEPARATOR)
-      end
+      attr_reader :package_file_id
 
       def nuspec_file_content
-        with_zip_file do |zip_file|
-          entry = zip_file.glob('*.nuspec').first
-
-          raise ExtractionError, 'nuspec file not found' unless entry
-          raise ExtractionError, 'nuspec file too big' if MAX_FILE_SIZE < entry.size
-
-          Tempfile.open("nuget_extraction_package_file_#{@package_file_id}") do |file|
-            entry.extract(file.path) { true } # allow #extract to overwrite the file
-            file.unlink
-            file.read
-          end
-        rescue Zip::EntrySizeError => e
-          raise ExtractionError, "nuspec file has the wrong entry size: #{e.message}"
-        end
+        ExtractMetadataFileService
+          .new(package_file_id)
+          .execute
+          .payload
       end
 
-      def with_zip_file(&block)
-        package_file.file.use_open_file do |open_file|
-          zip_file = Zip::File.new(open_file, false, true)
-          yield(zip_file)
-        end
+      def metadata
+        ExtractMetadataContentService
+          .new(nuspec_file_content)
+          .execute
+          .payload
       end
     end
   end