diff options
Diffstat (limited to 'app')
12 files changed, 31 insertions, 19 deletions
diff --git a/app/assets/javascripts/self_monitor/components/self_monitor_form.vue b/app/assets/javascripts/self_monitor/components/self_monitor_form.vue index b14e816a674..ffba3aac681 100644 --- a/app/assets/javascripts/self_monitor/components/self_monitor_form.vue +++ b/app/assets/javascripts/self_monitor/components/self_monitor_form.vue @@ -29,7 +29,7 @@ export default { SafeHtml: GlSafeHtmlDirective, }, formLabels: { - createProject: __('Self monitoring'), + createProject: __('Self-monitoring'), }, data() { return { @@ -60,7 +60,7 @@ export default { if (this.projectCreated) { return sprintf( s__( - 'SelfMonitoring|Self monitoring is active. Use the %{projectLinkStart}self monitoring project%{projectLinkEnd} to monitor the health of your instance.', + 'SelfMonitoring|Self-monitoring is active. Use the %{projectLinkStart}self-monitoring project%{projectLinkEnd} to monitor the health of your instance.', ), { projectLinkStart: `<a href="${this.selfMonitorProjectFullUrl}">`, @@ -71,7 +71,7 @@ export default { } return s__( - 'SelfMonitoring|Activate self monitoring to create a project to use to monitor the health of your instance.', + 'SelfMonitoring|Activate self-monitoring to create a project to use to monitor the health of your instance.', ); }, helpDocsPath() { @@ -139,11 +139,11 @@ export default { <h4 class="js-section-header settings-title js-settings-toggle js-settings-toggle-trigger-only" > - {{ s__('SelfMonitoring|Self monitoring') }} + {{ s__('SelfMonitoring|Self-monitoring') }} </h4> <gl-button class="js-settings-toggle">{{ __('Expand') }}</gl-button> <p class="js-section-sub-header"> - {{ s__('SelfMonitoring|Activate or deactivate instance self monitoring.') }} + {{ s__('SelfMonitoring|Activate or deactivate instance self-monitoring.') }} <gl-link :href="helpDocsPath">{{ __('Learn more.') }}</gl-link> </p> </div> @@ -160,9 +160,9 @@ export default { </form> </div> <gl-modal - :title="s__('SelfMonitoring|Deactivate self monitoring?')" + :title="s__('SelfMonitoring|Deactivate self-monitoring?')" :modal-id="modalId" - :ok-title="__('Delete self monitoring project')" + :ok-title="__('Delete self-monitoring project')" :cancel-title="__('Cancel')" ok-variant="danger" category="primary" @@ -172,7 +172,7 @@ export default { <div> {{ s__( - 'SelfMonitoring|Deactivating self monitoring deletes the self monitoring project. Are you sure you want to deactivate self monitoring and delete the project?', + 'SelfMonitoring|Deactivating self-monitoring deletes the self-monitoring project. Are you sure you want to deactivate self-monitoring and delete the project?', ) }} </div> diff --git a/app/assets/javascripts/self_monitor/store/actions.js b/app/assets/javascripts/self_monitor/store/actions.js index f37b654b00a..5b9e994290c 100644 --- a/app/assets/javascripts/self_monitor/store/actions.js +++ b/app/assets/javascripts/self_monitor/store/actions.js @@ -56,7 +56,7 @@ export const requestCreateProjectSuccess = ({ commit, dispatch }, selfMonitorDat commit(types.SET_LOADING, false); commit(types.SET_PROJECT_URL, selfMonitorData.project_full_path); commit(types.SET_ALERT_CONTENT, { - message: s__('SelfMonitoring|Self monitoring project successfully created.'), + message: s__('SelfMonitoring|Self-monitoring project successfully created.'), actionText: __('View project'), actionName: 'viewSelfMonitorProject', }); @@ -108,7 +108,7 @@ export const requestDeleteProjectSuccess = ({ commit }) => { commit(types.SET_PROJECT_URL, ''); commit(types.SET_PROJECT_CREATED, false); commit(types.SET_ALERT_CONTENT, { - message: s__('SelfMonitoring|Self monitoring project successfully deleted.'), + message: s__('SelfMonitoring|Self-monitoring project successfully deleted.'), actionText: __('Undo'), actionName: 'createProject', }); diff --git a/app/assets/javascripts/vue_shared/alert_details/components/alert_details.vue b/app/assets/javascripts/vue_shared/alert_details/components/alert_details.vue index f2ea55df63d..9a734a12a46 100644 --- a/app/assets/javascripts/vue_shared/alert_details/components/alert_details.vue +++ b/app/assets/javascripts/vue_shared/alert_details/components/alert_details.vue @@ -149,7 +149,9 @@ export default { }, set(tabIdx) { const tabId = this.$options.tabsConfig[tabIdx].id; - this.$router.replace({ name: 'tab', params: { tabId } }); + if (this.$route.params?.tabId !== tabId) { + this.$router.push({ name: 'tab', params: { tabId } }); + } }, }, environmentName() { diff --git a/app/assets/javascripts/vue_shared/alert_details/index.js b/app/assets/javascripts/vue_shared/alert_details/index.js index 5793069440c..357dfa49901 100644 --- a/app/assets/javascripts/vue_shared/alert_details/index.js +++ b/app/assets/javascripts/vue_shared/alert_details/index.js @@ -15,9 +15,17 @@ Vue.use(VueApollo); export default (selector) => { const domEl = document.querySelector(selector); - const { alertId, projectPath, projectIssuesPath, projectId, page, canUpdate } = domEl.dataset; + const { + alertId, + projectPath, + projectIssuesPath, + projectAlertManagementDetailsPath, + projectId, + page, + canUpdate, + } = domEl.dataset; const iid = alertId; - const router = createRouter(); + const router = createRouter(projectAlertManagementDetailsPath); const resolvers = { Mutation: { diff --git a/app/assets/javascripts/vue_shared/alert_details/router.js b/app/assets/javascripts/vue_shared/alert_details/router.js index 5687fe4e0f5..616d5c259b9 100644 --- a/app/assets/javascripts/vue_shared/alert_details/router.js +++ b/app/assets/javascripts/vue_shared/alert_details/router.js @@ -6,7 +6,7 @@ Vue.use(VueRouter); export default function createRouter(base) { return new VueRouter({ - mode: 'hash', + mode: 'history', base: joinPaths(gon.relative_url_root || '', base), routes: [{ path: '/:tabId', name: 'tab' }], }); diff --git a/app/helpers/projects/alert_management_helper.rb b/app/helpers/projects/alert_management_helper.rb index f21538fd3fb..50c7db683c6 100644 --- a/app/helpers/projects/alert_management_helper.rb +++ b/app/helpers/projects/alert_management_helper.rb @@ -21,6 +21,7 @@ module Projects::AlertManagementHelper 'project-path' => project.full_path, 'project-id' => project.id, 'project-issues-path' => project_issues_path(project), + 'project-alert-management-details-path' => details_project_alert_management_path(project, alert_id), 'page' => 'OPERATIONS', 'can-update' => can?(current_user, :update_alert_management_alert, project).to_s } diff --git a/app/models/ci/pipeline.rb b/app/models/ci/pipeline.rb index 950e0a583bc..84ccc4b54a8 100644 --- a/app/models/ci/pipeline.rb +++ b/app/models/ci/pipeline.rb @@ -121,7 +121,7 @@ module Ci accepts_nested_attributes_for :variables, reject_if: :persisted? delegate :full_path, to: :project, prefix: true - delegate :title, to: :pipeline_metadata, allow_nil: true + delegate :name, to: :pipeline_metadata, allow_nil: true validates :sha, presence: { unless: :importing? } validates :ref, presence: { unless: :importing? } diff --git a/app/models/ci/pipeline_metadata.rb b/app/models/ci/pipeline_metadata.rb index c96b395b45f..2bd206c5ca5 100644 --- a/app/models/ci/pipeline_metadata.rb +++ b/app/models/ci/pipeline_metadata.rb @@ -9,6 +9,6 @@ module Ci validates :pipeline, presence: true validates :project, presence: true - validates :title, presence: true, length: { minimum: 1, maximum: 255 } + validates :name, presence: true, length: { minimum: 1, maximum: 255 } end end diff --git a/app/presenters/ci/pipeline_presenter.rb b/app/presenters/ci/pipeline_presenter.rb index fed4ae7837b..5cdc6ff12cb 100644 --- a/app/presenters/ci/pipeline_presenter.rb +++ b/app/presenters/ci/pipeline_presenter.rb @@ -53,6 +53,7 @@ module Ci }.freeze end + delegator_override :name def name # Currently, `merge_request_event_type` is the only source to name pipelines # but this could be extended with the other types in the future. diff --git a/app/services/google_cloud/generate_pipeline_service.rb b/app/services/google_cloud/generate_pipeline_service.rb index be0c7a783c9..610ff47ef2a 100644 --- a/app/services/google_cloud/generate_pipeline_service.rb +++ b/app/services/google_cloud/generate_pipeline_service.rb @@ -73,7 +73,7 @@ module GoogleCloud includes << { 'remote' => include_url } gitlab_ci_yml['include'] = includes.uniq - gitlab_ci_yml.to_yaml + gitlab_ci_yml.deep_stringify_keys.to_yaml end end end diff --git a/app/services/metrics/dashboard/self_monitoring_dashboard_service.rb b/app/services/metrics/dashboard/self_monitoring_dashboard_service.rb index 0651e569d07..62264281a02 100644 --- a/app/services/metrics/dashboard/self_monitoring_dashboard_service.rb +++ b/app/services/metrics/dashboard/self_monitoring_dashboard_service.rb @@ -1,6 +1,6 @@ # frozen_string_literal: true -# Fetches the self monitoring metrics dashboard and formats the output. +# Fetches the self-monitoring metrics dashboard and formats the output. # Use Gitlab::Metrics::Dashboard::Finder to retrieve dashboards. module Metrics module Dashboard diff --git a/app/views/admin/application_settings/_repository_check.html.haml b/app/views/admin/application_settings/_repository_check.html.haml index ef8d3ccc8ab..fae8f82783a 100644 --- a/app/views/admin/application_settings/_repository_check.html.haml +++ b/app/views/admin/application_settings/_repository_check.html.haml @@ -18,7 +18,7 @@ .sub-section %h4= _("Housekeeping") .form-group - - help_text = _("Leaving this setting enabled is recommended.") + - help_text = _("Run housekeeping tasks to automatically optimize Git repositories. Disabling this option will cause performance to degenerate over time.") - help_link = link_to s_('Learn more.'), help_page_path('administration/housekeeping.md', anchor: 'housekeeping-options'), target: '_blank', rel: 'noopener noreferrer' = f.gitlab_ui_checkbox_component :housekeeping_enabled, _("Enable automatic repository housekeeping"), |