diff options
Diffstat (limited to 'danger/changelog/Dangerfile')
-rw-r--r-- | danger/changelog/Dangerfile | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/danger/changelog/Dangerfile b/danger/changelog/Dangerfile index c8474157fa5..444303d4b9e 100644 --- a/danger/changelog/Dangerfile +++ b/danger/changelog/Dangerfile @@ -17,8 +17,8 @@ def check_changelog_yaml(path) raw_file = File.read(path) yaml = YAML.safe_load(raw_file) - fail "`title` should be set, in #{gitlab.html_link(path)}! #{SEE_DOC}" if yaml["title"].nil? - fail "`type` should be set, in #{gitlab.html_link(path)}! #{SEE_DOC}" if yaml["type"].nil? + fail "`title` should be set, in #{helper.html_link(path)}! #{SEE_DOC}" if yaml["title"].nil? + fail "`type` should be set, in #{helper.html_link(path)}! #{SEE_DOC}" if yaml["type"].nil? return if helper.security_mr? @@ -30,23 +30,23 @@ def check_changelog_yaml(path) if mr_line markdown(format(SUGGEST_MR_COMMENT, mr_iid: gitlab.mr_json["iid"]), file: path, line: mr_line.succ) else - message "Consider setting `merge_request` to #{gitlab.mr_json["iid"]} in #{gitlab.html_link(path)}. #{SEE_DOC}" + message "Consider setting `merge_request` to #{gitlab.mr_json["iid"]} in #{helper.html_link(path)}. #{SEE_DOC}" end elsif yaml["merge_request"] != gitlab.mr_json["iid"] && !cherry_pick_against_stable_branch fail "Merge request ID was not set to #{gitlab.mr_json["iid"]}! #{SEE_DOC}" end rescue Psych::Exception # YAML could not be parsed, fail the build. - fail "#{gitlab.html_link(path)} isn't valid YAML! #{SEE_DOC}" + fail "#{helper.html_link(path)} isn't valid YAML! #{SEE_DOC}" rescue StandardError => e warn "There was a problem trying to check the Changelog. Exception: #{e.class.name} - #{e.message}" end def check_changelog_path(path) - ee_changes = helper.all_ee_changes.dup + ee_changes = project_helper.all_ee_changes.dup ee_changes.delete(path) - if ee_changes.any? && !changelog.ee_changelog? && !changelog.db_changes? + if ee_changes.any? && !changelog.ee_changelog? && !changelog.required? warn "This MR has a Changelog file outside `ee/`, but code changes in `ee/`. Consider moving the Changelog file into `ee/`." end @@ -54,7 +54,7 @@ def check_changelog_path(path) warn "This MR has a Changelog file in `ee/`, but no code changes in `ee/`. Consider moving the Changelog file outside `ee/`." end - if ee_changes.any? && changelog.ee_changelog? && changelog.db_changes? + if ee_changes.any? && changelog.ee_changelog? && changelog.required_reasons.include?(:db_changes) warn "This MR has a Changelog file inside `ee/`, but there are database changes which [requires](https://docs.gitlab.com/ee/development/changelog.html#what-warrants-a-changelog-entry) the Changelog placement to be outside of `ee/`. Consider moving the Changelog file outside `ee/`." end end @@ -69,7 +69,7 @@ if changelog_found check_changelog_yaml(changelog_found) check_changelog_path(changelog_found) elsif changelog.required? - fail changelog.required_text + changelog.required_texts.each { |_, text| fail(text) } # rubocop:disable Lint/UnreachableLoop elsif changelog.optional? message changelog.optional_text end |