diff options
Diffstat (limited to 'doc/development/database_review.md')
| -rw-r--r-- | doc/development/database_review.md | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/doc/development/database_review.md b/doc/development/database_review.md index 76e9add215b..42021a5ae95 100644 --- a/doc/development/database_review.md +++ b/doc/development/database_review.md @@ -151,9 +151,7 @@ Include in the MR description: - Write the raw SQL in the MR description. Preferably formatted nicely with [pgFormatter](https://sqlformat.darold.net) or <https://paste.depesz.com> and using regular quotes -<!-- vale gitlab.NonStandardQuotes = NO --> - (for example, `"projects"."id"`) and avoiding smart quotes (for example, `“projects”.“id”`). -<!-- vale gitlab.NonStandardQuotes = YES --> + (for example, `"projects"."id"`) and avoiding smart quotes (for example, `"projects"."id"`). - In case of queries generated dynamically by using parameters, there should be one raw SQL query for each variation. For example, a finder for issues that may take as a parameter an optional filter on projects, @@ -244,7 +242,7 @@ Include in the MR description: - Manually trigger the [database testing](database/database_migration_pipeline.md) job (`db:gitlabcom-database-testing`) in the `test` stage. - If a single `update` is below than `1s` the query can be placed directly in a regular migration (inside `db/migrate`). - - Background migrations are normally used, but not limited to: + - Background migrations are usually used, but not limited to: - Migrating data in larger tables. - Making numerous SQL queries per record in a dataset. - Review queries (for example, make sure batch sizes are fine) |