diff options
Diffstat (limited to 'doc/development/jh_features_review.md')
| -rw-r--r-- | doc/development/jh_features_review.md | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/doc/development/jh_features_review.md b/doc/development/jh_features_review.md index 7e90d79c067..f4ed7070948 100644 --- a/doc/development/jh_features_review.md +++ b/doc/development/jh_features_review.md @@ -99,6 +99,20 @@ the relevant EE and JH modules by the name of the receiver module. If reviewing the corresponding JH file is needed, it should be found at [JH repository](https://jihulab.com/gitlab-cn/gitlab). +NOTE: +In some cases, JH does need to override something we don't need, and in that +case it is ok to also add `prepend_mod` for the modules. When we do this, +also add a comment mentioning it, and a link to the JH module using it. +This way we know where it's used and when we might not need it anymore, +and we do not remove them only because we're not using it, accidentally +breaking JH. An example of this: + +```ruby +# Added for JiHu +# Used in https://jihulab.com/gitlab-cn/gitlab/-/blob/main-jh/jh/lib/jh/api/integrations.rb +API::Integrations.prepend_mod +``` + ### General guidance for writing JH extensions See [Guidelines for implementing Enterprise Edition features](ee_features.md) |