Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
Diffstat (limited to 'rubocop/cop/performance/active_record_subtransaction_methods.rb')
-rw-r--r--rubocop/cop/performance/active_record_subtransaction_methods.rb29
1 files changed, 29 insertions, 0 deletions
diff --git a/rubocop/cop/performance/active_record_subtransaction_methods.rb b/rubocop/cop/performance/active_record_subtransaction_methods.rb
new file mode 100644
index 00000000000..3b89d3ab858
--- /dev/null
+++ b/rubocop/cop/performance/active_record_subtransaction_methods.rb
@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+module RuboCop
+ module Cop
+ module Performance
+ # Cop that disallows certain methods that rely on subtransactions in their implementation.
+ # Companion to Performance/ActiveRecordSubtransactions, which bans direct usage of subtransactions.
+ class ActiveRecordSubtransactionMethods < RuboCop::Cop::Cop
+ MSG = 'Methods that rely on subtransactions should not be used. ' \
+ 'For more information see: https://gitlab.com/gitlab-org/gitlab/-/issues/338346'
+
+ DISALLOWED_METHODS = %i[
+ safe_ensure_unique
+ safe_find_or_create_by
+ safe_find_or_create_by!
+ with_fast_read_statement_timeout
+ create_or_find_by
+ create_or_find_by!
+ ].to_set.freeze
+
+ def on_send(node)
+ return unless DISALLOWED_METHODS.include?(node.method_name)
+
+ add_offense(node, location: :selector)
+ end
+ end
+ end
+ end
+end