Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
Diffstat (limited to 'spec/controllers/projects/releases_controller_spec.rb')
-rw-r--r--spec/controllers/projects/releases_controller_spec.rb23
1 files changed, 7 insertions, 16 deletions
diff --git a/spec/controllers/projects/releases_controller_spec.rb b/spec/controllers/projects/releases_controller_spec.rb
index 0dba7dab643..ad6682601f3 100644
--- a/spec/controllers/projects/releases_controller_spec.rb
+++ b/spec/controllers/projects/releases_controller_spec.rb
@@ -115,15 +115,6 @@ RSpec.describe Projects::ReleasesController do
expect(json_response.map { |release| release["id"] } ).to eq([release_2.id, release_1.id])
end
- # TODO: remove in https://gitlab.com/gitlab-org/gitlab/-/issues/360903
- it "returns release sha when remove_sha_from_releases_json is disabled" do
- stub_feature_flags(remove_sha_from_releases_json: false)
-
- get_index
-
- expect(json_response).to eq([release_2, release_1].as_json)
- end
-
it_behaves_like 'common access controls'
context 'when the project is private and the user is not logged in' do
@@ -157,19 +148,19 @@ RSpec.describe Projects::ReleasesController do
end
let(:release) { create(:release, project: project) }
- let(:tag) { CGI.escape(release.tag) }
+ let(:tag) { release.tag }
it_behaves_like 'successful request'
context 'when tag name contains slash' do
let(:release) { create(:release, project: project, tag: 'awesome/v1.0') }
- let(:tag) { CGI.escape(release.tag) }
+ let(:tag) { release.tag }
it_behaves_like 'successful request'
it 'is accesible at a URL encoded path' do
expect(edit_project_release_path(project, release))
- .to eq("/#{project.namespace.path}/#{project.name}/-/releases/awesome%252Fv1.0/edit")
+ .to eq("/#{project.namespace.path}/#{project.name}/-/releases/awesome%2Fv1.0/edit")
end
end
@@ -196,19 +187,19 @@ RSpec.describe Projects::ReleasesController do
end
let(:release) { create(:release, project: project) }
- let(:tag) { CGI.escape(release.tag) }
+ let(:tag) { release.tag }
it_behaves_like 'successful request'
context 'when tag name contains slash' do
let(:release) { create(:release, project: project, tag: 'awesome/v1.0') }
- let(:tag) { CGI.escape(release.tag) }
+ let(:tag) { release.tag }
it_behaves_like 'successful request'
it 'is accesible at a URL encoded path' do
expect(project_release_path(project, release))
- .to eq("/#{project.namespace.path}/#{project.name}/-/releases/awesome%252Fv1.0")
+ .to eq("/#{project.namespace.path}/#{project.name}/-/releases/awesome%2Fv1.0")
end
end
@@ -248,7 +239,7 @@ RSpec.describe Projects::ReleasesController do
end
let(:release) { create(:release, project: project) }
- let(:tag) { CGI.escape(release.tag) }
+ let(:tag) { release.tag }
context 'when user is a guest' do
let(:project) { private_project }