diff options
Diffstat (limited to 'spec/features/issues')
22 files changed, 66 insertions, 65 deletions
diff --git a/spec/features/issues/filtered_search/dropdown_assignee_spec.rb b/spec/features/issues/filtered_search/dropdown_assignee_spec.rb index 18b70c9622a..05eb656461e 100644 --- a/spec/features/issues/filtered_search/dropdown_assignee_spec.rb +++ b/spec/features/issues/filtered_search/dropdown_assignee_spec.rb @@ -9,10 +9,6 @@ RSpec.describe 'Dropdown assignee', :js do let_it_be(:user) { create(:user) } let_it_be(:issue) { create(:issue, project: project) } - before do - stub_feature_flags(vue_issues_list: true) - end - describe 'behavior' do before do project.add_maintainer(user) diff --git a/spec/features/issues/filtered_search/dropdown_author_spec.rb b/spec/features/issues/filtered_search/dropdown_author_spec.rb index 07e2bd3b7e4..36a8f1f3902 100644 --- a/spec/features/issues/filtered_search/dropdown_author_spec.rb +++ b/spec/features/issues/filtered_search/dropdown_author_spec.rb @@ -10,8 +10,6 @@ RSpec.describe 'Dropdown author', :js do let_it_be(:issue) { create(:issue, project: project) } before do - stub_feature_flags(vue_issues_list: true) - project.add_maintainer(user) sign_in(user) diff --git a/spec/features/issues/filtered_search/dropdown_base_spec.rb b/spec/features/issues/filtered_search/dropdown_base_spec.rb index 5fdab288b2d..9e3e3d394cd 100644 --- a/spec/features/issues/filtered_search/dropdown_base_spec.rb +++ b/spec/features/issues/filtered_search/dropdown_base_spec.rb @@ -10,8 +10,6 @@ RSpec.describe 'Dropdown base', :js do let_it_be(:issue) { create(:issue, project: project) } before do - stub_feature_flags(vue_issues_list: true) - project.add_maintainer(user) sign_in(user) diff --git a/spec/features/issues/filtered_search/dropdown_emoji_spec.rb b/spec/features/issues/filtered_search/dropdown_emoji_spec.rb index d6d59b89a8c..78450a9c3f7 100644 --- a/spec/features/issues/filtered_search/dropdown_emoji_spec.rb +++ b/spec/features/issues/filtered_search/dropdown_emoji_spec.rb @@ -11,8 +11,6 @@ RSpec.describe 'Dropdown emoji', :js do let_it_be(:award_emoji_star) { create(:award_emoji, name: 'star', user: user, awardable: issue) } before do - stub_feature_flags(vue_issues_list: true) - project.add_maintainer(user) create_list(:award_emoji, 2, user: user, name: 'thumbsup') create_list(:award_emoji, 1, user: user, name: 'thumbsdown') diff --git a/spec/features/issues/filtered_search/dropdown_hint_spec.rb b/spec/features/issues/filtered_search/dropdown_hint_spec.rb index c64247b2b15..dcbab308efa 100644 --- a/spec/features/issues/filtered_search/dropdown_hint_spec.rb +++ b/spec/features/issues/filtered_search/dropdown_hint_spec.rb @@ -10,8 +10,6 @@ RSpec.describe 'Dropdown hint', :js do let_it_be(:issue) { create(:issue, project: project) } before do - stub_feature_flags(vue_issues_list: true) - project.add_maintainer(user) end diff --git a/spec/features/issues/filtered_search/dropdown_label_spec.rb b/spec/features/issues/filtered_search/dropdown_label_spec.rb index 67e3792a04c..0ff56909ad1 100644 --- a/spec/features/issues/filtered_search/dropdown_label_spec.rb +++ b/spec/features/issues/filtered_search/dropdown_label_spec.rb @@ -11,8 +11,6 @@ RSpec.describe 'Dropdown label', :js do let_it_be(:label) { create(:label, project: project, title: 'bug-label') } before do - stub_feature_flags(vue_issues_list: true) - project.add_maintainer(user) sign_in(user) diff --git a/spec/features/issues/filtered_search/dropdown_milestone_spec.rb b/spec/features/issues/filtered_search/dropdown_milestone_spec.rb index 19a4c8853f1..37d604106f1 100644 --- a/spec/features/issues/filtered_search/dropdown_milestone_spec.rb +++ b/spec/features/issues/filtered_search/dropdown_milestone_spec.rb @@ -12,8 +12,6 @@ RSpec.describe 'Dropdown milestone', :js do let_it_be(:issue) { create(:issue, project: project) } before do - stub_feature_flags(vue_issues_list: true) - project.add_maintainer(user) sign_in(user) diff --git a/spec/features/issues/filtered_search/dropdown_release_spec.rb b/spec/features/issues/filtered_search/dropdown_release_spec.rb index 50ac9068b26..08e20563c8e 100644 --- a/spec/features/issues/filtered_search/dropdown_release_spec.rb +++ b/spec/features/issues/filtered_search/dropdown_release_spec.rb @@ -12,8 +12,6 @@ RSpec.describe 'Dropdown release', :js do let_it_be(:issue) { create(:issue, project: project) } before do - stub_feature_flags(vue_issues_list: true) - project.add_maintainer(user) sign_in(user) diff --git a/spec/features/issues/filtered_search/filter_issues_spec.rb b/spec/features/issues/filtered_search/filter_issues_spec.rb index 13bce49e6d1..8d96bbc38cb 100644 --- a/spec/features/issues/filtered_search/filter_issues_spec.rb +++ b/spec/features/issues/filtered_search/filter_issues_spec.rb @@ -19,7 +19,6 @@ RSpec.describe 'Filter issues', :js do end before do - stub_feature_flags(vue_issues_list: true) project.add_maintainer(user) create(:issue, project: project, author: user2, title: "Bug report 1") diff --git a/spec/features/issues/filtered_search/recent_searches_spec.rb b/spec/features/issues/filtered_search/recent_searches_spec.rb index bb5964258be..cb17349dd43 100644 --- a/spec/features/issues/filtered_search/recent_searches_spec.rb +++ b/spec/features/issues/filtered_search/recent_searches_spec.rb @@ -13,8 +13,6 @@ RSpec.describe 'Recent searches', :js do let(:project_1_local_storage_key) { "#{project_1.full_path}-issue-recent-searches" } before do - stub_feature_flags(vue_issues_list: true) - # Visit any fast-loading page so we can clear local storage without a DOM exception visit '/404' remove_recent_searches diff --git a/spec/features/issues/filtered_search/search_bar_spec.rb b/spec/features/issues/filtered_search/search_bar_spec.rb index 8639ec2a227..e075547e326 100644 --- a/spec/features/issues/filtered_search/search_bar_spec.rb +++ b/spec/features/issues/filtered_search/search_bar_spec.rb @@ -10,7 +10,6 @@ RSpec.describe 'Search bar', :js do let_it_be(:issue) { create(:issue, project: project) } before do - stub_feature_flags(vue_issues_list: true) project.add_maintainer(user) sign_in(user) diff --git a/spec/features/issues/filtered_search/visual_tokens_spec.rb b/spec/features/issues/filtered_search/visual_tokens_spec.rb index 9fb6a4cc2af..7a367723609 100644 --- a/spec/features/issues/filtered_search/visual_tokens_spec.rb +++ b/spec/features/issues/filtered_search/visual_tokens_spec.rb @@ -15,7 +15,6 @@ RSpec.describe 'Visual tokens', :js do let_it_be(:issue) { create(:issue, project: project) } before do - stub_feature_flags(vue_issues_list: true) project.add_user(user, :maintainer) project.add_user(user_rock, :maintainer) sign_in(user) diff --git a/spec/features/issues/incident_issue_spec.rb b/spec/features/issues/incident_issue_spec.rb index a2519a44604..d6ec7f1c539 100644 --- a/spec/features/issues/incident_issue_spec.rb +++ b/spec/features/issues/incident_issue_spec.rb @@ -26,6 +26,7 @@ RSpec.describe 'Incident Detail', :js do context 'when user displays the incident' do before do + stub_feature_flags(incident_timeline: project) project.add_developer(user) sign_in(user) @@ -72,6 +73,12 @@ RSpec.describe 'Incident Detail', :js do expect(hidden_items).to all(be_visible) end end + + it 'shows the edit title and description button' do + edit_button = find_all('[aria-label="Edit title and description"]') + + expect(edit_button).to all(be_visible) + end end context 'when on alert details tab' do @@ -87,6 +94,61 @@ RSpec.describe 'Incident Detail', :js do expect(hidden_items.count).to eq(0) end end + + it 'does not show the edit title and description button' do + edit_button = find_all('[aria-label="Edit title and description"]') + + expect(edit_button.count).to eq(0) + end + end + + context 'when on timeline events tab from incident route' do + before do + visit project_issues_incident_path(project, incident) + wait_for_requests + click_link 'Timeline' + end + + it 'does not show the linked issues and notes/comment components' do + page.within('.issuable-details') do + hidden_items = find_all('.js-issue-widgets') + + # Linked Issues/MRs and comment box are hidden on page + expect(hidden_items.count).to eq(0) + end + end + end + + context 'when on timeline events tab from issue route' do + before do + visit project_issue_path(project, incident) + wait_for_requests + click_link 'Timeline' + end + + it 'does not show the linked issues and notes/comment commponents' do + page.within('.issuable-details') do + hidden_items = find_all('.js-issue-widgets') + + # Linked Issues/MRs and comment box are hidden on page + expect(hidden_items.count).to eq(0) + end + end + end + + context 'when incident_timeline feature flag is disabled' do + before do + stub_feature_flags(incident_timeline: false) + + visit project_issue_path(project, incident) + wait_for_requests + end + + it 'does not show Timeline tab' do + tabs = find('[data-testid="incident-tabs"]') + + expect(tabs).not_to have_content('Timeline') + end end end end diff --git a/spec/features/issues/issue_detail_spec.rb b/spec/features/issues/issue_detail_spec.rb index 88709d66887..2af54e51bb7 100644 --- a/spec/features/issues/issue_detail_spec.rb +++ b/spec/features/issues/issue_detail_spec.rb @@ -140,13 +140,9 @@ RSpec.describe 'Issue Detail', :js do end context 'by non-member author' do - it 'routes the user to the issue details page when the `issue_type` is set to issue' do - open_issue_edit_form - - page.within('[data-testid="issuable-form"]') do - update_type_select('Incident', 'Issue') - - expect(page).to have_current_path(project_issue_path(project, incident)) + it 'cannot edit issuable' do + page.within('.content') do + expect(page).to have_no_button('Edit title and description') end end end diff --git a/spec/features/issues/rss_spec.rb b/spec/features/issues/rss_spec.rb index bdc5f282875..e3faed81c73 100644 --- a/spec/features/issues/rss_spec.rb +++ b/spec/features/issues/rss_spec.rb @@ -13,10 +13,6 @@ RSpec.describe 'Project Issues RSS', :js do group.add_developer(user) end - before do - stub_feature_flags(vue_issues_list: true) - end - context 'when signed in' do let_it_be(:user) { create(:user) } diff --git a/spec/features/issues/user_bulk_edits_issues_labels_spec.rb b/spec/features/issues/user_bulk_edits_issues_labels_spec.rb index 27377f6e1fd..4837d13574c 100644 --- a/spec/features/issues/user_bulk_edits_issues_labels_spec.rb +++ b/spec/features/issues/user_bulk_edits_issues_labels_spec.rb @@ -15,10 +15,6 @@ RSpec.describe 'Issues > Labels bulk assignment' do let(:issue_1_selector) { "#issuable_#{issue1.id}" } let(:issue_2_selector) { "#issuable_#{issue2.id}" } - before do - stub_feature_flags(vue_issues_list: true) - end - context 'as an allowed user', :js do before do project.add_maintainer(user) diff --git a/spec/features/issues/user_bulk_edits_issues_spec.rb b/spec/features/issues/user_bulk_edits_issues_spec.rb index 625303f89e4..0533f1688e2 100644 --- a/spec/features/issues/user_bulk_edits_issues_spec.rb +++ b/spec/features/issues/user_bulk_edits_issues_spec.rb @@ -107,10 +107,6 @@ RSpec.describe 'Multiple issue updating from issues#index', :js do describe 'select all issues' do let!(:issue_2) { create(:issue, project: project) } - before do - stub_feature_flags(vue_issues_list: true) - end - it 'after selecting all issues, unchecking one issue only unselects that one issue' do visit project_issues_path(project) diff --git a/spec/features/issues/user_comments_on_issue_spec.rb b/spec/features/issues/user_comments_on_issue_spec.rb index a719263f092..a1e7c007b90 100644 --- a/spec/features/issues/user_comments_on_issue_spec.rb +++ b/spec/features/issues/user_comments_on_issue_spec.rb @@ -10,7 +10,6 @@ RSpec.describe "User comments on issue", :js do let(:user) { create(:user) } before do - stub_feature_flags(sandboxed_mermaid: false) project.add_guest(user) sign_in(user) @@ -42,17 +41,6 @@ RSpec.describe "User comments on issue", :js do expect(page.find('pre code').text).to eq code_block_content end - it "renders HTML content as text in Mermaid" do - html_content = "<img onerror=location=`javascript\\u003aalert\\u0028document.domain\\u0029` src=x>" - mermaid_content = "graph LR\n B-->D(#{html_content});" - comment = "```mermaid\n#{mermaid_content}\n```" - - add_note(comment) - - expect(page.find('svg.mermaid')).not_to have_content 'javascript' - within('svg.mermaid') { expect(page).not_to have_selector('img') } - end - it 'opens autocomplete menu for quick actions and have `/label` first choice' do project.add_maintainer(user) create(:label, project: project, title: 'label') @@ -67,7 +55,7 @@ RSpec.describe "User comments on issue", :js do it "edits comment" do add_note("# Comment with a header") - page.within(".note-body > .note-text") do + page.within(".note-body .note-text") do expect(page).to have_content("Comment with a header").and have_no_css("#comment-with-a-header") end diff --git a/spec/features/issues/user_creates_issue_spec.rb b/spec/features/issues/user_creates_issue_spec.rb index 3bba041dab7..151d3c60fa2 100644 --- a/spec/features/issues/user_creates_issue_spec.rb +++ b/spec/features/issues/user_creates_issue_spec.rb @@ -8,10 +8,6 @@ RSpec.describe "User creates issue" do let_it_be(:project) { create(:project_empty_repo, :public) } let_it_be(:user) { create(:user) } - before do - stub_feature_flags(vue_issues_list: true) - end - context "when unauthenticated" do before do sign_out(:user) diff --git a/spec/features/issues/user_filters_issues_spec.rb b/spec/features/issues/user_filters_issues_spec.rb index 42c2b5d32c1..2941ea6ec36 100644 --- a/spec/features/issues/user_filters_issues_spec.rb +++ b/spec/features/issues/user_filters_issues_spec.rb @@ -7,8 +7,6 @@ RSpec.describe 'User filters issues', :js do let_it_be(:project) { create(:project_empty_repo, :public) } before do - stub_feature_flags(vue_issues_list: true) - %w[foobar barbaz].each do |title| create(:issue, author: user, diff --git a/spec/features/issues/user_sees_breadcrumb_links_spec.rb b/spec/features/issues/user_sees_breadcrumb_links_spec.rb index 1577d7d5ce8..4ec13533a8d 100644 --- a/spec/features/issues/user_sees_breadcrumb_links_spec.rb +++ b/spec/features/issues/user_sees_breadcrumb_links_spec.rb @@ -8,8 +8,6 @@ RSpec.describe 'New issue breadcrumb' do let(:user) { project.creator } before do - stub_feature_flags(vue_issues_list: true) - sign_in(user) visit(new_project_issue_path(project)) end diff --git a/spec/features/issues/user_sorts_issues_spec.rb b/spec/features/issues/user_sorts_issues_spec.rb index 4af313576ed..7add6c782f7 100644 --- a/spec/features/issues/user_sorts_issues_spec.rb +++ b/spec/features/issues/user_sorts_issues_spec.rb @@ -16,8 +16,6 @@ RSpec.describe "User sorts issues" do let_it_be(:later_due_milestone) { create(:milestone, project: project, due_date: '2013-12-12') } before do - stub_feature_flags(vue_issues_list: true) - create_list(:award_emoji, 2, :upvote, awardable: issue1) create_list(:award_emoji, 2, :downvote, awardable: issue2) create(:award_emoji, :downvote, awardable: issue1) |