diff options
Diffstat (limited to 'spec/features/projects/members/manage_groups_spec.rb')
| -rw-r--r-- | spec/features/projects/members/manage_groups_spec.rb | 233 |
1 files changed, 233 insertions, 0 deletions
diff --git a/spec/features/projects/members/manage_groups_spec.rb b/spec/features/projects/members/manage_groups_spec.rb new file mode 100644 index 00000000000..006fa3b6eff --- /dev/null +++ b/spec/features/projects/members/manage_groups_spec.rb @@ -0,0 +1,233 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe 'Project > Members > Manage groups', :js do + include ActionView::Helpers::DateHelper + include Spec::Support::Helpers::Features::MembersHelpers + include Spec::Support::Helpers::Features::InviteMembersModalHelper + + let_it_be(:maintainer) { create(:user) } + + it 'displays the invite group button' do + project = create(:project, namespace: create(:group)) + + project.add_maintainer(maintainer) + sign_in(maintainer) + + visit project_project_members_path(project) + + expect(page).to have_selector(invite_group_selector) + end + + it 'does not display the button when visiting the page not signed in' do + project = create(:project, namespace: create(:group)) + + visit project_project_members_path(project) + + expect(page).not_to have_selector(invite_group_selector) + end + + describe 'Share with group lock' do + shared_examples 'the project can be shared with groups' do + it 'the "Invite a group" button exists' do + visit project_project_members_path(project) + expect(page).to have_selector(invite_group_selector) + end + end + + shared_examples 'the project cannot be shared with groups' do + it 'the "Invite a group" button does not exist' do + visit project_project_members_path(project) + expect(page).not_to have_selector(invite_group_selector) + end + end + + context 'for a project in a root group' do + let!(:group_to_share_with) { create(:group) } + let(:project) { create(:project, namespace: create(:group)) } + + before do + project.add_maintainer(maintainer) + group_to_share_with.add_guest(maintainer) + sign_in(maintainer) + end + + context 'when the group has "Share with group lock" disabled' do + it_behaves_like 'the project can be shared with groups' + + it 'the project can be shared with another group' do + visit project_project_members_path(project) + + expect(page).not_to have_link 'Groups' + + invite_group(group_to_share_with.name) + + visit project_project_members_path(project) + + click_link 'Groups' + + expect(members_table).to have_content(group_to_share_with.name) + end + end + + context 'when the group has "Share with group lock" enabled' do + before do + project.namespace.update_column(:share_with_group_lock, true) + end + + it_behaves_like 'the project cannot be shared with groups' + end + end + + context 'for a project in a subgroup' do + let!(:group_to_share_with) { create(:group) } + let(:root_group) { create(:group) } + let(:subgroup) { create(:group, parent: root_group) } + let(:project) { create(:project, namespace: subgroup) } + + before do + project.add_maintainer(maintainer) + sign_in(maintainer) + end + + context 'when the root_group has "Share with group lock" disabled' do + context 'when the subgroup has "Share with group lock" disabled' do + it_behaves_like 'the project can be shared with groups' + end + + context 'when the subgroup has "Share with group lock" enabled' do + before do + subgroup.update_column(:share_with_group_lock, true) + end + + it_behaves_like 'the project cannot be shared with groups' + end + end + + context 'when the root_group has "Share with group lock" enabled' do + before do + root_group.update_column(:share_with_group_lock, true) + end + + context 'when the subgroup has "Share with group lock" disabled (parent overridden)' do + it_behaves_like 'the project can be shared with groups' + end + + context 'when the subgroup has "Share with group lock" enabled' do + before do + subgroup.update_column(:share_with_group_lock, true) + end + + it_behaves_like 'the project cannot be shared with groups' + end + end + end + end + + describe 'setting an expiration date for a group link' do + let(:project) { create(:project, :with_namespace_settings) } + let!(:group) { create(:group) } + + let_it_be(:expiration_date) { 5.days.from_now.to_date } + + around do |example| + freeze_time { example.run } + end + + def setup + project.add_maintainer(maintainer) + group.add_guest(maintainer) + sign_in(maintainer) + + visit project_project_members_path(project) + + invite_group(group.name, role: 'Guest', expires_at: expiration_date) + end + + it 'the group link shows the expiration time with a warning class' do + setup + click_link 'Groups' + + expect(page).to have_field('Expiration date', with: expiration_date) + end + end + + describe 'group search results' do + let_it_be(:parent_group) { create(:group, :public) } + let_it_be(:project_group) { create(:group, :public, parent: parent_group) } + let_it_be(:project) { create(:project, group: project_group) } + + it_behaves_like 'inviting groups search results' do + let_it_be(:user) { maintainer } + let_it_be(:group) { parent_group } + let_it_be(:group_within_hierarchy) { create(:group, parent: group) } + let_it_be(:project_within_hierarchy) { create(:project, group: group_within_hierarchy)} + let_it_be(:members_page_path) { project_project_members_path(project) } + let_it_be(:members_page_path_within_hierarchy) { project_project_members_path(project_within_hierarchy) } + end + + context 'for a project in a nested group' do + let_it_be(:public_sub_subgroup) { create(:group, :public, parent: project_group) } + let_it_be(:public_sibbling_group) { create(:group, :public, parent: parent_group) } + let_it_be(:private_sibbling_group) { create(:group, :private, parent: parent_group) } + let_it_be(:private_membership_group) { create(:group, :private) } + let_it_be(:public_membership_group) { create(:group, :public) } + let_it_be(:project) { create(:project, group: project_group) } + + before do + private_membership_group.add_guest(maintainer) + public_membership_group.add_maintainer(maintainer) + + sign_in(maintainer) + end + + it 'does not show the groups inherited from projects' do + project.add_maintainer(maintainer) + public_sibbling_group.add_maintainer(maintainer) + + visit project_project_members_path(project) + + click_on 'Invite a group' + click_on 'Select a group' + wait_for_requests + + page.within(group_dropdown_selector) do + expect_to_have_group(public_membership_group) + expect_to_have_group(public_sibbling_group) + expect_to_have_group(private_membership_group) + + expect_not_to_have_group(public_sub_subgroup) + expect_not_to_have_group(private_sibbling_group) + expect_not_to_have_group(parent_group) + expect_not_to_have_group(project_group) + end + end + + it 'does not show the ancestors or project group', :aggregate_failures do + parent_group.add_maintainer(maintainer) + + visit project_project_members_path(project) + + click_on 'Invite a group' + click_on 'Select a group' + wait_for_requests + + page.within(group_dropdown_selector) do + expect_to_have_group(public_membership_group) + expect_to_have_group(public_sibbling_group) + expect_to_have_group(private_membership_group) + expect_to_have_group(public_sub_subgroup) + expect_to_have_group(private_sibbling_group) + + expect_not_to_have_group(parent_group) + expect_not_to_have_group(project_group) + end + end + end + end + + def invite_group_selector + 'button[data-test-id="invite-group-button"]' + end +end |