diff options
Diffstat (limited to 'spec/features/search/user_searches_for_code_spec.rb')
| -rw-r--r-- | spec/features/search/user_searches_for_code_spec.rb | 318 |
1 files changed, 149 insertions, 169 deletions
diff --git a/spec/features/search/user_searches_for_code_spec.rb b/spec/features/search/user_searches_for_code_spec.rb index dd7095107f4..b7d06a3a962 100644 --- a/spec/features/search/user_searches_for_code_spec.rb +++ b/spec/features/search/user_searches_for_code_spec.rb @@ -4,241 +4,221 @@ require 'spec_helper' RSpec.describe 'User searches for code', :js, :disable_rate_limiter, feature_category: :global_search do using RSpec::Parameterized::TableSyntax + include ListboxHelpers let_it_be(:user) { create(:user) } let_it_be_with_reload(:project) { create(:project, :repository, namespace: user.namespace) } - where(search_page_vertical_nav_enabled: [true, false]) - with_them do - context 'when signed in' do + context 'when signed in' do + before do + project.add_maintainer(user) + sign_in(user) + end + + context 'when on a project page' do before do - stub_feature_flags(search_page_vertical_nav: search_page_vertical_nav_enabled) - project.add_maintainer(user) - sign_in(user) + visit(project_path(project)) end - context 'when on a project page' do - before do - visit(project_path(project)) - end - - it 'finds a file' do - submit_search('application.js') - select_search_scope('Code') + it 'finds a file' do + submit_search('application.js') + select_search_scope('Code') - expect(page).to have_selector('.results', text: 'application.js') - expect(page).to have_selector('.file-content .code') - expect(page).to have_selector("span.line[lang='javascript']") - expect(page).to have_link('application.js', href: %r{master/files/js/application.js}) - expect(page).to have_button('Copy file path') - end + expect(page).to have_selector('.results', text: 'application.js') + expect(page).to have_selector('.file-content .code') + expect(page).to have_selector("span.line[lang='javascript']") + expect(page).to have_link('application.js', href: %r{master/files/js/application.js}) + expect(page).to have_button('Copy file path') end + end - context 'when on a project search page' do - before do - visit(search_path) - find('[data-testid="project-filter"]').click + context 'when on a project search page' do + before do + visit(search_path) + find('[data-testid="project-filter"]').click - wait_for_requests + wait_for_requests - page.within('[data-testid="project-filter"]') do - click_on(project.name) - end + page.within('[data-testid="project-filter"]') do + click_on(project.name) end + end - include_examples 'top right search form' - include_examples 'search timeouts', 'blobs' do - let(:additional_params) { { project_id: project.id } } - end + include_examples 'top right search form' + include_examples 'search timeouts', 'blobs' do + let(:additional_params) { { project_id: project.id } } + end - context 'when searching code' do - let(:expected_result) { 'Update capybara, rspec-rails, poltergeist to recent versions' } + context 'when searching code' do + let(:expected_result) { 'Update capybara, rspec-rails, poltergeist to recent versions' } - before do - fill_in('dashboard_search', with: 'rspec') - find('.gl-search-box-by-click-search-button').click - end + before do + fill_in('dashboard_search', with: 'rspec') + find('.gl-search-box-by-click-search-button').click + end - it 'finds code and links to blob' do - expect(page).to have_selector('.results', text: expected_result) + it 'finds code and links to blob' do + expect(page).to have_selector('.results', text: expected_result) - find("#blob-L3").click - expect(current_url).to match(%r{blob/master/.gitignore#L3}) - end + find("#blob-L3").click + expect(current_url).to match(%r{blob/master/.gitignore#L3}) + end - it 'finds code and links to blame' do - expect(page).to have_selector('.results', text: expected_result) + it 'finds code and links to blame' do + expect(page).to have_selector('.results', text: expected_result) - find("#blame-L3").click - expect(current_url).to match(%r{blame/master/.gitignore#L3}) - end + find("#blame-L3").click + expect(current_url).to match(%r{blame/master/.gitignore#L3}) + end - it_behaves_like 'code highlight' do - subject { page } - end + it_behaves_like 'code highlight' do + subject { page } end + end - it 'search multiple words with refs switching' do - expected_result = 'Use `snake_case` for naming files' - search = 'for naming files' + it 'search multiple words with refs switching' do + expected_result = 'Use `snake_case` for naming files' + search = 'for naming files' + ref_selector = 'v1.0.0' - fill_in('dashboard_search', with: search) - find('.gl-search-box-by-click-search-button').click + fill_in('dashboard_search', with: search) + find('.gl-search-box-by-click-search-button').click - expect(page).to have_selector('.results', text: expected_result) + expect(page).to have_selector('.results', text: expected_result) - find('.ref-selector').click - wait_for_requests + click_button 'master' + wait_for_requests - page.within('.ref-selector') do - find('li', text: 'v1.0.0').click - end + select_listbox_item(ref_selector) - expect(page).to have_selector('.results', text: expected_result) + expect(page).to have_selector('.results', text: expected_result) - expect(find_field('dashboard_search').value).to eq(search) - expect(find("#blob-L1502")[:href]).to match(%r{blob/v1.0.0/files/markdown/ruby-style-guide.md#L1502}) - expect(find("#blame-L1502")[:href]).to match(%r{blame/v1.0.0/files/markdown/ruby-style-guide.md#L1502}) - end + expect(find_field('dashboard_search').value).to eq(search) + expect(find("#blob-L1502")[:href]).to match(%r{blob/v1.0.0/files/markdown/ruby-style-guide.md#L1502}) + expect(find("#blame-L1502")[:href]).to match(%r{blame/v1.0.0/files/markdown/ruby-style-guide.md#L1502}) end + end - context 'when :new_header_search is true' do - context 'search code within refs' do - let(:ref_name) { 'v1.0.0' } + context 'when :new_header_search is true' do + context 'search code within refs' do + let(:ref_name) { 'v1.0.0' } - before do - # This feature is disabled by default in spec_helper.rb. - # We missed a feature breaking bug, so to prevent this regression, testing both scenarios for this spec. - # This can be removed as part of closing https://gitlab.com/gitlab-org/gitlab/-/issues/339348. - stub_feature_flags(new_header_search: true) - visit(project_tree_path(project, ref_name)) + before do + # This feature is disabled by default in spec_helper.rb. + # We missed a feature breaking bug, so to prevent this regression, testing both scenarios for this spec. + # This can be removed as part of closing https://gitlab.com/gitlab-org/gitlab/-/issues/339348. + stub_feature_flags(new_header_search: true) + visit(project_tree_path(project, ref_name)) - submit_search('gitlab-grack') - select_search_scope('Code') - end + submit_search('gitlab-grack') + select_search_scope('Code') + end - it 'shows ref switcher in code result summary' do - expect(find('.ref-selector')).to have_text(ref_name) - end + it 'shows ref switcher in code result summary' do + expect(find('.ref-selector')).to have_text(ref_name) + end - it 'persists branch name across search' do - find('.gl-search-box-by-click-search-button').click - expect(find('.ref-selector')).to have_text(ref_name) - end + it 'persists branch name across search' do + find('.gl-search-box-by-click-search-button').click + expect(find('.ref-selector')).to have_text(ref_name) + end - # this example is use to test the design that the refs is not - # only represent the branch as well as the tags. - it 'ref switcher list all the branches and tags' do - find('.ref-selector').click - wait_for_requests + # this example is use to test the design that the refs is not + # only represent the branch as well as the tags. + it 'ref switcher list all the branches and tags' do + find('.ref-selector').click + wait_for_requests - page.within('.ref-selector') do - expect(page).to have_selector('li', text: 'add-ipython-files') - expect(page).to have_selector('li', text: 'v1.0.0') - end + page.within('.ref-selector') do + expect(page).to have_selector('li', text: 'add-ipython-files') + expect(page).to have_selector('li', text: 'v1.0.0') end + end - it 'search result changes when refs switched' do - ref = 'master' - expect(find('.results')).not_to have_content('path = gitlab-grack') - - find('.ref-selector').click - wait_for_requests + it 'search result changes when refs switched' do + expect(find('.results')).not_to have_content('path = gitlab-grack') - page.within('.ref-selector') do - fill_in _('Search by Git revision'), with: ref - wait_for_requests + find('.ref-selector').click + wait_for_requests - find('li', text: ref).click - end + select_listbox_item('add-ipython-files') - expect(page).to have_selector('.results', text: 'path = gitlab-grack') - end + expect(page).to have_selector('.results', text: 'path = gitlab-grack') end end + end - context 'when :new_header_search is false' do - context 'search code within refs' do - let(:ref_name) { 'v1.0.0' } + context 'when :new_header_search is false' do + context 'search code within refs' do + let(:ref_name) { 'v1.0.0' } - before do - # This feature is disabled by default in spec_helper.rb. - # We missed a feature breaking bug, so to prevent this regression, testing both scenarios for this spec. - # This can be removed as part of closing https://gitlab.com/gitlab-org/gitlab/-/issues/339348. - stub_feature_flags(new_header_search: false) - visit(project_tree_path(project, ref_name)) + before do + # This feature is disabled by default in spec_helper.rb. + # We missed a feature breaking bug, so to prevent this regression, testing both scenarios for this spec. + # This can be removed as part of closing https://gitlab.com/gitlab-org/gitlab/-/issues/339348. + stub_feature_flags(new_header_search: false) + visit(project_tree_path(project, ref_name)) - submit_search('gitlab-grack') - select_search_scope('Code') - end + submit_search('gitlab-grack') + select_search_scope('Code') + end - it 'shows ref switcher in code result summary' do - expect(find('.ref-selector')).to have_text(ref_name) - end + it 'shows ref switcher in code result summary' do + expect(find('.ref-selector')).to have_text(ref_name) + end - it 'persists branch name across search' do - find('.gl-search-box-by-click-search-button').click - expect(find('.ref-selector')).to have_text(ref_name) - end + it 'persists branch name across search' do + find('.gl-search-box-by-click-search-button').click + expect(find('.ref-selector')).to have_text(ref_name) + end - # this example is use to test the design that the refs is not - # only represent the branch as well as the tags. - it 'ref switcher list all the branches and tags' do - find('.ref-selector').click - wait_for_requests + # this example is use to test the design that the refs is not + # only represent the branch as well as the tags. + it 'ref switcher list all the branches and tags' do + find('.ref-selector').click + wait_for_requests - page.within('.ref-selector') do - expect(page).to have_selector('li', text: 'add-ipython-files') - expect(page).to have_selector('li', text: 'v1.0.0') - end + page.within('.ref-selector') do + expect(page).to have_selector('li', text: 'add-ipython-files') + expect(page).to have_selector('li', text: 'v1.0.0') end + end - it 'search result changes when refs switched' do - ref = 'master' - expect(find('.results')).not_to have_content('path = gitlab-grack') - - find('.ref-selector').click - wait_for_requests + it 'search result changes when refs switched' do + expect(find('.results')).not_to have_content('path = gitlab-grack') - page.within('.ref-selector') do - fill_in _('Search by Git revision'), with: ref - wait_for_requests + find('.ref-selector').click + wait_for_requests - find('li', text: ref).click - end + select_listbox_item('add-ipython-files') - expect(page).to have_selector('.results', text: 'path = gitlab-grack') - end + expect(page).to have_selector('.results', text: 'path = gitlab-grack') end end + end - it 'no ref switcher shown in issue result summary' do - issue = create(:issue, title: 'test', project: project) - visit(project_tree_path(project)) + it 'no ref switcher shown in issue result summary' do + issue = create(:issue, title: 'test', project: project) + visit(project_tree_path(project)) - submit_search('test') - select_search_scope('Code') + submit_search('test') + select_search_scope('Code') - expect(page).to have_selector('.ref-selector') + expect(page).to have_selector('.ref-selector') - select_search_scope('Issues') + select_search_scope('Issues') - expect(find(:css, '.results')).to have_link(issue.title) - expect(page).not_to have_selector('.ref-selector') - end + expect(find(:css, '.results')).to have_link(issue.title) + expect(page).not_to have_selector('.ref-selector') end + end - context 'when signed out' do - before do - stub_feature_flags(search_page_vertical_nav: search_page_vertical_nav_enabled) - end - - context 'when block_anonymous_global_searches is enabled' do - it 'is redirected to login page' do - visit(search_path) + context 'when signed out' do + context 'when block_anonymous_global_searches is enabled' do + it 'is redirected to login page' do + visit(search_path) - expect(page).to have_content('You must be logged in to search across all of GitLab') - end + expect(page).to have_content('You must be logged in to search across all of GitLab') end end end |