1 files changed, 93 insertions, 84 deletions

diff --git a/spec/features/search/user_searches_for_issues_spec.rb b/spec/features/search/user_searches_for_issues_spec.rb
index 51d2f355848..22d48bd38f2 100644
--- a/spec/features/search/user_searches_for_issues_spec.rb
+++ b/spec/features/search/user_searches_for_issues_spec.rb
@@ -2,9 +2,12 @@
 
 require 'spec_helper'
 
-RSpec.describe 'User searches for issues', :js do
-  let(:user) { create(:user) }
-  let(:project) { create(:project, namespace: user.namespace) }
+RSpec.describe 'User searches for issues', :js, :clean_gitlab_redis_rate_limiting do
+  using RSpec::Parameterized::TableSyntax
+
+  let_it_be(:user) { create(:user) }
+  let_it_be(:project) { create(:project, namespace: user.namespace) }
+
   let!(:issue1) { create(:issue, title: 'issue Foo', project: project, created_at: 1.hour.ago) }
   let!(:issue2) { create(:issue, :closed, :confidential, title: 'issue Bar', project: project) }
 
@@ -14,127 +17,133 @@ RSpec.describe 'User searches for issues', :js do
     select_search_scope('Issues')
   end
 
-  context 'when signed in' do
-    before do
-      project.add_maintainer(user)
-      sign_in(user)
-      stub_feature_flags(search_page_vertical_nav: false)
-
-      visit(search_path)
-    end
+  where(search_page_vertical_nav_enabled: [true, false])
 
-    include_examples 'top right search form'
-    include_examples 'search timeouts', 'issues'
+  with_them do
+    context 'when signed in' do
+      before do
+        stub_feature_flags(search_page_vertical_nav: search_page_vertical_nav_enabled)
 
-    it 'finds an issue' do
-      search_for_issue(issue1.title)
+        project.add_maintainer(user)
+        sign_in(user)
 
-      page.within('.results') do
-        expect(page).to have_link(issue1.title)
-        expect(page).not_to have_link(issue2.title)
+        visit(search_path)
       end
-    end
-
-    it 'hides confidential icon for non-confidential issues' do
-      search_for_issue(issue1.title)
 
-      page.within('.results') do
-        expect(page).not_to have_css('[data-testid="eye-slash-icon"]')
-      end
-    end
+      include_examples 'top right search form'
+      include_examples 'search timeouts', 'issues'
 
-    it 'shows confidential icon for confidential issues' do
-      search_for_issue(issue2.title)
+      it 'finds an issue' do
+        search_for_issue(issue1.title)
 
-      page.within('.results') do
-        expect(page).to have_css('[data-testid="eye-slash-icon"]')
+        page.within('.results') do
+          expect(page).to have_link(issue1.title)
+          expect(page).not_to have_link(issue2.title)
+        end
       end
-    end
 
-    it 'shows correct badge for open issues' do
-      search_for_issue(issue1.title)
+      it 'hides confidential icon for non-confidential issues' do
+        search_for_issue(issue1.title)
 
-      page.within('.results') do
-        expect(page).to have_css('.badge-success')
-        expect(page).not_to have_css('.badge-info')
+        page.within('.results') do
+          expect(page).not_to have_css('[data-testid="eye-slash-icon"]')
+        end
       end
-    end
 
-    it 'shows correct badge for closed issues' do
-      search_for_issue(issue2.title)
+      it 'shows confidential icon for confidential issues' do
+        search_for_issue(issue2.title)
 
-      page.within('.results') do
-        expect(page).not_to have_css('.badge-success')
-        expect(page).to have_css('.badge-info')
+        page.within('.results') do
+          expect(page).to have_css('[data-testid="eye-slash-icon"]')
+        end
       end
-    end
 
-    it 'sorts by created date' do
-      search_for_issue('issue')
+      it 'shows correct badge for open issues' do
+        search_for_issue(issue1.title)
 
-      page.within('.results') do
-        expect(page.all('.search-result-row').first).to have_link(issue2.title)
-        expect(page.all('.search-result-row').last).to have_link(issue1.title)
+        page.within('.results') do
+          expect(page).to have_css('.badge-success')
+          expect(page).not_to have_css('.badge-info')
+        end
       end
 
-      find('[data-testid="sort-highest-icon"]').click
+      it 'shows correct badge for closed issues' do
+        search_for_issue(issue2.title)
 
-      page.within('.results') do
-        expect(page.all('.search-result-row').first).to have_link(issue1.title)
-        expect(page.all('.search-result-row').last).to have_link(issue2.title)
+        page.within('.results') do
+          expect(page).not_to have_css('.badge-success')
+          expect(page).to have_css('.badge-info')
+        end
       end
-    end
-
-    context 'when on a project page' do
-      it 'finds an issue' do
-        find('[data-testid="project-filter"]').click
 
-        wait_for_requests
+      it 'sorts by created date' do
+        search_for_issue('issue')
 
-        page.within('[data-testid="project-filter"]') do
-          click_on(project.name)
+        page.within('.results') do
+          expect(page.all('.search-result-row').first).to have_link(issue2.title)
+          expect(page.all('.search-result-row').last).to have_link(issue1.title)
         end
 
-        search_for_issue(issue1.title)
+        find('[data-testid="sort-highest-icon"]').click
 
         page.within('.results') do
-          expect(page).to have_link(issue1.title)
-          expect(page).not_to have_link(issue2.title)
+          expect(page.all('.search-result-row').first).to have_link(issue1.title)
+          expect(page.all('.search-result-row').last).to have_link(issue2.title)
         end
       end
-    end
-  end
 
-  context 'when signed out' do
-    context 'when block_anonymous_global_searches is disabled' do
-      let(:project) { create(:project, :public) }
+      context 'when on a project page' do
+        it 'finds an issue' do
+          find('[data-testid="project-filter"]').click
 
-      before do
-        stub_feature_flags(block_anonymous_global_searches: false)
-        stub_feature_flags(search_page_vertical_nav: false)
-        visit(search_path)
-      end
+          wait_for_requests
 
-      include_examples 'top right search form'
+          page.within('[data-testid="project-filter"]') do
+            click_on(project.name)
+          end
 
-      it 'finds an issue' do
-        search_for_issue(issue1.title)
+          search_for_issue(issue1.title)
 
-        page.within('.results') do
-          expect(page).to have_link(issue1.title)
-          expect(page).not_to have_link(issue2.title)
+          page.within('.results') do
+            expect(page).to have_link(issue1.title)
+            expect(page).not_to have_link(issue2.title)
+          end
         end
       end
     end
 
-    context 'when block_anonymous_global_searches is enabled' do
+    context 'when signed out' do
       before do
-        stub_feature_flags(search_page_vertical_nav: false)
-        visit(search_path)
+        stub_feature_flags(search_page_vertical_nav: search_page_vertical_nav_enabled)
       end
 
-      it 'is redirected to login page' do
-        expect(page).to have_content('You must be logged in to search across all of GitLab')
+      context 'when block_anonymous_global_searches is disabled' do
+        let_it_be(:project) { create(:project, :public) }
+
+        before do
+          stub_feature_flags(block_anonymous_global_searches: false)
+
+          visit(search_path)
+        end
+
+        include_examples 'top right search form'
+
+        it 'finds an issue' do
+          search_for_issue(issue1.title)
+
+          page.within('.results') do
+            expect(page).to have_link(issue1.title)
+            expect(page).not_to have_link(issue2.title)
+          end
+        end
+      end
+
+      context 'when block_anonymous_global_searches is enabled' do
+        it 'is redirected to login page' do
+          visit(search_path)
+
+          expect(page).to have_content('You must be logged in to search across all of GitLab')
+        end
       end
     end
   end