1 files changed, 8 insertions, 27 deletions

diff --git a/spec/frontend/__helpers__/vuex_action_helper.js b/spec/frontend/__helpers__/vuex_action_helper.js
index 95a811d0385..ab2637d6024 100644
--- a/spec/frontend/__helpers__/vuex_action_helper.js
+++ b/spec/frontend/__helpers__/vuex_action_helper.js
@@ -1,5 +1,3 @@
-const noop = () => {};
-
 /**
  * Helper for testing action with expected mutations inspired in
  * https://vuex.vuejs.org/en/testing.html
@@ -9,7 +7,6 @@ const noop = () => {};
  * @param {Object} state will be provided to the action
  * @param {Array} [expectedMutations=[]] mutations expected to be committed
  * @param {Array} [expectedActions=[]] actions expected to be dispatched
- * @param {Function} [done=noop] to be executed after the tests
  * @return {Promise}
  *
  * @example
@@ -27,20 +24,9 @@ const noop = () => {};
  *    { type: 'actionName', payload: {param: 'foobar'}},
  *    { type: 'actionName1'}
  *   ]
- *   done,
  * );
  *
  * @example
- * testAction(
- *   actions.actionName, // action
- *   { }, // mocked payload
- *   state, //state
- *   [ { type: types.MUTATION} ], // expected mutations
- *   [], // expected actions
- * ).then(done)
- * .catch(done.fail);
- *
- * @example
  * await testAction({
  *   action: actions.actionName,
  *   payload: { deleteListId: 1 },
@@ -56,24 +42,15 @@ export default (
   stateArg,
   expectedMutationsArg = [],
   expectedActionsArg = [],
-  doneArg = noop,
 ) => {
   let action = actionArg;
   let payload = payloadArg;
   let state = stateArg;
   let expectedMutations = expectedMutationsArg;
   let expectedActions = expectedActionsArg;
-  let done = doneArg;
 
   if (typeof actionArg !== 'function') {
-    ({
-      action,
-      payload,
-      state,
-      expectedMutations = [],
-      expectedActions = [],
-      done = noop,
-    } = actionArg);
+    ({ action, payload, state, expectedMutations = [], expectedActions = [] } = actionArg);
   }
 
   const mutations = [];
@@ -109,7 +86,6 @@ export default (
       mutations: expectedMutations,
       actions: expectedActions,
     });
-    done();
   };
 
   const result = action(
@@ -117,8 +93,13 @@ export default (
     payload,
   );
 
-  // eslint-disable-next-line no-restricted-syntax
-  return (result || new Promise((resolve) => setImmediate(resolve)))
+  return (
+    result ||
+    new Promise((resolve) => {
+      // eslint-disable-next-line no-restricted-syntax
+      setImmediate(resolve);
+    })
+  )
     .catch((error) => {
       validateResults();
       throw error;