diff options
Diffstat (limited to 'spec/frontend/design_management/pages/design')
-rw-r--r-- | spec/frontend/design_management/pages/design/__snapshots__/index_spec.js.snap | 23 | ||||
-rw-r--r-- | spec/frontend/design_management/pages/design/index_spec.js | 21 |
2 files changed, 17 insertions, 27 deletions
diff --git a/spec/frontend/design_management/pages/design/__snapshots__/index_spec.js.snap b/spec/frontend/design_management/pages/design/__snapshots__/index_spec.js.snap index 8f12dc8fb06..0f2857821ea 100644 --- a/spec/frontend/design_management/pages/design/__snapshots__/index_spec.js.snap +++ b/spec/frontend/design_management/pages/design/__snapshots__/index_spec.js.snap @@ -99,7 +99,7 @@ exports[`Design management design index page renders design index 1`] = ` variant="link" > Resolved Comments (1) - + </gl-button-stub> <gl-popover-stub @@ -112,8 +112,8 @@ exports[`Design management design index page renders design index 1`] = ` > <p> - Comments you resolve can be viewed and unresolved by going to the "Resolved Comments" section below - + Comments you resolve can be viewed and unresolved by going to the "Resolved Comments" section below + </p> <a @@ -144,19 +144,6 @@ exports[`Design management design index page renders design index 1`] = ` </div> `; -exports[`Design management design index page sets loading state 1`] = ` -<div - class="design-detail js-design-detail fixed-top gl-w-full gl-bottom-0 gl-display-flex gl-justify-content-center gl-flex-direction-column gl-lg-flex-direction-row" -> - <gl-loading-icon-stub - class="gl-align-self-center" - color="dark" - label="Loading" - size="xl" - /> -</div> -`; - exports[`Design management design index page with error GlAlert is rendered in correct position with correct content 1`] = ` <div class="design-detail js-design-detail fixed-top gl-w-full gl-bottom-0 gl-display-flex gl-justify-content-center gl-flex-direction-column gl-lg-flex-direction-row" @@ -185,8 +172,8 @@ exports[`Design management design index page with error GlAlert is rendered in c variant="danger" > - woops - + woops + </gl-alert-stub> </div> diff --git a/spec/frontend/design_management/pages/design/index_spec.js b/spec/frontend/design_management/pages/design/index_spec.js index 55d0fabe402..17a299c5de1 100644 --- a/spec/frontend/design_management/pages/design/index_spec.js +++ b/spec/frontend/design_management/pages/design/index_spec.js @@ -91,7 +91,12 @@ describe('Design management design index page', () => { function createComponent( { loading = false } = {}, - { data = {}, intialRouteOptions = {}, provide = {} } = {}, + { + data = {}, + intialRouteOptions = {}, + provide = {}, + stubs = { ApolloMutation, DesignSidebar, DesignReplyForm }, + } = {}, ) { const $apollo = { queries: { @@ -109,11 +114,7 @@ describe('Design management design index page', () => { wrapper = shallowMount(DesignIndex, { propsData: { id: '1' }, mocks: { $apollo }, - stubs: { - ApolloMutation, - DesignSidebar, - DesignReplyForm, - }, + stubs, provide: { issueIid: '1', projectPath: 'project-path', @@ -139,7 +140,7 @@ describe('Design management design index page', () => { describe('when navigating to component', () => { it('applies fullscreen layout class', () => { jest.spyOn(utils, 'getPageLayoutElement').mockReturnValue(mockPageLayoutElement); - createComponent({ loading: true }); + createComponent({}, { stubs: {} }); expect(mockPageLayoutElement.classList.add).toHaveBeenCalledTimes(1); expect(mockPageLayoutElement.classList.add).toHaveBeenCalledWith( @@ -151,7 +152,7 @@ describe('Design management design index page', () => { describe('when navigating within the component', () => { it('`scale` prop of DesignPresentation component is 1', async () => { jest.spyOn(utils, 'getPageLayoutElement').mockReturnValue(mockPageLayoutElement); - createComponent({ loading: false }, { data: { design, scale: 2 } }); + createComponent({}, { data: { design, scale: 2 } }); await nextTick(); expect(findDesignPresentation().props('scale')).toBe(2); @@ -180,7 +181,8 @@ describe('Design management design index page', () => { it('sets loading state', () => { createComponent({ loading: true }); - expect(wrapper.element).toMatchSnapshot(); + expect(wrapper.find(DesignPresentation).props('isLoading')).toBe(true); + expect(wrapper.find(DesignSidebar).props('isLoading')).toBe(true); }); it('renders design index', () => { @@ -197,6 +199,7 @@ describe('Design management design index page', () => { design, markdownPreviewPath: '/project-path/preview_markdown?target_type=Issue', resolvedDiscussionsExpanded: false, + isLoading: false, }); }); |