diff options
Diffstat (limited to 'spec/frontend/issues/show/components/app_spec.js')
-rw-r--r-- | spec/frontend/issues/show/components/app_spec.js | 40 |
1 files changed, 26 insertions, 14 deletions
diff --git a/spec/frontend/issues/show/components/app_spec.js b/spec/frontend/issues/show/components/app_spec.js index 6cf44e60092..9fa0ce6f93d 100644 --- a/spec/frontend/issues/show/components/app_spec.js +++ b/spec/frontend/issues/show/components/app_spec.js @@ -6,7 +6,14 @@ import { createMockDirective, getBinding } from 'helpers/vue_mock_directive'; import { shallowMountExtended } from 'helpers/vue_test_utils_helper'; import waitForPromises from 'helpers/wait_for_promises'; import { createAlert } from '~/flash'; -import { IssuableStatus, IssuableStatusText, IssuableType } from '~/issues/constants'; +import { + IssuableStatusText, + STATUS_CLOSED, + STATUS_OPEN, + STATUS_REOPENED, + TYPE_EPIC, + TYPE_ISSUE, +} from '~/issues/constants'; import IssuableApp from '~/issues/show/components/app.vue'; import DescriptionComponent from '~/issues/show/components/description.vue'; import EditedComponent from '~/issues/show/components/edited.vue'; @@ -17,6 +24,7 @@ import PinnedLinks from '~/issues/show/components/pinned_links.vue'; import { POLLING_DELAY } from '~/issues/show/constants'; import eventHub from '~/issues/show/event_hub'; import axios from '~/lib/utils/axios_utils'; +import { HTTP_STATUS_OK } from '~/lib/utils/http_status'; import { visitUrl } from '~/lib/utils/url_utility'; import { appProps, @@ -94,7 +102,7 @@ describe('Issuable output', () => { mock .onGet('/gitlab-org/gitlab-shell/-/issues/9/realtime_changes/realtime_changes') .reply(() => { - const res = Promise.resolve([200, REALTIME_REQUEST_STACK[realtimeRequestCount]]); + const res = Promise.resolve([HTTP_STATUS_OK, REALTIME_REQUEST_STACK[realtimeRequestCount]]); realtimeRequestCount += 1; return res; }); @@ -330,7 +338,9 @@ describe('Issuable output', () => { const mockData = { test: [{ name: 'test', id: 'test', project_path: '/', namespace_path: '/' }], }; - mock.onGet('/issuable-templates-path').reply(() => Promise.resolve([200, mockData])); + mock + .onGet('/issuable-templates-path') + .reply(() => Promise.resolve([HTTP_STATUS_OK, mockData])); return wrapper.vm.requestTemplatesAndShowForm().then(() => { expect(formSpy).toHaveBeenCalledWith(mockData); @@ -339,7 +349,9 @@ describe('Issuable output', () => { it('shows the form if template names as array request is successful', () => { const mockData = [{ name: 'test', id: 'test', project_path: '/', namespace_path: '/' }]; - mock.onGet('/issuable-templates-path').reply(() => Promise.resolve([200, mockData])); + mock + .onGet('/issuable-templates-path') + .reply(() => Promise.resolve([HTTP_STATUS_OK, mockData])); return wrapper.vm.requestTemplatesAndShowForm().then(() => { expect(formSpy).toHaveBeenCalledWith(mockData); @@ -473,11 +485,11 @@ describe('Issuable output', () => { }); it.each` - issuableType | issuableStatus | statusIcon - ${IssuableType.Issue} | ${IssuableStatus.Open} | ${'issues'} - ${IssuableType.Issue} | ${IssuableStatus.Closed} | ${'issue-closed'} - ${IssuableType.Epic} | ${IssuableStatus.Open} | ${'epic'} - ${IssuableType.Epic} | ${IssuableStatus.Closed} | ${'epic-closed'} + issuableType | issuableStatus | statusIcon + ${TYPE_ISSUE} | ${STATUS_OPEN} | ${'issues'} + ${TYPE_ISSUE} | ${STATUS_CLOSED} | ${'issue-closed'} + ${TYPE_EPIC} | ${STATUS_OPEN} | ${'epic'} + ${TYPE_EPIC} | ${STATUS_CLOSED} | ${'epic-closed'} `( 'shows with state icon "$statusIcon" for $issuableType when status is $issuableStatus', async ({ issuableType, issuableStatus, statusIcon }) => { @@ -491,9 +503,9 @@ describe('Issuable output', () => { it.each` title | state - ${'shows with Open when status is opened'} | ${IssuableStatus.Open} - ${'shows with Closed when status is closed'} | ${IssuableStatus.Closed} - ${'shows with Open when status is reopened'} | ${IssuableStatus.Reopened} + ${'shows with Open when status is opened'} | ${STATUS_OPEN} + ${'shows with Closed when status is closed'} | ${STATUS_CLOSED} + ${'shows with Open when status is reopened'} | ${STATUS_REOPENED} `('$title', async ({ state }) => { wrapper.setProps({ issuableStatus: state }); @@ -645,10 +657,10 @@ describe('Issuable output', () => { }); }); - describe('listItemReorder event', () => { + describe('saveDescription event', () => { it('makes request to update issue', async () => { const description = 'I have been updated!'; - findDescription().vm.$emit('listItemReorder', description); + findDescription().vm.$emit('saveDescription', description); await waitForPromises(); expect(mock.history.put[0].data).toContain(description); |