diff options
Diffstat (limited to 'spec/frontend')
4 files changed, 10 insertions, 15 deletions
diff --git a/spec/frontend/boards/issue_card_spec.js b/spec/frontend/boards/issue_card_spec.js index df55a106945..08cffed5f00 100644 --- a/spec/frontend/boards/issue_card_spec.js +++ b/spec/frontend/boards/issue_card_spec.js @@ -1,6 +1,6 @@ /* global ListAssignee, ListLabel, ListIssue */ import { mount } from '@vue/test-utils'; -import _ from 'underscore'; +import { range } from 'lodash'; import '~/boards/models/label'; import '~/boards/models/assignee'; import '~/boards/models/issue'; @@ -222,7 +222,7 @@ describe('Issue card component', () => { it('renders 99+ avatar counter', done => { const assignees = [ ...wrapper.props('issue').assignees, - ..._.range(5, 103).map( + ...range(5, 103).map( i => new ListAssignee({ id: i, diff --git a/spec/frontend/error_tracking_settings/components/project_dropdown_spec.js b/spec/frontend/error_tracking_settings/components/project_dropdown_spec.js index 3ce105f27e4..d924f895da8 100644 --- a/spec/frontend/error_tracking_settings/components/project_dropdown_spec.js +++ b/spec/frontend/error_tracking_settings/components/project_dropdown_spec.js @@ -1,4 +1,4 @@ -import _ from 'underscore'; +import { pick, clone } from 'lodash'; import Vuex from 'vuex'; import { createLocalVue, shallowMount } from '@vue/test-utils'; import { GlDropdown, GlDropdownItem } from '@gitlab/ui'; @@ -15,7 +15,7 @@ describe('error tracking settings project dropdown', () => { wrapper = shallowMount(ProjectDropdown, { localVue, propsData: { - ..._.pick( + ...pick( defaultProps, 'dropdownLabel', 'invalidProjectLabel', @@ -65,7 +65,7 @@ describe('error tracking settings project dropdown', () => { describe('populated project list', () => { beforeEach(() => { - wrapper.setProps({ projects: _.clone(projectList), hasProjects: true }); + wrapper.setProps({ projects: clone(projectList), hasProjects: true }); return wrapper.vm.$nextTick(); }); @@ -82,10 +82,10 @@ describe('error tracking settings project dropdown', () => { }); describe('selected project', () => { - const selectedProject = _.clone(projectList[0]); + const selectedProject = clone(projectList[0]); beforeEach(() => { - wrapper.setProps({ projects: _.clone(projectList), selectedProject, hasProjects: true }); + wrapper.setProps({ projects: clone(projectList), selectedProject, hasProjects: true }); return wrapper.vm.$nextTick(); }); @@ -98,7 +98,7 @@ describe('error tracking settings project dropdown', () => { describe('invalid project selected', () => { beforeEach(() => { wrapper.setProps({ - projects: _.clone(projectList), + projects: clone(projectList), selectedProject: staleProject, isProjectInvalid: true, }); diff --git a/spec/frontend/notes/old_notes_spec.js b/spec/frontend/notes/old_notes_spec.js index c1c9d5cef4a..5f7a5d57cd8 100644 --- a/spec/frontend/notes/old_notes_spec.js +++ b/spec/frontend/notes/old_notes_spec.js @@ -1,7 +1,6 @@ /* eslint-disable import/no-commonjs, no-new */ import $ from 'jquery'; -import _ from 'underscore'; import MockAdapter from 'axios-mock-adapter'; import '~/behaviors/markdown/render_gfm'; import { createSpyObj } from 'helpers/jest_helpers'; @@ -792,14 +791,11 @@ describe('Old Notes (~/notes.js)', () => { }); it('should return form metadata with sanitized formContent from form reference', () => { - jest.spyOn(_, 'escape'); - sampleComment = '<script>alert("Boom!");</script>'; $form.find('textarea.js-note-text').val(sampleComment); const { formContent } = notes.getFormData($form); - expect(_.escape).toHaveBeenCalledWith(sampleComment); expect(formContent).toEqual('<script>alert("Boom!");</script>'); }); }); @@ -990,7 +986,6 @@ describe('Old Notes (~/notes.js)', () => { beforeEach(() => { notes = new Notes('', []); - jest.spyOn(_, 'escape'); }); it('should return constructed placeholder element for system note based on form contents', () => { diff --git a/spec/frontend/vue_shared/components/user_avatar/user_avatar_link_spec.js b/spec/frontend/vue_shared/components/user_avatar/user_avatar_link_spec.js index 2f68e15b0d7..902e83da7be 100644 --- a/spec/frontend/vue_shared/components/user_avatar/user_avatar_link_spec.js +++ b/spec/frontend/vue_shared/components/user_avatar/user_avatar_link_spec.js @@ -1,4 +1,4 @@ -import _ from 'underscore'; +import { each } from 'lodash'; import { trimText } from 'helpers/text_helper'; import { shallowMount } from '@vue/test-utils'; import { GlLink } from '@gitlab/ui'; @@ -58,7 +58,7 @@ describe('User Avatar Link Component', () => { }); it('should return necessary props as defined', () => { - _.each(defaultProps, (val, key) => { + each(defaultProps, (val, key) => { expect(wrapper.vm[key]).toBeDefined(); }); }); |