diff options
Diffstat (limited to 'spec/graphql/mutations/incident_management')
4 files changed, 302 insertions, 0 deletions
diff --git a/spec/graphql/mutations/incident_management/timeline_event/create_spec.rb b/spec/graphql/mutations/incident_management/timeline_event/create_spec.rb new file mode 100644 index 00000000000..63faecad5d5 --- /dev/null +++ b/spec/graphql/mutations/incident_management/timeline_event/create_spec.rb @@ -0,0 +1,51 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe Mutations::IncidentManagement::TimelineEvent::Create do + let_it_be(:current_user) { create(:user) } + let_it_be(:project) { create(:project) } + let_it_be(:incident) { create(:incident, project: project) } + + let(:args) { { note: 'note', occurred_at: Time.current } } + + specify { expect(described_class).to require_graphql_authorizations(:admin_incident_management_timeline_event) } + + describe '#resolve' do + subject(:resolve) { mutation_for(project, current_user).resolve(incident_id: incident.to_global_id, **args) } + + context 'when a user has permissions to create a timeline event' do + let(:expected_timeline_event) do + instance_double( + 'IncidentManagement::TimelineEvent', + note: args[:note], + occurred_at: args[:occurred_at].to_s, + incident: incident, + author: current_user, + promoted_from_note: nil + ) + end + + before do + project.add_developer(current_user) + end + + it_behaves_like 'creating an incident timeline event' + + context 'when TimelineEvents::CreateService responds with an error' do + let(:args) { {} } + + it_behaves_like 'responding with an incident timeline errors', + errors: ["Occurred at can't be blank, Note can't be blank, and Note html can't be blank"] + end + end + + it_behaves_like 'failing to create an incident timeline event' + end + + private + + def mutation_for(project, user) + described_class.new(object: project, context: { current_user: user }, field: nil) + end +end diff --git a/spec/graphql/mutations/incident_management/timeline_event/destroy_spec.rb b/spec/graphql/mutations/incident_management/timeline_event/destroy_spec.rb new file mode 100644 index 00000000000..4dd7b2ccb14 --- /dev/null +++ b/spec/graphql/mutations/incident_management/timeline_event/destroy_spec.rb @@ -0,0 +1,66 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe Mutations::IncidentManagement::TimelineEvent::Destroy do + let_it_be(:current_user) { create(:user) } + let_it_be(:project) { create(:project) } + let_it_be(:incident) { create(:incident, project: project) } + + let(:timeline_event) { create(:incident_management_timeline_event, incident: incident, project: project) } + let(:args) { { id: timeline_event.to_global_id } } + + specify { expect(described_class).to require_graphql_authorizations(:admin_incident_management_timeline_event) } + + describe '#resolve' do + subject(:resolve) { mutation_for(project, current_user).resolve(**args) } + + context 'when a user has permissions to delete timeline event' do + before do + project.add_developer(current_user) + end + + context 'when TimelineEvents::DestroyService responds with success' do + it 'returns the timeline event with no errors' do + expect(resolve).to eq( + timeline_event: timeline_event, + errors: [] + ) + end + end + + context 'when TimelineEvents::DestroyService responds with an error' do + before do + allow_next_instance_of(::IncidentManagement::TimelineEvents::DestroyService) do |service| + allow(service) + .to receive(:execute) + .and_return(ServiceResponse.error(payload: { timeline_event: nil }, message: 'An error has occurred')) + end + end + + it 'returns errors' do + expect(resolve).to eq( + timeline_event: nil, + errors: ['An error has occurred'] + ) + end + end + end + + context 'when a user has no permissions to delete timeline event' do + before do + project.add_guest(current_user) + end + + it 'raises an error' do + expect { resolve }.to raise_error(Gitlab::Graphql::Errors::ResourceNotAvailable) + end + end + end + + private + + def mutation_for(project, user) + described_class.new(object: project, context: { current_user: user }, field: nil) + end +end diff --git a/spec/graphql/mutations/incident_management/timeline_event/promote_from_note_spec.rb b/spec/graphql/mutations/incident_management/timeline_event/promote_from_note_spec.rb new file mode 100644 index 00000000000..598ee496cf1 --- /dev/null +++ b/spec/graphql/mutations/incident_management/timeline_event/promote_from_note_spec.rb @@ -0,0 +1,85 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe Mutations::IncidentManagement::TimelineEvent::PromoteFromNote do + let_it_be(:current_user) { create(:user) } + let_it_be(:project) { create(:project) } + let_it_be(:incident) { create(:incident, project: project) } + let_it_be(:comment) { create(:note, project: project, noteable: incident) } + let_it_be(:issue) { create(:issue, project: project) } + let_it_be(:issue_comment) { create(:note, project: project, noteable: issue) } + let_it_be(:alert) { create(:alert_management_alert, project: project) } + let_it_be(:alert_comment) { create(:note, project: project, noteable: alert) } + + let(:args) { { note_id: comment.to_global_id.to_s } } + + specify { expect(described_class).to require_graphql_authorizations(:admin_incident_management_timeline_event) } + + describe '#resolve' do + subject(:resolve) { mutation_for(project, current_user).resolve(**args) } + + context 'when a user has permissions to create timeline event' do + let(:expected_timeline_event) do + instance_double( + 'IncidentManagement::TimelineEvent', + note: comment.note, + occurred_at: comment.created_at.to_s, + incident: incident, + author: current_user, + promoted_from_note: comment + ) + end + + before do + project.add_developer(current_user) + end + + it_behaves_like 'creating an incident timeline event' + + context 'when TimelineEvents::CreateService responds with an error' do + before do + allow_next_instance_of(::IncidentManagement::TimelineEvents::CreateService) do |service| + allow(service).to receive(:execute).and_return( + ServiceResponse.error(payload: { timeline_event: nil }, message: 'Some error') + ) + end + end + + it_behaves_like 'responding with an incident timeline errors', errors: ['Some error'] + end + end + + context 'when note does not exist' do + let(:args) { { note_id: 'gid://gitlab/Note/0' } } + + it 'raises an error' do + expect { resolve }.to raise_error(Gitlab::Graphql::Errors::ResourceNotAvailable) + end + end + + context 'when note does not belong to an incident' do + let(:args) { { note_id: issue_comment.to_global_id.to_s } } + + it 'raises an error' do + expect { resolve }.to raise_error(Gitlab::Graphql::Errors::ResourceNotAvailable) + end + end + + context 'when note belongs to anything else but issuable' do + let(:args) { { note_id: alert_comment.to_global_id.to_s } } + + it 'raises an error' do + expect { resolve }.to raise_error(Gitlab::Graphql::Errors::ResourceNotAvailable) + end + end + + it_behaves_like 'failing to create an incident timeline event' + end + + private + + def mutation_for(project, user) + described_class.new(object: project, context: { current_user: user }, field: nil) + end +end diff --git a/spec/graphql/mutations/incident_management/timeline_event/update_spec.rb b/spec/graphql/mutations/incident_management/timeline_event/update_spec.rb new file mode 100644 index 00000000000..8296e5c6c15 --- /dev/null +++ b/spec/graphql/mutations/incident_management/timeline_event/update_spec.rb @@ -0,0 +1,100 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe Mutations::IncidentManagement::TimelineEvent::Update do + let_it_be(:developer) { create(:user) } + let_it_be(:reporter) { create(:user) } + let_it_be(:project) { create(:project) } + let_it_be(:incident) { create(:incident, project: project) } + let_it_be_with_reload(:timeline_event) do + create(:incident_management_timeline_event, project: project, incident: incident) + end + + let(:args) do + { + id: timeline_event_id, + note: note, + occurred_at: occurred_at + } + end + + let(:note) { 'Updated Note' } + let(:timeline_event_id) { GitlabSchema.id_from_object(timeline_event).to_s } + let(:occurred_at) { 1.minute.ago } + + before do + project.add_developer(developer) + project.add_reporter(reporter) + end + + describe '#resolve' do + let(:current_user) { developer } + + subject(:resolve) { mutation_for(current_user).resolve(**args) } + + shared_examples 'failed update with a top-level access error' do |error| + specify do + expect { resolve }.to raise_error( + Gitlab::Graphql::Errors::ResourceNotAvailable, + error || Gitlab::Graphql::Authorize::AuthorizeResource::RESOURCE_ACCESS_ERROR + ) + end + end + + context 'when user has permissions to update the timeline event' do + context 'when timeline event exists' do + it 'updates the timeline event' do + expect { resolve }.to change { timeline_event.reload.note }.to(note) + .and change { timeline_event.reload.occurred_at.to_s }.to(occurred_at.to_s) + end + + it 'returns updated timeline event' do + expect(resolve).to eq( + timeline_event: timeline_event.reload, + errors: [] + ) + end + + context 'when there is a validation error' do + let(:occurred_at) { 'invalid date' } + + it 'does not update the timeline event' do + expect { resolve }.not_to change { timeline_event.reload.updated_at } + end + + it 'responds with error' do + expect(resolve).to eq( + timeline_event: nil, + errors: ["Occurred at can't be blank"] + ) + end + end + end + + context 'when timeline event cannot be found' do + let(:timeline_event_id) do + Gitlab::GlobalId.build( + nil, + model_name: ::IncidentManagement::TimelineEvent.name, + id: non_existing_record_id + ).to_s + end + + it_behaves_like 'failed update with a top-level access error' + end + end + + context 'when user does not have permissions to update the timeline event' do + let(:current_user) { reporter } + + it_behaves_like 'failed update with a top-level access error' + end + end + + private + + def mutation_for(user) + described_class.new(object: nil, context: { current_user: user }, field: nil) + end +end |