Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
Diffstat (limited to 'spec/graphql/resolvers/metrics/dashboards/annotation_resolver_spec.rb')
-rw-r--r--spec/graphql/resolvers/metrics/dashboards/annotation_resolver_spec.rb37
1 files changed, 5 insertions, 32 deletions
diff --git a/spec/graphql/resolvers/metrics/dashboards/annotation_resolver_spec.rb b/spec/graphql/resolvers/metrics/dashboards/annotation_resolver_spec.rb
index 2ca194d519c..75e0a816086 100644
--- a/spec/graphql/resolvers/metrics/dashboards/annotation_resolver_spec.rb
+++ b/spec/graphql/resolvers/metrics/dashboards/annotation_resolver_spec.rb
@@ -7,13 +7,12 @@ RSpec.describe Resolvers::Metrics::Dashboards::AnnotationResolver, feature_categ
describe '#resolve' do
context 'user with developer access' do
- subject(:resolve_annotations) { resolve(described_class, obj: dashboard, args: args, ctx: { current_user: current_user }) }
+ subject(:resolve_annotations) { resolve(described_class, obj: nil, args: args, ctx: { current_user: current_user }) }
let_it_be(:current_user) { create(:user) }
let_it_be(:environment) { create(:environment) }
let_it_be(:path) { 'config/prometheus/common_metrics.yml' }
- let(:dashboard) { PerformanceMonitoring::PrometheusDashboard.new(path: path, environment: environment) }
let(:args) do
{
from: 10.minutes.ago,
@@ -30,36 +29,6 @@ RSpec.describe Resolvers::Metrics::Dashboards::AnnotationResolver, feature_categ
end
context 'with annotation records' do
- let_it_be(:annotation_1) { create(:metrics_dashboard_annotation, environment: environment, starting_at: 9.minutes.ago, dashboard_path: path) }
-
- it 'loads annotations with usage of finder class', :aggregate_failures do
- expect_next_instance_of(::Metrics::Dashboards::AnnotationsFinder, dashboard: dashboard, params: args) do |finder|
- expect(finder).to receive(:execute).and_return [annotation_1]
- end
-
- expect(resolve_annotations).to eql [annotation_1]
- end
-
- context 'dashboard is missing' do
- let(:dashboard) { nil }
-
- it 'returns empty array', :aggregate_failures do
- expect(::Metrics::Dashboards::AnnotationsFinder).not_to receive(:new)
-
- expect(resolve_annotations).to be_empty
- end
- end
-
- context 'there are no annotations records' do
- it 'returns empty array' do
- allow_next_instance_of(::Metrics::Dashboards::AnnotationsFinder) do |finder|
- allow(finder).to receive(:execute).and_return []
- end
-
- expect(resolve_annotations).to be_empty
- end
- end
-
context 'when metrics dashboard feature is unavailable' do
before do
stub_feature_flags(remove_monitor_metrics: true)
@@ -69,6 +38,10 @@ RSpec.describe Resolvers::Metrics::Dashboards::AnnotationResolver, feature_categ
expect(resolve_annotations).to be_nil
end
end
+
+ it 'returns [] all the time' do
+ expect(resolve_annotations).to be_empty
+ end
end
end
end