diff options
Diffstat (limited to 'spec/helpers/environments_helper_spec.rb')
| -rw-r--r-- | spec/helpers/environments_helper_spec.rb | 82 |
1 files changed, 41 insertions, 41 deletions
diff --git a/spec/helpers/environments_helper_spec.rb b/spec/helpers/environments_helper_spec.rb index cb7d12b331a..d316f2b0a0a 100644 --- a/spec/helpers/environments_helper_spec.rb +++ b/spec/helpers/environments_helper_spec.rb @@ -18,34 +18,34 @@ RSpec.describe EnvironmentsHelper do it 'returns data' do expect(metrics_data).to include( - 'settings-path' => edit_project_service_path(project, 'prometheus'), - 'clusters-path' => project_clusters_path(project), - 'metrics-dashboard-base-path' => environment_metrics_path(environment), - 'current-environment-name' => environment.name, - 'documentation-path' => help_page_path('administration/monitoring/prometheus/index.md'), - 'add-dashboard-documentation-path' => help_page_path('operations/metrics/dashboards/index.md', anchor: 'add-a-new-dashboard-to-your-project'), - 'empty-getting-started-svg-path' => match_asset_path('/assets/illustrations/monitoring/getting_started.svg'), - 'empty-loading-svg-path' => match_asset_path('/assets/illustrations/monitoring/loading.svg'), - 'empty-no-data-svg-path' => match_asset_path('/assets/illustrations/monitoring/no_data.svg'), - 'empty-unable-to-connect-svg-path' => match_asset_path('/assets/illustrations/monitoring/unable_to_connect.svg'), - 'metrics-endpoint' => additional_metrics_project_environment_path(project, environment, format: :json), - 'deployments-endpoint' => project_environment_deployments_path(project, environment, format: :json), - 'default-branch' => 'master', - 'project-path' => project_path(project), - 'tags-path' => project_tags_path(project), - 'has-metrics' => "#{environment.has_metrics?}", - 'prometheus-status' => "#{environment.prometheus_status}", - 'external-dashboard-url' => nil, - 'environment-state' => environment.state, - 'custom-metrics-path' => project_prometheus_metrics_path(project), - 'validate-query-path' => validate_query_project_prometheus_metrics_path(project), - 'custom-metrics-available' => 'true', - 'alerts-endpoint' => project_prometheus_alerts_path(project, environment_id: environment.id, format: :json), - 'prometheus-alerts-available' => 'true', - 'custom-dashboard-base-path' => Gitlab::Metrics::Dashboard::RepoDashboardFinder::DASHBOARD_ROOT, - 'operations-settings-path' => project_settings_operations_path(project), - 'can-access-operations-settings' => 'true', - 'panel-preview-endpoint' => project_metrics_dashboards_builder_path(project, format: :json) + 'settings_path' => edit_project_service_path(project, 'prometheus'), + 'clusters_path' => project_clusters_path(project), + 'metrics_dashboard_base_path' => environment_metrics_path(environment), + 'current_environment_name' => environment.name, + 'documentation_path' => help_page_path('administration/monitoring/prometheus/index.md'), + 'add_dashboard_documentation_path' => help_page_path('operations/metrics/dashboards/index.md', anchor: 'add-a-new-dashboard-to-your-project'), + 'empty_getting_started_svg_path' => match_asset_path('/assets/illustrations/monitoring/getting_started.svg'), + 'empty_loading_svg_path' => match_asset_path('/assets/illustrations/monitoring/loading.svg'), + 'empty_no_data_svg_path' => match_asset_path('/assets/illustrations/monitoring/no_data.svg'), + 'empty_unable_to_connect_svg_path' => match_asset_path('/assets/illustrations/monitoring/unable_to_connect.svg'), + 'metrics_endpoint' => additional_metrics_project_environment_path(project, environment, format: :json), + 'deployments_endpoint' => project_environment_deployments_path(project, environment, format: :json), + 'default_branch' => 'master', + 'project_path' => project_path(project), + 'tags_path' => project_tags_path(project), + 'has_metrics' => "#{environment.has_metrics?}", + 'prometheus_status' => "#{environment.prometheus_status}", + 'external_dashboard_url' => nil, + 'environment_state' => environment.state, + 'custom_metrics_path' => project_prometheus_metrics_path(project), + 'validate_query_path' => validate_query_project_prometheus_metrics_path(project), + 'custom_metrics_available' => 'true', + 'alerts_endpoint' => project_prometheus_alerts_path(project, environment_id: environment.id, format: :json), + 'prometheus_alerts_available' => 'true', + 'custom_dashboard_base_path' => Gitlab::Metrics::Dashboard::RepoDashboardFinder::DASHBOARD_ROOT, + 'operations_settings_path' => project_settings_operations_path(project), + 'can_access_operations_settings' => 'true', + 'panel_preview_endpoint' => project_metrics_dashboards_builder_path(project, format: :json) ) end @@ -58,7 +58,7 @@ RSpec.describe EnvironmentsHelper do specify do expect(metrics_data).to include( - 'can-access-operations-settings' => 'false' + 'can_access_operations_settings' => 'false' ) end end @@ -72,7 +72,7 @@ RSpec.describe EnvironmentsHelper do it 'returns false' do expect(metrics_data).to include( - 'prometheus-alerts-available' => 'false' + 'prometheus_alerts_available' => 'false' ) end end @@ -83,7 +83,7 @@ RSpec.describe EnvironmentsHelper do end it 'adds external_dashboard_url' do - expect(metrics_data['external-dashboard-url']).to eq('http://gitlab.com') + expect(metrics_data['external_dashboard_url']).to eq('http://gitlab.com') end end @@ -94,7 +94,7 @@ RSpec.describe EnvironmentsHelper do subject { metrics_data } - it { is_expected.to include('environment-state' => 'stopped') } + it { is_expected.to include('environment_state' => 'stopped') } end context 'when request is from project scoped metrics path' do @@ -107,16 +107,16 @@ RSpec.describe EnvironmentsHelper do context '/:namespace/:project/-/metrics' do let(:path) { project_metrics_dashboard_path(project) } - it 'uses correct path for metrics-dashboard-base-path' do - expect(metrics_data['metrics-dashboard-base-path']).to eq(project_metrics_dashboard_path(project)) + it 'uses correct path for metrics_dashboard_base_path' do + expect(metrics_data['metrics_dashboard_base_path']).to eq(project_metrics_dashboard_path(project)) end end context '/:namespace/:project/-/metrics/some_custom_dashboard.yml' do let(:path) { "#{project_metrics_dashboard_path(project)}/some_custom_dashboard.yml" } - it 'uses correct path for metrics-dashboard-base-path' do - expect(metrics_data['metrics-dashboard-base-path']).to eq(project_metrics_dashboard_path(project)) + it 'uses correct path for metrics_dashboard_base_path' do + expect(metrics_data['metrics_dashboard_base_path']).to eq(project_metrics_dashboard_path(project)) end end end @@ -143,11 +143,11 @@ RSpec.describe EnvironmentsHelper do describe '#environment_logs_data' do it 'returns logs data' do expected_data = { - "environment-name": environment.name, - "environments-path": project_environments_path(project, format: :json), - "environment-id": environment.id, - "cluster-applications-documentation-path" => help_page_path('user/clusters/applications.md', anchor: 'elastic-stack'), - "clusters-path": project_clusters_path(project, format: :json) + "environment_name": environment.name, + "environments_path": project_environments_path(project, format: :json), + "environment_id": environment.id, + "cluster_applications_documentation_path" => help_page_path('user/clusters/applications.md', anchor: 'elastic-stack'), + "clusters_path": project_clusters_path(project, format: :json) } expect(helper.environment_logs_data(project, environment)).to eq(expected_data) |