1 files changed, 16 insertions, 8 deletions
diff --git a/spec/lib/gitlab/ci/config/entry/rules/rule_spec.rb b/spec/lib/gitlab/ci/config/entry/rules/rule_spec.rb
index d1bd22e5573..86270788431 100644
--- a/spec/lib/gitlab/ci/config/entry/rules/rule_spec.rb
+++ b/spec/lib/gitlab/ci/config/entry/rules/rule_spec.rb
@@ -92,12 +92,10 @@ RSpec.describe Gitlab::Ci::Config::Entry::Rules::Rule do
     context 'when using an if: clause with lookahead regex character "?"' do
       let(:config) { { if: '$CI_COMMIT_REF =~ /^(?!master).+/' } }
 
-      context 'when allow_unsafe_ruby_regexp is disabled' do
-        it { is_expected.not_to be_valid }
+      it { is_expected.not_to be_valid }
 
-        it 'reports an error about invalid expression syntax' do
-          expect(subject.errors).to include(/invalid expression syntax/)
-        end
+      it 'reports an error about invalid expression syntax' do
+        expect(subject.errors).to include(/invalid expression syntax/)
       end
     end
 
@@ -174,13 +172,13 @@ RSpec.describe Gitlab::Ci::Config::Entry::Rules::Rule do
     end
 
     context 'specifying a delayed job' do
-      let(:config) { { if: '$THIS || $THAT', when: 'delayed', start_in: '15 minutes' } }
+      let(:config) { { if: '$THIS || $THAT', when: 'delayed', start_in: '2 days' } }
 
       it { is_expected.to be_valid }
 
       it 'sets attributes for the job delay' do
         expect(entry.when).to eq('delayed')
-        expect(entry.start_in).to eq('15 minutes')
+        expect(entry.start_in).to eq('2 days')
       end
 
       context 'without a when: key' do
@@ -198,10 +196,20 @@ RSpec.describe Gitlab::Ci::Config::Entry::Rules::Rule do
 
         it { is_expected.not_to be_valid }
 
-        it 'returns an error about tstart_in being blank' do
+        it 'returns an error about start_in being blank' do
           expect(entry.errors).to include(/start in can't be blank/)
         end
       end
+
+      context 'when start_in value is longer than a week' do
+        let(:config) { { if: '$THIS || $THAT', when: 'delayed', start_in: '2 weeks' } }
+
+        it { is_expected.not_to be_valid }
+
+        it 'returns an error about start_in exceeding the limit' do
+          expect(entry.errors).to include(/start in should not exceed the limit/)
+        end
+      end
     end
 
     context 'when specifying unknown policy' do