Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
Diffstat (limited to 'spec/lib/gitlab/ci/parsers/codequality/code_climate_spec.rb')
-rw-r--r--spec/lib/gitlab/ci/parsers/codequality/code_climate_spec.rb62
1 files changed, 61 insertions, 1 deletions
diff --git a/spec/lib/gitlab/ci/parsers/codequality/code_climate_spec.rb b/spec/lib/gitlab/ci/parsers/codequality/code_climate_spec.rb
index 6a08e8f0b7f..1ef341ff863 100644
--- a/spec/lib/gitlab/ci/parsers/codequality/code_climate_spec.rb
+++ b/spec/lib/gitlab/ci/parsers/codequality/code_climate_spec.rb
@@ -4,7 +4,7 @@ require 'spec_helper'
RSpec.describe Gitlab::Ci::Parsers::Codequality::CodeClimate do
describe '#parse!' do
- subject(:parse) { described_class.new.parse!(code_climate, codequality_report) }
+ subject(:parse) { described_class.new.parse!(code_climate, codequality_report, metadata) }
let(:codequality_report) { Gitlab::Ci::Reports::CodequalityReports.new }
let(:code_climate) do
@@ -35,6 +35,15 @@ RSpec.describe Gitlab::Ci::Parsers::Codequality::CodeClimate do
].to_json
end
+ let_it_be(:group) { create(:group, name: 'test-group') }
+ let_it_be(:project) { create(:project, path: 'test-project', group: group) }
+ let(:metadata) do
+ {
+ project: project,
+ commit_sha: 'f0cc5229e2aa5e9429f1b17a3b3b102f21d7fe31'
+ }
+ end
+
context "when data is code_climate style JSON" do
context "when there are no degradations" do
let(:code_climate) { [].to_json }
@@ -133,5 +142,56 @@ RSpec.describe Gitlab::Ci::Parsers::Codequality::CodeClimate do
expect(codequality_report.degradations_count).to eq(0)
end
end
+
+ context 'for web_url' do
+ let(:code_climate) do
+ [
+ {
+ "categories": [
+ "Complexity"
+ ],
+ "check_name": "argument_count",
+ "content": {
+ "body": ""
+ },
+ "description": "Method `new_array` has 12 arguments (exceeds 4 allowed). Consider refactoring.",
+ "fingerprint": "15cdb5c53afd42bc22f8ca366a08d547",
+ "location": {
+ "path": "foo.rb",
+ "lines": {
+ "begin": 10,
+ "end": 10
+ }
+ },
+ "other_locations": [],
+ "remediation_points": 900000,
+ "severity": "major",
+ "type": "issue",
+ "engine_name": "structure"
+ }
+ ].to_json
+ end
+
+ context 'when metadata has project and commit_sha' do
+ it 'adds a non nil url' do
+ want = 'http://localhost/test-group/test-project/-/blob/f0cc5229e2aa5e9429f1b17a3b3b102f21d7fe31/foo.rb#L10'
+ expect { parse }.not_to raise_error
+
+ expect(codequality_report.degradations_count).to eq(1)
+ expect(codequality_report.all_degradations[0]['web_url']).to eq(want)
+ end
+ end
+
+ context 'when metadata does not have project and commit_sha' do
+ let(:metadata) { {} }
+
+ it 'adds a nil url' do
+ expect { parse }.not_to raise_error
+
+ expect(codequality_report.degradations_count).to eq(1)
+ expect(codequality_report.all_degradations[0]['web_url']).to be_nil
+ end
+ end
+ end
end
end