1 files changed, 23 insertions, 8 deletions

diff --git a/spec/lib/gitlab/ci/parsers/security/sast_spec.rb b/spec/lib/gitlab/ci/parsers/security/sast_spec.rb
index 4bc48f6611a..f6113308201 100644
--- a/spec/lib/gitlab/ci/parsers/security/sast_spec.rb
+++ b/spec/lib/gitlab/ci/parsers/security/sast_spec.rb
@@ -10,24 +10,39 @@ RSpec.describe Gitlab::Ci::Parsers::Security::Sast do
 
     let(:created_at) { 2.weeks.ago }
 
-    context "when parsing valid reports" do
-      where(:report_format, :report_version, :scanner_length, :finding_length, :identifier_length, :file_path, :line) do
-        :sast               | '14.0.0' | 1 | 5  | 6  | 'groovy/src/main/java/com/gitlab/security_products/tests/App.groovy' | 47
-        :sast_deprecated    | '1.2'    | 3 | 33 | 17 | 'python/hardcoded/hardcoded-tmp.py'                                  | 1
+    context "when passing valid report" do
+      # rubocop: disable Layout/LineLength
+      where(:report_format, :report_version, :scanner_length, :finding_length, :identifier_length, :file_path, :start_line, :end_line, :primary_identifiers_length) do
+        :sast                               | '14.0.0' | 1 | 5  | 6  | 'groovy/src/main/java/com/gitlab/security_products/tests/App.groovy' | 47 | 47  | nil
+        :sast_semgrep_for_multiple_findings | '14.0.4' | 1 | 2  | 6  | 'app/app.py'                                                         | 39 | nil | 2
       end
+      # rubocop: enable Layout/LineLength
 
       with_them do
-        let(:report) { Gitlab::Ci::Reports::Security::Report.new(artifact.file_type, pipeline, created_at) }
+        let(:report) do
+          Gitlab::Ci::Reports::Security::Report.new(
+            artifact.file_type,
+            pipeline,
+            created_at
+          )
+        end
+
         let(:artifact) { create(:ci_job_artifact, report_format) }
 
         before do
-          artifact.each_blob { |blob| described_class.parse!(blob, report) }
+          artifact.each_blob { |blob| described_class.parse!(blob, report, validate: true) }
         end
 
         it "parses all identifiers and findings" do
           expect(report.findings.length).to eq(finding_length)
           expect(report.identifiers.length).to eq(identifier_length)
           expect(report.scanners.length).to eq(scanner_length)
+
+          if primary_identifiers_length
+            expect(
+              report.scanners.each_value.first.primary_identifiers.length
+            ).to eq(primary_identifiers_length)
+          end
         end
 
         it 'generates expected location' do
@@ -36,8 +51,8 @@ RSpec.describe Gitlab::Ci::Parsers::Security::Sast do
           expect(location).to be_a(::Gitlab::Ci::Reports::Security::Locations::Sast)
           expect(location).to have_attributes(
             file_path: file_path,
-            end_line: line,
-            start_line: line
+            end_line: end_line,
+            start_line: start_line
           )
         end