1 files changed, 4 insertions, 131 deletions

diff --git a/spec/lib/gitlab/danger/commit_linter_spec.rb b/spec/lib/gitlab/danger/commit_linter_spec.rb
index ebfeedba700..d3d86037a53 100644
--- a/spec/lib/gitlab/danger/commit_linter_spec.rb
+++ b/spec/lib/gitlab/danger/commit_linter_spec.rb
@@ -98,28 +98,6 @@ RSpec.describe Gitlab::Danger::CommitLinter do
     end
   end
 
-  describe '#failed?' do
-    context 'with no failures' do
-      it { expect(commit_linter).not_to be_failed }
-    end
-
-    context 'with failures' do
-      before do
-        commit_linter.add_problem(:details_line_too_long)
-      end
-
-      it { expect(commit_linter).to be_failed }
-    end
-  end
-
-  describe '#add_problem' do
-    it 'stores messages in #failures' do
-      commit_linter.add_problem(:details_line_too_long)
-
-      expect(commit_linter.problems).to eq({ details_line_too_long: described_class::PROBLEMS[:details_line_too_long] })
-    end
-  end
-
   shared_examples 'a valid commit' do
     it 'does not have any problem' do
       commit_linter.lint
@@ -129,113 +107,6 @@ RSpec.describe Gitlab::Danger::CommitLinter do
   end
 
   describe '#lint' do
-    describe 'subject' do
-      context 'when subject valid' do
-        it_behaves_like 'a valid commit'
-      end
-
-      context 'when subject is too short' do
-        let(:commit_message) { 'A B' }
-
-        it 'adds a problem' do
-          expect(commit_linter).to receive(:add_problem).with(:subject_too_short, described_class::DEFAULT_SUBJECT_DESCRIPTION)
-
-          commit_linter.lint
-        end
-      end
-
-      context 'when subject is too long' do
-        let(:commit_message) { 'A B ' + 'C' * described_class::MAX_LINE_LENGTH }
-
-        it 'adds a problem' do
-          expect(commit_linter).to receive(:add_problem).with(:subject_too_long, described_class::DEFAULT_SUBJECT_DESCRIPTION)
-
-          commit_linter.lint
-        end
-      end
-
-      context 'when subject is a WIP' do
-        let(:final_message) { 'A B C' }
-        # commit message with prefix will be over max length. commit message without prefix will be of maximum size
-        let(:commit_message) { described_class::WIP_PREFIX + final_message + 'D' * (described_class::MAX_LINE_LENGTH - final_message.size) }
-
-        it 'does not have any problems' do
-          commit_linter.lint
-
-          expect(commit_linter.problems).to be_empty
-        end
-      end
-
-      context 'when subject is too short and too long' do
-        let(:commit_message) { 'A ' + 'B' * described_class::MAX_LINE_LENGTH }
-
-        it 'adds a problem' do
-          expect(commit_linter).to receive(:add_problem).with(:subject_too_short, described_class::DEFAULT_SUBJECT_DESCRIPTION)
-          expect(commit_linter).to receive(:add_problem).with(:subject_too_long, described_class::DEFAULT_SUBJECT_DESCRIPTION)
-
-          commit_linter.lint
-        end
-      end
-
-      context 'when subject starts with lowercase' do
-        let(:commit_message) { 'a B C' }
-
-        it 'adds a problem' do
-          expect(commit_linter).to receive(:add_problem).with(:subject_starts_with_lowercase, described_class::DEFAULT_SUBJECT_DESCRIPTION)
-
-          commit_linter.lint
-        end
-      end
-
-      [
-        '[ci skip] A commit message',
-        '[Ci skip] A commit message',
-        '[API] A commit message',
-        'api: A commit message',
-        'API: A commit message'
-      ].each do |message|
-        context "when subject is '#{message}'" do
-          let(:commit_message) { message }
-
-          it 'does not add a problem' do
-            expect(commit_linter).not_to receive(:add_problem)
-
-            commit_linter.lint
-          end
-        end
-      end
-
-      [
-        '[ci skip]A commit message',
-        '[Ci skip]  A commit message',
-        '[ci skip] a commit message',
-        'API: a commit message',
-        'API: a commit message',
-        'api: a commit message',
-        '! A commit message'
-      ].each do |message|
-        context "when subject is '#{message}'" do
-          let(:commit_message) { message }
-
-          it 'adds a problem' do
-            expect(commit_linter).to receive(:add_problem).with(:subject_starts_with_lowercase, described_class::DEFAULT_SUBJECT_DESCRIPTION)
-
-            commit_linter.lint
-          end
-        end
-      end
-
-      context 'when subject ends with a period' do
-        let(:commit_message) { 'A B C.' }
-
-        it 'adds a problem' do
-          expect(commit_linter).to receive(:add_problem).with(:subject_ends_with_a_period, described_class::DEFAULT_SUBJECT_DESCRIPTION)
-
-          commit_linter.lint
-        end
-      end
-    end
-
     describe 'separator' do
       context 'when separator is missing' do
         let(:commit_message) { "A B C\n" }
@@ -300,8 +171,10 @@ RSpec.describe Gitlab::Danger::CommitLinter do
         end
       end
 
-      context 'when details exceeds the max line length including a URL' do
-        let(:commit_message) { "A B C\n\nhttps://gitlab.com" + 'D' * described_class::MAX_LINE_LENGTH }
+      context 'when details exceeds the max line length including URLs' do
+        let(:commit_message) do
+          "A B C\n\nsome message with https://example.com and https://gitlab.com" + 'D' * described_class::MAX_LINE_LENGTH
+        end
 
         it_behaves_like 'a valid commit'
       end