1 files changed, 73 insertions, 50 deletions

diff --git a/spec/lib/gitlab/database/dictionary_spec.rb b/spec/lib/gitlab/database/dictionary_spec.rb
index 6d2de41468b..261cf27ed69 100644
--- a/spec/lib/gitlab/database/dictionary_spec.rb
+++ b/spec/lib/gitlab/database/dictionary_spec.rb
@@ -3,81 +3,104 @@
 require 'spec_helper'
 
 RSpec.describe Gitlab::Database::Dictionary, feature_category: :database do
-  subject(:database_dictionary) { described_class.new(file_path) }
+  describe '.entries' do
+    it 'all tables and views are unique' do
+      table_and_view_names = described_class.entries('')
+      table_and_view_names += described_class.entries('views')
+
+      # ignore gitlab_internal due to `ar_internal_metadata`, `schema_migrations`
+      table_and_view_names = table_and_view_names
+        .reject { |database_dictionary| database_dictionary.schema?('gitlab_internal') }
+
+      duplicated_tables = table_and_view_names
+        .group_by(&:key_name)
+        .select { |_, schemas| schemas.count > 1 }
+        .keys
+
+      expect(duplicated_tables).to be_empty, \
+        "Duplicated table(s) #{duplicated_tables.to_a} found in #{described_class}.views_and_tables_to_schema. " \
+        "Any duplicated table must be removed from db/docs/ or ee/db/docs/. " \
+        "More info: https://docs.gitlab.com/ee/development/database/database_dictionary.html"
+    end
+  end
 
-  context 'for a table' do
-    let(:file_path) { 'db/docs/application_settings.yml' }
+  describe '::Entry' do
+    subject(:database_dictionary) { described_class::Entry.new(file_path) }
 
-    describe '#name_and_schema' do
-      it 'returns the name of the table and its gitlab schema' do
-        expect(database_dictionary.name_and_schema).to match_array(['application_settings', :gitlab_main_clusterwide])
+    context 'for a table' do
+      let(:file_path) { 'db/docs/application_settings.yml' }
+
+      describe '#name_and_schema' do
+        it 'returns the name of the table and its gitlab schema' do
+          expect(database_dictionary.name_and_schema).to match_array(['application_settings', :gitlab_main_clusterwide])
+        end
       end
-    end
 
-    describe '#table_name' do
-      it 'returns the name of the table' do
-        expect(database_dictionary.table_name).to eq('application_settings')
+      describe '#table_name' do
+        it 'returns the name of the table' do
+          expect(database_dictionary.table_name).to eq('application_settings')
+        end
       end
-    end
 
-    describe '#view_name' do
-      it 'returns nil' do
-        expect(database_dictionary.view_name).to be_nil
+      describe '#view_name' do
+        it 'returns nil' do
+          expect(database_dictionary.view_name).to be_nil
+        end
       end
-    end
 
-    describe '#milestone' do
-      it 'returns the milestone in which the table was introduced' do
-        expect(database_dictionary.milestone).to eq('7.7')
+      describe '#milestone' do
+        it 'returns the milestone in which the table was introduced' do
+          expect(database_dictionary.milestone).to eq('7.7')
+        end
       end
-    end
 
-    describe '#gitlab_schema' do
-      it 'returns the gitlab_schema of the table' do
-        expect(database_dictionary.table_name).to eq('application_settings')
+      describe '#gitlab_schema' do
+        it 'returns the gitlab_schema of the table' do
+          expect(database_dictionary.table_name).to eq('application_settings')
+        end
       end
-    end
 
-    describe '#schema?' do
-      it 'checks if the given schema matches the schema of the table' do
-        expect(database_dictionary.schema?('gitlab_main')).to eq(false)
-        expect(database_dictionary.schema?('gitlab_main_clusterwide')).to eq(true)
+      describe '#schema?' do
+        it 'checks if the given schema matches the schema of the table' do
+          expect(database_dictionary.schema?('gitlab_main')).to eq(false)
+          expect(database_dictionary.schema?('gitlab_main_clusterwide')).to eq(true)
+        end
       end
-    end
 
-    describe '#key_name' do
-      it 'returns the value of the name of the table' do
-        expect(database_dictionary.key_name).to eq('application_settings')
+      describe '#key_name' do
+        it 'returns the value of the name of the table' do
+          expect(database_dictionary.key_name).to eq('application_settings')
+        end
       end
-    end
 
-    describe '#validate!' do
-      it 'raises an error if the gitlab_schema is empty' do
-        allow(database_dictionary).to receive(:gitlab_schema).and_return(nil)
+      describe '#validate!' do
+        it 'raises an error if the gitlab_schema is empty' do
+          allow(database_dictionary).to receive(:gitlab_schema).and_return(nil)
 
-        expect { database_dictionary.validate! }.to raise_error(Gitlab::Database::GitlabSchema::UnknownSchemaError)
+          expect { database_dictionary.validate! }.to raise_error(Gitlab::Database::GitlabSchema::UnknownSchemaError)
+        end
       end
     end
-  end
 
-  context 'for a view' do
-    let(:file_path) { 'db/docs/views/postgres_constraints.yml' }
+    context 'for a view' do
+      let(:file_path) { 'db/docs/views/postgres_constraints.yml' }
 
-    describe '#table_name' do
-      it 'returns nil' do
-        expect(database_dictionary.table_name).to be_nil
+      describe '#table_name' do
+        it 'returns nil' do
+          expect(database_dictionary.table_name).to be_nil
+        end
       end
-    end
 
-    describe '#view_name' do
-      it 'returns the name of the view' do
-        expect(database_dictionary.view_name).to eq('postgres_constraints')
+      describe '#view_name' do
+        it 'returns the name of the view' do
+          expect(database_dictionary.view_name).to eq('postgres_constraints')
+        end
       end
-    end
 
-    describe '#key_name' do
-      it 'returns the value of the name of the view' do
-        expect(database_dictionary.key_name).to eq('postgres_constraints')
+      describe '#key_name' do
+        it 'returns the value of the name of the view' do
+          expect(database_dictionary.key_name).to eq('postgres_constraints')
+        end
       end
     end
   end