1 files changed, 70 insertions, 0 deletions
diff --git a/spec/lib/gitlab/database/query_analyzers/gitlab_schemas_validate_connection_spec.rb b/spec/lib/gitlab/database/query_analyzers/gitlab_schemas_validate_connection_spec.rb
new file mode 100644
index 00000000000..5e8afc0102e
--- /dev/null
+++ b/spec/lib/gitlab/database/query_analyzers/gitlab_schemas_validate_connection_spec.rb
@@ -0,0 +1,70 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe Gitlab::Database::QueryAnalyzers::GitlabSchemasValidateConnection, query_analyzers: false do
+  let(:analyzer) { described_class }
+
+  context 'properly observes all queries', :request_store do
+    using RSpec::Parameterized::TableSyntax
+
+    where do
+      {
+        "for simple query observes schema correctly" => {
+          model: ApplicationRecord,
+          sql: "SELECT 1 FROM projects",
+          expect_error: nil,
+          setup: nil
+        },
+        "for query accessing gitlab_ci and gitlab_main" => {
+          model: ApplicationRecord,
+          sql: "SELECT 1 FROM projects LEFT JOIN ci_builds ON ci_builds.project_id=projects.id",
+          expect_error: /The query tried to access \["projects", "ci_builds"\]/,
+          setup: -> (_) { skip_if_multiple_databases_not_setup }
+        },
+        "for query accessing gitlab_ci and gitlab_main the gitlab_schemas is always ordered" => {
+          model: ApplicationRecord,
+          sql: "SELECT 1 FROM ci_builds LEFT JOIN projects ON ci_builds.project_id=projects.id",
+          expect_error: /The query tried to access \["ci_builds", "projects"\]/,
+          setup: -> (_) { skip_if_multiple_databases_not_setup }
+        },
+        "for query accessing main table from CI database" => {
+          model: Ci::ApplicationRecord,
+          sql: "SELECT 1 FROM projects",
+          expect_error: /The query tried to access \["projects"\]/,
+          setup: -> (_) { skip_if_multiple_databases_not_setup }
+        },
+        "for query accessing CI database" => {
+          model: Ci::ApplicationRecord,
+          sql: "SELECT 1 FROM ci_builds",
+          expect_error: nil
+        },
+        "for query accessing CI table from main database" => {
+          model: ::ApplicationRecord,
+          sql: "SELECT 1 FROM ci_builds",
+          expect_error: /The query tried to access \["ci_builds"\]/,
+          setup: -> (_) { skip_if_multiple_databases_not_setup }
+        }
+      }
+    end
+
+    with_them do
+      it do
+        instance_eval(&setup) if setup
+
+        if expect_error
+          expect { process_sql(model, sql) }.to raise_error(expect_error)
+        else
+          expect { process_sql(model, sql) }.not_to raise_error
+        end
+      end
+    end
+  end
+
+  def process_sql(model, sql)
+    Gitlab::Database::QueryAnalyzer.instance.within([analyzer]) do
+      # Skip load balancer and retrieve connection assigned to model
+      Gitlab::Database::QueryAnalyzer.instance.send(:process_sql, sql, model.retrieve_connection)
+    end
+  end
+end