1 files changed, 57 insertions, 18 deletions

diff --git a/spec/lib/gitlab/github_import/importer/events/changed_label_spec.rb b/spec/lib/gitlab/github_import/importer/events/changed_label_spec.rb
index 4476b4123ee..6a409762599 100644
--- a/spec/lib/gitlab/github_import/importer/events/changed_label_spec.rb
+++ b/spec/lib/gitlab/github_import/importer/events/changed_label_spec.rb
@@ -10,7 +10,9 @@ RSpec.describe Gitlab::GithubImport::Importer::Events::ChangedLabel do
 
   let(:client) { instance_double('Gitlab::GithubImport::Client') }
   let(:issuable) { create(:issue, project: project) }
-  let!(:label) { create(:label, project: project) }
+  let(:label) { create(:label, project: project) }
+  let(:label_title) { label.title }
+  let(:label_id) { label.id }
 
   let(:issue_event) do
     Gitlab::GithubImport::Representation::IssueEvent.from_json_hash(
@@ -18,7 +20,7 @@ RSpec.describe Gitlab::GithubImport::Importer::Events::ChangedLabel do
       'actor' => { 'id' => user.id, 'login' => user.username },
       'event' => event_type,
       'commit_id' => nil,
-      'label_title' => label.title,
+      'label_title' => label_title,
       'created_at' => '2022-04-26 18:30:53 UTC',
       'issue' => { 'number' => issuable.iid, pull_request: issuable.is_a?(MergeRequest) }
     )
@@ -27,7 +29,7 @@ RSpec.describe Gitlab::GithubImport::Importer::Events::ChangedLabel do
   let(:event_attrs) do
     {
       user_id: user.id,
-      label_id: label.id,
+      label_id: label_id,
       created_at: issue_event.created_at
     }.stringify_keys
   end
@@ -42,7 +44,6 @@ RSpec.describe Gitlab::GithubImport::Importer::Events::ChangedLabel do
   end
 
   before do
-    allow(Gitlab::Cache::Import::Caching).to receive(:read_integer).and_return(label.id)
     allow_next_instance_of(Gitlab::GithubImport::IssuableFinder) do |finder|
       allow(finder).to receive(:database_id).and_return(issuable.id)
     end
@@ -52,16 +53,35 @@ RSpec.describe Gitlab::GithubImport::Importer::Events::ChangedLabel do
   end
 
   context 'with Issue' do
-    context 'when importing a labeled event' do
-      let(:event_type) { 'labeled' }
-      let(:expected_event_attrs) { event_attrs.merge(issue_id: issuable.id, action: 'add') }
+    context 'when importing event with associated label' do
+      before do
+        allow(Gitlab::Cache::Import::Caching).to receive(:read_integer).and_return(label.id)
+      end
 
-      it_behaves_like 'new event'
+      context 'when importing a labeled event' do
+        let(:event_type) { 'labeled' }
+        let(:expected_event_attrs) { event_attrs.merge(issue_id: issuable.id, action: 'add') }
+
+        it_behaves_like 'new event'
+      end
+
+      context 'when importing an unlabeled event' do
+        let(:event_type) { 'unlabeled' }
+        let(:expected_event_attrs) { event_attrs.merge(issue_id: issuable.id, action: 'remove') }
+
+        it_behaves_like 'new event'
+      end
     end
 
-    context 'when importing an unlabeled event' do
-      let(:event_type) { 'unlabeled' }
-      let(:expected_event_attrs) { event_attrs.merge(issue_id: issuable.id, action: 'remove') }
+    context 'when importing event without associated label' do
+      before do
+        allow(Gitlab::Cache::Import::Caching).to receive(:read_integer).and_return(nil)
+      end
+
+      let(:label_title) { 'deleted_label' }
+      let(:label_id) { nil }
+      let(:event_type) { 'labeled' }
+      let(:expected_event_attrs) { event_attrs.merge(issue_id: issuable.id, action: 'add') }
 
       it_behaves_like 'new event'
     end
@@ -70,16 +90,35 @@ RSpec.describe Gitlab::GithubImport::Importer::Events::ChangedLabel do
   context 'with MergeRequest' do
     let(:issuable) { create(:merge_request, source_project: project, target_project: project) }
 
-    context 'when importing a labeled event' do
-      let(:event_type) { 'labeled' }
-      let(:expected_event_attrs) { event_attrs.merge(merge_request_id: issuable.id, action: 'add') }
+    context 'when importing event with associated label' do
+      before do
+        allow(Gitlab::Cache::Import::Caching).to receive(:read_integer).and_return(label.id)
+      end
 
-      it_behaves_like 'new event'
+      context 'when importing a labeled event' do
+        let(:event_type) { 'labeled' }
+        let(:expected_event_attrs) { event_attrs.merge(merge_request_id: issuable.id, action: 'add') }
+
+        it_behaves_like 'new event'
+      end
+
+      context 'when importing an unlabeled event' do
+        let(:event_type) { 'unlabeled' }
+        let(:expected_event_attrs) { event_attrs.merge(merge_request_id: issuable.id, action: 'remove') }
+
+        it_behaves_like 'new event'
+      end
     end
 
-    context 'when importing an unlabeled event' do
-      let(:event_type) { 'unlabeled' }
-      let(:expected_event_attrs) { event_attrs.merge(merge_request_id: issuable.id, action: 'remove') }
+    context 'when importing event without associated label' do
+      before do
+        allow(Gitlab::Cache::Import::Caching).to receive(:read_integer).and_return(nil)
+      end
+
+      let(:label_title) { 'deleted_label' }
+      let(:label_id) { nil }
+      let(:event_type) { 'labeled' }
+      let(:expected_event_attrs) { event_attrs.merge(merge_request_id: issuable.id, action: 'add') }
 
       it_behaves_like 'new event'
     end