1 files changed, 23 insertions, 27 deletions

diff --git a/spec/lib/gitlab/github_import/importer/pull_requests_importer_spec.rb b/spec/lib/gitlab/github_import/importer/pull_requests_importer_spec.rb
index c5846fa7a87..aa92abdb110 100644
--- a/spec/lib/gitlab/github_import/importer/pull_requests_importer_spec.rb
+++ b/spec/lib/gitlab/github_import/importer/pull_requests_importer_spec.rb
@@ -8,33 +8,30 @@ RSpec.describe Gitlab::GithubImport::Importer::PullRequestsImporter do
   let(:client) { double(:client) }
 
   let(:pull_request) do
-    double(
-      :response,
+    {
       number: 42,
       title: 'My Pull Request',
       body: 'This is my pull request',
       state: 'closed',
-      head: double(
-        :head,
+      head: {
         sha: '123abc',
         ref: 'my-feature',
-        repo: double(:repo, id: 400),
-        user: double(:user, id: 4, login: 'alice')
-      ),
-      base: double(
-        :base,
+        repo: { id: 400 },
+        user: { id: 4, login: 'alice' }
+      },
+      base: {
         sha: '456def',
         ref: 'master',
-        repo: double(:repo, id: 200)
-      ),
-      milestone: double(:milestone, number: 4),
-      user: double(:user, id: 4, login: 'alice'),
-      assignee: double(:user, id: 4, login: 'alice'),
-      merged_by: double(:user, id: 4, login: 'alice'),
+        repo: { id: 200 }
+      },
+      milestone: { number: 4 },
+      user: { id: 4, login: 'alice' },
+      assignee: { id: 4, login: 'alice' },
+      merged_by: { id: 4, login: 'alice' },
       created_at: 1.second.ago,
       updated_at: 1.second.ago,
       merged_at: 1.second.ago
-    )
+    }
   end
 
   describe '#parallel?' do
@@ -184,12 +181,11 @@ RSpec.describe Gitlab::GithubImport::Importer::PullRequestsImporter do
 
     context 'when the pull request was updated after the last update' do
       let(:pr) do
-        double(
-          :pr,
+        {
           updated_at: Time.zone.now,
-          head: double(:head, sha: '123'),
-          base: double(:base, sha: '456')
-        )
+          head: { sha: '123' },
+          base: { sha: '456' }
+        }
       end
 
       before do
@@ -201,7 +197,7 @@ RSpec.describe Gitlab::GithubImport::Importer::PullRequestsImporter do
       it 'returns true when the head SHA is not present' do
         expect(importer)
           .to receive(:commit_exists?)
-          .with(pr.head.sha)
+          .with('123')
           .and_return(false)
 
         expect(importer.update_repository?(pr)).to eq(true)
@@ -210,12 +206,12 @@ RSpec.describe Gitlab::GithubImport::Importer::PullRequestsImporter do
       it 'returns true when the base SHA is not present' do
         expect(importer)
           .to receive(:commit_exists?)
-          .with(pr.head.sha)
+          .with('123')
           .and_return(true)
 
         expect(importer)
           .to receive(:commit_exists?)
-          .with(pr.base.sha)
+          .with('456')
           .and_return(false)
 
         expect(importer.update_repository?(pr)).to eq(true)
@@ -224,12 +220,12 @@ RSpec.describe Gitlab::GithubImport::Importer::PullRequestsImporter do
       it 'returns false if both the head and base SHAs are present' do
         expect(importer)
           .to receive(:commit_exists?)
-          .with(pr.head.sha)
+          .with('123')
           .and_return(true)
 
         expect(importer)
           .to receive(:commit_exists?)
-          .with(pr.base.sha)
+          .with('456')
           .and_return(true)
 
         expect(importer.update_repository?(pr)).to eq(false)
@@ -238,7 +234,7 @@ RSpec.describe Gitlab::GithubImport::Importer::PullRequestsImporter do
 
     context 'when the pull request was updated before the last update' do
       it 'returns false' do
-        pr = double(:pr, updated_at: 1.year.ago)
+        pr = { updated_at: 1.year.ago }
 
         allow(project)
           .to receive(:last_repository_updated_at)