Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
Diffstat (limited to 'spec/lib/gitlab/github_import/object_counter_spec.rb')
-rw-r--r--spec/lib/gitlab/github_import/object_counter_spec.rb18
1 files changed, 17 insertions, 1 deletions
diff --git a/spec/lib/gitlab/github_import/object_counter_spec.rb b/spec/lib/gitlab/github_import/object_counter_spec.rb
index 668c11667b5..c9e4ac67061 100644
--- a/spec/lib/gitlab/github_import/object_counter_spec.rb
+++ b/spec/lib/gitlab/github_import/object_counter_spec.rb
@@ -7,7 +7,7 @@ RSpec.describe Gitlab::GithubImport::ObjectCounter, :clean_gitlab_redis_cache do
it 'validates the operation being incremented' do
expect { described_class.increment(project, :issue, :unknown) }
- .to raise_error(ArgumentError, 'Operation must be fetched or imported')
+ .to raise_error(ArgumentError, 'operation must be fetched or imported')
end
it 'increments the counter and saves the key to be listed in the summary later' do
@@ -33,4 +33,20 @@ RSpec.describe Gitlab::GithubImport::ObjectCounter, :clean_gitlab_redis_cache do
'imported' => { 'issue' => 2 }
})
end
+
+ it 'does not increment the counter if the given value is <= 0' do
+ expect(Gitlab::Metrics)
+ .not_to receive(:counter)
+
+ expect(Gitlab::Metrics)
+ .not_to receive(:counter)
+
+ described_class.increment(project, :issue, :fetched, value: 0)
+ described_class.increment(project, :issue, :imported, value: nil)
+
+ expect(described_class.summary(project)).to eq({
+ 'fetched' => {},
+ 'imported' => {}
+ })
+ end
end