Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
path: root/spec/lib/gitlab/observability_spec.rb
diff options
context:
space:
mode:
Diffstat (limited to 'spec/lib/gitlab/observability_spec.rb')
-rw-r--r--spec/lib/gitlab/observability_spec.rb204
1 files changed, 26 insertions, 178 deletions
diff --git a/spec/lib/gitlab/observability_spec.rb b/spec/lib/gitlab/observability_spec.rb
index 04c35f0ee3a..7af2daea11c 100644
--- a/spec/lib/gitlab/observability_spec.rb
+++ b/spec/lib/gitlab/observability_spec.rb
@@ -46,206 +46,54 @@ RSpec.describe Gitlab::Observability, feature_category: :error_tracking do
it { is_expected.to eq("#{described_class.observability_url}/v3/tenant/#{project.id}") }
end
- describe '.build_full_url' do
- let_it_be(:group) { build_stubbed(:group, id: 123) }
- let(:observability_url) { described_class.observability_url }
+ describe '.should_enable_observability_auth_scopes?' do
+ subject { described_class.should_enable_observability_auth_scopes?(resource) }
- it 'returns the full observability url for the given params' do
- url = described_class.build_full_url(group, '/foo?bar=baz', '/')
- expect(url).to eq("https://observe.gitlab.com/-/123/foo?bar=baz")
- end
-
- it 'handles missing / from observability_path' do
- url = described_class.build_full_url(group, 'foo?bar=baz', '/')
- expect(url).to eq("https://observe.gitlab.com/-/123/foo?bar=baz")
- end
-
- it 'sanitises observability_path' do
- url = described_class.build_full_url(group, "/test?groupId=<script>alert('attack!')</script>", '/')
- expect(url).to eq("https://observe.gitlab.com/-/123/test?groupId=alert('attack!')")
- end
-
- context 'when observability_path is missing' do
- it 'builds the url with the fallback_path' do
- url = described_class.build_full_url(group, nil, '/fallback')
- expect(url).to eq("https://observe.gitlab.com/-/123/fallback")
- end
-
- it 'defaults to / if fallback_path is also missing' do
- url = described_class.build_full_url(group, nil, nil)
- expect(url).to eq("https://observe.gitlab.com/-/123/")
+ let(:parent) { build_stubbed(:group) }
+ let(:resource) do
+ build_stubbed(:group, parent: parent).tap do |g|
+ g.namespace_settings = build_stubbed(:namespace_settings, namespace: g)
end
end
- end
- describe '.embeddable_url' do
before do
- stub_config_setting(url: "https://www.gitlab.com")
- # Can't use build/build_stubbed as we want the routes to be generated as well
- create(:group, path: 'test-path', id: 123)
- end
-
- context 'when URL is valid' do
- where(:input, :expected) do
- [
- [
- "https://www.gitlab.com/groups/test-path/-/observability/explore?observability_path=%2Fexplore%3FgroupId%3D14485840%26left%3D%255B%2522now-1h%2522,%2522now%2522,%2522new-sentry.gitlab.net%2522,%257B%257D%255D",
- "https://observe.gitlab.com/-/123/explore?groupId=14485840&left=%5B%22now-1h%22,%22now%22,%22new-sentry.gitlab.net%22,%7B%7D%5D"
- ],
- [
- "https://www.gitlab.com/groups/test-path/-/observability/explore?observability_path=/goto/foo",
- "https://observe.gitlab.com/-/123/goto/foo"
- ]
- ]
- end
-
- with_them do
- it 'returns an embeddable observability url' do
- expect(described_class.embeddable_url(input)).to eq(expected)
- end
- end
+ stub_feature_flags(observability_tracing: parent)
end
- context 'when URL is invalid' do
- where(:input) do
- [
- # direct links to observe.gitlab.com
- "https://observe.gitlab.com/-/123/explore",
- 'https://observe.gitlab.com/v1/auth/start',
-
- # invalid GitLab URL
- "not a link",
- "https://foo.bar/groups/test-path/-/observability/explore?observability_path=/explore",
- "http://www.gitlab.com/groups/test-path/-/observability/explore?observability_path=/explore",
- "https://www.gitlab.com:123/groups/test-path/-/observability/explore?observability_path=/explore",
- "https://www.gitlab.com@example.com/groups/test-path/-/observability/explore?observability_path=/explore",
- "https://www.gitlab.com/groups/test-path/-/observability/explore?observability_path=@example.com",
-
- # invalid group/controller/actions
- "https://www.gitlab.com/groups/INVALID_GROUP/-/observability/explore?observability_path=/explore",
- "https://www.gitlab.com/groups/test-path/-/INVALID_CONTROLLER/explore?observability_path=/explore",
- "https://www.gitlab.com/groups/test-path/-/observability/INVALID_ACTION?observability_path=/explore",
-
- # invalid observablity path
- "https://www.gitlab.com/groups/test-path/-/observability/explore",
- "https://www.gitlab.com/groups/test-path/-/observability/explore?missing_observability_path=/explore",
- "https://www.gitlab.com/groups/test-path/-/observability/explore?observability_path=/not_embeddable",
- "https://www.gitlab.com/groups/test-path/-/observability/explore?observability_path=/datasources",
- "https://www.gitlab.com/groups/test-path/-/observability/explore?observability_path=not a valid path"
- ]
+ describe 'when resource is group' do
+ context 'if observability_tracing FF enabled' do
+ it { is_expected.to be true }
end
- with_them do
- it 'returns nil' do
- expect(described_class.embeddable_url(input)).to be_nil
+ context 'if observability_tracing FF disabled' do
+ before do
+ stub_feature_flags(observability_tracing: false)
end
- end
-
- it 'returns nil if the path detection throws an error' do
- test_url = "https://www.gitlab.com/groups/test-path/-/observability/explore"
- allow(Rails.application.routes).to receive(:recognize_path).with(test_url) {
- raise ActionController::RoutingError, 'test'
- }
- expect(described_class.embeddable_url(test_url)).to be_nil
- end
-
- it 'returns nil if parsing observaboility path throws an error' do
- observability_path = 'some-path'
- test_url = "https://www.gitlab.com/groups/test-path/-/observability/explore?observability_path=#{observability_path}"
-
- allow(URI).to receive(:parse).and_call_original
- allow(URI).to receive(:parse).with(observability_path) {
- raise URI::InvalidURIError, 'test'
- }
- expect(described_class.embeddable_url(test_url)).to be_nil
+ it { is_expected.to be false }
end
end
- end
-
- describe '.allowed_for_action?' do
- let(:group) { build_stubbed(:group) }
- let(:user) { build_stubbed(:user) }
-
- before do
- allow(described_class).to receive(:allowed?).and_call_original
- end
-
- it 'returns false if action is nil' do
- expect(described_class.allowed_for_action?(user, group, nil)).to eq(false)
- end
- describe 'allowed? calls' do
- using RSpec::Parameterized::TableSyntax
+ describe 'when resource is project' do
+ let(:resource) { build_stubbed(:project, namespace: parent) }
- where(:action, :permission) do
- :foo | :admin_observability
- :explore | :read_observability
- :datasources | :admin_observability
- :manage | :admin_observability
- :dashboards | :read_observability
+ context 'if observability_tracing FF enabled' do
+ it { is_expected.to be true }
end
- with_them do
- it "calls allowed? with #{params[:permission]} when actions is #{params[:action]}" do
- described_class.allowed_for_action?(user, group, action)
- expect(described_class).to have_received(:allowed?).with(user, group, permission)
+ context 'if observability_tracing FF disabled' do
+ before do
+ stub_feature_flags(observability_tracing: false)
end
- end
- end
- end
-
- describe '.allowed?' do
- let(:user) { build_stubbed(:user) }
- let(:group) { build_stubbed(:group) }
- let(:test_permission) { :read_observability }
-
- before do
- allow(Ability).to receive(:allowed?).and_return(false)
- end
-
- subject do
- described_class.allowed?(user, group, test_permission)
- end
-
- it 'checks if ability is allowed for the given user and group' do
- allow(Ability).to receive(:allowed?).and_return(true)
-
- subject
-
- expect(Ability).to have_received(:allowed?).with(user, test_permission, group)
- end
-
- it 'checks for admin_observability if permission is missing' do
- described_class.allowed?(user, group)
-
- expect(Ability).to have_received(:allowed?).with(user, :admin_observability, group)
- end
-
- it 'returns true if the ability is allowed' do
- allow(Ability).to receive(:allowed?).and_return(true)
-
- expect(subject).to eq(true)
- end
- it 'returns false if the ability is not allowed' do
- allow(Ability).to receive(:allowed?).and_return(false)
-
- expect(subject).to eq(false)
- end
-
- it 'returns false if observability url is missing' do
- allow(described_class).to receive(:observability_url).and_return("")
-
- expect(subject).to eq(false)
+ it { is_expected.to be false }
+ end
end
- it 'returns false if group is missing' do
- expect(described_class.allowed?(user, nil, :read_observability)).to eq(false)
- end
+ describe 'when resource is not a group or project' do
+ let(:resource) { build_stubbed(:user) }
- it 'returns false if user is missing' do
- expect(described_class.allowed?(nil, group, :read_observability)).to eq(false)
+ it { is_expected.to be false }
end
end
end
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-12 10:35:39 +0300