diff options
Diffstat (limited to 'spec/lib/gitlab/patch/sidekiq_scheduled_enq_spec.rb')
-rw-r--r-- | spec/lib/gitlab/patch/sidekiq_scheduled_enq_spec.rb | 89 |
1 files changed, 89 insertions, 0 deletions
diff --git a/spec/lib/gitlab/patch/sidekiq_scheduled_enq_spec.rb b/spec/lib/gitlab/patch/sidekiq_scheduled_enq_spec.rb new file mode 100644 index 00000000000..f57257cd1c0 --- /dev/null +++ b/spec/lib/gitlab/patch/sidekiq_scheduled_enq_spec.rb @@ -0,0 +1,89 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe Gitlab::Patch::SidekiqScheduledEnq, :clean_gitlab_redis_queues, feature_category: :scalability do + describe '#enqueue_jobs' do + let_it_be(:payload) { {} } + + before do + allow(Sidekiq).to receive(:load_json).and_return(payload) + + # stub data in both namespaces + Sidekiq.redis { |c| c.zadd('schedule', 100, 'dummy') } + Gitlab::Redis::Queues.with { |c| c.zadd('schedule', 100, 'dummy') } + end + + subject { Sidekiq::Scheduled::Enq.new.enqueue_jobs } + + it 'polls both namespaces by default' do + expect(Sidekiq::Client).to receive(:push).with(payload).twice + + subject + + Sidekiq.redis do |conn| + expect(conn.zcard('schedule')).to eq(0) + end + + Gitlab::Redis::Queues.with do |conn| + expect(conn.zcard('schedule')).to eq(0) + end + end + + context 'when SIDEKIQ_ENABLE_DUAL_NAMESPACE_POLLING is disabled' do + before do + stub_env('SIDEKIQ_ENABLE_DUAL_NAMESPACE_POLLING', 'false') + end + + it 'polls via Sidekiq.redis only' do + expect(Sidekiq::Client).to receive(:push).with(payload).once + + subject + + Sidekiq.redis do |conn| + expect(conn.zcard('schedule')).to eq(0) + end + + Gitlab::Redis::Queues.with do |conn| + expect(conn.zcard('schedule')).to eq(1) + end + end + end + + context 'when both envvar are enabled' do + around do |example| + # runs the zadd to ensure it goes into namespaced set + Sidekiq.redis { |c| c.zadd('schedule', 100, 'dummy') } + + holder = Sidekiq.redis_pool + + # forcibly replace Sidekiq.redis since this is set in config/initializer/sidekiq.rb + Sidekiq.redis = Gitlab::Redis::Queues.pool + + example.run + + ensure + Sidekiq.redis = holder + end + + before do + stub_env('SIDEKIQ_ENQUEUE_NON_NAMESPACED', 'true') + stub_env('SIDEKIQ_ENABLE_DUAL_NAMESPACE_POLLING', 'true') + end + + it 'polls both sets' do + expect(Sidekiq::Client).to receive(:push).with(payload).twice + + subject + + Sidekiq.redis do |conn| + expect(conn.zcard('schedule')).to eq(0) + end + + Gitlab::Redis::Queues.with do |conn| + expect(conn.zcard('schedule')).to eq(0) + end + end + end + end +end |