1 files changed, 10 insertions, 10 deletions
diff --git a/spec/lib/gitlab/usage/metric_definition_spec.rb b/spec/lib/gitlab/usage/metric_definition_spec.rb
index a1bddcb3a47..931340947a2 100644
--- a/spec/lib/gitlab/usage/metric_definition_spec.rb
+++ b/spec/lib/gitlab/usage/metric_definition_spec.rb
@@ -74,13 +74,12 @@ RSpec.describe Gitlab::Usage::MetricDefinition do
   end
 
   describe '#with_instrumentation_class' do
-    let(:metric_status) { 'active' }
     let(:all_definitions) do
       metrics_definitions = [
-        { key_path: 'metric1', instrumentation_class: 'RedisHLLMetric', status: 'data_available' },
-        { key_path: 'metric2', instrumentation_class: 'RedisHLLMetric', status: 'implemented' },
-        { key_path: 'metric3', instrumentation_class: 'RedisHLLMetric', status: 'deprecated' },
-        { key_path: 'metric4', instrumentation_class: 'RedisHLLMetric', status: metric_status },
+        { key_path: 'metric1', instrumentation_class: 'RedisHLLMetric', status: 'active' },
+        { key_path: 'metric2', instrumentation_class: 'RedisHLLMetric', status: 'broken' },
+        { key_path: 'metric3', instrumentation_class: 'RedisHLLMetric', status: 'active' },
+        { key_path: 'metric4', instrumentation_class: 'RedisHLLMetric', status: 'removed' },
         { key_path: 'metric5', status: 'active' },
         { key_path: 'metric_missing_status' }
       ]
@@ -92,7 +91,7 @@ RSpec.describe Gitlab::Usage::MetricDefinition do
     end
 
     it 'includes definitions with instrumentation_class' do
-      expect(described_class.with_instrumentation_class.count).to eq(4)
+      expect(described_class.with_instrumentation_class.count).to eq(3)
     end
 
     context 'with removed metric' do
@@ -135,8 +134,9 @@ RSpec.describe Gitlab::Usage::MetricDefinition do
       :repair_issue_url   | nil
       :removed_by_url     | 1
 
-      :instrumentation_class | 'Metric_Class'
-      :instrumentation_class | 'metricClass'
+      :performance_indicator_type | nil
+      :instrumentation_class      | 'Metric_Class'
+      :instrumentation_class      | 'metricClass'
     end
 
     with_them do
@@ -201,9 +201,9 @@ RSpec.describe Gitlab::Usage::MetricDefinition do
     using RSpec::Parameterized::TableSyntax
 
     where(:status, :skip_validation?) do
-      'deprecated'     | true
-      'removed'        | true
       'active'         | false
+      'broken'         | false
+      'removed'        | true
     end
 
     with_them do