diff options
Diffstat (limited to 'spec/lib/gitlab/usage_data_counters')
3 files changed, 2 insertions, 27 deletions
diff --git a/spec/lib/gitlab/usage_data_counters/code_review_events_spec.rb b/spec/lib/gitlab/usage_data_counters/code_review_events_spec.rb index c4a84445a01..01396602f29 100644 --- a/spec/lib/gitlab/usage_data_counters/code_review_events_spec.rb +++ b/spec/lib/gitlab/usage_data_counters/code_review_events_spec.rb @@ -3,6 +3,7 @@ require 'spec_helper' # If this spec fails, we need to add the new code review event to the correct aggregated metric +# NOTE: ONLY user related metrics to be added to the aggregates - otherwise add it to the exception list RSpec.describe 'Code review events' do it 'the aggregated metrics contain all the code review metrics' do path = Rails.root.join('config/metrics/aggregates/code_review.yml') @@ -15,7 +16,7 @@ RSpec.describe 'Code review events' do code_review_events = Gitlab::UsageDataCounters::HLLRedisCounter.events_for_category("code_review") - exceptions = %w[i_code_review_mr_diffs i_code_review_mr_single_file_diffs i_code_review_total_suggestions_applied i_code_review_total_suggestions_added] + exceptions = %w[i_code_review_mr_diffs i_code_review_mr_with_invalid_approvers i_code_review_mr_single_file_diffs i_code_review_total_suggestions_applied i_code_review_total_suggestions_added i_code_review_create_note_in_ipynb_diff i_code_review_create_note_in_ipynb_diff_mr i_code_review_create_note_in_ipynb_diff_commit] code_review_aggregated_events += exceptions expect(code_review_events - code_review_aggregated_events).to be_empty diff --git a/spec/lib/gitlab/usage_data_counters/editor_unique_counter_spec.rb b/spec/lib/gitlab/usage_data_counters/editor_unique_counter_spec.rb index 9aecb8f8b25..dbc34681660 100644 --- a/spec/lib/gitlab/usage_data_counters/editor_unique_counter_spec.rb +++ b/spec/lib/gitlab/usage_data_counters/editor_unique_counter_spec.rb @@ -66,18 +66,6 @@ RSpec.describe Gitlab::UsageDataCounters::EditorUniqueCounter, :clean_gitlab_red end end - context 'for SSE edit actions' do - it_behaves_like 'tracks and counts action' do - def track_action(params) - described_class.track_sse_edit_action(**params) - end - - def count_unique(params) - described_class.count_sse_edit_actions(**params) - end - end - end - it 'can return the count of actions per user deduplicated' do described_class.track_web_ide_edit_action(author: user1) described_class.track_live_preview_edit_action(author: user1) diff --git a/spec/lib/gitlab/usage_data_counters/static_site_editor_counter_spec.rb b/spec/lib/gitlab/usage_data_counters/static_site_editor_counter_spec.rb deleted file mode 100644 index 1bf5dad1c9f..00000000000 --- a/spec/lib/gitlab/usage_data_counters/static_site_editor_counter_spec.rb +++ /dev/null @@ -1,14 +0,0 @@ -# frozen_string_literal: true - -require 'spec_helper' - -RSpec.describe Gitlab::UsageDataCounters::StaticSiteEditorCounter do - it_behaves_like 'a redis usage counter', 'StaticSiteEditor', :views - it_behaves_like 'a redis usage counter', 'StaticSiteEditor', :commits - it_behaves_like 'a redis usage counter', 'StaticSiteEditor', :merge_requests - - it_behaves_like 'a redis usage counter with totals', :static_site_editor, - views: 3, - commits: 4, - merge_requests: 5 -end |