1 files changed, 65 insertions, 42 deletions

diff --git a/spec/models/ci/namespace_mirror_spec.rb b/spec/models/ci/namespace_mirror_spec.rb
index b4c71f51377..a9d916115fc 100644
--- a/spec/models/ci/namespace_mirror_spec.rb
+++ b/spec/models/ci/namespace_mirror_spec.rb
@@ -8,50 +8,91 @@ RSpec.describe Ci::NamespaceMirror do
   let!(:group3) { create(:group, parent: group2) }
   let!(:group4) { create(:group, parent: group3) }
 
-  describe '.sync!' do
-    let!(:event) { namespace.sync_events.create! }
+  before do
+    # refreshing ci mirrors according to the parent tree above
+    Namespaces::SyncEvent.find_each { |event| Ci::NamespaceMirror.sync!(event) }
+
+    # checking initial situation. we need to reload to reflect the changes of event sync
+    expect(group1.reload.ci_namespace_mirror).to have_attributes(traversal_ids: [group1.id])
+    expect(group2.reload.ci_namespace_mirror).to have_attributes(traversal_ids: [group1.id, group2.id])
+    expect(group3.reload.ci_namespace_mirror).to have_attributes(traversal_ids: [group1.id, group2.id, group3.id])
+    expect(group4.reload.ci_namespace_mirror).to have_attributes(traversal_ids: [group1.id, group2.id, group3.id, group4.id])
+  end
+
+  context 'scopes' do
+    describe '.contains_namespace' do
+      let_it_be(:another_group) { create(:group) }
+
+      subject(:result) { described_class.contains_namespace(group2.id) }
+
+      it 'returns groups having group2.id in traversal_ids' do
+        expect(result.pluck(:namespace_id)).to contain_exactly(group2.id, group3.id, group4.id)
+      end
+    end
+
+    describe '.contains_any_of_namespaces' do
+      let!(:other_group1) { create(:group) }
+      let!(:other_group2) { create(:group, parent: other_group1) }
+      let!(:other_group3) { create(:group, parent: other_group2) }
+
+      subject(:result) { described_class.contains_any_of_namespaces([group2.id, other_group2.id]) }
+
+      it 'returns groups having group2.id in traversal_ids' do
+        expect(result.pluck(:namespace_id)).to contain_exactly(
+          group2.id, group3.id, group4.id, other_group2.id, other_group3.id
+        )
+      end
+    end
+
+    describe '.by_namespace_id' do
+      subject(:result) { described_class.by_namespace_id(group2.id) }
+
+      it 'returns namesapce mirrors of namespace id' do
+        expect(result).to contain_exactly(group2.ci_namespace_mirror)
+      end
+    end
+  end
 
-    subject(:sync) { described_class.sync!(event.reload) }
+  describe '.sync!' do
+    subject(:sync) { described_class.sync!(Namespaces::SyncEvent.last) }
 
-    context 'when namespace hierarchy does not exist in the first place' do
+    context 'when namespace mirror does not exist in the first place' do
       let(:namespace) { group3 }
 
-      it 'creates the hierarchy' do
-        expect { sync }.to change { described_class.count }.from(0).to(1)
+      before do
+        namespace.ci_namespace_mirror.destroy!
+        namespace.sync_events.create!
+      end
+
+      it 'creates the mirror' do
+        expect { sync }.to change { described_class.count }.from(3).to(4)
 
-        expect(namespace.ci_namespace_mirror).to have_attributes(traversal_ids: [group1.id, group2.id, group3.id])
+        expect(namespace.reload.ci_namespace_mirror).to have_attributes(traversal_ids: [group1.id, group2.id, group3.id])
       end
     end
 
-    context 'when namespace hierarchy does already exist' do
+    context 'when namespace mirror does already exist' do
       let(:namespace) { group3 }
 
       before do
-        described_class.create!(namespace: namespace, traversal_ids: [namespace.id])
+        namespace.sync_events.create!
       end
 
-      it 'updates the hierarchy' do
+      it 'updates the mirror' do
         expect { sync }.not_to change { described_class.count }
 
-        expect(namespace.ci_namespace_mirror).to have_attributes(traversal_ids: [group1.id, group2.id, group3.id])
+        expect(namespace.reload.ci_namespace_mirror).to have_attributes(traversal_ids: [group1.id, group2.id, group3.id])
       end
     end
 
-    # I did not extract this context to a `shared_context` because the behavior will change
-    # after implementing the TODO in `Ci::NamespaceMirror.sync!`
-    context 'changing the middle namespace' do
+    shared_context 'changing the middle namespace' do
       let(:namespace) { group2 }
 
       before do
-        described_class.create!(namespace_id: group1.id, traversal_ids: [group1.id])
-        described_class.create!(namespace_id: group2.id, traversal_ids: [group1.id, group2.id])
-        described_class.create!(namespace_id: group3.id, traversal_ids: [group1.id, group2.id, group3.id])
-        described_class.create!(namespace_id: group4.id, traversal_ids: [group1.id, group2.id, group3.id, group4.id])
-
-        group2.update!(parent: nil)
+        group2.update!(parent: nil) # creates a sync event
       end
 
-      it 'updates hierarchies for the base but wait for events for the children' do
+      it 'updates traversal_ids for the base and descendants' do
         expect { sync }.not_to change { described_class.count }
 
         expect(group1.reload.ci_namespace_mirror).to have_attributes(traversal_ids: [group1.id])
@@ -61,6 +102,8 @@ RSpec.describe Ci::NamespaceMirror do
       end
     end
 
+    it_behaves_like 'changing the middle namespace'
+
     context 'when the FFs sync_traversal_ids, use_traversal_ids and use_traversal_ids_for_ancestors are disabled' do
       before do
         stub_feature_flags(sync_traversal_ids: false,
@@ -68,27 +111,7 @@ RSpec.describe Ci::NamespaceMirror do
                            use_traversal_ids_for_ancestors: false)
       end
 
-      context 'changing the middle namespace' do
-        let(:namespace) { group2 }
-
-        before do
-          described_class.create!(namespace_id: group1.id, traversal_ids: [group1.id])
-          described_class.create!(namespace_id: group2.id, traversal_ids: [group1.id, group2.id])
-          described_class.create!(namespace_id: group3.id, traversal_ids: [group1.id, group2.id, group3.id])
-          described_class.create!(namespace_id: group4.id, traversal_ids: [group1.id, group2.id, group3.id, group4.id])
-
-          group2.update!(parent: nil)
-        end
-
-        it 'updates hierarchies for the base and descendants' do
-          expect { sync }.not_to change { described_class.count }
-
-          expect(group1.reload.ci_namespace_mirror).to have_attributes(traversal_ids: [group1.id])
-          expect(group2.reload.ci_namespace_mirror).to have_attributes(traversal_ids: [group2.id])
-          expect(group3.reload.ci_namespace_mirror).to have_attributes(traversal_ids: [group2.id, group3.id])
-          expect(group4.reload.ci_namespace_mirror).to have_attributes(traversal_ids: [group2.id, group3.id, group4.id])
-        end
-      end
+      it_behaves_like 'changing the middle namespace'
     end
   end
 end