diff options
Diffstat (limited to 'spec/models/preloaders/user_max_access_level_in_groups_preloader_spec.rb')
-rw-r--r-- | spec/models/preloaders/user_max_access_level_in_groups_preloader_spec.rb | 49 |
1 files changed, 17 insertions, 32 deletions
diff --git a/spec/models/preloaders/user_max_access_level_in_groups_preloader_spec.rb b/spec/models/preloaders/user_max_access_level_in_groups_preloader_spec.rb index 5befa3ab66f..3dc409cbcc2 100644 --- a/spec/models/preloaders/user_max_access_level_in_groups_preloader_spec.rb +++ b/spec/models/preloaders/user_max_access_level_in_groups_preloader_spec.rb @@ -34,46 +34,31 @@ RSpec.describe Preloaders::UserMaxAccessLevelInGroupsPreloader, feature_category let(:groups) { [group1, group2, group3, child_maintainer, child_indirect_access] } - context 'when traversal_ids feature flag is disabled' do - it_behaves_like 'executes N max member permission queries to the DB' do - before do - stub_feature_flags(use_traversal_ids: false) - described_class.new(groups, user).execute - end - - # One query for group with no access and another one per group where the user is not a direct member - let(:expected_query_count) { 2 } + it_behaves_like 'executes N max member permission queries to the DB' do + before do + described_class.new(groups, user).execute end - end - - context 'when traversal_ids feature flag is enabled' do - it_behaves_like 'executes N max member permission queries to the DB' do - before do - stub_feature_flags(use_traversal_ids: true) - described_class.new(groups, user).execute - end - let(:expected_query_count) { 0 } - end + let(:expected_query_count) { 0 } + end - context 'for groups arising from group shares' do - let_it_be(:group4) { create(:group, :private) } - let_it_be(:group4_subgroup) { create(:group, :private, parent: group4) } + context 'for groups arising from group shares' do + let_it_be(:group4) { create(:group, :private) } + let_it_be(:group4_subgroup) { create(:group, :private, parent: group4) } - let(:groups) { [group4, group4_subgroup] } + let(:groups) { [group4, group4_subgroup] } - before do - create(:group_group_link, :guest, shared_with_group: group1, shared_group: group4) - end + before do + create(:group_group_link, :guest, shared_with_group: group1, shared_group: group4) + end - it 'sets the right access level in cache for groups arising from group shares' do - described_class.new(groups, user).execute + it 'sets the right access level in cache for groups arising from group shares' do + described_class.new(groups, user).execute - groups.each do |group| - cached_access_level = group.max_member_access_for_user(user) + groups.each do |group| + cached_access_level = group.max_member_access_for_user(user) - expect(cached_access_level).to eq(Gitlab::Access::GUEST) - end + expect(cached_access_level).to eq(Gitlab::Access::GUEST) end end end |