1 files changed, 12 insertions, 6 deletions
diff --git a/spec/models/users/credit_card_validation_spec.rb b/spec/models/users/credit_card_validation_spec.rb
index d2b4f5ebd65..43edf7ed093 100644
--- a/spec/models/users/credit_card_validation_spec.rb
+++ b/spec/models/users/credit_card_validation_spec.rb
@@ -6,19 +6,25 @@ RSpec.describe Users::CreditCardValidation do
   it { is_expected.to belong_to(:user) }
 
   it { is_expected.to validate_length_of(:holder_name).is_at_most(26) }
+  it { is_expected.to validate_length_of(:network).is_at_most(32) }
   it { is_expected.to validate_numericality_of(:last_digits).is_less_than_or_equal_to(9999) }
 
   describe '.similar_records' do
-    let(:card_details) { subject.attributes.slice(:expiration_date, :last_digits, :holder_name) }
+    let(:card_details) do
+      subject.attributes.with_indifferent_access.slice(:expiration_date, :last_digits, :network, :holder_name)
+    end
 
-    subject(:credit_card_validation) { create(:credit_card_validation) }
+    subject!(:credit_card_validation) { create(:credit_card_validation, holder_name: 'Alice') }
 
     let!(:match1) { create(:credit_card_validation, card_details) }
-    let!(:other1) { create(:credit_card_validation, card_details.merge(last_digits: 9)) }
-    let!(:match2) { create(:credit_card_validation, card_details) }
-    let!(:other2) { create(:credit_card_validation, card_details.merge(holder_name: 'foo bar')) }
+    let!(:match2) { create(:credit_card_validation, card_details.merge(holder_name: 'Bob')) }
+    let!(:non_match1) { create(:credit_card_validation, card_details.merge(last_digits: 9)) }
+    let!(:non_match2) { create(:credit_card_validation, card_details.merge(network: 'unknown')) }
+    let!(:non_match3) do
+      create(:credit_card_validation, card_details.dup.tap { |h| h[:expiration_date] += 1.year })
+    end
 
-    it 'returns records with matching credit card, ordered by credit_card_validated_at' do
+    it 'returns matches with the same last_digits, expiration and network, ordered by credit_card_validated_at' do
       expect(subject.similar_records).to eq([match2, match1, subject])
     end
   end