1 files changed, 83 insertions, 36 deletions

diff --git a/spec/requests/api/graphql/ci/jobs_spec.rb b/spec/requests/api/graphql/ci/jobs_spec.rb
index 618705e5f94..19954c4e52f 100644
--- a/spec/requests/api/graphql/ci/jobs_spec.rb
+++ b/spec/requests/api/graphql/ci/jobs_spec.rb
@@ -1,41 +1,44 @@
 # frozen_string_literal: true
 require 'spec_helper'
 
-RSpec.describe 'Query.project.pipeline.stages.groups.jobs' do
+RSpec.describe 'Query.project.pipeline' do
   include GraphqlHelpers
 
-  let(:project) { create(:project, :repository, :public) }
-  let(:user) { create(:user) }
-  let(:pipeline) do
-    pipeline = create(:ci_pipeline, project: project, user: user)
-    stage = create(:ci_stage_entity, pipeline: pipeline, name: 'first')
-    create(:commit_status, stage_id: stage.id, pipeline: pipeline, name: 'my test job')
-
-    pipeline
-  end
+  let_it_be(:project) { create(:project, :repository, :public) }
+  let_it_be(:user) { create(:user) }
 
   def first(field)
     [field.pluralize, 'nodes', 0]
   end
 
-  let(:jobs_graphql_data) { graphql_data.dig(*%w[project pipeline], *first('stage'), *first('group'), 'jobs', 'nodes') }
-
-  let(:query) do
-    %(
-      query {
-        project(fullPath: "#{project.full_path}") {
-          pipeline(iid: "#{pipeline.iid}") {
-            stages {
-              nodes {
-                name
-                groups {
-                  nodes {
-                    name
-                    jobs {
-                      nodes {
-                        name
-                        pipeline {
-                          id
+  describe '.stages.groups.jobs' do
+    let(:pipeline) do
+      pipeline = create(:ci_pipeline, project: project, user: user)
+      stage = create(:ci_stage_entity, pipeline: pipeline, name: 'first')
+      create(:commit_status, stage_id: stage.id, pipeline: pipeline, name: 'my test job')
+
+      pipeline
+    end
+
+    let(:jobs_graphql_data) { graphql_data.dig(*%w[project pipeline], *first('stage'), *first('group'), 'jobs', 'nodes') }
+
+    let(:query) do
+      %(
+        query {
+          project(fullPath: "#{project.full_path}") {
+            pipeline(iid: "#{pipeline.iid}") {
+              stages {
+                nodes {
+                  name
+                  groups {
+                    nodes {
+                      name
+                      jobs {
+                        nodes {
+                          name
+                          pipeline {
+                            id
+                          }
                         }
                       }
                     }
@@ -45,17 +48,15 @@ RSpec.describe 'Query.project.pipeline.stages.groups.jobs' do
             }
           }
         }
-      }
-    )
-  end
+      )
+    end
 
-  it 'returns the jobs of a pipeline stage' do
-    post_graphql(query, current_user: user)
+    it 'returns the jobs of a pipeline stage' do
+      post_graphql(query, current_user: user)
 
-    expect(jobs_graphql_data).to contain_exactly(a_hash_including('name' => 'my test job'))
-  end
+      expect(jobs_graphql_data).to contain_exactly(a_hash_including('name' => 'my test job'))
+    end
 
-  context 'when fetching jobs from the pipeline' do
     it 'avoids N+1 queries', :aggregate_failures do
       control_count = ActiveRecord::QueryRecorder.new do
         post_graphql(query, current_user: user)
@@ -112,4 +113,50 @@ RSpec.describe 'Query.project.pipeline.stages.groups.jobs' do
       ])
     end
   end
+
+  describe '.jobs.artifacts' do
+    let_it_be(:pipeline) { create(:ci_pipeline, project: project) }
+
+    let(:query) do
+      %(
+        query {
+          project(fullPath: "#{project.full_path}") {
+            pipeline(iid: "#{pipeline.iid}") {
+              jobs {
+                nodes {
+                  artifacts {
+                    nodes {
+                      downloadPath
+                    }
+                  }
+                }
+              }
+            }
+          }
+        }
+      )
+    end
+
+    context 'when the job is a build' do
+      it "returns the build's artifacts" do
+        create(:ci_build, :artifacts, pipeline: pipeline)
+
+        post_graphql(query, current_user: user)
+
+        job_data = graphql_data.dig('project', 'pipeline', 'jobs', 'nodes').first
+        expect(job_data.dig('artifacts', 'nodes').count).to be(2)
+      end
+    end
+
+    context 'when the job is not a build' do
+      it 'returns nil' do
+        create(:ci_bridge, pipeline: pipeline)
+
+        post_graphql(query, current_user: user)
+
+        job_data = graphql_data.dig('project', 'pipeline', 'jobs', 'nodes').first
+        expect(job_data['artifacts']).to be_nil
+      end
+    end
+  end
 end