diff options
Diffstat (limited to 'spec/requests/api/graphql/mutations/issues')
12 files changed, 164 insertions, 10 deletions
diff --git a/spec/requests/api/graphql/mutations/issues/create_spec.rb b/spec/requests/api/graphql/mutations/issues/create_spec.rb index a489b7424e8..d2d2f0014d6 100644 --- a/spec/requests/api/graphql/mutations/issues/create_spec.rb +++ b/spec/requests/api/graphql/mutations/issues/create_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Create an issue' do +RSpec.describe 'Create an issue', feature_category: :team_planning do include GraphqlHelpers let_it_be(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/issues/link_alerts_spec.rb b/spec/requests/api/graphql/mutations/issues/link_alerts_spec.rb new file mode 100644 index 00000000000..85e21952f47 --- /dev/null +++ b/spec/requests/api/graphql/mutations/issues/link_alerts_spec.rb @@ -0,0 +1,65 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe 'Link alerts to an incident', feature_category: :incident_management do + include GraphqlHelpers + + let_it_be(:user) { create(:user) } + let_it_be(:project) { create(:project) } + let_it_be(:linked_alert) { create(:alert_management_alert, project: project) } + let_it_be(:alert1) { create(:alert_management_alert, project: project) } + let_it_be(:alert2) { create(:alert_management_alert, project: project) } + let_it_be(:incident) { create(:incident, project: project, alert_management_alerts: [linked_alert]) } + + let(:mutation) do + variables = { + project_path: project.full_path, + iid: incident.iid.to_s, + alert_references: [alert1.to_reference, alert2.details_url] + } + + graphql_mutation(:issue_link_alerts, variables, + <<-QL.strip_heredoc + clientMutationId + errors + issue { + iid + alertManagementAlerts { + nodes { + iid + } + } + } + QL + ) + end + + def mutation_response + graphql_mutation_response(:issue_link_alerts) + end + + context 'when the user is not allowed to update the incident' do + it 'returns an error' do + error = Gitlab::Graphql::Authorize::AuthorizeResource::RESOURCE_ACCESS_ERROR + post_graphql_mutation(mutation, current_user: user) + + expect(response).to have_gitlab_http_status(:success) + expect(graphql_errors).to include(a_hash_including('message' => error)) + end + end + + context 'when the user is allowed to update the incident' do + before do + project.add_developer(user) + end + + it 'links alerts to the incident' do + post_graphql_mutation(mutation, current_user: user) + + expect(response).to have_gitlab_http_status(:success) + expected_response = [linked_alert, alert1, alert2].map { |a| { 'iid' => a.iid.to_s } } + expect(mutation_response.dig('issue', 'alertManagementAlerts', 'nodes')).to match_array(expected_response) + end + end +end diff --git a/spec/requests/api/graphql/mutations/issues/move_spec.rb b/spec/requests/api/graphql/mutations/issues/move_spec.rb index 20ed16879f6..7d9579067b6 100644 --- a/spec/requests/api/graphql/mutations/issues/move_spec.rb +++ b/spec/requests/api/graphql/mutations/issues/move_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Moving an issue' do +RSpec.describe 'Moving an issue', feature_category: :team_planning do include GraphqlHelpers let_it_be(:user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/issues/set_confidential_spec.rb b/spec/requests/api/graphql/mutations/issues/set_confidential_spec.rb index 12ab504da14..c5e6901d8f8 100644 --- a/spec/requests/api/graphql/mutations/issues/set_confidential_spec.rb +++ b/spec/requests/api/graphql/mutations/issues/set_confidential_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Setting an issue as confidential' do +RSpec.describe 'Setting an issue as confidential', feature_category: :team_planning do include GraphqlHelpers let(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/issues/set_crm_contacts_spec.rb b/spec/requests/api/graphql/mutations/issues/set_crm_contacts_spec.rb index 395a490bfc3..9fce5f8497f 100644 --- a/spec/requests/api/graphql/mutations/issues/set_crm_contacts_spec.rb +++ b/spec/requests/api/graphql/mutations/issues/set_crm_contacts_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Setting issues crm contacts' do +RSpec.describe 'Setting issues crm contacts', feature_category: :service_desk do include GraphqlHelpers let_it_be(:user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/issues/set_due_date_spec.rb b/spec/requests/api/graphql/mutations/issues/set_due_date_spec.rb index 8e223b6fdaf..1a5a64e4196 100644 --- a/spec/requests/api/graphql/mutations/issues/set_due_date_spec.rb +++ b/spec/requests/api/graphql/mutations/issues/set_due_date_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Setting Due Date of an issue' do +RSpec.describe 'Setting Due Date of an issue', feature_category: :team_planning do include GraphqlHelpers let(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/issues/set_escalation_status_spec.rb b/spec/requests/api/graphql/mutations/issues/set_escalation_status_spec.rb index a81364d37b2..8fc3ad4236d 100644 --- a/spec/requests/api/graphql/mutations/issues/set_escalation_status_spec.rb +++ b/spec/requests/api/graphql/mutations/issues/set_escalation_status_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Setting the escalation status of an incident' do +RSpec.describe 'Setting the escalation status of an incident', feature_category: :incident_management do include GraphqlHelpers let_it_be(:project) { create(:project) } diff --git a/spec/requests/api/graphql/mutations/issues/set_locked_spec.rb b/spec/requests/api/graphql/mutations/issues/set_locked_spec.rb index 435ed0f9eb2..a8025894b1e 100644 --- a/spec/requests/api/graphql/mutations/issues/set_locked_spec.rb +++ b/spec/requests/api/graphql/mutations/issues/set_locked_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Setting an issue as locked' do +RSpec.describe 'Setting an issue as locked', feature_category: :team_planning do include GraphqlHelpers let_it_be(:current_user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/issues/set_severity_spec.rb b/spec/requests/api/graphql/mutations/issues/set_severity_spec.rb index cd9d695bd2c..77262c7f64f 100644 --- a/spec/requests/api/graphql/mutations/issues/set_severity_spec.rb +++ b/spec/requests/api/graphql/mutations/issues/set_severity_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Setting severity level of an incident' do +RSpec.describe 'Setting severity level of an incident', feature_category: :incident_management do include GraphqlHelpers let_it_be(:user) { create(:user) } diff --git a/spec/requests/api/graphql/mutations/issues/set_subscription_spec.rb b/spec/requests/api/graphql/mutations/issues/set_subscription_spec.rb index 1edc1e0553b..6c8e5b1d15d 100644 --- a/spec/requests/api/graphql/mutations/issues/set_subscription_spec.rb +++ b/spec/requests/api/graphql/mutations/issues/set_subscription_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Setting subscribed status of an issue' do +RSpec.describe 'Setting subscribed status of an issue', feature_category: :team_planning do include GraphqlHelpers it_behaves_like 'a subscribable resource api' do diff --git a/spec/requests/api/graphql/mutations/issues/unlink_alerts_spec.rb b/spec/requests/api/graphql/mutations/issues/unlink_alerts_spec.rb new file mode 100644 index 00000000000..7f6f968b1dd --- /dev/null +++ b/spec/requests/api/graphql/mutations/issues/unlink_alerts_spec.rb @@ -0,0 +1,89 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe 'Unlink alert from an incident', feature_category: :incident_management do + include GraphqlHelpers + + let_it_be(:user) { create(:user) } + let_it_be(:project) { create(:project) } + let_it_be(:another_project) { create(:project) } + let_it_be(:internal_alert) { create(:alert_management_alert, project: project) } + let_it_be(:external_alert) { create(:alert_management_alert, project: another_project) } + let_it_be(:incident) do + create(:incident, project: project, alert_management_alerts: [internal_alert, external_alert]) + end + + let(:mutation) do + variables = { + project_path: project.full_path, + iid: incident.iid.to_s, + alert_id: alert_to_unlink.to_global_id.to_s + } + + graphql_mutation(:issue_unlink_alert, variables, + <<-QL.strip_heredoc + clientMutationId + errors + issue { + iid + alertManagementAlerts { + nodes { + id + } + } + } + QL + ) + end + + def mutation_response + graphql_mutation_response(:issue_unlink_alert) + end + + context 'when the user is not allowed to update the incident' do + let(:alert_to_unlink) { internal_alert } + + it 'returns an error' do + error = Gitlab::Graphql::Authorize::AuthorizeResource::RESOURCE_ACCESS_ERROR + post_graphql_mutation(mutation, current_user: user) + + expect(response).to have_gitlab_http_status(:success) + expect(graphql_errors).to include(a_hash_including('message' => error)) + end + end + + context 'when the user is allowed to update the incident' do + before_all do + project.add_developer(user) + end + + shared_examples 'unlinking' do + it 'unlinks the alert from the incident', :aggregate_failures do + post_graphql_mutation(mutation, current_user: user) + + expect(response).to have_gitlab_http_status(:success) + expected_response = visible_remainded_alerts.map { |a| { 'id' => a.to_global_id.to_s } } + expect(mutation_response.dig('issue', 'alertManagementAlerts', 'nodes')).to match_array(expected_response) + + expect(incident.reload.alert_management_alerts).to match_array(actual_remainded_alerts) + end + end + + context 'when the alert is internal' do + let(:alert_to_unlink) { internal_alert } + let(:actual_remainded_alerts) { [external_alert] } + let(:visible_remainded_alerts) { [] } # The user cannot fetch external alerts without reading permissions + + it_behaves_like 'unlinking' + end + + context 'when the alert is external' do + let(:alert_to_unlink) { external_alert } + let(:actual_remainded_alerts) { [internal_alert] } + let(:visible_remainded_alerts) { [internal_alert] } + + it_behaves_like 'unlinking' + end + end +end diff --git a/spec/requests/api/graphql/mutations/issues/update_spec.rb b/spec/requests/api/graphql/mutations/issues/update_spec.rb index f38deb426b1..e51c057c182 100644 --- a/spec/requests/api/graphql/mutations/issues/update_spec.rb +++ b/spec/requests/api/graphql/mutations/issues/update_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe 'Update of an existing issue' do +RSpec.describe 'Update of an existing issue', feature_category: :team_planning do include GraphqlHelpers let_it_be(:current_user) { create(:user) } |