diff options
Diffstat (limited to 'spec/requests/api/graphql/mutations/metrics/dashboard/annotations/delete_spec.rb')
-rw-r--r-- | spec/requests/api/graphql/mutations/metrics/dashboard/annotations/delete_spec.rb | 22 |
1 files changed, 3 insertions, 19 deletions
diff --git a/spec/requests/api/graphql/mutations/metrics/dashboard/annotations/delete_spec.rb b/spec/requests/api/graphql/mutations/metrics/dashboard/annotations/delete_spec.rb index c81f6381398..6768998b31c 100644 --- a/spec/requests/api/graphql/mutations/metrics/dashboard/annotations/delete_spec.rb +++ b/spec/requests/api/graphql/mutations/metrics/dashboard/annotations/delete_spec.rb @@ -7,19 +7,14 @@ RSpec.describe Mutations::Metrics::Dashboard::Annotations::Delete, feature_categ let_it_be(:current_user) { create(:user) } let_it_be(:project) { create(:project, :private, :repository) } - let_it_be(:annotation) { create(:metrics_dashboard_annotation) } - let(:variables) { { id: GitlabSchema.id_from_object(annotation).to_s } } + let(:variables) { { id: 'ids-dont-matter' } } let(:mutation) { graphql_mutation(:delete_annotation, variables) } def mutation_response graphql_mutation_response(:delete_annotation) end - before do - stub_feature_flags(remove_monitor_metrics: false) - end - specify { expect(described_class).to require_graphql_authorizations(:admin_metrics_dashboard_annotation) } context 'when the user has permission to delete the annotation' do @@ -30,16 +25,11 @@ RSpec.describe Mutations::Metrics::Dashboard::Annotations::Delete, feature_categ context 'with invalid params' do let(:variables) { { id: GitlabSchema.id_from_object(project).to_s } } - it_behaves_like 'a mutation that returns top-level errors' do - let(:match_errors) { contain_exactly(include('invalid value for id')) } - end + it_behaves_like 'a mutation that returns top-level errors', + errors: [Gitlab::Graphql::Authorize::AuthorizeResource::RESOURCE_ACCESS_ERROR] end context 'when metrics dashboard feature is unavailable' do - before do - stub_feature_flags(remove_monitor_metrics: true) - end - it_behaves_like 'a mutation that returns top-level errors', errors: [Gitlab::Graphql::Authorize::AuthorizeResource::RESOURCE_ACCESS_ERROR] end @@ -51,11 +41,5 @@ RSpec.describe Mutations::Metrics::Dashboard::Annotations::Delete, feature_categ end it_behaves_like 'a mutation that returns top-level errors', errors: [Gitlab::Graphql::Authorize::AuthorizeResource::RESOURCE_ACCESS_ERROR] - - it 'does not delete the annotation' do - expect do - post_graphql_mutation(mutation, current_user: current_user) - end.not_to change { Metrics::Dashboard::Annotation.count } - end end end |