1 files changed, 89 insertions, 16 deletions

diff --git a/spec/requests/api/graphql/mutations/work_items/update_spec.rb b/spec/requests/api/graphql/mutations/work_items/update_spec.rb
index 6b0129c457f..96736457f26 100644
--- a/spec/requests/api/graphql/mutations/work_items/update_spec.rb
+++ b/spec/requests/api/graphql/mutations/work_items/update_spec.rb
@@ -5,8 +5,11 @@ require 'spec_helper'
 RSpec.describe 'Update a work item' do
   include GraphqlHelpers
 
-  let_it_be(:project) { create(:project) }
+  let_it_be(:group) { create(:group) }
+  let_it_be(:project) { create(:project, group: group) }
   let_it_be(:developer) { create(:user).tap { |user| project.add_developer(user) } }
+  let_it_be(:reporter) { create(:user).tap { |user| project.add_reporter(user) } }
+  let_it_be(:guest) { create(:user).tap { |user| project.add_guest(user) } }
   let_it_be(:work_item, refind: true) { create(:work_item, project: project) }
 
   let(:work_item_event) { 'CLOSE' }
@@ -543,6 +546,91 @@ RSpec.describe 'Update a work item' do
       end
     end
 
+    context 'when updating milestone' do
+      let_it_be(:project_milestone) { create(:milestone, project: project) }
+      let_it_be(:group_milestone) { create(:milestone, project: project) }
+
+      let(:input) { { 'milestoneWidget' => { 'milestoneId' => new_milestone&.to_global_id&.to_s } } }
+
+      let(:fields) do
+        <<~FIELDS
+        workItem {
+          widgets {
+            type
+            ... on WorkItemWidgetMilestone {
+              milestone {
+                id
+              }
+            }
+          }
+        }
+        errors
+        FIELDS
+      end
+
+      shared_examples "work item's milestone is updated" do
+        it "updates the work item's milestone" do
+          expect do
+            post_graphql_mutation(mutation, current_user: current_user)
+
+            work_item.reload
+          end.to change(work_item, :milestone).from(old_milestone).to(new_milestone)
+
+          expect(response).to have_gitlab_http_status(:success)
+        end
+      end
+
+      shared_examples "work item's milestone is not updated" do
+        it "ignores the update request" do
+          expect do
+            post_graphql_mutation(mutation, current_user: current_user)
+
+            work_item.reload
+          end.to not_change(work_item, :milestone)
+
+          expect(response).to have_gitlab_http_status(:success)
+        end
+      end
+
+      context 'when user cannot set work item metadata' do
+        let(:current_user) { guest }
+        let(:old_milestone) { nil }
+
+        it_behaves_like "work item's milestone is not updated" do
+          let(:new_milestone) { project_milestone }
+        end
+      end
+
+      context 'when user can set work item metadata' do
+        let(:current_user) { reporter }
+
+        context 'when assigning a project milestone' do
+          it_behaves_like "work item's milestone is updated" do
+            let(:old_milestone) { nil }
+            let(:new_milestone) { project_milestone }
+          end
+        end
+
+        context 'when assigning a group milestone' do
+          it_behaves_like "work item's milestone is updated" do
+            let(:old_milestone) { nil }
+            let(:new_milestone) { group_milestone }
+          end
+        end
+
+        context "when unsetting the work item's milestone" do
+          it_behaves_like "work item's milestone is updated" do
+            let(:old_milestone) { group_milestone }
+            let(:new_milestone) { nil }
+
+            before do
+              work_item.update!(milestone: old_milestone)
+            end
+          end
+        end
+      end
+    end
+
     context 'when unsupported widget input is sent' do
       let_it_be(:test_case) { create(:work_item_type, :default, :test_case, name: 'some_test_case_name') }
       let_it_be(:work_item) { create(:work_item, work_item_type: test_case, project: project) }
@@ -556,20 +644,5 @@ RSpec.describe 'Update a work item' do
       it_behaves_like 'a mutation that returns top-level errors',
         errors: ["Following widget keys are not supported by some_test_case_name type: [:hierarchy_widget]"]
     end
-
-    context 'when the work_items feature flag is disabled' do
-      before do
-        stub_feature_flags(work_items: false)
-      end
-
-      it 'does not update the work item and returns and error' do
-        expect do
-          post_graphql_mutation(mutation, current_user: current_user)
-          work_item.reload
-        end.to not_change(work_item, :title)
-
-        expect(mutation_response['errors']).to contain_exactly('`work_items` feature flag disabled for this project')
-      end
-    end
   end
 end