Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
Diffstat (limited to 'spec/requests/api/metrics/user_starred_dashboards_spec.rb')
-rw-r--r--spec/requests/api/metrics/user_starred_dashboards_spec.rb57
1 files changed, 0 insertions, 57 deletions
diff --git a/spec/requests/api/metrics/user_starred_dashboards_spec.rb b/spec/requests/api/metrics/user_starred_dashboards_spec.rb
index 2ac7d3cffc8..bdeba777350 100644
--- a/spec/requests/api/metrics/user_starred_dashboards_spec.rb
+++ b/spec/requests/api/metrics/user_starred_dashboards_spec.rb
@@ -15,10 +15,6 @@ RSpec.describe API::Metrics::UserStarredDashboards, feature_category: :metrics d
}
end
- before do
- stub_feature_flags(remove_monitor_metrics: false)
- end
-
describe 'POST /projects/:id/metrics/user_starred_dashboards' do
before do
project.add_reporter(user)
@@ -26,13 +22,6 @@ RSpec.describe API::Metrics::UserStarredDashboards, feature_category: :metrics d
context 'with correct permissions' do
context 'with invalid parameters' do
- it 'returns error message' do
- post api(url, user), params: { dashboard_path: '' }
-
- expect(response).to have_gitlab_http_status(:bad_request)
- expect(json_response['error']).to eq('dashboard_path is empty')
- end
-
context 'user is missing' do
it 'returns 404 not found' do
post api(url, nil), params: params
@@ -60,10 +49,6 @@ RSpec.describe API::Metrics::UserStarredDashboards, feature_category: :metrics d
end
context 'when metrics dashboard feature is unavailable' do
- before do
- stub_feature_flags(remove_monitor_metrics: true)
- end
-
it 'returns 404 not found' do
post api(url, user), params: params
@@ -83,44 +68,6 @@ RSpec.describe API::Metrics::UserStarredDashboards, feature_category: :metrics d
end
context 'with correct permissions' do
- context 'with valid parameters' do
- context 'dashboard_path as url param url escaped' do
- it 'deletes given user starred metrics dashboard', :aggregate_failures do
- delete api(url, user), params: params
-
- expect(response).to have_gitlab_http_status(:ok)
- expect(json_response['deleted_rows']).to eq(1)
- expect(::Metrics::UsersStarredDashboard.all.pluck(:dashboard_path)).not_to include(dashboard)
- end
- end
-
- context 'dashboard_path in request body unescaped' do
- let(:params) do
- {
- dashboard_path: dashboard
- }
- end
-
- it 'deletes given user starred metrics dashboard', :aggregate_failures do
- delete api(url, user), params: params
-
- expect(response).to have_gitlab_http_status(:ok)
- expect(json_response['deleted_rows']).to eq(1)
- expect(::Metrics::UsersStarredDashboard.all.pluck(:dashboard_path)).not_to include(dashboard)
- end
- end
-
- context 'dashboard_path has not been specified' do
- it 'deletes all starred dashboards for that user within given project', :aggregate_failures do
- delete api(url, user), params: {}
-
- expect(response).to have_gitlab_http_status(:ok)
- expect(json_response['deleted_rows']).to eq(2)
- expect(::Metrics::UsersStarredDashboard.all).to contain_exactly(other_user_starred_dashboard, other_project_starred_dashboard)
- end
- end
- end
-
context 'with invalid parameters' do
context 'user is missing' do
it 'returns 404 not found' do
@@ -149,10 +96,6 @@ RSpec.describe API::Metrics::UserStarredDashboards, feature_category: :metrics d
end
context 'when metrics dashboard feature is unavailable' do
- before do
- stub_feature_flags(remove_monitor_metrics: true)
- end
-
it 'returns 404 not found' do
delete api(url, user), params: params