1 files changed, 63 insertions, 3 deletions

diff --git a/spec/requests/api/remote_mirrors_spec.rb b/spec/requests/api/remote_mirrors_spec.rb
index 436efb708fd..338647224e0 100644
--- a/spec/requests/api/remote_mirrors_spec.rb
+++ b/spec/requests/api/remote_mirrors_spec.rb
@@ -26,6 +26,26 @@ RSpec.describe API::RemoteMirrors do
     end
   end
 
+  describe 'GET /projects/:id/remote_mirrors/:mirror_id' do
+    let(:route) { "/projects/#{project.id}/remote_mirrors/#{mirror.id}" }
+    let(:mirror) { project.remote_mirrors.first }
+
+    it 'requires `admin_remote_mirror` permission' do
+      get api(route, developer)
+
+      expect(response).to have_gitlab_http_status(:unauthorized)
+    end
+
+    it 'returns at remote mirror' do
+      project.add_maintainer(user)
+
+      get api(route, user)
+
+      expect(response).to have_gitlab_http_status(:success)
+      expect(response).to match_response_schema('remote_mirror')
+    end
+  end
+
   describe 'POST /projects/:id/remote_mirrors' do
     let(:route) { "/projects/#{project.id}/remote_mirrors" }
 
@@ -75,11 +95,11 @@ RSpec.describe API::RemoteMirrors do
   end
 
   describe 'PUT /projects/:id/remote_mirrors/:mirror_id' do
-    let(:route) { ->(id) { "/projects/#{project.id}/remote_mirrors/#{id}" } }
+    let(:route) { "/projects/#{project.id}/remote_mirrors/#{mirror.id}" }
     let(:mirror) { project.remote_mirrors.first }
 
     it 'requires `admin_remote_mirror` permission' do
-      put api(route[mirror.id], developer)
+      put api(route, developer)
 
       expect(response).to have_gitlab_http_status(:unauthorized)
     end
@@ -87,7 +107,7 @@ RSpec.describe API::RemoteMirrors do
     it 'updates a remote mirror' do
       project.add_maintainer(user)
 
-      put api(route[mirror.id], user), params: {
+      put api(route, user), params: {
         enabled: '0',
         only_protected_branches: 'true',
         keep_divergent_refs: 'true'
@@ -99,4 +119,44 @@ RSpec.describe API::RemoteMirrors do
       expect(json_response['keep_divergent_refs']).to eq(true)
     end
   end
+
+  describe 'DELETE /projects/:id/remote_mirrors/:mirror_id' do
+    let(:route) { ->(id) { "/projects/#{project.id}/remote_mirrors/#{id}" } }
+    let(:mirror) { project.remote_mirrors.first }
+
+    it 'requires `admin_remote_mirror` permission' do
+      expect { delete api(route[mirror.id], developer) }.not_to change { project.remote_mirrors.count }
+
+      expect(response).to have_gitlab_http_status(:unauthorized)
+    end
+
+    context 'when the user is a maintainer' do
+      before do
+        project.add_maintainer(user)
+      end
+
+      it 'returns 404 for non existing id' do
+        delete api(route[non_existing_record_id], user)
+
+        expect(response).to have_gitlab_http_status(:not_found)
+      end
+
+      it 'returns bad request if the update service fails' do
+        expect_next_instance_of(Projects::UpdateService) do |service|
+          expect(service).to receive(:execute).and_return(status: :error, message: 'message')
+        end
+
+        expect { delete api(route[mirror.id], user) }.not_to change { project.remote_mirrors.count }
+
+        expect(response).to have_gitlab_http_status(:bad_request)
+        expect(json_response).to eq({ 'message' => 'message' })
+      end
+
+      it 'deletes a remote mirror' do
+        expect { delete api(route[mirror.id], user) }.to change { project.remote_mirrors.count }.from(1).to(0)
+
+        expect(response).to have_gitlab_http_status(:no_content)
+      end
+    end
+  end
 end