diff options
Diffstat (limited to 'spec/requests/jira_routing_spec.rb')
-rw-r--r-- | spec/requests/jira_routing_spec.rb | 72 |
1 files changed, 72 insertions, 0 deletions
diff --git a/spec/requests/jira_routing_spec.rb b/spec/requests/jira_routing_spec.rb new file mode 100644 index 00000000000..a627eea33a8 --- /dev/null +++ b/spec/requests/jira_routing_spec.rb @@ -0,0 +1,72 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe 'Jira referenced paths', type: :request do + using RSpec::Parameterized::TableSyntax + + let(:user) { create(:user) } + + let(:group) { create(:group, name: 'group') } + let(:sub_group) { create(:group, name: 'subgroup', parent: group) } + + let!(:group_project) { create(:project, name: 'group_project', namespace: group) } + let!(:sub_group_project) { create(:project, name: 'sub_group_project', namespace: sub_group) } + + before do + group.add_owner(user) + + login_as user + end + + def redirects_to_canonical_path(jira_path, redirect_path) + get(jira_path) + + expect(response).to redirect_to(redirect_path) + end + + context 'with encoded subgroup path' do + where(:jira_path, :redirect_path) do + '/group/group@sub_group@sub_group_project' | '/group/sub_group/sub_group_project' + '/group@sub_group/group@sub_group@sub_group_project' | '/group/sub_group/sub_group_project' + '/group/group@sub_group@sub_group_project/commit/1234567' | '/group/sub_group/sub_group_project/commit/1234567' + '/group/group@sub_group@sub_group_project/tree/1234567' | '/group/sub_group/sub_group_project/-/tree/1234567' + end + + with_them do + context 'with legacy prefix' do + it 'redirects to canonical path' do + redirects_to_canonical_path "/-/jira#{jira_path}", redirect_path + end + end + + it 'redirects to canonical path' do + redirects_to_canonical_path jira_path, redirect_path + end + end + end + + context 'regular paths with legacy prefix' do + where(:jira_path, :redirect_path) do + '/-/jira/group/group_project' | '/group/group_project' + '/-/jira/group/group_project/commit/1234567' | '/group/group_project/commit/1234567' + '/-/jira/group/group_project/tree/1234567' | '/group/group_project/-/tree/1234567' + end + + with_them do + it 'redirects to canonical path' do + redirects_to_canonical_path jira_path, redirect_path + end + end + end + + context 'when tree path has an @' do + let(:path) { '/group/project/tree/folder-with-@' } + + it 'does not do a redirect' do + get path + + expect(response).not_to have_gitlab_http_status(:moved_permanently) + end + end +end |