diff options
Diffstat (limited to 'spec/rubocop/code_reuse_helpers_spec.rb')
-rw-r--r-- | spec/rubocop/code_reuse_helpers_spec.rb | 56 |
1 files changed, 28 insertions, 28 deletions
diff --git a/spec/rubocop/code_reuse_helpers_spec.rb b/spec/rubocop/code_reuse_helpers_spec.rb index 574a4a85a34..4c3dd8f8167 100644 --- a/spec/rubocop/code_reuse_helpers_spec.rb +++ b/spec/rubocop/code_reuse_helpers_spec.rb @@ -6,7 +6,7 @@ require 'parser/current' require_relative '../../rubocop/code_reuse_helpers' RSpec.describe RuboCop::CodeReuseHelpers do - def parse_source(source, path = 'foo.rb') + def build_and_parse_source(source, path = 'foo.rb') buffer = Parser::Source::Buffer.new(path) buffer.source = source @@ -24,13 +24,13 @@ RSpec.describe RuboCop::CodeReuseHelpers do describe '#send_to_constant?' do it 'returns true when sending to a constant' do - node = parse_source('Foo.bar') + node = build_and_parse_source('Foo.bar') expect(cop.send_to_constant?(node)).to eq(true) end it 'returns false when sending to something other than a constant' do - node = parse_source('10') + node = build_and_parse_source('10') expect(cop.send_to_constant?(node)).to eq(false) end @@ -38,13 +38,13 @@ RSpec.describe RuboCop::CodeReuseHelpers do describe '#send_receiver_name_ends_with?' do it 'returns true when the receiver ends with a suffix' do - node = parse_source('FooFinder.new') + node = build_and_parse_source('FooFinder.new') expect(cop.send_receiver_name_ends_with?(node, 'Finder')).to eq(true) end it 'returns false when the receiver is the same as a suffix' do - node = parse_source('Finder.new') + node = build_and_parse_source('Finder.new') expect(cop.send_receiver_name_ends_with?(node, 'Finder')).to eq(false) end @@ -52,7 +52,7 @@ RSpec.describe RuboCop::CodeReuseHelpers do describe '#file_path_for_node' do it 'returns the file path of a node' do - node = parse_source('10') + node = build_and_parse_source('10') path = cop.file_path_for_node(node) expect(path).to eq('foo.rb') @@ -61,7 +61,7 @@ RSpec.describe RuboCop::CodeReuseHelpers do describe '#name_of_constant' do it 'returns the name of a constant' do - node = parse_source('Foo') + node = build_and_parse_source('Foo') expect(cop.name_of_constant(node)).to eq(:Foo) end @@ -69,13 +69,13 @@ RSpec.describe RuboCop::CodeReuseHelpers do describe '#in_finder?' do it 'returns true for a node in the finders directory' do - node = parse_source('10', rails_root_join('app', 'finders', 'foo.rb')) + node = build_and_parse_source('10', rails_root_join('app', 'finders', 'foo.rb')) expect(cop.in_finder?(node)).to eq(true) end it 'returns false for a node outside the finders directory' do - node = parse_source('10', rails_root_join('app', 'foo', 'foo.rb')) + node = build_and_parse_source('10', rails_root_join('app', 'foo', 'foo.rb')) expect(cop.in_finder?(node)).to eq(false) end @@ -83,13 +83,13 @@ RSpec.describe RuboCop::CodeReuseHelpers do describe '#in_model?' do it 'returns true for a node in the models directory' do - node = parse_source('10', rails_root_join('app', 'models', 'foo.rb')) + node = build_and_parse_source('10', rails_root_join('app', 'models', 'foo.rb')) expect(cop.in_model?(node)).to eq(true) end it 'returns false for a node outside the models directory' do - node = parse_source('10', rails_root_join('app', 'foo', 'foo.rb')) + node = build_and_parse_source('10', rails_root_join('app', 'foo', 'foo.rb')) expect(cop.in_model?(node)).to eq(false) end @@ -97,13 +97,13 @@ RSpec.describe RuboCop::CodeReuseHelpers do describe '#in_service_class?' do it 'returns true for a node in the services directory' do - node = parse_source('10', rails_root_join('app', 'services', 'foo.rb')) + node = build_and_parse_source('10', rails_root_join('app', 'services', 'foo.rb')) expect(cop.in_service_class?(node)).to eq(true) end it 'returns false for a node outside the services directory' do - node = parse_source('10', rails_root_join('app', 'foo', 'foo.rb')) + node = build_and_parse_source('10', rails_root_join('app', 'foo', 'foo.rb')) expect(cop.in_service_class?(node)).to eq(false) end @@ -111,13 +111,13 @@ RSpec.describe RuboCop::CodeReuseHelpers do describe '#in_presenter?' do it 'returns true for a node in the presenters directory' do - node = parse_source('10', rails_root_join('app', 'presenters', 'foo.rb')) + node = build_and_parse_source('10', rails_root_join('app', 'presenters', 'foo.rb')) expect(cop.in_presenter?(node)).to eq(true) end it 'returns false for a node outside the presenters directory' do - node = parse_source('10', rails_root_join('app', 'foo', 'foo.rb')) + node = build_and_parse_source('10', rails_root_join('app', 'foo', 'foo.rb')) expect(cop.in_presenter?(node)).to eq(false) end @@ -125,13 +125,13 @@ RSpec.describe RuboCop::CodeReuseHelpers do describe '#in_serializer?' do it 'returns true for a node in the serializers directory' do - node = parse_source('10', rails_root_join('app', 'serializers', 'foo.rb')) + node = build_and_parse_source('10', rails_root_join('app', 'serializers', 'foo.rb')) expect(cop.in_serializer?(node)).to eq(true) end it 'returns false for a node outside the serializers directory' do - node = parse_source('10', rails_root_join('app', 'foo', 'foo.rb')) + node = build_and_parse_source('10', rails_root_join('app', 'foo', 'foo.rb')) expect(cop.in_serializer?(node)).to eq(false) end @@ -139,13 +139,13 @@ RSpec.describe RuboCop::CodeReuseHelpers do describe '#in_worker?' do it 'returns true for a node in the workers directory' do - node = parse_source('10', rails_root_join('app', 'workers', 'foo.rb')) + node = build_and_parse_source('10', rails_root_join('app', 'workers', 'foo.rb')) expect(cop.in_worker?(node)).to eq(true) end it 'returns false for a node outside the workers directory' do - node = parse_source('10', rails_root_join('app', 'foo', 'foo.rb')) + node = build_and_parse_source('10', rails_root_join('app', 'foo', 'foo.rb')) expect(cop.in_worker?(node)).to eq(false) end @@ -153,13 +153,13 @@ RSpec.describe RuboCop::CodeReuseHelpers do describe '#in_api?' do it 'returns true for a node in the API directory' do - node = parse_source('10', rails_root_join('lib', 'api', 'foo.rb')) + node = build_and_parse_source('10', rails_root_join('lib', 'api', 'foo.rb')) expect(cop.in_api?(node)).to eq(true) end it 'returns false for a node outside the API directory' do - node = parse_source('10', rails_root_join('lib', 'foo', 'foo.rb')) + node = build_and_parse_source('10', rails_root_join('lib', 'foo', 'foo.rb')) expect(cop.in_api?(node)).to eq(false) end @@ -167,21 +167,21 @@ RSpec.describe RuboCop::CodeReuseHelpers do describe '#in_directory?' do it 'returns true for a directory in the CE app/ directory' do - node = parse_source('10', rails_root_join('app', 'models', 'foo.rb')) + node = build_and_parse_source('10', rails_root_join('app', 'models', 'foo.rb')) expect(cop.in_directory?(node, 'models')).to eq(true) end it 'returns true for a directory in the EE app/ directory' do node = - parse_source('10', rails_root_join('ee', 'app', 'models', 'foo.rb')) + build_and_parse_source('10', rails_root_join('ee', 'app', 'models', 'foo.rb')) expect(cop.in_directory?(node, 'models')).to eq(true) end it 'returns false for a directory in the lib/ directory' do node = - parse_source('10', rails_root_join('lib', 'models', 'foo.rb')) + build_and_parse_source('10', rails_root_join('lib', 'models', 'foo.rb')) expect(cop.in_directory?(node, 'models')).to eq(false) end @@ -189,7 +189,7 @@ RSpec.describe RuboCop::CodeReuseHelpers do describe '#name_of_receiver' do it 'returns the name of a send receiver' do - node = parse_source('Foo.bar') + node = build_and_parse_source('Foo.bar') expect(cop.name_of_receiver(node)).to eq('Foo') end @@ -197,7 +197,7 @@ RSpec.describe RuboCop::CodeReuseHelpers do describe '#each_class_method' do it 'yields every class method to the supplied block' do - node = parse_source(<<~RUBY) + node = build_and_parse_source(<<~RUBY) class Foo class << self def first @@ -220,7 +220,7 @@ RSpec.describe RuboCop::CodeReuseHelpers do describe '#each_send_node' do it 'yields every send node to the supplied block' do - node = parse_source("foo\nbar") + node = build_and_parse_source("foo\nbar") nodes = cop.each_send_node(node).to_a expect(nodes.length).to eq(2) @@ -231,7 +231,7 @@ RSpec.describe RuboCop::CodeReuseHelpers do describe '#disallow_send_to' do it 'disallows sending a message to a constant' do - def_node = parse_source(<<~RUBY) + def_node = build_and_parse_source(<<~RUBY) def foo FooFinder.new end |