Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
Diffstat (limited to 'spec/rubocop/cop/background_migration/feature_category_spec.rb')
-rw-r--r--spec/rubocop/cop/background_migration/feature_category_spec.rb71
1 files changed, 71 insertions, 0 deletions
diff --git a/spec/rubocop/cop/background_migration/feature_category_spec.rb b/spec/rubocop/cop/background_migration/feature_category_spec.rb
new file mode 100644
index 00000000000..359520b1d9f
--- /dev/null
+++ b/spec/rubocop/cop/background_migration/feature_category_spec.rb
@@ -0,0 +1,71 @@
+# frozen_string_literal: true
+
+require 'rubocop_spec_helper'
+require_relative '../../../../rubocop/cop/background_migration/feature_category'
+
+RSpec.describe RuboCop::Cop::BackgroundMigration::FeatureCategory, feature_category: :database do
+ let(:cop) { described_class.new }
+
+ context 'for non background migrations' do
+ before do
+ allow(cop).to receive(:in_background_migration?).and_return(false)
+ end
+
+ it 'does not throw any offense' do
+ expect_no_offenses(<<~RUBY)
+ module Gitlab
+ module BackgroundMigration
+ class MyJob < Gitlab::BackgroundMigration::BatchedMigrationJob
+ def perform; end
+ end
+ end
+ end
+ RUBY
+ end
+ end
+
+ context 'for background migrations' do
+ before do
+ allow(cop).to receive(:in_background_migration?).and_return(true)
+ end
+
+ it 'throws offense on not defining the feature_category' do
+ expect_offense(<<~RUBY)
+ module Gitlab
+ module BackgroundMigration
+ class MyJob1 < Gitlab::BackgroundMigration::BatchedMigrationJob
+ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ #{described_class::MSG}
+ end
+ end
+ end
+ RUBY
+ end
+
+ it 'throws offense on not defining a valid feature_category' do
+ expect_offense(<<~RUBY)
+ module Gitlab
+ module BackgroundMigration
+ class MyJob1 < Gitlab::BackgroundMigration::BatchedMigrationJob
+ feature_category :invalid_random
+ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ #{described_class::INVALID_FEATURE_CATEGORY_MSG}
+ end
+ end
+ end
+ RUBY
+ end
+
+ it 'will not throw offense on defining a valid feature_category' do
+ expect_no_offenses(<<~RUBY)
+ module Gitlab
+ module BackgroundMigration
+ class MyJob < Gitlab::BackgroundMigration::BatchedMigrationJob
+ feature_category :database
+
+ def perform; end
+ end
+ end
+ end
+ RUBY
+ end
+ end
+end